commit 11f25386100ce50e114ec52d5487027af2912ebf
author Wouter van Oortmerssen <wvo@google.com> Thu Sep 04 11:57:09 2014 -0700
committer Wouter van Oortmerssen <wvo@google.com> Thu Sep 04 16:36:41 2014 -0700
tree c655975ca952129e3591a5af03b983ee4af6a4bf
parent ea57dfe89754464d88ed683071a0b3b11b9075a7

Made "field set more than once" check in JSON parser faster.

Change-Id: I3ecc1aa610526c270faa56cc5266f14cd81db247
Tested: on Linux.

include/flatbuffers/idl.h

diff --git a/include/flatbuffers/idl.h b/include/flatbuffers/idl.h
index 272fd2c..889664b 100644
--- a/include/flatbuffers/idl.h
+++ b/include/flatbuffers/idl.h
@@ -176,11 +176,12 @@
 };
 
 struct FieldDef : public Definition {
-  FieldDef() : deprecated(false), padding(0) {}
+  FieldDef() : deprecated(false), padding(0), used(false) {}
 
   Value value;
   bool deprecated;
-  size_t padding;  // bytes to always pad after this field
+  size_t padding;  // Bytes to always pad after this field.
+  bool used;       // Used during JSON parsing to check for repeated fields.
 };
 
 struct StructDef : public Definition {

src/idl_parser.cpp

diff --git a/src/idl_parser.cpp b/src/idl_parser.cpp
index 4c60fd7..ed4476d 100644
--- a/src/idl_parser.cpp
+++ b/src/idl_parser.cpp
@@ -457,10 +457,6 @@
                             || struct_def.fields.vec[fieldn] != field)) {
        Error("struct field appearing out of order: " + name);
     }
-    for (auto it = field_stack_.rbegin();
-             it != field_stack_.rbegin() + fieldn; ++it) {
-      if (it->second == field) Error("field already set: " + name);
-    }
     Expect(':');
     Value val = field->value;
     ParseAnyValue(val, field);
@@ -469,6 +465,16 @@
     if (IsNext('}')) break;
     Expect(',');
   }
+  for (auto it = field_stack_.rbegin();
+           it != field_stack_.rbegin() + fieldn; ++it) {
+    if (it->second->used)
+      Error("field set more than once: " + it->second->name);
+    it->second->used = true;
+  }
+  for (auto it = field_stack_.rbegin();
+           it != field_stack_.rbegin() + fieldn; ++it) {
+    it->second->used = false;
+  }
   if (struct_def.fixed && fieldn != struct_def.fields.vec.size())
     Error("incomplete struct initialization: " + struct_def.name);
   auto start = struct_def.fixed

tests/test.cpp

diff --git a/tests/test.cpp b/tests/test.cpp
index 4cd4fd1..118ecb6 100644
--- a/tests/test.cpp
+++ b/tests/test.cpp
@@ -490,7 +490,7 @@
   TestError("union Z { X } struct X { Y:int; }", "only tables");
   TestError("table X { Y:[int]; YLength:int; }", "clash");
   TestError("table X { Y:string = 1; }", "scalar");
-  TestError("table X { Y:byte; } root_type X; { Y:1, Y:2 }", "already set");
+  TestError("table X { Y:byte; } root_type X; { Y:1, Y:2 }", "more than once");
 }
 
 // Additional parser testing not covered elsewhere.