Some reorganization that results from a new method I'm moving to to
maintaining this opensource tree. Some of this reorganization is
entirely a result of reorganization: blank lines in a few different
places, etc. Here are the others:
1) I've added a new file, util.h, with lots of new, helpful routines,
most notably StringPrintf (printf returning a string). I've also
moved some routines from the .cc and unittest.cc file here, such as
the CHECK macros, testing framework, and #ifdefs for 16-bit ints.
Quite a bit of code was rewritten to use these new routines.
2) I noticed that the special-case setenv() code was only needed for
windows systems, so I moved it to port.h/cc.
3) I also had to add a new vsnprintf wrapper in port.h/cc, to support
StringPrintf.
4) A few places I used an old name, commandlineflags, instead of
gflags. Most or all of these should be fixed now.
5) Some of my copyright dates weren't quite right. Fixed them up.
6) In some .cc files, I added using directives to not have to use
std:: so much.
7) I've added a minor new test, adding 10000 or so flags to see how
the system scales.
8) Some compile-warning fixes, such as int -> size_t when appropriate,
and better protected #defines in mutex.h
9) The .h files gained some logic defining GFLAGS_DLL_DECL. This is
true even for .h files outside the windows directory, which will never
have these dll issues. But one big advantage of my new organization
is auto-generating the windows versions of these files from the unix
versions, so there's some unnecessary (but harmless) duplication as a
result.
10) Fixed a bug in rpm.sh which would cause an unnecessary crash when
dpkg was missing.
git-svn-id: https://gflags.googlecode.com/svn/trunk@52 6586e3c6-dcc4-952a-343f-ff74eb82781d
diff --git a/src/gflags_completions.sh b/src/gflags_completions.sh
index 2291b59..c5fb7e6 100755
--- a/src/gflags_completions.sh
+++ b/src/gflags_completions.sh
@@ -50,12 +50,12 @@
completion_word_index="$(($# - 1))"
completion_word="${!completion_word_index}"
-# TODO(daven): Replace this once commandlineflags_completions.cc has
+# TODO(user): Replace this once gflags_completions.cc has
# a bool parameter indicating unambiguously to hijack the process for
# completion purposes.
if [ -z "$completion_word" ]; then
# Until an empty value for the completion word stops being misunderstood
- # by google3 binaries, don't actuall execute the binary or the process
+ # by binaries, don't actually execute the binary or the process
# won't be hijacked!
exit 0
fi
@@ -74,12 +74,10 @@
# places this in the $COMP_LINE variable.
if [ "$binary" == "time" ] || [ "$binary" == "env" ]; then
# we'll assume that the first 'argument' is actually the
- # binary to be run, if we think it looks like a google3
# binary
- # TODO(daven): Decide what 'looks' like a google3 binary. =)
- # TODO(daven): This is not perfect - the 'env' command, for instance,
+ # TODO(user): This is not perfect - the 'env' command, for instance,
# is allowed to have options between the 'env' and 'the command to
# be executed'. For example, consider:
# $ env FOO="bar" bin/do_something --help<TAB>
@@ -105,7 +103,7 @@
done
params="$params --tab_completion_word \"$completion_word\""
-# TODO(daven): Perhaps stash the output in a temporary file somewhere
+# TODO(user): Perhaps stash the output in a temporary file somewhere
# in /tmp, and only cat it to stdout if the command returned a success
# code, to prevent false positives