reflect/protodesc: enforce strict validation
Hyrum's Law dictates that if we do not prevent naughty behavior,
people will rely on it. If we do not validate that the provided
file descriptor is correct today, it will be near impossible
to add proper validation checks later on.
The logic added validates that the provided file descriptor is
correct according to the same semantics as protoc,
which was reversed engineered to derive the set of rules implemented here.
The rules are unfortunately complicated because protobuf is a language
full of many non-orthogonal features. While our logic is complicated,
it is still 1/7th the size of the equivalent C++ code!
Change-Id: I6acc5dc3bd2e4c6bea6cd9e81214f8104402602a
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/184837
Reviewed-by: Damien Neil <dneil@google.com>
diff --git a/internal/encoding/pack/pack_test.go b/internal/encoding/pack/pack_test.go
index d6704e9..9d1239a 100644
--- a/internal/encoding/pack/pack_test.go
+++ b/internal/encoding/pack/pack_test.go
@@ -26,21 +26,22 @@
message_type: [{
name: "Message"
field: [
- {name:"F1" number:1 label:LABEL_REPEATED type:TYPE_BOOL options:{packed:true}},
- {name:"F2" number:2 label:LABEL_REPEATED type:TYPE_INT64 options:{packed:true}},
- {name:"F3" number:3 label:LABEL_REPEATED type:TYPE_SINT64 options:{packed:true}},
- {name:"F4" number:4 label:LABEL_REPEATED type:TYPE_UINT64 options:{packed:true}},
- {name:"F5" number:5 label:LABEL_REPEATED type:TYPE_FIXED32 options:{packed:true}},
- {name:"F6" number:6 label:LABEL_REPEATED type:TYPE_SFIXED32 options:{packed:true}},
- {name:"F7" number:7 label:LABEL_REPEATED type:TYPE_FLOAT options:{packed:true}},
- {name:"F8" number:8 label:LABEL_REPEATED type:TYPE_FIXED64 options:{packed:true}},
- {name:"F9" number:9 label:LABEL_REPEATED type:TYPE_SFIXED64 options:{packed:true}},
- {name:"F10" number:10 label:LABEL_REPEATED type:TYPE_DOUBLE options:{packed:true}},
- {name:"F11" number:11 label:LABEL_OPTIONAL type:TYPE_STRING},
- {name:"F12" number:12 label:LABEL_OPTIONAL type:TYPE_BYTES},
- {name:"F13" number:13 label:LABEL_OPTIONAL type:TYPE_MESSAGE type_name:".Message"},
- {name:"F14" number:14 label:LABEL_OPTIONAL type:TYPE_GROUP type_name:".Message"}
+ {name:"f1" number:1 label:LABEL_REPEATED type:TYPE_BOOL options:{packed:true}},
+ {name:"f2" number:2 label:LABEL_REPEATED type:TYPE_INT64 options:{packed:true}},
+ {name:"f3" number:3 label:LABEL_REPEATED type:TYPE_SINT64 options:{packed:true}},
+ {name:"f4" number:4 label:LABEL_REPEATED type:TYPE_UINT64 options:{packed:true}},
+ {name:"f5" number:5 label:LABEL_REPEATED type:TYPE_FIXED32 options:{packed:true}},
+ {name:"f6" number:6 label:LABEL_REPEATED type:TYPE_SFIXED32 options:{packed:true}},
+ {name:"f7" number:7 label:LABEL_REPEATED type:TYPE_FLOAT options:{packed:true}},
+ {name:"f8" number:8 label:LABEL_REPEATED type:TYPE_FIXED64 options:{packed:true}},
+ {name:"f9" number:9 label:LABEL_REPEATED type:TYPE_SFIXED64 options:{packed:true}},
+ {name:"f10" number:10 label:LABEL_REPEATED type:TYPE_DOUBLE options:{packed:true}},
+ {name:"f11" number:11 label:LABEL_OPTIONAL type:TYPE_STRING},
+ {name:"f12" number:12 label:LABEL_OPTIONAL type:TYPE_BYTES},
+ {name:"f13" number:13 label:LABEL_OPTIONAL type:TYPE_MESSAGE type_name:".Message"},
+ {name:"f14" number:14 label:LABEL_OPTIONAL type:TYPE_GROUP type_name:".Message.F14"}
]
+ nested_type: [{name: "F14"}]
}]
`
pb := new(descriptorpb.FileDescriptorProto)