| commit | 62d204ccc39ba6c25a7ca786cd75ef0cad2af528 | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Mon Dec 09 21:18:02 2019 -0800 |
| committer | Joe Tsai <thebrokentoaster@gmail.com> | Tue Dec 10 16:55:03 2019 +0000 |
| tree | 6aba1ac6aabe88c8b28d66e1f2e40a0b607515b6 | |
| parent | 4663ebc85242a9e20b6f8fd3239b1ede3b73b199 [diff] |
internal/impl: fix legacy UnmarshalJSONEnum The conditional was accidentally inverted. This function provides dubious support for encoding/json. Change-Id: Ib4131a229afa14d9aef1ad31fec51f4dac417a3b Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/210638 Reviewed-by: Damien Neil <dneil@google.com>
diff --git a/internal/impl/legacy_export.go b/internal/impl/legacy_export.go index cf17794..94f4572 100644 --- a/internal/impl/legacy_export.go +++ b/internal/impl/legacy_export.go
@@ -45,7 +45,7 @@ return 0, errors.New("invalid input for enum %v: %s", ed.FullName(), b) } ev := ed.Values().ByName(name) - if ev != nil { + if ev == nil { return 0, errors.New("invalid value for enum %v: %s", ed.FullName(), name) } return ev.Number(), nil