| commit | ae313d4af361c5f372b454220280d2daf9b34fbc | [log] [tgz] |
|---|---|---|
| author | Joe Tsai <joetsai@digital-static.net> | Wed Oct 16 10:25:54 2019 -0700 |
| committer | Joe Tsai <joetsai@digital-static.net> | Thu Oct 17 17:10:14 2019 +0000 |
| tree | afbbdae2abee2d63b2f27fe65ac4622cdcb8e620 | |
| parent | 591f09ab7ccf5332e66d6e6d24e1e8fb08167b89 [diff] [blame] |
cmd/protoc-gen-go: fix Reset method The MessageInfo cache, once set, must not be cleared, otherwise there exists a *messageState value where the MessageInfo value is nil. Fix the generation of the Reset method to avoid clearing this value. Change-Id: Ic84ca8b2640a43e967c36993da1ccd3f2b7096c4 Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/201478 Reviewed-by: Damien Neil <dneil@google.com>
diff --git a/internal/testprotos/legacy/legacy.pb.go b/internal/testprotos/legacy/legacy.pb.go index 1eee7c0..c4eaef8 100644 --- a/internal/testprotos/legacy/legacy.pb.go +++ b/internal/testprotos/legacy/legacy.pb.go
@@ -47,6 +47,11 @@ func (x *Legacy) Reset() { *x = Legacy{} + if protoimpl.UnsafeEnabled { + mi := &file_legacy_legacy_proto_msgTypes[0] + ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x)) + ms.StoreMessageInfo(mi) + } } func (x *Legacy) String() string {