blob: 2333fc5472ba4306036b6f14c3e9c5d95fc05216 [file] [log] [blame]
Joe Tsai90fe9962018-10-18 11:06:29 -07001// Copyright 2018 The Go Authors. All rights reserved.
2// Use of this source code is governed by a BSD-style
3// license that can be found in the LICENSE file.
4
5package impl
6
7import (
Joe Tsaie2afdc22018-10-25 14:06:56 -07008 "bytes"
9 "math"
Joe Tsai90fe9962018-10-18 11:06:29 -070010 "reflect"
11 "testing"
12
Joe Tsai95b02902018-10-31 18:23:42 -070013 protoV1 "github.com/golang/protobuf/proto"
Joe Tsaiea118132018-11-11 17:56:21 -080014 pack "github.com/golang/protobuf/v2/internal/encoding/pack"
15 pragma "github.com/golang/protobuf/v2/internal/pragma"
Joe Tsai90fe9962018-10-18 11:06:29 -070016 pref "github.com/golang/protobuf/v2/reflect/protoreflect"
17 ptype "github.com/golang/protobuf/v2/reflect/prototype"
Joe Tsaiea118132018-11-11 17:56:21 -080018 cmp "github.com/google/go-cmp/cmp"
19
20 proto2_20160225 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto2.v0.0.0-20160225-2fc053c5"
21 proto2_20160519 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto2.v0.0.0-20160519-a4ab9ec5"
22 proto2_20180125 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto2.v1.0.0-20180125-92554152"
23 proto2_20180430 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto2.v1.1.0-20180430-b4deda09"
24 proto2_20180814 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto2.v1.2.0-20180814-aa810b61"
25 proto3_20160225 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto3.v0.0.0-20160225-2fc053c5"
26 proto3_20160519 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto3.v0.0.0-20160519-a4ab9ec5"
27 proto3_20180125 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto3.v1.0.0-20180125-92554152"
28 proto3_20180430 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto3.v1.1.0-20180430-b4deda09"
29 proto3_20180814 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto3.v1.2.0-20180814-aa810b61"
Joe Tsai90fe9962018-10-18 11:06:29 -070030)
31
Joe Tsaiea118132018-11-11 17:56:21 -080032func mustLoadFileDesc(b []byte, _ []int) pref.FileDescriptor {
Joe Tsaif0c01e42018-11-06 13:05:20 -080033 fd, err := ptype.NewFileFromDescriptorProto(legacyLoadFileDesc(b), nil)
Joe Tsai90fe9962018-10-18 11:06:29 -070034 if err != nil {
35 panic(err)
36 }
37 return fd
38}
39
Joe Tsaie2afdc22018-10-25 14:06:56 -070040func TestLegacyDescriptor(t *testing.T) {
Joe Tsaiea118132018-11-11 17:56:21 -080041 var tests []struct{ got, want pref.Descriptor }
42
43 fileDescP2_20160225 := mustLoadFileDesc(new(proto2_20160225.Message).Descriptor())
44 tests = append(tests, []struct{ got, want pref.Descriptor }{{
Joe Tsaif0c01e42018-11-06 13:05:20 -080045 got: legacyLoadEnumDesc(reflect.TypeOf(proto2_20160225.SiblingEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -080046 want: fileDescP2_20160225.Enums().ByName("SiblingEnum"),
Joe Tsai90fe9962018-10-18 11:06:29 -070047 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080048 got: legacyLoadEnumDesc(reflect.TypeOf(proto2_20160225.Message_ChildEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -080049 want: fileDescP2_20160225.Messages().ByName("Message").Enums().ByName("ChildEnum"),
Joe Tsai90fe9962018-10-18 11:06:29 -070050 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080051 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160225.SiblingMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -080052 want: fileDescP2_20160225.Messages().ByName("SiblingMessage"),
Joe Tsai90fe9962018-10-18 11:06:29 -070053 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080054 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160225.Message_ChildMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -080055 want: fileDescP2_20160225.Messages().ByName("Message").Messages().ByName("ChildMessage"),
Joe Tsai90fe9962018-10-18 11:06:29 -070056 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080057 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160225.Message))),
Joe Tsaiea118132018-11-11 17:56:21 -080058 want: fileDescP2_20160225.Messages().ByName("Message"),
Joe Tsai90fe9962018-10-18 11:06:29 -070059 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080060 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160225.Message_NamedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -080061 want: fileDescP2_20160225.Messages().ByName("Message").Messages().ByName("NamedGroup"),
Joe Tsai90fe9962018-10-18 11:06:29 -070062 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080063 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160225.Message_OptionalGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -080064 want: fileDescP2_20160225.Messages().ByName("Message").Messages().ByName("OptionalGroup"),
Joe Tsai90fe9962018-10-18 11:06:29 -070065 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080066 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160225.Message_RequiredGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -080067 want: fileDescP2_20160225.Messages().ByName("Message").Messages().ByName("RequiredGroup"),
Joe Tsai90fe9962018-10-18 11:06:29 -070068 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080069 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160225.Message_RepeatedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -080070 want: fileDescP2_20160225.Messages().ByName("Message").Messages().ByName("RepeatedGroup"),
Joe Tsai90fe9962018-10-18 11:06:29 -070071 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080072 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160225.Message_OneofGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -080073 want: fileDescP2_20160225.Messages().ByName("Message").Messages().ByName("OneofGroup"),
Joe Tsai90fe9962018-10-18 11:06:29 -070074 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080075 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160225.Message_ExtensionOptionalGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -080076 want: fileDescP2_20160225.Messages().ByName("Message").Messages().ByName("ExtensionOptionalGroup"),
Joe Tsai90fe9962018-10-18 11:06:29 -070077 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080078 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160225.Message_ExtensionRepeatedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -080079 want: fileDescP2_20160225.Messages().ByName("Message").Messages().ByName("ExtensionRepeatedGroup"),
80 }}...)
81
82 fileDescP3_20160225 := mustLoadFileDesc(new(proto3_20160225.Message).Descriptor())
83 tests = append(tests, []struct{ got, want pref.Descriptor }{{
Joe Tsaif0c01e42018-11-06 13:05:20 -080084 got: legacyLoadEnumDesc(reflect.TypeOf(proto3_20160225.SiblingEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -080085 want: fileDescP3_20160225.Enums().ByName("SiblingEnum"),
Joe Tsai90fe9962018-10-18 11:06:29 -070086 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080087 got: legacyLoadEnumDesc(reflect.TypeOf(proto3_20160225.Message_ChildEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -080088 want: fileDescP3_20160225.Messages().ByName("Message").Enums().ByName("ChildEnum"),
Joe Tsai90fe9962018-10-18 11:06:29 -070089 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080090 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20160225.SiblingMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -080091 want: fileDescP3_20160225.Messages().ByName("SiblingMessage"),
Joe Tsai90fe9962018-10-18 11:06:29 -070092 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080093 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20160225.Message_ChildMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -080094 want: fileDescP3_20160225.Messages().ByName("Message").Messages().ByName("ChildMessage"),
95 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -080096 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20160225.Message))),
Joe Tsaiea118132018-11-11 17:56:21 -080097 want: fileDescP3_20160225.Messages().ByName("Message"),
98 }}...)
99
100 fileDescP2_20160519 := mustLoadFileDesc(new(proto2_20160519.Message).Descriptor())
101 tests = append(tests, []struct{ got, want pref.Descriptor }{{
Joe Tsaif0c01e42018-11-06 13:05:20 -0800102 got: legacyLoadEnumDesc(reflect.TypeOf(proto2_20160519.SiblingEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800103 want: fileDescP2_20160519.Enums().ByName("SiblingEnum"),
104 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800105 got: legacyLoadEnumDesc(reflect.TypeOf(proto2_20160519.Message_ChildEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800106 want: fileDescP2_20160519.Messages().ByName("Message").Enums().ByName("ChildEnum"),
107 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800108 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160519.SiblingMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800109 want: fileDescP2_20160519.Messages().ByName("SiblingMessage"),
110 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800111 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160519.Message_ChildMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800112 want: fileDescP2_20160519.Messages().ByName("Message").Messages().ByName("ChildMessage"),
113 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800114 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160519.Message))),
Joe Tsaiea118132018-11-11 17:56:21 -0800115 want: fileDescP2_20160519.Messages().ByName("Message"),
116 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800117 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160519.Message_NamedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800118 want: fileDescP2_20160519.Messages().ByName("Message").Messages().ByName("NamedGroup"),
119 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800120 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160519.Message_OptionalGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800121 want: fileDescP2_20160519.Messages().ByName("Message").Messages().ByName("OptionalGroup"),
122 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800123 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160519.Message_RequiredGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800124 want: fileDescP2_20160519.Messages().ByName("Message").Messages().ByName("RequiredGroup"),
125 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800126 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160519.Message_RepeatedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800127 want: fileDescP2_20160519.Messages().ByName("Message").Messages().ByName("RepeatedGroup"),
128 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800129 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160519.Message_OneofGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800130 want: fileDescP2_20160519.Messages().ByName("Message").Messages().ByName("OneofGroup"),
131 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800132 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160519.Message_ExtensionOptionalGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800133 want: fileDescP2_20160519.Messages().ByName("Message").Messages().ByName("ExtensionOptionalGroup"),
134 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800135 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20160519.Message_ExtensionRepeatedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800136 want: fileDescP2_20160519.Messages().ByName("Message").Messages().ByName("ExtensionRepeatedGroup"),
137 }}...)
138
139 fileDescP3_20160519 := mustLoadFileDesc(new(proto3_20160519.Message).Descriptor())
140 tests = append(tests, []struct{ got, want pref.Descriptor }{{
Joe Tsaif0c01e42018-11-06 13:05:20 -0800141 got: legacyLoadEnumDesc(reflect.TypeOf(proto3_20160519.SiblingEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800142 want: fileDescP3_20160519.Enums().ByName("SiblingEnum"),
143 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800144 got: legacyLoadEnumDesc(reflect.TypeOf(proto3_20160519.Message_ChildEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800145 want: fileDescP3_20160519.Messages().ByName("Message").Enums().ByName("ChildEnum"),
146 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800147 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20160519.SiblingMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800148 want: fileDescP3_20160519.Messages().ByName("SiblingMessage"),
149 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800150 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20160519.Message_ChildMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800151 want: fileDescP3_20160519.Messages().ByName("Message").Messages().ByName("ChildMessage"),
152 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800153 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20160519.Message))),
Joe Tsaiea118132018-11-11 17:56:21 -0800154 want: fileDescP3_20160519.Messages().ByName("Message"),
155 }}...)
156
157 fileDescP2_20180125 := mustLoadFileDesc(new(proto2_20180125.Message).Descriptor())
158 tests = append(tests, []struct{ got, want pref.Descriptor }{{
Joe Tsaif0c01e42018-11-06 13:05:20 -0800159 got: legacyLoadEnumDesc(reflect.TypeOf(proto2_20180125.SiblingEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800160 want: fileDescP2_20180125.Enums().ByName("SiblingEnum"),
161 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800162 got: legacyLoadEnumDesc(reflect.TypeOf(proto2_20180125.Message_ChildEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800163 want: fileDescP2_20180125.Messages().ByName("Message").Enums().ByName("ChildEnum"),
164 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800165 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180125.SiblingMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800166 want: fileDescP2_20180125.Messages().ByName("SiblingMessage"),
167 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800168 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180125.Message_ChildMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800169 want: fileDescP2_20180125.Messages().ByName("Message").Messages().ByName("ChildMessage"),
170 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800171 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180125.Message))),
Joe Tsaiea118132018-11-11 17:56:21 -0800172 want: fileDescP2_20180125.Messages().ByName("Message"),
173 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800174 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180125.Message_NamedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800175 want: fileDescP2_20180125.Messages().ByName("Message").Messages().ByName("NamedGroup"),
176 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800177 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180125.Message_OptionalGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800178 want: fileDescP2_20180125.Messages().ByName("Message").Messages().ByName("OptionalGroup"),
179 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800180 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180125.Message_RequiredGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800181 want: fileDescP2_20180125.Messages().ByName("Message").Messages().ByName("RequiredGroup"),
182 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800183 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180125.Message_RepeatedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800184 want: fileDescP2_20180125.Messages().ByName("Message").Messages().ByName("RepeatedGroup"),
185 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800186 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180125.Message_OneofGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800187 want: fileDescP2_20180125.Messages().ByName("Message").Messages().ByName("OneofGroup"),
188 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800189 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180125.Message_ExtensionOptionalGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800190 want: fileDescP2_20180125.Messages().ByName("Message").Messages().ByName("ExtensionOptionalGroup"),
191 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800192 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180125.Message_ExtensionRepeatedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800193 want: fileDescP2_20180125.Messages().ByName("Message").Messages().ByName("ExtensionRepeatedGroup"),
194 }}...)
195
196 fileDescP3_20180125 := mustLoadFileDesc(new(proto3_20180125.Message).Descriptor())
197 tests = append(tests, []struct{ got, want pref.Descriptor }{{
Joe Tsaif0c01e42018-11-06 13:05:20 -0800198 got: legacyLoadEnumDesc(reflect.TypeOf(proto3_20180125.SiblingEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800199 want: fileDescP3_20180125.Enums().ByName("SiblingEnum"),
200 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800201 got: legacyLoadEnumDesc(reflect.TypeOf(proto3_20180125.Message_ChildEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800202 want: fileDescP3_20180125.Messages().ByName("Message").Enums().ByName("ChildEnum"),
203 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800204 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20180125.SiblingMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800205 want: fileDescP3_20180125.Messages().ByName("SiblingMessage"),
206 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800207 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20180125.Message_ChildMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800208 want: fileDescP3_20180125.Messages().ByName("Message").Messages().ByName("ChildMessage"),
209 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800210 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20180125.Message))),
Joe Tsaiea118132018-11-11 17:56:21 -0800211 want: fileDescP3_20180125.Messages().ByName("Message"),
212 }}...)
213
214 fileDescP2_20180430 := mustLoadFileDesc(new(proto2_20180430.Message).Descriptor())
215 tests = append(tests, []struct{ got, want pref.Descriptor }{{
Joe Tsaif0c01e42018-11-06 13:05:20 -0800216 got: legacyLoadEnumDesc(reflect.TypeOf(proto2_20180430.SiblingEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800217 want: fileDescP2_20180430.Enums().ByName("SiblingEnum"),
218 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800219 got: legacyLoadEnumDesc(reflect.TypeOf(proto2_20180430.Message_ChildEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800220 want: fileDescP2_20180430.Messages().ByName("Message").Enums().ByName("ChildEnum"),
221 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800222 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180430.SiblingMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800223 want: fileDescP2_20180430.Messages().ByName("SiblingMessage"),
224 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800225 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180430.Message_ChildMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800226 want: fileDescP2_20180430.Messages().ByName("Message").Messages().ByName("ChildMessage"),
227 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800228 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180430.Message))),
Joe Tsaiea118132018-11-11 17:56:21 -0800229 want: fileDescP2_20180430.Messages().ByName("Message"),
230 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800231 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180430.Message_NamedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800232 want: fileDescP2_20180430.Messages().ByName("Message").Messages().ByName("NamedGroup"),
233 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800234 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180430.Message_OptionalGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800235 want: fileDescP2_20180430.Messages().ByName("Message").Messages().ByName("OptionalGroup"),
236 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800237 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180430.Message_RequiredGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800238 want: fileDescP2_20180430.Messages().ByName("Message").Messages().ByName("RequiredGroup"),
239 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800240 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180430.Message_RepeatedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800241 want: fileDescP2_20180430.Messages().ByName("Message").Messages().ByName("RepeatedGroup"),
242 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800243 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180430.Message_OneofGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800244 want: fileDescP2_20180430.Messages().ByName("Message").Messages().ByName("OneofGroup"),
245 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800246 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180430.Message_ExtensionOptionalGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800247 want: fileDescP2_20180430.Messages().ByName("Message").Messages().ByName("ExtensionOptionalGroup"),
248 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800249 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180430.Message_ExtensionRepeatedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800250 want: fileDescP2_20180430.Messages().ByName("Message").Messages().ByName("ExtensionRepeatedGroup"),
251 }}...)
252
253 fileDescP3_20180430 := mustLoadFileDesc(new(proto3_20180430.Message).Descriptor())
254 tests = append(tests, []struct{ got, want pref.Descriptor }{{
Joe Tsaif0c01e42018-11-06 13:05:20 -0800255 got: legacyLoadEnumDesc(reflect.TypeOf(proto3_20180430.SiblingEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800256 want: fileDescP3_20180430.Enums().ByName("SiblingEnum"),
257 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800258 got: legacyLoadEnumDesc(reflect.TypeOf(proto3_20180430.Message_ChildEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800259 want: fileDescP3_20180430.Messages().ByName("Message").Enums().ByName("ChildEnum"),
260 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800261 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20180430.SiblingMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800262 want: fileDescP3_20180430.Messages().ByName("SiblingMessage"),
263 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800264 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20180430.Message_ChildMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800265 want: fileDescP3_20180430.Messages().ByName("Message").Messages().ByName("ChildMessage"),
266 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800267 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20180430.Message))),
Joe Tsaiea118132018-11-11 17:56:21 -0800268 want: fileDescP3_20180430.Messages().ByName("Message"),
269 }}...)
270
271 fileDescP2_20180814 := mustLoadFileDesc(new(proto2_20180814.Message).Descriptor())
272 tests = append(tests, []struct{ got, want pref.Descriptor }{{
Joe Tsaif0c01e42018-11-06 13:05:20 -0800273 got: legacyLoadEnumDesc(reflect.TypeOf(proto2_20180814.SiblingEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800274 want: fileDescP2_20180814.Enums().ByName("SiblingEnum"),
275 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800276 got: legacyLoadEnumDesc(reflect.TypeOf(proto2_20180814.Message_ChildEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800277 want: fileDescP2_20180814.Messages().ByName("Message").Enums().ByName("ChildEnum"),
278 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800279 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180814.SiblingMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800280 want: fileDescP2_20180814.Messages().ByName("SiblingMessage"),
281 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800282 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180814.Message_ChildMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800283 want: fileDescP2_20180814.Messages().ByName("Message").Messages().ByName("ChildMessage"),
284 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800285 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180814.Message))),
Joe Tsaiea118132018-11-11 17:56:21 -0800286 want: fileDescP2_20180814.Messages().ByName("Message"),
287 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800288 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180814.Message_NamedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800289 want: fileDescP2_20180814.Messages().ByName("Message").Messages().ByName("NamedGroup"),
290 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800291 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180814.Message_OptionalGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800292 want: fileDescP2_20180814.Messages().ByName("Message").Messages().ByName("OptionalGroup"),
293 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800294 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180814.Message_RequiredGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800295 want: fileDescP2_20180814.Messages().ByName("Message").Messages().ByName("RequiredGroup"),
296 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800297 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180814.Message_RepeatedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800298 want: fileDescP2_20180814.Messages().ByName("Message").Messages().ByName("RepeatedGroup"),
299 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800300 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180814.Message_OneofGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800301 want: fileDescP2_20180814.Messages().ByName("Message").Messages().ByName("OneofGroup"),
302 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800303 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180814.Message_ExtensionOptionalGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800304 want: fileDescP2_20180814.Messages().ByName("Message").Messages().ByName("ExtensionOptionalGroup"),
305 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800306 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto2_20180814.Message_ExtensionRepeatedGroup))),
Joe Tsaiea118132018-11-11 17:56:21 -0800307 want: fileDescP2_20180814.Messages().ByName("Message").Messages().ByName("ExtensionRepeatedGroup"),
308 }}...)
309
310 fileDescP3_20180814 := mustLoadFileDesc(new(proto3_20180814.Message).Descriptor())
311 tests = append(tests, []struct{ got, want pref.Descriptor }{{
Joe Tsaif0c01e42018-11-06 13:05:20 -0800312 got: legacyLoadEnumDesc(reflect.TypeOf(proto3_20180814.SiblingEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800313 want: fileDescP3_20180814.Enums().ByName("SiblingEnum"),
314 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800315 got: legacyLoadEnumDesc(reflect.TypeOf(proto3_20180814.Message_ChildEnum(0))),
Joe Tsaiea118132018-11-11 17:56:21 -0800316 want: fileDescP3_20180814.Messages().ByName("Message").Enums().ByName("ChildEnum"),
317 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800318 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20180814.SiblingMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800319 want: fileDescP3_20180814.Messages().ByName("SiblingMessage"),
320 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800321 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20180814.Message_ChildMessage))),
Joe Tsaiea118132018-11-11 17:56:21 -0800322 want: fileDescP3_20180814.Messages().ByName("Message").Messages().ByName("ChildMessage"),
323 }, {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800324 got: legacyLoadMessageDesc(reflect.TypeOf(new(proto3_20180814.Message))),
Joe Tsaiea118132018-11-11 17:56:21 -0800325 want: fileDescP3_20180814.Messages().ByName("Message"),
326 }}...)
Joe Tsai90fe9962018-10-18 11:06:29 -0700327
328 type list interface {
329 Len() int
330 pragma.DoNotImplement
331 }
332 opts := cmp.Options{
333 cmp.Transformer("", func(x list) []interface{} {
334 out := make([]interface{}, x.Len())
335 v := reflect.ValueOf(x)
336 for i := 0; i < x.Len(); i++ {
337 m := v.MethodByName("Get")
338 out[i] = m.Call([]reflect.Value{reflect.ValueOf(i)})[0].Interface()
339 }
340 return out
341 }),
342 cmp.Transformer("", func(x pref.Descriptor) map[string]interface{} {
343 out := make(map[string]interface{})
344 v := reflect.ValueOf(x)
345 for i := 0; i < v.NumMethod(); i++ {
346 name := v.Type().Method(i).Name
347 if m := v.Method(i); m.Type().NumIn() == 0 && m.Type().NumOut() == 1 {
348 switch name {
349 case "Index":
350 // Ignore index since legacy descriptors have no parent.
Damien Neil204f1c02018-10-23 15:03:38 -0700351 case "Options":
352 // Ignore descriptor options since protos are not cmperable.
Joe Tsaiea118132018-11-11 17:56:21 -0800353 case "Enums", "Messages", "Extensions":
Joe Tsai90fe9962018-10-18 11:06:29 -0700354 // Ignore nested message and enum declarations since
355 // legacy descriptors are all created standalone.
Joe Tsaiea118132018-11-11 17:56:21 -0800356 case "OneofType", "ExtendedType", "EnumType", "MessageType":
Joe Tsai90fe9962018-10-18 11:06:29 -0700357 // Avoid descending into a dependency to avoid a cycle.
358 // Just record the full name if available.
359 //
360 // TODO: Cycle support in cmp would be useful here.
361 v := m.Call(nil)[0]
362 if !v.IsNil() {
363 out[name] = v.Interface().(pref.Descriptor).FullName()
364 }
365 default:
366 out[name] = m.Call(nil)[0].Interface()
367 }
368 }
369 }
370 return out
371 }),
372 cmp.Transformer("", func(v pref.Value) interface{} {
373 return v.Interface()
374 }),
375 }
376
377 for _, tt := range tests {
378 t.Run(string(tt.want.FullName()), func(t *testing.T) {
379 if diff := cmp.Diff(&tt.want, &tt.got, opts); diff != "" {
380 t.Errorf("descriptor mismatch (-want, +got):\n%s", diff)
381 }
382 })
383 }
384}
Joe Tsaie2afdc22018-10-25 14:06:56 -0700385
Joe Tsaif0c01e42018-11-06 13:05:20 -0800386type legacyTestMessage struct {
Joe Tsai95b02902018-10-31 18:23:42 -0700387 XXX_unrecognized []byte
388 protoV1.XXX_InternalExtensions
389}
390
Joe Tsaif0c01e42018-11-06 13:05:20 -0800391func (*legacyTestMessage) Reset() {}
392func (*legacyTestMessage) String() string { return "" }
393func (*legacyTestMessage) ProtoMessage() {}
394func (*legacyTestMessage) ExtensionRangeArray() []protoV1.ExtensionRange {
395 return []protoV1.ExtensionRange{{Start: 10, End: 20}, {Start: 40, End: 80}, {Start: 10000, End: 20000}}
Joe Tsai95b02902018-10-31 18:23:42 -0700396}
397
Joe Tsaie2afdc22018-10-25 14:06:56 -0700398func TestLegacyUnknown(t *testing.T) {
399 rawOf := func(toks ...pack.Token) pref.RawFields {
400 return pref.RawFields(pack.Message(toks).Marshal())
401 }
402 raw1a := rawOf(pack.Tag{1, pack.VarintType}, pack.Svarint(-4321)) // 08c143
403 raw1b := rawOf(pack.Tag{1, pack.Fixed32Type}, pack.Uint32(0xdeadbeef)) // 0defbeadde
404 raw1c := rawOf(pack.Tag{1, pack.Fixed64Type}, pack.Float64(math.Pi)) // 09182d4454fb210940
405 raw2a := rawOf(pack.Tag{2, pack.BytesType}, pack.String("hello, world!")) // 120d68656c6c6f2c20776f726c6421
406 raw2b := rawOf(pack.Tag{2, pack.VarintType}, pack.Uvarint(1234)) // 10d209
407 raw3a := rawOf(pack.Tag{3, pack.StartGroupType}, pack.Tag{3, pack.EndGroupType}) // 1b1c
408 raw3b := rawOf(pack.Tag{3, pack.BytesType}, pack.Bytes("\xde\xad\xbe\xef")) // 1a04deadbeef
409
Joe Tsai95b02902018-10-31 18:23:42 -0700410 raw1 := rawOf(pack.Tag{1, pack.BytesType}, pack.Bytes("1")) // 0a0131
411 raw3 := rawOf(pack.Tag{3, pack.BytesType}, pack.Bytes("3")) // 1a0133
412 raw10 := rawOf(pack.Tag{10, pack.BytesType}, pack.Bytes("10")) // 52023130 - extension
413 raw15 := rawOf(pack.Tag{15, pack.BytesType}, pack.Bytes("15")) // 7a023135 - extension
414 raw26 := rawOf(pack.Tag{26, pack.BytesType}, pack.Bytes("26")) // d201023236
415 raw32 := rawOf(pack.Tag{32, pack.BytesType}, pack.Bytes("32")) // 8202023332
416 raw45 := rawOf(pack.Tag{45, pack.BytesType}, pack.Bytes("45")) // ea02023435 - extension
417 raw46 := rawOf(pack.Tag{45, pack.BytesType}, pack.Bytes("46")) // ea02023436 - extension
418 raw47 := rawOf(pack.Tag{45, pack.BytesType}, pack.Bytes("47")) // ea02023437 - extension
419 raw99 := rawOf(pack.Tag{99, pack.BytesType}, pack.Bytes("99")) // 9a06023939
420
Joe Tsaie2afdc22018-10-25 14:06:56 -0700421 joinRaw := func(bs ...pref.RawFields) (out []byte) {
422 for _, b := range bs {
423 out = append(out, b...)
424 }
425 return out
426 }
427
Joe Tsaif0c01e42018-11-06 13:05:20 -0800428 m := new(legacyTestMessage)
429 fs := MessageOf(m).UnknownFields()
Joe Tsai95b02902018-10-31 18:23:42 -0700430
Joe Tsaie2afdc22018-10-25 14:06:56 -0700431 if got, want := fs.Len(), 0; got != want {
432 t.Errorf("Len() = %d, want %d", got, want)
433 }
Joe Tsai95b02902018-10-31 18:23:42 -0700434 if got, want := m.XXX_unrecognized, joinRaw(); !bytes.Equal(got, want) {
Joe Tsaie2afdc22018-10-25 14:06:56 -0700435 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
436 }
437
438 fs.Set(1, raw1a)
439 fs.Set(1, append(fs.Get(1), raw1b...))
440 fs.Set(1, append(fs.Get(1), raw1c...))
441 if got, want := fs.Len(), 1; got != want {
442 t.Errorf("Len() = %d, want %d", got, want)
443 }
Joe Tsai95b02902018-10-31 18:23:42 -0700444 if got, want := m.XXX_unrecognized, joinRaw(raw1a, raw1b, raw1c); !bytes.Equal(got, want) {
Joe Tsaie2afdc22018-10-25 14:06:56 -0700445 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
446 }
447
448 fs.Set(2, raw2a)
449 if got, want := fs.Len(), 2; got != want {
450 t.Errorf("Len() = %d, want %d", got, want)
451 }
Joe Tsai95b02902018-10-31 18:23:42 -0700452 if got, want := m.XXX_unrecognized, joinRaw(raw1a, raw1b, raw1c, raw2a); !bytes.Equal(got, want) {
Joe Tsaie2afdc22018-10-25 14:06:56 -0700453 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
454 }
455
456 if got, want := fs.Get(1), joinRaw(raw1a, raw1b, raw1c); !bytes.Equal(got, want) {
457 t.Errorf("Get(%d) = %x, want %x", 1, got, want)
458 }
459 if got, want := fs.Get(2), joinRaw(raw2a); !bytes.Equal(got, want) {
460 t.Errorf("Get(%d) = %x, want %x", 2, got, want)
461 }
462 if got, want := fs.Get(3), joinRaw(); !bytes.Equal(got, want) {
463 t.Errorf("Get(%d) = %x, want %x", 3, got, want)
464 }
465
466 fs.Set(1, nil) // remove field 1
467 if got, want := fs.Len(), 1; got != want {
468 t.Errorf("Len() = %d, want %d", got, want)
469 }
Joe Tsai95b02902018-10-31 18:23:42 -0700470 if got, want := m.XXX_unrecognized, joinRaw(raw2a); !bytes.Equal(got, want) {
Joe Tsaie2afdc22018-10-25 14:06:56 -0700471 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
472 }
473
474 // Simulate manual appending of raw field data.
Joe Tsai95b02902018-10-31 18:23:42 -0700475 m.XXX_unrecognized = append(m.XXX_unrecognized, joinRaw(raw3a, raw1a, raw1b, raw2b, raw3b, raw1c)...)
Joe Tsaie2afdc22018-10-25 14:06:56 -0700476 if got, want := fs.Len(), 3; got != want {
477 t.Errorf("Len() = %d, want %d", got, want)
478 }
479
480 // Verify range iteration order.
481 var i int
482 want := []struct {
483 num pref.FieldNumber
484 raw pref.RawFields
485 }{
Joe Tsaie2afdc22018-10-25 14:06:56 -0700486 {2, joinRaw(raw2a, raw2b)},
Joe Tsai2d5a1692018-10-29 02:10:42 -0700487 {3, joinRaw(raw3a, raw3b)},
Joe Tsaie2afdc22018-10-25 14:06:56 -0700488 {1, joinRaw(raw1a, raw1b, raw1c)},
489 }
490 fs.Range(func(num pref.FieldNumber, raw pref.RawFields) bool {
491 if i < len(want) {
492 if num != want[i].num || !bytes.Equal(raw, want[i].raw) {
493 t.Errorf("Range(%d) = (%d, %x), want (%d, %x)", i, num, raw, want[i].num, want[i].raw)
494 }
495 } else {
496 t.Errorf("unexpected Range iteration: %d", i)
497 }
498 i++
499 return true
500 })
501
502 fs.Set(2, fs.Get(2)) // moves field 2 to the end
503 if got, want := fs.Len(), 3; got != want {
504 t.Errorf("Len() = %d, want %d", got, want)
505 }
Joe Tsai95b02902018-10-31 18:23:42 -0700506 if got, want := m.XXX_unrecognized, joinRaw(raw3a, raw1a, raw1b, raw3b, raw1c, raw2a, raw2b); !bytes.Equal(got, want) {
Joe Tsaie2afdc22018-10-25 14:06:56 -0700507 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
508 }
509 fs.Set(1, nil) // remove field 1
510 if got, want := fs.Len(), 2; got != want {
511 t.Errorf("Len() = %d, want %d", got, want)
512 }
Joe Tsai95b02902018-10-31 18:23:42 -0700513 if got, want := m.XXX_unrecognized, joinRaw(raw3a, raw3b, raw2a, raw2b); !bytes.Equal(got, want) {
Joe Tsaie2afdc22018-10-25 14:06:56 -0700514 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
515 }
516
517 // Remove all fields.
518 fs.Range(func(n pref.FieldNumber, b pref.RawFields) bool {
519 fs.Set(n, nil)
520 return true
521 })
522 if got, want := fs.Len(), 0; got != want {
523 t.Errorf("Len() = %d, want %d", got, want)
524 }
Joe Tsai95b02902018-10-31 18:23:42 -0700525 if got, want := m.XXX_unrecognized, joinRaw(); !bytes.Equal(got, want) {
Joe Tsaie2afdc22018-10-25 14:06:56 -0700526 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
527 }
Joe Tsai95b02902018-10-31 18:23:42 -0700528
529 fs.Set(1, raw1)
530 if got, want := fs.Len(), 1; got != want {
531 t.Errorf("Len() = %d, want %d", got, want)
532 }
533 if got, want := m.XXX_unrecognized, joinRaw(raw1); !bytes.Equal(got, want) {
534 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
535 }
536
537 fs.Set(45, raw45)
538 fs.Set(10, raw10) // extension
539 fs.Set(32, raw32)
540 fs.Set(1, nil) // deletion
541 fs.Set(26, raw26)
542 fs.Set(47, raw47) // extension
543 fs.Set(46, raw46) // extension
544 if got, want := fs.Len(), 6; got != want {
545 t.Errorf("Len() = %d, want %d", got, want)
546 }
547 if got, want := m.XXX_unrecognized, joinRaw(raw32, raw26); !bytes.Equal(got, want) {
548 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
549 }
550
551 // Verify iteration order.
552 i = 0
553 want = []struct {
554 num pref.FieldNumber
555 raw pref.RawFields
556 }{
557 {32, raw32},
558 {26, raw26},
559 {10, raw10}, // extension
560 {45, raw45}, // extension
561 {46, raw46}, // extension
562 {47, raw47}, // extension
563 }
564 fs.Range(func(num pref.FieldNumber, raw pref.RawFields) bool {
565 if i < len(want) {
566 if num != want[i].num || !bytes.Equal(raw, want[i].raw) {
567 t.Errorf("Range(%d) = (%d, %x), want (%d, %x)", i, num, raw, want[i].num, want[i].raw)
568 }
569 } else {
570 t.Errorf("unexpected Range iteration: %d", i)
571 }
572 i++
573 return true
574 })
575
576 // Perform partial deletion while iterating.
577 i = 0
578 fs.Range(func(num pref.FieldNumber, raw pref.RawFields) bool {
579 if i%2 == 0 {
580 fs.Set(num, nil)
581 }
582 i++
583 return true
584 })
585
586 if got, want := fs.Len(), 3; got != want {
587 t.Errorf("Len() = %d, want %d", got, want)
588 }
589 if got, want := m.XXX_unrecognized, joinRaw(raw26); !bytes.Equal(got, want) {
590 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
591 }
592
593 fs.Set(15, raw15) // extension
594 fs.Set(3, raw3)
595 fs.Set(99, raw99)
596 if got, want := fs.Len(), 6; got != want {
597 t.Errorf("Len() = %d, want %d", got, want)
598 }
599 if got, want := m.XXX_unrecognized, joinRaw(raw26, raw3, raw99); !bytes.Equal(got, want) {
600 t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want)
601 }
602
603 // Perform partial iteration.
604 i = 0
605 want = []struct {
606 num pref.FieldNumber
607 raw pref.RawFields
608 }{
609 {26, raw26},
610 {3, raw3},
611 }
612 fs.Range(func(num pref.FieldNumber, raw pref.RawFields) bool {
613 if i < len(want) {
614 if num != want[i].num || !bytes.Equal(raw, want[i].raw) {
615 t.Errorf("Range(%d) = (%d, %x), want (%d, %x)", i, num, raw, want[i].num, want[i].raw)
616 }
617 } else {
618 t.Errorf("unexpected Range iteration: %d", i)
619 }
620 i++
621 return i < 2
622 })
Joe Tsaie2afdc22018-10-25 14:06:56 -0700623}
Joe Tsaif0c01e42018-11-06 13:05:20 -0800624
625func TestLegactExtensions(t *testing.T) {
626 extensions := []pref.ExtensionType{
627 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
628 ExtendedType: (*legacyTestMessage)(nil),
629 ExtensionType: (*bool)(nil),
630 Field: 10000,
631 Name: "fizz.buzz.optional_bool",
632 Tag: "varint,10000,opt,name=optional_bool,json=optionalBool,def=1",
633 Filename: "fizz/buzz/test.proto",
634 }),
635 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
636 ExtendedType: (*legacyTestMessage)(nil),
637 ExtensionType: (*int32)(nil),
638 Field: 10001,
639 Name: "fizz.buzz.optional_int32",
640 Tag: "varint,10001,opt,name=optional_int32,json=optionalInt32,def=-12345",
641 Filename: "fizz/buzz/test.proto",
642 }),
643 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
644 ExtendedType: (*legacyTestMessage)(nil),
645 ExtensionType: (*uint32)(nil),
646 Field: 10002,
647 Name: "fizz.buzz.optional_uint32",
648 Tag: "varint,10002,opt,name=optional_uint32,json=optionalUint32,def=3200",
649 Filename: "fizz/buzz/test.proto",
650 }),
651 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
652 ExtendedType: (*legacyTestMessage)(nil),
653 ExtensionType: (*float32)(nil),
654 Field: 10003,
655 Name: "fizz.buzz.optional_float",
656 Tag: "fixed32,10003,opt,name=optional_float,json=optionalFloat,def=3.14159",
657 Filename: "fizz/buzz/test.proto",
658 }),
659 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
660 ExtendedType: (*legacyTestMessage)(nil),
661 ExtensionType: (*string)(nil),
662 Field: 10004,
663 Name: "fizz.buzz.optional_string",
664 Tag: "bytes,10004,opt,name=optional_string,json=optionalString,def=hello, \"world!\"\n",
665 Filename: "fizz/buzz/test.proto",
666 }),
667 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
668 ExtendedType: (*legacyTestMessage)(nil),
669 ExtensionType: ([]byte)(nil),
670 Field: 10005,
671 Name: "fizz.buzz.optional_bytes",
672 Tag: "bytes,10005,opt,name=optional_bytes,json=optionalBytes,def=dead\\336\\255\\276\\357beef",
673 Filename: "fizz/buzz/test.proto",
674 }),
675 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
676 ExtendedType: (*legacyTestMessage)(nil),
677 ExtensionType: (*proto2_20180125.Message_ChildEnum)(nil),
678 Field: 10006,
Joe Tsai87b955b2018-11-14 21:59:49 -0800679 Name: "fizz.buzz.optional_enum_v1",
680 Tag: "varint,10006,opt,name=optional_enum_v1,json=optionalEnumV1,enum=google.golang.org.proto2_20180125.Message_ChildEnum,def=0",
Joe Tsaif0c01e42018-11-06 13:05:20 -0800681 Filename: "fizz/buzz/test.proto",
682 }),
683 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
684 ExtendedType: (*legacyTestMessage)(nil),
685 ExtensionType: (*proto2_20180125.Message_ChildMessage)(nil),
686 Field: 10007,
Joe Tsai87b955b2018-11-14 21:59:49 -0800687 Name: "fizz.buzz.optional_message_v1",
688 Tag: "bytes,10007,opt,name=optional_message_v1,json=optionalMessageV1",
Joe Tsaif0c01e42018-11-06 13:05:20 -0800689 Filename: "fizz/buzz/test.proto",
690 }),
Joe Tsai87b955b2018-11-14 21:59:49 -0800691 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
692 ExtendedType: (*legacyTestMessage)(nil),
693 ExtensionType: (*EnumProto2)(nil),
694 Field: 10008,
695 Name: "fizz.buzz.optional_enum_v2",
696 Tag: "varint,10008,opt,name=optional_enum_v2,json=optionalEnumV2,enum=EnumProto2,def=57005",
697 Filename: "fizz/buzz/test.proto",
698 }),
699 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
700 ExtendedType: (*legacyTestMessage)(nil),
701 ExtensionType: (*EnumMessages)(nil),
702 Field: 10009,
703 Name: "fizz.buzz.optional_message_v2",
704 Tag: "bytes,10009,opt,name=optional_message_v2,json=optionalMessageV2",
705 Filename: "fizz/buzz/test.proto",
706 }),
Joe Tsaif0c01e42018-11-06 13:05:20 -0800707 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
708 ExtendedType: (*legacyTestMessage)(nil),
709 ExtensionType: ([]bool)(nil),
Joe Tsai87b955b2018-11-14 21:59:49 -0800710 Field: 10010,
Joe Tsaif0c01e42018-11-06 13:05:20 -0800711 Name: "fizz.buzz.repeated_bool",
Joe Tsai87b955b2018-11-14 21:59:49 -0800712 Tag: "varint,10010,rep,name=repeated_bool,json=repeatedBool",
Joe Tsaif0c01e42018-11-06 13:05:20 -0800713 Filename: "fizz/buzz/test.proto",
714 }),
715 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
716 ExtendedType: (*legacyTestMessage)(nil),
717 ExtensionType: ([]int32)(nil),
Joe Tsai87b955b2018-11-14 21:59:49 -0800718 Field: 10011,
Joe Tsaif0c01e42018-11-06 13:05:20 -0800719 Name: "fizz.buzz.repeated_int32",
Joe Tsai87b955b2018-11-14 21:59:49 -0800720 Tag: "varint,10011,rep,name=repeated_int32,json=repeatedInt32",
Joe Tsaif0c01e42018-11-06 13:05:20 -0800721 Filename: "fizz/buzz/test.proto",
722 }),
723 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
724 ExtendedType: (*legacyTestMessage)(nil),
725 ExtensionType: ([]uint32)(nil),
Joe Tsai87b955b2018-11-14 21:59:49 -0800726 Field: 10012,
Joe Tsaif0c01e42018-11-06 13:05:20 -0800727 Name: "fizz.buzz.repeated_uint32",
Joe Tsai87b955b2018-11-14 21:59:49 -0800728 Tag: "varint,10012,rep,name=repeated_uint32,json=repeatedUint32",
Joe Tsaif0c01e42018-11-06 13:05:20 -0800729 Filename: "fizz/buzz/test.proto",
730 }),
731 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
732 ExtendedType: (*legacyTestMessage)(nil),
733 ExtensionType: ([]float32)(nil),
Joe Tsai87b955b2018-11-14 21:59:49 -0800734 Field: 10013,
Joe Tsaif0c01e42018-11-06 13:05:20 -0800735 Name: "fizz.buzz.repeated_float",
Joe Tsai87b955b2018-11-14 21:59:49 -0800736 Tag: "fixed32,10013,rep,name=repeated_float,json=repeatedFloat",
Joe Tsaif0c01e42018-11-06 13:05:20 -0800737 Filename: "fizz/buzz/test.proto",
738 }),
739 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
740 ExtendedType: (*legacyTestMessage)(nil),
741 ExtensionType: ([]string)(nil),
Joe Tsai87b955b2018-11-14 21:59:49 -0800742 Field: 10014,
Joe Tsaif0c01e42018-11-06 13:05:20 -0800743 Name: "fizz.buzz.repeated_string",
Joe Tsai87b955b2018-11-14 21:59:49 -0800744 Tag: "bytes,10014,rep,name=repeated_string,json=repeatedString",
Joe Tsaif0c01e42018-11-06 13:05:20 -0800745 Filename: "fizz/buzz/test.proto",
746 }),
747 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
748 ExtendedType: (*legacyTestMessage)(nil),
749 ExtensionType: ([][]byte)(nil),
Joe Tsai87b955b2018-11-14 21:59:49 -0800750 Field: 10015,
Joe Tsaif0c01e42018-11-06 13:05:20 -0800751 Name: "fizz.buzz.repeated_bytes",
Joe Tsai87b955b2018-11-14 21:59:49 -0800752 Tag: "bytes,10015,rep,name=repeated_bytes,json=repeatedBytes",
Joe Tsaif0c01e42018-11-06 13:05:20 -0800753 Filename: "fizz/buzz/test.proto",
754 }),
755 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
756 ExtendedType: (*legacyTestMessage)(nil),
757 ExtensionType: ([]proto2_20180125.Message_ChildEnum)(nil),
Joe Tsai87b955b2018-11-14 21:59:49 -0800758 Field: 10016,
759 Name: "fizz.buzz.repeated_enum_v1",
760 Tag: "varint,10016,rep,name=repeated_enum_v1,json=repeatedEnumV1,enum=google.golang.org.proto2_20180125.Message_ChildEnum",
Joe Tsaif0c01e42018-11-06 13:05:20 -0800761 Filename: "fizz/buzz/test.proto",
762 }),
763 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
764 ExtendedType: (*legacyTestMessage)(nil),
765 ExtensionType: ([]*proto2_20180125.Message_ChildMessage)(nil),
Joe Tsai87b955b2018-11-14 21:59:49 -0800766 Field: 10017,
767 Name: "fizz.buzz.repeated_message_v1",
768 Tag: "bytes,10017,rep,name=repeated_message_v1,json=repeatedMessageV1",
Joe Tsaif0c01e42018-11-06 13:05:20 -0800769 Filename: "fizz/buzz/test.proto",
770 }),
Joe Tsai87b955b2018-11-14 21:59:49 -0800771 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
772 ExtendedType: (*legacyTestMessage)(nil),
773 ExtensionType: ([]EnumProto2)(nil),
774 Field: 10018,
775 Name: "fizz.buzz.repeated_enum_v2",
776 Tag: "varint,10018,rep,name=repeated_enum_v2,json=repeatedEnumV2,enum=EnumProto2",
777 Filename: "fizz/buzz/test.proto",
778 }),
779 legacyExtensionTypeOf(&protoV1.ExtensionDesc{
780 ExtendedType: (*legacyTestMessage)(nil),
781 ExtensionType: ([]*EnumMessages)(nil),
782 Field: 10019,
783 Name: "fizz.buzz.repeated_message_v2",
784 Tag: "bytes,10019,rep,name=repeated_message_v2,json=repeatedMessageV2",
785 Filename: "fizz/buzz/test.proto",
786 }),
Joe Tsaif0c01e42018-11-06 13:05:20 -0800787 }
788 opts := cmp.Options{cmp.Comparer(func(x, y *proto2_20180125.Message_ChildMessage) bool {
789 return x == y // pointer compare messages for object identity
790 })}
791
792 m := new(legacyTestMessage)
793 fs := MessageOf(m).KnownFields()
794 ts := fs.ExtensionTypes()
795
796 if n := fs.Len(); n != 0 {
797 t.Errorf("KnownFields.Len() = %v, want 0", n)
798 }
799 if n := ts.Len(); n != 0 {
800 t.Errorf("ExtensionFieldTypes.Len() = %v, want 0", n)
801 }
802
803 // Register all the extension types.
804 for _, xt := range extensions {
805 ts.Register(xt)
806 }
807
808 // Check that getting the zero value returns the default value for scalars,
Joe Tsai4b7aff62018-11-14 14:05:19 -0800809 // nil for singular messages, and an empty list for repeated fields.
Joe Tsaif0c01e42018-11-06 13:05:20 -0800810 defaultValues := []interface{}{
811 bool(true),
812 int32(-12345),
813 uint32(3200),
814 float32(3.14159),
815 string("hello, \"world!\"\n"),
816 []byte("dead\xde\xad\xbe\xefbeef"),
817 proto2_20180125.Message_ALPHA,
818 nil,
Joe Tsai87b955b2018-11-14 21:59:49 -0800819 EnumProto2(0xdead),
820 nil,
Joe Tsaif0c01e42018-11-06 13:05:20 -0800821 new([]bool),
822 new([]int32),
823 new([]uint32),
824 new([]float32),
825 new([]string),
826 new([][]byte),
827 new([]proto2_20180125.Message_ChildEnum),
828 new([]*proto2_20180125.Message_ChildMessage),
Joe Tsai87b955b2018-11-14 21:59:49 -0800829 new([]EnumProto2),
830 new([]*EnumMessages),
Joe Tsaif0c01e42018-11-06 13:05:20 -0800831 }
832 for i, xt := range extensions {
833 var got interface{}
Joe Tsaif6d4a422018-11-19 14:26:06 -0800834 if v := fs.Get(xt.Number()); v.IsValid() {
835 got = xt.InterfaceOf(v)
Joe Tsaif0c01e42018-11-06 13:05:20 -0800836 }
837 want := defaultValues[i]
838 if diff := cmp.Diff(want, got, opts); diff != "" {
839 t.Errorf("KnownFields.Get(%d) mismatch (-want +got):\n%v", xt.Number(), diff)
840 }
841 }
842
843 // All fields should be unpopulated.
844 for _, xt := range extensions {
845 if fs.Has(xt.Number()) {
846 t.Errorf("KnownFields.Has(%d) = true, want false", xt.Number())
847 }
848 }
849
Joe Tsai4b7aff62018-11-14 14:05:19 -0800850 // Set some values and append to values to the lists.
Joe Tsai87b955b2018-11-14 21:59:49 -0800851 m1a := &proto2_20180125.Message_ChildMessage{F1: protoV1.String("m1a")}
852 m1b := &proto2_20180125.Message_ChildMessage{F1: protoV1.String("m2b")}
853 m2a := &EnumMessages{EnumP2: EnumProto2(0x1b).Enum()}
854 m2b := &EnumMessages{EnumP2: EnumProto2(0x2b).Enum()}
Joe Tsaif0c01e42018-11-06 13:05:20 -0800855 setValues := []interface{}{
856 bool(false),
857 int32(-54321),
858 uint32(6400),
859 float32(2.71828),
860 string("goodbye, \"world!\"\n"),
861 []byte("live\xde\xad\xbe\xefchicken"),
862 proto2_20180125.Message_CHARLIE,
Joe Tsai87b955b2018-11-14 21:59:49 -0800863 m1a,
864 EnumProto2(0xbeef),
865 m2a,
Joe Tsaif0c01e42018-11-06 13:05:20 -0800866 &[]bool{true},
867 &[]int32{-1000},
868 &[]uint32{1280},
869 &[]float32{1.6180},
870 &[]string{"zero"},
871 &[][]byte{[]byte("zero")},
872 &[]proto2_20180125.Message_ChildEnum{proto2_20180125.Message_BRAVO},
Joe Tsai87b955b2018-11-14 21:59:49 -0800873 &[]*proto2_20180125.Message_ChildMessage{m1b},
874 &[]EnumProto2{0xdead},
875 &[]*EnumMessages{m2b},
Joe Tsaif0c01e42018-11-06 13:05:20 -0800876 }
877 for i, xt := range extensions {
878 fs.Set(xt.Number(), xt.ValueOf(setValues[i]))
879 }
880 for i, xt := range extensions[len(extensions)/2:] {
881 v := extensions[i].ValueOf(setValues[i])
Joe Tsai4b7aff62018-11-14 14:05:19 -0800882 fs.Get(xt.Number()).List().Append(v)
Joe Tsaif0c01e42018-11-06 13:05:20 -0800883 }
884
885 // Get the values and check for equality.
886 getValues := []interface{}{
887 bool(false),
888 int32(-54321),
889 uint32(6400),
890 float32(2.71828),
891 string("goodbye, \"world!\"\n"),
892 []byte("live\xde\xad\xbe\xefchicken"),
893 proto2_20180125.Message_ChildEnum(proto2_20180125.Message_CHARLIE),
Joe Tsai87b955b2018-11-14 21:59:49 -0800894 m1a,
895 EnumProto2(0xbeef),
896 m2a,
Joe Tsaif0c01e42018-11-06 13:05:20 -0800897 &[]bool{true, false},
898 &[]int32{-1000, -54321},
899 &[]uint32{1280, 6400},
900 &[]float32{1.6180, 2.71828},
901 &[]string{"zero", "goodbye, \"world!\"\n"},
902 &[][]byte{[]byte("zero"), []byte("live\xde\xad\xbe\xefchicken")},
903 &[]proto2_20180125.Message_ChildEnum{proto2_20180125.Message_BRAVO, proto2_20180125.Message_CHARLIE},
Joe Tsai87b955b2018-11-14 21:59:49 -0800904 &[]*proto2_20180125.Message_ChildMessage{m1b, m1a},
905 &[]EnumProto2{0xdead, 0xbeef},
906 &[]*EnumMessages{m2b, m2a},
Joe Tsaif0c01e42018-11-06 13:05:20 -0800907 }
908 for i, xt := range extensions {
909 got := xt.InterfaceOf(fs.Get(xt.Number()))
910 want := getValues[i]
911 if diff := cmp.Diff(want, got, opts); diff != "" {
912 t.Errorf("KnownFields.Get(%d) mismatch (-want +got):\n%v", xt.Number(), diff)
913 }
914 }
915
Joe Tsai87b955b2018-11-14 21:59:49 -0800916 if n := fs.Len(); n != 20 {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800917 t.Errorf("KnownFields.Len() = %v, want 0", n)
918 }
Joe Tsai87b955b2018-11-14 21:59:49 -0800919 if n := ts.Len(); n != 20 {
920 t.Errorf("ExtensionFieldTypes.Len() = %v, want 20", n)
Joe Tsaif0c01e42018-11-06 13:05:20 -0800921 }
922
923 // Clear the field for all extension types.
Joe Tsaif6d4a422018-11-19 14:26:06 -0800924 for _, xt := range extensions[:len(extensions)/2] {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800925 fs.Clear(xt.Number())
926 }
Joe Tsaif6d4a422018-11-19 14:26:06 -0800927 for i, xt := range extensions[len(extensions)/2:] {
928 if i%2 == 0 {
929 fs.Clear(xt.Number())
930 } else {
931 fs.Get(xt.Number()).List().Truncate(0)
932 }
933 }
Joe Tsaif0c01e42018-11-06 13:05:20 -0800934 if n := fs.Len(); n != 0 {
935 t.Errorf("KnownFields.Len() = %v, want 0", n)
936 }
Joe Tsai87b955b2018-11-14 21:59:49 -0800937 if n := ts.Len(); n != 20 {
938 t.Errorf("ExtensionFieldTypes.Len() = %v, want 20", n)
Joe Tsaif0c01e42018-11-06 13:05:20 -0800939 }
940
941 // De-register all extension types.
942 for _, xt := range extensions {
943 ts.Remove(xt)
944 }
945 if n := fs.Len(); n != 0 {
946 t.Errorf("KnownFields.Len() = %v, want 0", n)
947 }
948 if n := ts.Len(); n != 0 {
949 t.Errorf("ExtensionFieldTypes.Len() = %v, want 0", n)
950 }
951
952}