blob: 1c758d2015a606974d684936c65f70dbdc76ff72 [file] [log] [blame]
Joe Tsai90fe9962018-10-18 11:06:29 -07001// Copyright 2018 The Go Authors. All rights reserved.
2// Use of this source code is governed by a BSD-style
3// license that can be found in the LICENSE file.
4
Joe Tsai08e00302018-11-26 22:32:06 -08005package impl_test
Joe Tsai90fe9962018-10-18 11:06:29 -07006
7import (
Joe Tsaid8881392019-06-06 13:01:53 -07008 "fmt"
Joe Tsai90fe9962018-10-18 11:06:29 -07009 "reflect"
Joe Tsai21ade492019-05-22 13:42:54 -040010 "sync"
Joe Tsai90fe9962018-10-18 11:06:29 -070011 "testing"
12
Joe Tsai378c1322019-04-25 23:48:08 -070013 "github.com/google/go-cmp/cmp"
14 "github.com/google/go-cmp/cmp/cmpopts"
Joe Tsaid8881392019-06-06 13:01:53 -070015 "google.golang.org/protobuf/encoding/prototext"
Damien Neile89e6242019-05-13 23:55:40 -070016 pimpl "google.golang.org/protobuf/internal/impl"
Joe Tsaid8881392019-06-06 13:01:53 -070017 "google.golang.org/protobuf/internal/pragma"
Joe Tsai378c1322019-04-25 23:48:08 -070018 "google.golang.org/protobuf/internal/scalar"
Joe Tsaid8881392019-06-06 13:01:53 -070019 "google.golang.org/protobuf/proto"
20 pdesc "google.golang.org/protobuf/reflect/protodesc"
Damien Neile89e6242019-05-13 23:55:40 -070021 pref "google.golang.org/protobuf/reflect/protoreflect"
22 preg "google.golang.org/protobuf/reflect/protoregistry"
23 piface "google.golang.org/protobuf/runtime/protoiface"
Joe Tsaiea118132018-11-11 17:56:21 -080024
Damien Neile89e6242019-05-13 23:55:40 -070025 proto2_20180125 "google.golang.org/protobuf/internal/testprotos/legacy/proto2.v1.0.0-20180125-92554152"
Joe Tsaid8881392019-06-06 13:01:53 -070026 "google.golang.org/protobuf/types/descriptorpb"
Joe Tsai90fe9962018-10-18 11:06:29 -070027)
28
Joe Tsaid8881392019-06-06 13:01:53 -070029type LegacyTestMessage struct {
Joe Tsai4fddeba2019-03-20 18:29:32 -070030 XXX_unrecognized []byte
Joe Tsai89d49632019-06-04 16:20:00 -070031 XXX_InternalExtensions map[int32]pimpl.ExtensionField
Joe Tsai95b02902018-10-31 18:23:42 -070032}
33
Joe Tsaid8881392019-06-06 13:01:53 -070034func (*LegacyTestMessage) Reset() {}
35func (*LegacyTestMessage) String() string { return "" }
36func (*LegacyTestMessage) ProtoMessage() {}
37func (*LegacyTestMessage) ExtensionRangeArray() []piface.ExtensionRangeV1 {
Joe Tsai4fddeba2019-03-20 18:29:32 -070038 return []piface.ExtensionRangeV1{{Start: 10, End: 20}, {Start: 40, End: 80}, {Start: 10000, End: 20000}}
Joe Tsai95b02902018-10-31 18:23:42 -070039}
Joe Tsaid8881392019-06-06 13:01:53 -070040func (*LegacyTestMessage) Descriptor() ([]byte, []int) { return legacyFD, []int{0} }
41
42var legacyFD = func() []byte {
43 b, _ := proto.Marshal(pdesc.ToFileDescriptorProto(mustMakeFileDesc(`
44 name: "legacy.proto"
45 syntax: "proto2"
46 message_type: [{
47 name: "LegacyTestMessage"
48 extension_range: [{start:10 end:20}, {start:40 end:80}, {start:10000 end:20000}]
49 }]
50 `, nil)))
51 return pimpl.Export{}.CompressGZIP(b)
52}()
Joe Tsai95b02902018-10-31 18:23:42 -070053
Joe Tsai0fc49f82019-05-01 12:29:25 -070054func init() {
Joe Tsaid8881392019-06-06 13:01:53 -070055 mt := pimpl.Export{}.MessageTypeOf((*LegacyTestMessage)(nil))
56 preg.GlobalFiles.Register(mt.ParentFile())
Joe Tsai0fc49f82019-05-01 12:29:25 -070057 preg.GlobalTypes.Register(mt)
58}
59
Joe Tsaid8881392019-06-06 13:01:53 -070060func mustMakeExtensionType(fileDesc, extDesc string, t interface{}, r pdesc.Resolver) pref.ExtensionType {
61 s := fmt.Sprintf(`name:"test.proto" syntax:"proto2" %s extension:[{%s}]`, fileDesc, extDesc)
62 xd := mustMakeFileDesc(s, r).Extensions().Get(0)
63 return pimpl.LegacyExtensionTypeOf(xd, reflect.TypeOf(t))
64}
65
66func mustMakeFileDesc(s string, r pdesc.Resolver) pref.FileDescriptor {
67 pb := new(descriptorpb.FileDescriptorProto)
68 if err := prototext.Unmarshal([]byte(s), pb); err != nil {
69 panic(err)
70 }
71 fd, err := pdesc.NewFile(pb, r)
72 if err != nil {
73 panic(err)
74 }
75 return fd
76}
77
Joe Tsai08e00302018-11-26 22:32:06 -080078var (
Joe Tsaid8881392019-06-06 13:01:53 -070079 testParentDesc = pimpl.Export{}.MessageDescriptorOf((*LegacyTestMessage)(nil))
Joe Tsai21ade492019-05-22 13:42:54 -040080 testEnumV1Desc = pimpl.Export{}.EnumDescriptorOf(proto2_20180125.Message_ChildEnum(0))
81 testMessageV1Desc = pimpl.Export{}.MessageDescriptorOf((*proto2_20180125.Message_ChildMessage)(nil))
82 testEnumV2Desc = enumProto2Type.Descriptor()
83 testMessageV2Desc = enumMessagesType.PBType.Descriptor()
Joe Tsai08e00302018-11-26 22:32:06 -080084
Joe Tsaid8881392019-06-06 13:01:53 -070085 depReg = preg.NewFiles(
86 testParentDesc.ParentFile(),
87 testEnumV1Desc.ParentFile(),
88 testMessageV1Desc.ParentFile(),
89 testEnumV2Desc.ParentFile(),
90 testMessageV2Desc.ParentFile(),
91 )
Joe Tsai08e00302018-11-26 22:32:06 -080092 extensionTypes = []pref.ExtensionType{
Joe Tsaid8881392019-06-06 13:01:53 -070093 mustMakeExtensionType(
94 `package:"fizz.buzz" dependency:"legacy.proto"`,
95 `name:"optional_bool" number:10000 label:LABEL_OPTIONAL type:TYPE_BOOL default_value:"true" extendee:".LegacyTestMessage"`,
96 nil, depReg,
97 ),
98 mustMakeExtensionType(
99 `package:"fizz.buzz" dependency:"legacy.proto"`,
100 `name:"optional_int32" number:10001 label:LABEL_OPTIONAL type:TYPE_INT32 default_value:"-12345" extendee:".LegacyTestMessage"`,
101 nil, depReg,
102 ),
103 mustMakeExtensionType(
104 `package:"fizz.buzz" dependency:"legacy.proto"`,
105 `name:"optional_uint32" number:10002 label:LABEL_OPTIONAL type:TYPE_UINT32 default_value:"3200" extendee:".LegacyTestMessage"`,
106 nil, depReg,
107 ),
108 mustMakeExtensionType(
109 `package:"fizz.buzz" dependency:"legacy.proto"`,
110 `name:"optional_float" number:10003 label:LABEL_OPTIONAL type:TYPE_FLOAT default_value:"3.14159" extendee:".LegacyTestMessage"`,
111 nil, depReg,
112 ),
113 mustMakeExtensionType(
114 `package:"fizz.buzz" dependency:"legacy.proto"`,
115 `name:"optional_string" number:10004 label:LABEL_OPTIONAL type:TYPE_STRING default_value:"hello, \"world!\"\n" extendee:".LegacyTestMessage"`,
116 nil, depReg,
117 ),
118 mustMakeExtensionType(
119 `package:"fizz.buzz" dependency:"legacy.proto"`,
120 `name:"optional_bytes" number:10005 label:LABEL_OPTIONAL type:TYPE_BYTES default_value:"dead\\336\\255\\276\\357beef" extendee:".LegacyTestMessage"`,
121 nil, depReg,
122 ),
123 mustMakeExtensionType(
124 `package:"fizz.buzz" dependency:["legacy.proto", "proto2.v1.0.0-20180125-92554152/test.proto"]`,
125 `name:"optional_enum_v1" number:10006 label:LABEL_OPTIONAL type:TYPE_ENUM type_name:".google.golang.org.proto2_20180125.Message.ChildEnum" default_value:"ALPHA" extendee:".LegacyTestMessage"`,
126 proto2_20180125.Message_ChildEnum(0), depReg,
127 ),
128 mustMakeExtensionType(
129 `package:"fizz.buzz" dependency:["legacy.proto", "proto2.v1.0.0-20180125-92554152/test.proto"]`,
130 `name:"optional_message_v1" number:10007 label:LABEL_OPTIONAL type:TYPE_MESSAGE type_name:".google.golang.org.proto2_20180125.Message.ChildMessage" extendee:".LegacyTestMessage"`,
131 (*proto2_20180125.Message_ChildMessage)(nil), depReg,
132 ),
133 mustMakeExtensionType(
134 `package:"fizz.buzz" dependency:["legacy.proto", "enum2.proto"]`,
135 `name:"optional_enum_v2" number:10008 label:LABEL_OPTIONAL type:TYPE_ENUM type_name:".EnumProto2" default_value:"DEAD" extendee:".LegacyTestMessage"`,
136 EnumProto2(0), depReg,
137 ),
138 mustMakeExtensionType(
139 `package:"fizz.buzz" dependency:["legacy.proto", "enum-messages.proto"]`,
140 `name:"optional_message_v2" number:10009 label:LABEL_OPTIONAL type:TYPE_MESSAGE type_name:".EnumMessages" extendee:".LegacyTestMessage"`,
141 (*EnumMessages)(nil), depReg,
142 ),
143 mustMakeExtensionType(
144 `package:"fizz.buzz" dependency:"legacy.proto"`,
145 `name:"repeated_bool" number:10010 label:LABEL_REPEATED type:TYPE_BOOL extendee:".LegacyTestMessage"`,
146 nil, depReg,
147 ),
148 mustMakeExtensionType(
149 `package:"fizz.buzz" dependency:"legacy.proto"`,
150 `name:"repeated_int32" number:10011 label:LABEL_REPEATED type:TYPE_INT32 extendee:".LegacyTestMessage"`,
151 nil, depReg,
152 ),
153 mustMakeExtensionType(
154 `package:"fizz.buzz" dependency:"legacy.proto"`,
155 `name:"repeated_uint32" number:10012 label:LABEL_REPEATED type:TYPE_UINT32 extendee:".LegacyTestMessage"`,
156 nil, depReg,
157 ),
158 mustMakeExtensionType(
159 `package:"fizz.buzz" dependency:"legacy.proto"`,
160 `name:"repeated_float" number:10013 label:LABEL_REPEATED type:TYPE_FLOAT extendee:".LegacyTestMessage"`,
161 nil, depReg,
162 ),
163 mustMakeExtensionType(
164 `package:"fizz.buzz" dependency:"legacy.proto"`,
165 `name:"repeated_string" number:10014 label:LABEL_REPEATED type:TYPE_STRING extendee:".LegacyTestMessage"`,
166 nil, depReg,
167 ),
168 mustMakeExtensionType(
169 `package:"fizz.buzz" dependency:"legacy.proto"`,
170 `name:"repeated_bytes" number:10015 label:LABEL_REPEATED type:TYPE_BYTES extendee:".LegacyTestMessage"`,
171 nil, depReg,
172 ),
173 mustMakeExtensionType(
174 `package:"fizz.buzz" dependency:["legacy.proto", "proto2.v1.0.0-20180125-92554152/test.proto"]`,
175 `name:"repeated_enum_v1" number:10016 label:LABEL_REPEATED type:TYPE_ENUM type_name:".google.golang.org.proto2_20180125.Message.ChildEnum" extendee:".LegacyTestMessage"`,
176 proto2_20180125.Message_ChildEnum(0), depReg,
177 ),
178 mustMakeExtensionType(
179 `package:"fizz.buzz" dependency:["legacy.proto", "proto2.v1.0.0-20180125-92554152/test.proto"]`,
180 `name:"repeated_message_v1" number:10017 label:LABEL_REPEATED type:TYPE_MESSAGE type_name:".google.golang.org.proto2_20180125.Message.ChildMessage" extendee:".LegacyTestMessage"`,
181 (*proto2_20180125.Message_ChildMessage)(nil), depReg,
182 ),
183 mustMakeExtensionType(
184 `package:"fizz.buzz" dependency:["legacy.proto", "enum2.proto"]`,
185 `name:"repeated_enum_v2" number:10018 label:LABEL_REPEATED type:TYPE_ENUM type_name:".EnumProto2" extendee:".LegacyTestMessage"`,
186 EnumProto2(0), depReg,
187 ),
188 mustMakeExtensionType(
189 `package:"fizz.buzz" dependency:["legacy.proto", "enum-messages.proto"]`,
190 `name:"repeated_message_v2" number:10019 label:LABEL_REPEATED type:TYPE_MESSAGE type_name:".EnumMessages" extendee:".LegacyTestMessage"`,
191 (*EnumMessages)(nil), depReg,
192 ),
Joe Tsai08e00302018-11-26 22:32:06 -0800193 }
194
Joe Tsai4fddeba2019-03-20 18:29:32 -0700195 extensionDescs = []*piface.ExtensionDescV1{{
Joe Tsaid8881392019-06-06 13:01:53 -0700196 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800197 ExtensionType: (*bool)(nil),
198 Field: 10000,
199 Name: "fizz.buzz.optional_bool",
200 Tag: "varint,10000,opt,name=optional_bool,def=1",
Joe Tsaid8881392019-06-06 13:01:53 -0700201 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800202 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700203 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800204 ExtensionType: (*int32)(nil),
205 Field: 10001,
206 Name: "fizz.buzz.optional_int32",
207 Tag: "varint,10001,opt,name=optional_int32,def=-12345",
Joe Tsaid8881392019-06-06 13:01:53 -0700208 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800209 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700210 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800211 ExtensionType: (*uint32)(nil),
212 Field: 10002,
213 Name: "fizz.buzz.optional_uint32",
214 Tag: "varint,10002,opt,name=optional_uint32,def=3200",
Joe Tsaid8881392019-06-06 13:01:53 -0700215 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800216 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700217 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800218 ExtensionType: (*float32)(nil),
219 Field: 10003,
220 Name: "fizz.buzz.optional_float",
221 Tag: "fixed32,10003,opt,name=optional_float,def=3.14159",
Joe Tsaid8881392019-06-06 13:01:53 -0700222 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800223 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700224 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800225 ExtensionType: (*string)(nil),
226 Field: 10004,
227 Name: "fizz.buzz.optional_string",
228 Tag: "bytes,10004,opt,name=optional_string,def=hello, \"world!\"\n",
Joe Tsaid8881392019-06-06 13:01:53 -0700229 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800230 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700231 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800232 ExtensionType: ([]byte)(nil),
233 Field: 10005,
234 Name: "fizz.buzz.optional_bytes",
235 Tag: "bytes,10005,opt,name=optional_bytes,def=dead\\336\\255\\276\\357beef",
Joe Tsaid8881392019-06-06 13:01:53 -0700236 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800237 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700238 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800239 ExtensionType: (*proto2_20180125.Message_ChildEnum)(nil),
240 Field: 10006,
241 Name: "fizz.buzz.optional_enum_v1",
242 Tag: "varint,10006,opt,name=optional_enum_v1,enum=google.golang.org.proto2_20180125.Message_ChildEnum,def=0",
Joe Tsaid8881392019-06-06 13:01:53 -0700243 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800244 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700245 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800246 ExtensionType: (*proto2_20180125.Message_ChildMessage)(nil),
247 Field: 10007,
248 Name: "fizz.buzz.optional_message_v1",
249 Tag: "bytes,10007,opt,name=optional_message_v1",
Joe Tsaid8881392019-06-06 13:01:53 -0700250 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800251 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700252 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800253 ExtensionType: (*EnumProto2)(nil),
254 Field: 10008,
255 Name: "fizz.buzz.optional_enum_v2",
256 Tag: "varint,10008,opt,name=optional_enum_v2,enum=EnumProto2,def=57005",
Joe Tsaid8881392019-06-06 13:01:53 -0700257 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800258 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700259 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800260 ExtensionType: (*EnumMessages)(nil),
261 Field: 10009,
262 Name: "fizz.buzz.optional_message_v2",
263 Tag: "bytes,10009,opt,name=optional_message_v2",
Joe Tsaid8881392019-06-06 13:01:53 -0700264 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800265 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700266 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800267 ExtensionType: ([]bool)(nil),
268 Field: 10010,
269 Name: "fizz.buzz.repeated_bool",
270 Tag: "varint,10010,rep,name=repeated_bool",
Joe Tsaid8881392019-06-06 13:01:53 -0700271 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800272 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700273 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800274 ExtensionType: ([]int32)(nil),
275 Field: 10011,
276 Name: "fizz.buzz.repeated_int32",
277 Tag: "varint,10011,rep,name=repeated_int32",
Joe Tsaid8881392019-06-06 13:01:53 -0700278 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800279 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700280 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800281 ExtensionType: ([]uint32)(nil),
282 Field: 10012,
283 Name: "fizz.buzz.repeated_uint32",
284 Tag: "varint,10012,rep,name=repeated_uint32",
Joe Tsaid8881392019-06-06 13:01:53 -0700285 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800286 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700287 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800288 ExtensionType: ([]float32)(nil),
289 Field: 10013,
290 Name: "fizz.buzz.repeated_float",
291 Tag: "fixed32,10013,rep,name=repeated_float",
Joe Tsaid8881392019-06-06 13:01:53 -0700292 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800293 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700294 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800295 ExtensionType: ([]string)(nil),
296 Field: 10014,
297 Name: "fizz.buzz.repeated_string",
298 Tag: "bytes,10014,rep,name=repeated_string",
Joe Tsaid8881392019-06-06 13:01:53 -0700299 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800300 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700301 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800302 ExtensionType: ([][]byte)(nil),
303 Field: 10015,
304 Name: "fizz.buzz.repeated_bytes",
305 Tag: "bytes,10015,rep,name=repeated_bytes",
Joe Tsaid8881392019-06-06 13:01:53 -0700306 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800307 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700308 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800309 ExtensionType: ([]proto2_20180125.Message_ChildEnum)(nil),
310 Field: 10016,
311 Name: "fizz.buzz.repeated_enum_v1",
312 Tag: "varint,10016,rep,name=repeated_enum_v1,enum=google.golang.org.proto2_20180125.Message_ChildEnum",
Joe Tsaid8881392019-06-06 13:01:53 -0700313 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800314 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700315 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800316 ExtensionType: ([]*proto2_20180125.Message_ChildMessage)(nil),
317 Field: 10017,
318 Name: "fizz.buzz.repeated_message_v1",
319 Tag: "bytes,10017,rep,name=repeated_message_v1",
Joe Tsaid8881392019-06-06 13:01:53 -0700320 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800321 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700322 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800323 ExtensionType: ([]EnumProto2)(nil),
324 Field: 10018,
325 Name: "fizz.buzz.repeated_enum_v2",
326 Tag: "varint,10018,rep,name=repeated_enum_v2,enum=EnumProto2",
Joe Tsaid8881392019-06-06 13:01:53 -0700327 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800328 }, {
Joe Tsaid8881392019-06-06 13:01:53 -0700329 ExtendedType: (*LegacyTestMessage)(nil),
Joe Tsai08e00302018-11-26 22:32:06 -0800330 ExtensionType: ([]*EnumMessages)(nil),
331 Field: 10019,
332 Name: "fizz.buzz.repeated_message_v2",
333 Tag: "bytes,10019,rep,name=repeated_message_v2",
Joe Tsaid8881392019-06-06 13:01:53 -0700334 Filename: "test.proto",
Joe Tsai08e00302018-11-26 22:32:06 -0800335 }}
336)
337
338func TestLegacyExtensions(t *testing.T) {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800339 opts := cmp.Options{cmp.Comparer(func(x, y *proto2_20180125.Message_ChildMessage) bool {
340 return x == y // pointer compare messages for object identity
341 })}
342
Joe Tsaid8881392019-06-06 13:01:53 -0700343 m := pimpl.Export{}.MessageOf(new(LegacyTestMessage))
Joe Tsaif0c01e42018-11-06 13:05:20 -0800344
Joe Tsaif0c01e42018-11-06 13:05:20 -0800345 // Check that getting the zero value returns the default value for scalars,
Joe Tsai4b7aff62018-11-14 14:05:19 -0800346 // nil for singular messages, and an empty list for repeated fields.
Joe Tsai378c1322019-04-25 23:48:08 -0700347 defaultValues := map[int]interface{}{
348 0: bool(true),
349 1: int32(-12345),
350 2: uint32(3200),
351 3: float32(3.14159),
352 4: string("hello, \"world!\"\n"),
353 5: []byte("dead\xde\xad\xbe\xefbeef"),
354 6: proto2_20180125.Message_ALPHA,
355 7: nil,
356 8: EnumProto2(0xdead),
357 9: nil,
Joe Tsaif0c01e42018-11-06 13:05:20 -0800358 }
Joe Tsai08e00302018-11-26 22:32:06 -0800359 for i, xt := range extensionTypes {
Joe Tsaif0c01e42018-11-06 13:05:20 -0800360 var got interface{}
Joe Tsai378c1322019-04-25 23:48:08 -0700361 if !(xt.IsList() || xt.IsMap() || xt.Message() != nil) {
362 got = xt.InterfaceOf(m.Get(xt))
Joe Tsaif0c01e42018-11-06 13:05:20 -0800363 }
364 want := defaultValues[i]
365 if diff := cmp.Diff(want, got, opts); diff != "" {
Joe Tsai378c1322019-04-25 23:48:08 -0700366 t.Errorf("Message.Get(%d) mismatch (-want +got):\n%v", xt.Number(), diff)
Joe Tsaif0c01e42018-11-06 13:05:20 -0800367 }
368 }
369
370 // All fields should be unpopulated.
Joe Tsai08e00302018-11-26 22:32:06 -0800371 for _, xt := range extensionTypes {
Joe Tsai378c1322019-04-25 23:48:08 -0700372 if m.Has(xt) {
373 t.Errorf("Message.Has(%d) = true, want false", xt.Number())
Joe Tsaif0c01e42018-11-06 13:05:20 -0800374 }
375 }
376
Joe Tsai4b7aff62018-11-14 14:05:19 -0800377 // Set some values and append to values to the lists.
Joe Tsai009e0672018-11-27 18:45:07 -0800378 m1a := &proto2_20180125.Message_ChildMessage{F1: scalar.String("m1a")}
379 m1b := &proto2_20180125.Message_ChildMessage{F1: scalar.String("m2b")}
Joe Tsai87b955b2018-11-14 21:59:49 -0800380 m2a := &EnumMessages{EnumP2: EnumProto2(0x1b).Enum()}
381 m2b := &EnumMessages{EnumP2: EnumProto2(0x2b).Enum()}
Joe Tsai378c1322019-04-25 23:48:08 -0700382 setValues := map[int]interface{}{
383 0: bool(false),
384 1: int32(-54321),
385 2: uint32(6400),
386 3: float32(2.71828),
387 4: string("goodbye, \"world!\"\n"),
388 5: []byte("live\xde\xad\xbe\xefchicken"),
389 6: proto2_20180125.Message_CHARLIE,
390 7: m1a,
391 8: EnumProto2(0xbeef),
392 9: m2a,
393 10: &[]bool{true},
394 11: &[]int32{-1000},
395 12: &[]uint32{1280},
396 13: &[]float32{1.6180},
397 14: &[]string{"zero"},
398 15: &[][]byte{[]byte("zero")},
399 16: &[]proto2_20180125.Message_ChildEnum{proto2_20180125.Message_BRAVO},
400 17: &[]*proto2_20180125.Message_ChildMessage{m1b},
401 18: &[]EnumProto2{0xdead},
402 19: &[]*EnumMessages{m2b},
Joe Tsaif0c01e42018-11-06 13:05:20 -0800403 }
Joe Tsai08e00302018-11-26 22:32:06 -0800404 for i, xt := range extensionTypes {
Joe Tsai378c1322019-04-25 23:48:08 -0700405 m.Set(xt, xt.ValueOf(setValues[i]))
Joe Tsaif0c01e42018-11-06 13:05:20 -0800406 }
Joe Tsai08e00302018-11-26 22:32:06 -0800407 for i, xt := range extensionTypes[len(extensionTypes)/2:] {
408 v := extensionTypes[i].ValueOf(setValues[i])
Joe Tsai378c1322019-04-25 23:48:08 -0700409 m.Get(xt).List().Append(v)
Joe Tsaif0c01e42018-11-06 13:05:20 -0800410 }
411
412 // Get the values and check for equality.
Joe Tsai378c1322019-04-25 23:48:08 -0700413 getValues := map[int]interface{}{
414 0: bool(false),
415 1: int32(-54321),
416 2: uint32(6400),
417 3: float32(2.71828),
418 4: string("goodbye, \"world!\"\n"),
419 5: []byte("live\xde\xad\xbe\xefchicken"),
420 6: proto2_20180125.Message_ChildEnum(proto2_20180125.Message_CHARLIE),
421 7: m1a,
422 8: EnumProto2(0xbeef),
423 9: m2a,
424 10: &[]bool{true, false},
425 11: &[]int32{-1000, -54321},
426 12: &[]uint32{1280, 6400},
427 13: &[]float32{1.6180, 2.71828},
428 14: &[]string{"zero", "goodbye, \"world!\"\n"},
429 15: &[][]byte{[]byte("zero"), []byte("live\xde\xad\xbe\xefchicken")},
430 16: &[]proto2_20180125.Message_ChildEnum{proto2_20180125.Message_BRAVO, proto2_20180125.Message_CHARLIE},
431 17: &[]*proto2_20180125.Message_ChildMessage{m1b, m1a},
432 18: &[]EnumProto2{0xdead, 0xbeef},
433 19: &[]*EnumMessages{m2b, m2a},
Joe Tsaif0c01e42018-11-06 13:05:20 -0800434 }
Joe Tsai08e00302018-11-26 22:32:06 -0800435 for i, xt := range extensionTypes {
Joe Tsai378c1322019-04-25 23:48:08 -0700436 got := xt.InterfaceOf(m.Get(xt))
Joe Tsaif0c01e42018-11-06 13:05:20 -0800437 want := getValues[i]
438 if diff := cmp.Diff(want, got, opts); diff != "" {
Joe Tsai378c1322019-04-25 23:48:08 -0700439 t.Errorf("Message.Get(%d) mismatch (-want +got):\n%v", xt.Number(), diff)
Joe Tsaif0c01e42018-11-06 13:05:20 -0800440 }
441 }
442
Joe Tsai378c1322019-04-25 23:48:08 -0700443 // Clear all singular fields and truncate all repeated fields.
Joe Tsai08e00302018-11-26 22:32:06 -0800444 for _, xt := range extensionTypes[:len(extensionTypes)/2] {
Joe Tsai378c1322019-04-25 23:48:08 -0700445 m.Clear(xt)
Joe Tsaif0c01e42018-11-06 13:05:20 -0800446 }
Joe Tsai378c1322019-04-25 23:48:08 -0700447 for _, xt := range extensionTypes[len(extensionTypes)/2:] {
448 m.Get(xt).List().Truncate(0)
Joe Tsaif6d4a422018-11-19 14:26:06 -0800449 }
Joe Tsaif0c01e42018-11-06 13:05:20 -0800450
Joe Tsai378c1322019-04-25 23:48:08 -0700451 // Clear all repeated fields.
452 for _, xt := range extensionTypes[len(extensionTypes)/2:] {
453 m.Clear(xt)
Joe Tsaif0c01e42018-11-06 13:05:20 -0800454 }
Joe Tsai08e00302018-11-26 22:32:06 -0800455}
Joe Tsaif0c01e42018-11-06 13:05:20 -0800456
Joe Tsai08e00302018-11-26 22:32:06 -0800457func TestExtensionConvert(t *testing.T) {
458 for i := range extensionTypes {
459 i := i
460 t.Run("", func(t *testing.T) {
461 t.Parallel()
462
463 wantType := extensionTypes[i]
464 wantDesc := extensionDescs[i]
Joe Tsai21ade492019-05-22 13:42:54 -0400465 gotType := pimpl.Export{}.ExtensionTypeFromDesc(wantDesc)
466 gotDesc := pimpl.Export{}.ExtensionDescFromType(wantType)
Joe Tsai08e00302018-11-26 22:32:06 -0800467
468 // TODO: We need a test package to compare descriptors.
469 type list interface {
470 Len() int
471 pragma.DoNotImplement
472 }
473 opts := cmp.Options{
474 cmp.Comparer(func(x, y reflect.Type) bool {
475 return x == y
476 }),
477 cmp.Transformer("", func(x list) []interface{} {
478 out := make([]interface{}, x.Len())
479 v := reflect.ValueOf(x)
480 for i := 0; i < x.Len(); i++ {
481 m := v.MethodByName("Get")
482 out[i] = m.Call([]reflect.Value{reflect.ValueOf(i)})[0].Interface()
483 }
484 return out
485 }),
486 cmp.Transformer("", func(x pref.Descriptor) map[string]interface{} {
487 out := make(map[string]interface{})
488 v := reflect.ValueOf(x)
489 for i := 0; i < v.NumMethod(); i++ {
490 name := v.Type().Method(i).Name
491 if m := v.Method(i); m.Type().NumIn() == 0 && m.Type().NumOut() == 1 {
492 switch name {
Joe Tsaia93fdf52019-05-08 18:50:41 -0700493 case "ParentFile", "Parent":
494 // Ignore parents to avoid recursive cycle.
Joe Tsai08e00302018-11-26 22:32:06 -0800495 case "New":
496 // Ignore New since it a constructor.
497 case "Options":
498 // Ignore descriptor options since protos are not cmperable.
Joe Tsaiac31a352019-05-13 14:32:56 -0700499 case "ContainingOneof", "ContainingMessage", "Enum", "Message":
Joe Tsai08e00302018-11-26 22:32:06 -0800500 // Avoid descending into a dependency to avoid a cycle.
501 // Just record the full name if available.
502 //
503 // TODO: Cycle support in cmp would be useful here.
504 v := m.Call(nil)[0]
505 if !v.IsNil() {
506 out[name] = v.Interface().(pref.Descriptor).FullName()
507 }
508 default:
509 out[name] = m.Call(nil)[0].Interface()
510 }
511 }
512 }
513 return out
514 }),
515 cmp.Transformer("", func(v pref.Value) interface{} {
516 return v.Interface()
517 }),
518 }
519 if diff := cmp.Diff(&wantType, &gotType, opts); diff != "" {
520 t.Errorf("ExtensionType mismatch (-want, +got):\n%v", diff)
521 }
522
523 opts = cmp.Options{
Joe Tsai4fddeba2019-03-20 18:29:32 -0700524 cmpopts.IgnoreFields(piface.ExtensionDescV1{}, "Type"),
Joe Tsai08e00302018-11-26 22:32:06 -0800525 }
526 if diff := cmp.Diff(wantDesc, gotDesc, opts); diff != "" {
527 t.Errorf("ExtensionDesc mismatch (-want, +got):\n%v", diff)
528 }
529 })
530 }
Joe Tsaif0c01e42018-11-06 13:05:20 -0800531}
Joe Tsai21ade492019-05-22 13:42:54 -0400532
533type (
534 MessageA struct {
535 A1 *MessageA `protobuf:"bytes,1,req,name=a1"`
536 A2 *MessageB `protobuf:"bytes,2,req,name=a2"`
537 A3 Enum `protobuf:"varint,3,opt,name=a3,enum=legacy.Enum"`
538 }
539 MessageB struct {
540 B1 *MessageA `protobuf:"bytes,1,req,name=b1"`
541 B2 *MessageB `protobuf:"bytes,2,req,name=b2"`
542 B3 Enum `protobuf:"varint,3,opt,name=b3,enum=legacy.Enum"`
543 }
544 Enum int32
545)
546
Joe Tsaid8881392019-06-06 13:01:53 -0700547func (*MessageA) Descriptor() ([]byte, []int) { return concurrentFD, []int{0} }
548func (*MessageB) Descriptor() ([]byte, []int) { return concurrentFD, []int{1} }
549func (Enum) EnumDescriptor() ([]byte, []int) { return concurrentFD, []int{0} }
550
551var concurrentFD = func() []byte {
552 b, _ := proto.Marshal(pdesc.ToFileDescriptorProto(mustMakeFileDesc(`
553 name: "concurrent.proto"
554 syntax: "proto2"
555 package: "legacy"
556 message_type: [{
557 name: "MessageA"
558 field: [
559 {name:"a1" number:1 label:LABEL_REQUIRED type:TYPE_MESSAGE type_name:".legacy.MessageA"},
560 {name:"a2" number:2 label:LABEL_REQUIRED type:TYPE_MESSAGE type_name:".legacy.MessageB"},
561 {name:"a3" number:3 label:LABEL_OPTIONAL type:TYPE_ENUM type_name:".legacy.Enum"}
562 ]
563 }, {
564 name: "MessageB"
565 field: [
566 {name:"a1" number:1 label:LABEL_REQUIRED type:TYPE_MESSAGE type_name:".legacy.MessageA"},
567 {name:"a2" number:2 label:LABEL_REQUIRED type:TYPE_MESSAGE type_name:".legacy.MessageB"},
568 {name:"a3" number:3 label:LABEL_OPTIONAL type:TYPE_ENUM type_name:".legacy.Enum"}
569 ]
570 }]
571 enum_type: [{
572 name: "Enum"
573 value: [{name:"FOO" number:500}]
574 }]
575 `, nil)))
576 return pimpl.Export{}.CompressGZIP(b)
577}()
578
Joe Tsai21ade492019-05-22 13:42:54 -0400579// TestConcurrentInit tests that concurrent wrapping of multiple legacy types
580// results in the exact same descriptor being created.
581func TestConcurrentInit(t *testing.T) {
582 const numParallel = 5
583 var messageATypes [numParallel]pref.MessageType
584 var messageBTypes [numParallel]pref.MessageType
585 var enumDescs [numParallel]pref.EnumDescriptor
586
587 // Concurrently load message and enum types.
588 var wg sync.WaitGroup
589 for i := 0; i < numParallel; i++ {
590 i := i
591 wg.Add(3)
592 go func() {
593 defer wg.Done()
594 messageATypes[i] = pimpl.Export{}.MessageTypeOf((*MessageA)(nil))
595 }()
596 go func() {
597 defer wg.Done()
598 messageBTypes[i] = pimpl.Export{}.MessageTypeOf((*MessageB)(nil))
599 }()
600 go func() {
601 defer wg.Done()
602 enumDescs[i] = pimpl.Export{}.EnumDescriptorOf(Enum(0))
603 }()
604 }
605 wg.Wait()
606
607 var (
608 wantMTA = messageATypes[0]
609 wantMDA = messageATypes[0].Descriptor().Fields().ByNumber(1).Message()
610 wantMTB = messageBTypes[0]
611 wantMDB = messageBTypes[0].Descriptor().Fields().ByNumber(2).Message()
612 wantED = messageATypes[0].Descriptor().Fields().ByNumber(3).Enum()
613 )
614
615 for _, gotMT := range messageATypes[1:] {
616 if gotMT != wantMTA {
617 t.Error("MessageType(MessageA) mismatch")
618 }
619 if gotMDA := gotMT.Descriptor().Fields().ByNumber(1).Message(); gotMDA != wantMDA {
620 t.Error("MessageDescriptor(MessageA) mismatch")
621 }
622 if gotMDB := gotMT.Descriptor().Fields().ByNumber(2).Message(); gotMDB != wantMDB {
623 t.Error("MessageDescriptor(MessageB) mismatch")
624 }
625 if gotED := gotMT.Descriptor().Fields().ByNumber(3).Enum(); gotED != wantED {
626 t.Error("EnumDescriptor(Enum) mismatch")
627 }
628 }
629 for _, gotMT := range messageBTypes[1:] {
630 if gotMT != wantMTB {
631 t.Error("MessageType(MessageB) mismatch")
632 }
633 if gotMDA := gotMT.Descriptor().Fields().ByNumber(1).Message(); gotMDA != wantMDA {
634 t.Error("MessageDescriptor(MessageA) mismatch")
635 }
636 if gotMDB := gotMT.Descriptor().Fields().ByNumber(2).Message(); gotMDB != wantMDB {
637 t.Error("MessageDescriptor(MessageB) mismatch")
638 }
639 if gotED := gotMT.Descriptor().Fields().ByNumber(3).Enum(); gotED != wantED {
640 t.Error("EnumDescriptor(Enum) mismatch")
641 }
642 }
643 for _, gotED := range enumDescs[1:] {
644 if gotED != wantED {
645 t.Error("EnumType(Enum) mismatch")
646 }
647 }
648}