Joe Tsai | 90fe996 | 2018-10-18 11:06:29 -0700 | [diff] [blame] | 1 | // Copyright 2018 The Go Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style |
| 3 | // license that can be found in the LICENSE file. |
| 4 | |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 5 | package impl_test |
Joe Tsai | 90fe996 | 2018-10-18 11:06:29 -0700 | [diff] [blame] | 6 | |
| 7 | import ( |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 8 | "bytes" |
| 9 | "math" |
Joe Tsai | 90fe996 | 2018-10-18 11:06:29 -0700 | [diff] [blame] | 10 | "reflect" |
| 11 | "testing" |
| 12 | |
Joe Tsai | ea11813 | 2018-11-11 17:56:21 -0800 | [diff] [blame] | 13 | pack "github.com/golang/protobuf/v2/internal/encoding/pack" |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 14 | pimpl "github.com/golang/protobuf/v2/internal/impl" |
Joe Tsai | ea11813 | 2018-11-11 17:56:21 -0800 | [diff] [blame] | 15 | pragma "github.com/golang/protobuf/v2/internal/pragma" |
Joe Tsai | 990b9f5 | 2019-03-13 12:56:39 -0700 | [diff] [blame] | 16 | ptype "github.com/golang/protobuf/v2/internal/prototype" |
Joe Tsai | 009e067 | 2018-11-27 18:45:07 -0800 | [diff] [blame] | 17 | scalar "github.com/golang/protobuf/v2/internal/scalar" |
Joe Tsai | 90fe996 | 2018-10-18 11:06:29 -0700 | [diff] [blame] | 18 | pref "github.com/golang/protobuf/v2/reflect/protoreflect" |
Joe Tsai | 4fddeba | 2019-03-20 18:29:32 -0700 | [diff] [blame] | 19 | piface "github.com/golang/protobuf/v2/runtime/protoiface" |
Joe Tsai | ea11813 | 2018-11-11 17:56:21 -0800 | [diff] [blame] | 20 | cmp "github.com/google/go-cmp/cmp" |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 21 | cmpopts "github.com/google/go-cmp/cmp/cmpopts" |
Joe Tsai | ea11813 | 2018-11-11 17:56:21 -0800 | [diff] [blame] | 22 | |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 23 | // The legacy package must be imported prior to use of any legacy messages. |
| 24 | // TODO: Remove this when protoV1 registers these hooks for you. |
| 25 | plegacy "github.com/golang/protobuf/v2/internal/legacy" |
| 26 | |
Joe Tsai | ea11813 | 2018-11-11 17:56:21 -0800 | [diff] [blame] | 27 | proto2_20180125 "github.com/golang/protobuf/v2/internal/testprotos/legacy/proto2.v1.0.0-20180125-92554152" |
Joe Tsai | 90fe996 | 2018-10-18 11:06:29 -0700 | [diff] [blame] | 28 | ) |
| 29 | |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 30 | type legacyTestMessage struct { |
Joe Tsai | 4fddeba | 2019-03-20 18:29:32 -0700 | [diff] [blame] | 31 | XXX_unrecognized []byte |
Joe Tsai | 00e50dc | 2019-04-16 12:39:41 -0700 | [diff] [blame] | 32 | XXX_InternalExtensions map[int32]pimpl.ExtensionFieldV1 |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 33 | } |
| 34 | |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 35 | func (*legacyTestMessage) Reset() {} |
| 36 | func (*legacyTestMessage) String() string { return "" } |
| 37 | func (*legacyTestMessage) ProtoMessage() {} |
Joe Tsai | 4fddeba | 2019-03-20 18:29:32 -0700 | [diff] [blame] | 38 | func (*legacyTestMessage) ExtensionRangeArray() []piface.ExtensionRangeV1 { |
| 39 | return []piface.ExtensionRangeV1{{Start: 10, End: 20}, {Start: 40, End: 80}, {Start: 10000, End: 20000}} |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 40 | } |
| 41 | |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 42 | func TestLegacyUnknown(t *testing.T) { |
| 43 | rawOf := func(toks ...pack.Token) pref.RawFields { |
| 44 | return pref.RawFields(pack.Message(toks).Marshal()) |
| 45 | } |
Joe Tsai | 00a323d | 2019-05-06 23:27:29 -0700 | [diff] [blame] | 46 | raw1 := rawOf(pack.Tag{1, pack.BytesType}, pack.Bytes("1")) // 0a0131 |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 47 | raw1a := rawOf(pack.Tag{1, pack.VarintType}, pack.Svarint(-4321)) // 08c143 |
| 48 | raw1b := rawOf(pack.Tag{1, pack.Fixed32Type}, pack.Uint32(0xdeadbeef)) // 0defbeadde |
| 49 | raw1c := rawOf(pack.Tag{1, pack.Fixed64Type}, pack.Float64(math.Pi)) // 09182d4454fb210940 |
| 50 | raw2a := rawOf(pack.Tag{2, pack.BytesType}, pack.String("hello, world!")) // 120d68656c6c6f2c20776f726c6421 |
| 51 | raw2b := rawOf(pack.Tag{2, pack.VarintType}, pack.Uvarint(1234)) // 10d209 |
| 52 | raw3a := rawOf(pack.Tag{3, pack.StartGroupType}, pack.Tag{3, pack.EndGroupType}) // 1b1c |
| 53 | raw3b := rawOf(pack.Tag{3, pack.BytesType}, pack.Bytes("\xde\xad\xbe\xef")) // 1a04deadbeef |
| 54 | |
| 55 | joinRaw := func(bs ...pref.RawFields) (out []byte) { |
| 56 | for _, b := range bs { |
| 57 | out = append(out, b...) |
| 58 | } |
| 59 | return out |
| 60 | } |
| 61 | |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 62 | m := new(legacyTestMessage) |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 63 | fs := pimpl.Export{}.MessageOf(m).UnknownFields() |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 64 | |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 65 | if got, want := fs.Len(), 0; got != want { |
| 66 | t.Errorf("Len() = %d, want %d", got, want) |
| 67 | } |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 68 | if got, want := m.XXX_unrecognized, joinRaw(); !bytes.Equal(got, want) { |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 69 | t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want) |
| 70 | } |
| 71 | |
| 72 | fs.Set(1, raw1a) |
| 73 | fs.Set(1, append(fs.Get(1), raw1b...)) |
| 74 | fs.Set(1, append(fs.Get(1), raw1c...)) |
| 75 | if got, want := fs.Len(), 1; got != want { |
| 76 | t.Errorf("Len() = %d, want %d", got, want) |
| 77 | } |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 78 | if got, want := m.XXX_unrecognized, joinRaw(raw1a, raw1b, raw1c); !bytes.Equal(got, want) { |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 79 | t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want) |
| 80 | } |
| 81 | |
| 82 | fs.Set(2, raw2a) |
| 83 | if got, want := fs.Len(), 2; got != want { |
| 84 | t.Errorf("Len() = %d, want %d", got, want) |
| 85 | } |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 86 | if got, want := m.XXX_unrecognized, joinRaw(raw1a, raw1b, raw1c, raw2a); !bytes.Equal(got, want) { |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 87 | t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want) |
| 88 | } |
| 89 | |
| 90 | if got, want := fs.Get(1), joinRaw(raw1a, raw1b, raw1c); !bytes.Equal(got, want) { |
| 91 | t.Errorf("Get(%d) = %x, want %x", 1, got, want) |
| 92 | } |
| 93 | if got, want := fs.Get(2), joinRaw(raw2a); !bytes.Equal(got, want) { |
| 94 | t.Errorf("Get(%d) = %x, want %x", 2, got, want) |
| 95 | } |
| 96 | if got, want := fs.Get(3), joinRaw(); !bytes.Equal(got, want) { |
| 97 | t.Errorf("Get(%d) = %x, want %x", 3, got, want) |
| 98 | } |
| 99 | |
| 100 | fs.Set(1, nil) // remove field 1 |
| 101 | if got, want := fs.Len(), 1; got != want { |
| 102 | t.Errorf("Len() = %d, want %d", got, want) |
| 103 | } |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 104 | if got, want := m.XXX_unrecognized, joinRaw(raw2a); !bytes.Equal(got, want) { |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 105 | t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want) |
| 106 | } |
| 107 | |
| 108 | // Simulate manual appending of raw field data. |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 109 | m.XXX_unrecognized = append(m.XXX_unrecognized, joinRaw(raw3a, raw1a, raw1b, raw2b, raw3b, raw1c)...) |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 110 | if got, want := fs.Len(), 3; got != want { |
| 111 | t.Errorf("Len() = %d, want %d", got, want) |
| 112 | } |
| 113 | |
| 114 | // Verify range iteration order. |
| 115 | var i int |
| 116 | want := []struct { |
| 117 | num pref.FieldNumber |
| 118 | raw pref.RawFields |
| 119 | }{ |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 120 | {2, joinRaw(raw2a, raw2b)}, |
Joe Tsai | 2d5a169 | 2018-10-29 02:10:42 -0700 | [diff] [blame] | 121 | {3, joinRaw(raw3a, raw3b)}, |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 122 | {1, joinRaw(raw1a, raw1b, raw1c)}, |
| 123 | } |
| 124 | fs.Range(func(num pref.FieldNumber, raw pref.RawFields) bool { |
| 125 | if i < len(want) { |
| 126 | if num != want[i].num || !bytes.Equal(raw, want[i].raw) { |
| 127 | t.Errorf("Range(%d) = (%d, %x), want (%d, %x)", i, num, raw, want[i].num, want[i].raw) |
| 128 | } |
| 129 | } else { |
| 130 | t.Errorf("unexpected Range iteration: %d", i) |
| 131 | } |
| 132 | i++ |
| 133 | return true |
| 134 | }) |
| 135 | |
| 136 | fs.Set(2, fs.Get(2)) // moves field 2 to the end |
| 137 | if got, want := fs.Len(), 3; got != want { |
| 138 | t.Errorf("Len() = %d, want %d", got, want) |
| 139 | } |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 140 | if got, want := m.XXX_unrecognized, joinRaw(raw3a, raw1a, raw1b, raw3b, raw1c, raw2a, raw2b); !bytes.Equal(got, want) { |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 141 | t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want) |
| 142 | } |
| 143 | fs.Set(1, nil) // remove field 1 |
| 144 | if got, want := fs.Len(), 2; got != want { |
| 145 | t.Errorf("Len() = %d, want %d", got, want) |
| 146 | } |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 147 | if got, want := m.XXX_unrecognized, joinRaw(raw3a, raw3b, raw2a, raw2b); !bytes.Equal(got, want) { |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 148 | t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want) |
| 149 | } |
| 150 | |
| 151 | // Remove all fields. |
| 152 | fs.Range(func(n pref.FieldNumber, b pref.RawFields) bool { |
| 153 | fs.Set(n, nil) |
| 154 | return true |
| 155 | }) |
| 156 | if got, want := fs.Len(), 0; got != want { |
| 157 | t.Errorf("Len() = %d, want %d", got, want) |
| 158 | } |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 159 | if got, want := m.XXX_unrecognized, joinRaw(); !bytes.Equal(got, want) { |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 160 | t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want) |
| 161 | } |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 162 | |
| 163 | fs.Set(1, raw1) |
| 164 | if got, want := fs.Len(), 1; got != want { |
| 165 | t.Errorf("Len() = %d, want %d", got, want) |
| 166 | } |
| 167 | if got, want := m.XXX_unrecognized, joinRaw(raw1); !bytes.Equal(got, want) { |
| 168 | t.Errorf("data mismatch:\ngot: %x\nwant: %x", got, want) |
| 169 | } |
Joe Tsai | e2afdc2 | 2018-10-25 14:06:56 -0700 | [diff] [blame] | 170 | } |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 171 | |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 172 | func mustMakeExtensionType(x *ptype.StandaloneExtension, v interface{}) pref.ExtensionType { |
| 173 | xd, err := ptype.NewExtension(x) |
| 174 | if err != nil { |
| 175 | panic(xd) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 176 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 177 | return pimpl.Export{}.ExtensionTypeOf(xd, v) |
| 178 | } |
| 179 | |
| 180 | var ( |
| 181 | parentType = pimpl.Export{}.MessageTypeOf((*legacyTestMessage)(nil)) |
| 182 | enumV1Type = pimpl.Export{}.EnumTypeOf(proto2_20180125.Message_ChildEnum(0)) |
| 183 | messageV1Type = pimpl.Export{}.MessageTypeOf((*proto2_20180125.Message_ChildMessage)(nil)) |
| 184 | enumV2Type = enumProto2Type |
Damien Neil | 8012b44 | 2019-01-18 09:32:24 -0800 | [diff] [blame] | 185 | messageV2Type = enumMessagesType.PBType |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 186 | |
| 187 | extensionTypes = []pref.ExtensionType{ |
| 188 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 189 | FullName: "fizz.buzz.optional_bool", |
| 190 | Number: 10000, |
| 191 | Cardinality: pref.Optional, |
| 192 | Kind: pref.BoolKind, |
| 193 | Default: pref.ValueOf(true), |
| 194 | ExtendedType: parentType, |
| 195 | }, nil), |
| 196 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 197 | FullName: "fizz.buzz.optional_int32", |
| 198 | Number: 10001, |
| 199 | Cardinality: pref.Optional, |
| 200 | Kind: pref.Int32Kind, |
| 201 | Default: pref.ValueOf(int32(-12345)), |
| 202 | ExtendedType: parentType, |
| 203 | }, nil), |
| 204 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 205 | FullName: "fizz.buzz.optional_uint32", |
| 206 | Number: 10002, |
| 207 | Cardinality: pref.Optional, |
| 208 | Kind: pref.Uint32Kind, |
| 209 | Default: pref.ValueOf(uint32(3200)), |
| 210 | ExtendedType: parentType, |
| 211 | }, nil), |
| 212 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 213 | FullName: "fizz.buzz.optional_float", |
| 214 | Number: 10003, |
| 215 | Cardinality: pref.Optional, |
| 216 | Kind: pref.FloatKind, |
| 217 | Default: pref.ValueOf(float32(3.14159)), |
| 218 | ExtendedType: parentType, |
| 219 | }, nil), |
| 220 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 221 | FullName: "fizz.buzz.optional_string", |
| 222 | Number: 10004, |
| 223 | Cardinality: pref.Optional, |
| 224 | Kind: pref.StringKind, |
| 225 | Default: pref.ValueOf(string("hello, \"world!\"\n")), |
| 226 | ExtendedType: parentType, |
| 227 | }, nil), |
| 228 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 229 | FullName: "fizz.buzz.optional_bytes", |
| 230 | Number: 10005, |
| 231 | Cardinality: pref.Optional, |
| 232 | Kind: pref.BytesKind, |
| 233 | Default: pref.ValueOf([]byte("dead\xde\xad\xbe\xefbeef")), |
| 234 | ExtendedType: parentType, |
| 235 | }, nil), |
| 236 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 237 | FullName: "fizz.buzz.optional_enum_v1", |
| 238 | Number: 10006, |
| 239 | Cardinality: pref.Optional, |
| 240 | Kind: pref.EnumKind, |
| 241 | Default: pref.ValueOf(pref.EnumNumber(0)), |
| 242 | EnumType: enumV1Type, |
| 243 | ExtendedType: parentType, |
| 244 | }, proto2_20180125.Message_ChildEnum(0)), |
| 245 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 246 | FullName: "fizz.buzz.optional_message_v1", |
| 247 | Number: 10007, |
| 248 | Cardinality: pref.Optional, |
| 249 | Kind: pref.MessageKind, |
| 250 | MessageType: messageV1Type, |
| 251 | ExtendedType: parentType, |
| 252 | }, (*proto2_20180125.Message_ChildMessage)(nil)), |
| 253 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 254 | FullName: "fizz.buzz.optional_enum_v2", |
| 255 | Number: 10008, |
| 256 | Cardinality: pref.Optional, |
| 257 | Kind: pref.EnumKind, |
| 258 | Default: pref.ValueOf(pref.EnumNumber(57005)), |
| 259 | EnumType: enumV2Type, |
| 260 | ExtendedType: parentType, |
| 261 | }, EnumProto2(0)), |
| 262 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 263 | FullName: "fizz.buzz.optional_message_v2", |
| 264 | Number: 10009, |
| 265 | Cardinality: pref.Optional, |
| 266 | Kind: pref.MessageKind, |
| 267 | MessageType: messageV2Type, |
| 268 | ExtendedType: parentType, |
| 269 | }, (*EnumMessages)(nil)), |
| 270 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 271 | FullName: "fizz.buzz.repeated_bool", |
| 272 | Number: 10010, |
| 273 | Cardinality: pref.Repeated, |
| 274 | Kind: pref.BoolKind, |
| 275 | ExtendedType: parentType, |
| 276 | }, nil), |
| 277 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 278 | FullName: "fizz.buzz.repeated_int32", |
| 279 | Number: 10011, |
| 280 | Cardinality: pref.Repeated, |
| 281 | Kind: pref.Int32Kind, |
| 282 | ExtendedType: parentType, |
| 283 | }, nil), |
| 284 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 285 | FullName: "fizz.buzz.repeated_uint32", |
| 286 | Number: 10012, |
| 287 | Cardinality: pref.Repeated, |
| 288 | Kind: pref.Uint32Kind, |
| 289 | ExtendedType: parentType, |
| 290 | }, nil), |
| 291 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 292 | FullName: "fizz.buzz.repeated_float", |
| 293 | Number: 10013, |
| 294 | Cardinality: pref.Repeated, |
| 295 | Kind: pref.FloatKind, |
| 296 | ExtendedType: parentType, |
| 297 | }, nil), |
| 298 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 299 | FullName: "fizz.buzz.repeated_string", |
| 300 | Number: 10014, |
| 301 | Cardinality: pref.Repeated, |
| 302 | Kind: pref.StringKind, |
| 303 | ExtendedType: parentType, |
| 304 | }, nil), |
| 305 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 306 | FullName: "fizz.buzz.repeated_bytes", |
| 307 | Number: 10015, |
| 308 | Cardinality: pref.Repeated, |
| 309 | Kind: pref.BytesKind, |
| 310 | ExtendedType: parentType, |
| 311 | }, nil), |
| 312 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 313 | FullName: "fizz.buzz.repeated_enum_v1", |
| 314 | Number: 10016, |
| 315 | Cardinality: pref.Repeated, |
| 316 | Kind: pref.EnumKind, |
| 317 | EnumType: enumV1Type, |
| 318 | ExtendedType: parentType, |
| 319 | }, proto2_20180125.Message_ChildEnum(0)), |
| 320 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 321 | FullName: "fizz.buzz.repeated_message_v1", |
| 322 | Number: 10017, |
| 323 | Cardinality: pref.Repeated, |
| 324 | Kind: pref.MessageKind, |
| 325 | MessageType: messageV1Type, |
| 326 | ExtendedType: parentType, |
| 327 | }, (*proto2_20180125.Message_ChildMessage)(nil)), |
| 328 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 329 | FullName: "fizz.buzz.repeated_enum_v2", |
| 330 | Number: 10018, |
| 331 | Cardinality: pref.Repeated, |
| 332 | Kind: pref.EnumKind, |
| 333 | EnumType: enumV2Type, |
| 334 | ExtendedType: parentType, |
| 335 | }, EnumProto2(0)), |
| 336 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 337 | FullName: "fizz.buzz.repeated_message_v2", |
| 338 | Number: 10019, |
| 339 | Cardinality: pref.Repeated, |
| 340 | Kind: pref.MessageKind, |
| 341 | MessageType: messageV2Type, |
| 342 | ExtendedType: parentType, |
| 343 | }, (*EnumMessages)(nil)), |
| 344 | } |
| 345 | |
Joe Tsai | 4fddeba | 2019-03-20 18:29:32 -0700 | [diff] [blame] | 346 | extensionDescs = []*piface.ExtensionDescV1{{ |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 347 | ExtendedType: (*legacyTestMessage)(nil), |
| 348 | ExtensionType: (*bool)(nil), |
| 349 | Field: 10000, |
| 350 | Name: "fizz.buzz.optional_bool", |
| 351 | Tag: "varint,10000,opt,name=optional_bool,def=1", |
| 352 | }, { |
| 353 | ExtendedType: (*legacyTestMessage)(nil), |
| 354 | ExtensionType: (*int32)(nil), |
| 355 | Field: 10001, |
| 356 | Name: "fizz.buzz.optional_int32", |
| 357 | Tag: "varint,10001,opt,name=optional_int32,def=-12345", |
| 358 | }, { |
| 359 | ExtendedType: (*legacyTestMessage)(nil), |
| 360 | ExtensionType: (*uint32)(nil), |
| 361 | Field: 10002, |
| 362 | Name: "fizz.buzz.optional_uint32", |
| 363 | Tag: "varint,10002,opt,name=optional_uint32,def=3200", |
| 364 | }, { |
| 365 | ExtendedType: (*legacyTestMessage)(nil), |
| 366 | ExtensionType: (*float32)(nil), |
| 367 | Field: 10003, |
| 368 | Name: "fizz.buzz.optional_float", |
| 369 | Tag: "fixed32,10003,opt,name=optional_float,def=3.14159", |
| 370 | }, { |
| 371 | ExtendedType: (*legacyTestMessage)(nil), |
| 372 | ExtensionType: (*string)(nil), |
| 373 | Field: 10004, |
| 374 | Name: "fizz.buzz.optional_string", |
| 375 | Tag: "bytes,10004,opt,name=optional_string,def=hello, \"world!\"\n", |
| 376 | }, { |
| 377 | ExtendedType: (*legacyTestMessage)(nil), |
| 378 | ExtensionType: ([]byte)(nil), |
| 379 | Field: 10005, |
| 380 | Name: "fizz.buzz.optional_bytes", |
| 381 | Tag: "bytes,10005,opt,name=optional_bytes,def=dead\\336\\255\\276\\357beef", |
| 382 | }, { |
| 383 | ExtendedType: (*legacyTestMessage)(nil), |
| 384 | ExtensionType: (*proto2_20180125.Message_ChildEnum)(nil), |
| 385 | Field: 10006, |
| 386 | Name: "fizz.buzz.optional_enum_v1", |
| 387 | Tag: "varint,10006,opt,name=optional_enum_v1,enum=google.golang.org.proto2_20180125.Message_ChildEnum,def=0", |
| 388 | }, { |
| 389 | ExtendedType: (*legacyTestMessage)(nil), |
| 390 | ExtensionType: (*proto2_20180125.Message_ChildMessage)(nil), |
| 391 | Field: 10007, |
| 392 | Name: "fizz.buzz.optional_message_v1", |
| 393 | Tag: "bytes,10007,opt,name=optional_message_v1", |
| 394 | }, { |
| 395 | ExtendedType: (*legacyTestMessage)(nil), |
| 396 | ExtensionType: (*EnumProto2)(nil), |
| 397 | Field: 10008, |
| 398 | Name: "fizz.buzz.optional_enum_v2", |
| 399 | Tag: "varint,10008,opt,name=optional_enum_v2,enum=EnumProto2,def=57005", |
| 400 | }, { |
| 401 | ExtendedType: (*legacyTestMessage)(nil), |
| 402 | ExtensionType: (*EnumMessages)(nil), |
| 403 | Field: 10009, |
| 404 | Name: "fizz.buzz.optional_message_v2", |
| 405 | Tag: "bytes,10009,opt,name=optional_message_v2", |
| 406 | }, { |
| 407 | ExtendedType: (*legacyTestMessage)(nil), |
| 408 | ExtensionType: ([]bool)(nil), |
| 409 | Field: 10010, |
| 410 | Name: "fizz.buzz.repeated_bool", |
| 411 | Tag: "varint,10010,rep,name=repeated_bool", |
| 412 | }, { |
| 413 | ExtendedType: (*legacyTestMessage)(nil), |
| 414 | ExtensionType: ([]int32)(nil), |
| 415 | Field: 10011, |
| 416 | Name: "fizz.buzz.repeated_int32", |
| 417 | Tag: "varint,10011,rep,name=repeated_int32", |
| 418 | }, { |
| 419 | ExtendedType: (*legacyTestMessage)(nil), |
| 420 | ExtensionType: ([]uint32)(nil), |
| 421 | Field: 10012, |
| 422 | Name: "fizz.buzz.repeated_uint32", |
| 423 | Tag: "varint,10012,rep,name=repeated_uint32", |
| 424 | }, { |
| 425 | ExtendedType: (*legacyTestMessage)(nil), |
| 426 | ExtensionType: ([]float32)(nil), |
| 427 | Field: 10013, |
| 428 | Name: "fizz.buzz.repeated_float", |
| 429 | Tag: "fixed32,10013,rep,name=repeated_float", |
| 430 | }, { |
| 431 | ExtendedType: (*legacyTestMessage)(nil), |
| 432 | ExtensionType: ([]string)(nil), |
| 433 | Field: 10014, |
| 434 | Name: "fizz.buzz.repeated_string", |
| 435 | Tag: "bytes,10014,rep,name=repeated_string", |
| 436 | }, { |
| 437 | ExtendedType: (*legacyTestMessage)(nil), |
| 438 | ExtensionType: ([][]byte)(nil), |
| 439 | Field: 10015, |
| 440 | Name: "fizz.buzz.repeated_bytes", |
| 441 | Tag: "bytes,10015,rep,name=repeated_bytes", |
| 442 | }, { |
| 443 | ExtendedType: (*legacyTestMessage)(nil), |
| 444 | ExtensionType: ([]proto2_20180125.Message_ChildEnum)(nil), |
| 445 | Field: 10016, |
| 446 | Name: "fizz.buzz.repeated_enum_v1", |
| 447 | Tag: "varint,10016,rep,name=repeated_enum_v1,enum=google.golang.org.proto2_20180125.Message_ChildEnum", |
| 448 | }, { |
| 449 | ExtendedType: (*legacyTestMessage)(nil), |
| 450 | ExtensionType: ([]*proto2_20180125.Message_ChildMessage)(nil), |
| 451 | Field: 10017, |
| 452 | Name: "fizz.buzz.repeated_message_v1", |
| 453 | Tag: "bytes,10017,rep,name=repeated_message_v1", |
| 454 | }, { |
| 455 | ExtendedType: (*legacyTestMessage)(nil), |
| 456 | ExtensionType: ([]EnumProto2)(nil), |
| 457 | Field: 10018, |
| 458 | Name: "fizz.buzz.repeated_enum_v2", |
| 459 | Tag: "varint,10018,rep,name=repeated_enum_v2,enum=EnumProto2", |
| 460 | }, { |
| 461 | ExtendedType: (*legacyTestMessage)(nil), |
| 462 | ExtensionType: ([]*EnumMessages)(nil), |
| 463 | Field: 10019, |
| 464 | Name: "fizz.buzz.repeated_message_v2", |
| 465 | Tag: "bytes,10019,rep,name=repeated_message_v2", |
| 466 | }} |
| 467 | ) |
| 468 | |
| 469 | func TestLegacyExtensions(t *testing.T) { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 470 | opts := cmp.Options{cmp.Comparer(func(x, y *proto2_20180125.Message_ChildMessage) bool { |
| 471 | return x == y // pointer compare messages for object identity |
| 472 | })} |
| 473 | |
| 474 | m := new(legacyTestMessage) |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 475 | fs := pimpl.Export{}.MessageOf(m).KnownFields() |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 476 | ts := fs.ExtensionTypes() |
| 477 | |
| 478 | if n := fs.Len(); n != 0 { |
| 479 | t.Errorf("KnownFields.Len() = %v, want 0", n) |
| 480 | } |
| 481 | if n := ts.Len(); n != 0 { |
| 482 | t.Errorf("ExtensionFieldTypes.Len() = %v, want 0", n) |
| 483 | } |
| 484 | |
| 485 | // Register all the extension types. |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 486 | for _, xt := range extensionTypes { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 487 | ts.Register(xt) |
| 488 | } |
| 489 | |
| 490 | // Check that getting the zero value returns the default value for scalars, |
Joe Tsai | 4b7aff6 | 2018-11-14 14:05:19 -0800 | [diff] [blame] | 491 | // nil for singular messages, and an empty list for repeated fields. |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 492 | defaultValues := []interface{}{ |
| 493 | bool(true), |
| 494 | int32(-12345), |
| 495 | uint32(3200), |
| 496 | float32(3.14159), |
| 497 | string("hello, \"world!\"\n"), |
| 498 | []byte("dead\xde\xad\xbe\xefbeef"), |
| 499 | proto2_20180125.Message_ALPHA, |
| 500 | nil, |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 501 | EnumProto2(0xdead), |
| 502 | nil, |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 503 | new([]bool), |
| 504 | new([]int32), |
| 505 | new([]uint32), |
| 506 | new([]float32), |
| 507 | new([]string), |
| 508 | new([][]byte), |
| 509 | new([]proto2_20180125.Message_ChildEnum), |
| 510 | new([]*proto2_20180125.Message_ChildMessage), |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 511 | new([]EnumProto2), |
| 512 | new([]*EnumMessages), |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 513 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 514 | for i, xt := range extensionTypes { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 515 | var got interface{} |
Joe Tsai | f6d4a42 | 2018-11-19 14:26:06 -0800 | [diff] [blame] | 516 | if v := fs.Get(xt.Number()); v.IsValid() { |
| 517 | got = xt.InterfaceOf(v) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 518 | } |
| 519 | want := defaultValues[i] |
| 520 | if diff := cmp.Diff(want, got, opts); diff != "" { |
| 521 | t.Errorf("KnownFields.Get(%d) mismatch (-want +got):\n%v", xt.Number(), diff) |
| 522 | } |
| 523 | } |
| 524 | |
| 525 | // All fields should be unpopulated. |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 526 | for _, xt := range extensionTypes { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 527 | if fs.Has(xt.Number()) { |
| 528 | t.Errorf("KnownFields.Has(%d) = true, want false", xt.Number()) |
| 529 | } |
| 530 | } |
| 531 | |
Joe Tsai | 4b7aff6 | 2018-11-14 14:05:19 -0800 | [diff] [blame] | 532 | // Set some values and append to values to the lists. |
Joe Tsai | 009e067 | 2018-11-27 18:45:07 -0800 | [diff] [blame] | 533 | m1a := &proto2_20180125.Message_ChildMessage{F1: scalar.String("m1a")} |
| 534 | m1b := &proto2_20180125.Message_ChildMessage{F1: scalar.String("m2b")} |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 535 | m2a := &EnumMessages{EnumP2: EnumProto2(0x1b).Enum()} |
| 536 | m2b := &EnumMessages{EnumP2: EnumProto2(0x2b).Enum()} |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 537 | setValues := []interface{}{ |
| 538 | bool(false), |
| 539 | int32(-54321), |
| 540 | uint32(6400), |
| 541 | float32(2.71828), |
| 542 | string("goodbye, \"world!\"\n"), |
| 543 | []byte("live\xde\xad\xbe\xefchicken"), |
| 544 | proto2_20180125.Message_CHARLIE, |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 545 | m1a, |
| 546 | EnumProto2(0xbeef), |
| 547 | m2a, |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 548 | &[]bool{true}, |
| 549 | &[]int32{-1000}, |
| 550 | &[]uint32{1280}, |
| 551 | &[]float32{1.6180}, |
| 552 | &[]string{"zero"}, |
| 553 | &[][]byte{[]byte("zero")}, |
| 554 | &[]proto2_20180125.Message_ChildEnum{proto2_20180125.Message_BRAVO}, |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 555 | &[]*proto2_20180125.Message_ChildMessage{m1b}, |
| 556 | &[]EnumProto2{0xdead}, |
| 557 | &[]*EnumMessages{m2b}, |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 558 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 559 | for i, xt := range extensionTypes { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 560 | fs.Set(xt.Number(), xt.ValueOf(setValues[i])) |
| 561 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 562 | for i, xt := range extensionTypes[len(extensionTypes)/2:] { |
| 563 | v := extensionTypes[i].ValueOf(setValues[i]) |
Joe Tsai | 4b7aff6 | 2018-11-14 14:05:19 -0800 | [diff] [blame] | 564 | fs.Get(xt.Number()).List().Append(v) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 565 | } |
| 566 | |
| 567 | // Get the values and check for equality. |
| 568 | getValues := []interface{}{ |
| 569 | bool(false), |
| 570 | int32(-54321), |
| 571 | uint32(6400), |
| 572 | float32(2.71828), |
| 573 | string("goodbye, \"world!\"\n"), |
| 574 | []byte("live\xde\xad\xbe\xefchicken"), |
| 575 | proto2_20180125.Message_ChildEnum(proto2_20180125.Message_CHARLIE), |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 576 | m1a, |
| 577 | EnumProto2(0xbeef), |
| 578 | m2a, |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 579 | &[]bool{true, false}, |
| 580 | &[]int32{-1000, -54321}, |
| 581 | &[]uint32{1280, 6400}, |
| 582 | &[]float32{1.6180, 2.71828}, |
| 583 | &[]string{"zero", "goodbye, \"world!\"\n"}, |
| 584 | &[][]byte{[]byte("zero"), []byte("live\xde\xad\xbe\xefchicken")}, |
| 585 | &[]proto2_20180125.Message_ChildEnum{proto2_20180125.Message_BRAVO, proto2_20180125.Message_CHARLIE}, |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 586 | &[]*proto2_20180125.Message_ChildMessage{m1b, m1a}, |
| 587 | &[]EnumProto2{0xdead, 0xbeef}, |
| 588 | &[]*EnumMessages{m2b, m2a}, |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 589 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 590 | for i, xt := range extensionTypes { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 591 | got := xt.InterfaceOf(fs.Get(xt.Number())) |
| 592 | want := getValues[i] |
| 593 | if diff := cmp.Diff(want, got, opts); diff != "" { |
| 594 | t.Errorf("KnownFields.Get(%d) mismatch (-want +got):\n%v", xt.Number(), diff) |
| 595 | } |
| 596 | } |
| 597 | |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 598 | if n := fs.Len(); n != 20 { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 599 | t.Errorf("KnownFields.Len() = %v, want 0", n) |
| 600 | } |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 601 | if n := ts.Len(); n != 20 { |
| 602 | t.Errorf("ExtensionFieldTypes.Len() = %v, want 20", n) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 603 | } |
| 604 | |
| 605 | // Clear the field for all extension types. |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 606 | for _, xt := range extensionTypes[:len(extensionTypes)/2] { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 607 | fs.Clear(xt.Number()) |
| 608 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 609 | for i, xt := range extensionTypes[len(extensionTypes)/2:] { |
Joe Tsai | f6d4a42 | 2018-11-19 14:26:06 -0800 | [diff] [blame] | 610 | if i%2 == 0 { |
| 611 | fs.Clear(xt.Number()) |
| 612 | } else { |
| 613 | fs.Get(xt.Number()).List().Truncate(0) |
| 614 | } |
| 615 | } |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 616 | if n := fs.Len(); n != 0 { |
| 617 | t.Errorf("KnownFields.Len() = %v, want 0", n) |
| 618 | } |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 619 | if n := ts.Len(); n != 20 { |
| 620 | t.Errorf("ExtensionFieldTypes.Len() = %v, want 20", n) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 621 | } |
| 622 | |
| 623 | // De-register all extension types. |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 624 | for _, xt := range extensionTypes { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 625 | ts.Remove(xt) |
| 626 | } |
| 627 | if n := fs.Len(); n != 0 { |
| 628 | t.Errorf("KnownFields.Len() = %v, want 0", n) |
| 629 | } |
| 630 | if n := ts.Len(); n != 0 { |
| 631 | t.Errorf("ExtensionFieldTypes.Len() = %v, want 0", n) |
| 632 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 633 | } |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 634 | |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 635 | func TestExtensionConvert(t *testing.T) { |
| 636 | for i := range extensionTypes { |
| 637 | i := i |
| 638 | t.Run("", func(t *testing.T) { |
| 639 | t.Parallel() |
| 640 | |
| 641 | wantType := extensionTypes[i] |
| 642 | wantDesc := extensionDescs[i] |
| 643 | gotType := plegacy.Export{}.ExtensionTypeFromDesc(wantDesc) |
| 644 | gotDesc := plegacy.Export{}.ExtensionDescFromType(wantType) |
| 645 | |
| 646 | // TODO: We need a test package to compare descriptors. |
| 647 | type list interface { |
| 648 | Len() int |
| 649 | pragma.DoNotImplement |
| 650 | } |
| 651 | opts := cmp.Options{ |
| 652 | cmp.Comparer(func(x, y reflect.Type) bool { |
| 653 | return x == y |
| 654 | }), |
| 655 | cmp.Transformer("", func(x list) []interface{} { |
| 656 | out := make([]interface{}, x.Len()) |
| 657 | v := reflect.ValueOf(x) |
| 658 | for i := 0; i < x.Len(); i++ { |
| 659 | m := v.MethodByName("Get") |
| 660 | out[i] = m.Call([]reflect.Value{reflect.ValueOf(i)})[0].Interface() |
| 661 | } |
| 662 | return out |
| 663 | }), |
| 664 | cmp.Transformer("", func(x pref.Descriptor) map[string]interface{} { |
| 665 | out := make(map[string]interface{}) |
| 666 | v := reflect.ValueOf(x) |
| 667 | for i := 0; i < v.NumMethod(); i++ { |
| 668 | name := v.Type().Method(i).Name |
| 669 | if m := v.Method(i); m.Type().NumIn() == 0 && m.Type().NumOut() == 1 { |
| 670 | switch name { |
| 671 | case "New": |
| 672 | // Ignore New since it a constructor. |
| 673 | case "Options": |
| 674 | // Ignore descriptor options since protos are not cmperable. |
Joe Tsai | d24bc72 | 2019-04-15 23:39:09 -0700 | [diff] [blame] | 675 | case "Oneof", "Extendee", "Enum", "Message": |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 676 | // Avoid descending into a dependency to avoid a cycle. |
| 677 | // Just record the full name if available. |
| 678 | // |
| 679 | // TODO: Cycle support in cmp would be useful here. |
| 680 | v := m.Call(nil)[0] |
| 681 | if !v.IsNil() { |
| 682 | out[name] = v.Interface().(pref.Descriptor).FullName() |
| 683 | } |
| 684 | default: |
| 685 | out[name] = m.Call(nil)[0].Interface() |
| 686 | } |
| 687 | } |
| 688 | } |
| 689 | return out |
| 690 | }), |
| 691 | cmp.Transformer("", func(v pref.Value) interface{} { |
| 692 | return v.Interface() |
| 693 | }), |
| 694 | } |
| 695 | if diff := cmp.Diff(&wantType, &gotType, opts); diff != "" { |
| 696 | t.Errorf("ExtensionType mismatch (-want, +got):\n%v", diff) |
| 697 | } |
| 698 | |
| 699 | opts = cmp.Options{ |
Joe Tsai | 4fddeba | 2019-03-20 18:29:32 -0700 | [diff] [blame] | 700 | cmpopts.IgnoreFields(piface.ExtensionDescV1{}, "Type"), |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 701 | } |
| 702 | if diff := cmp.Diff(wantDesc, gotDesc, opts); diff != "" { |
| 703 | t.Errorf("ExtensionDesc mismatch (-want, +got):\n%v", diff) |
| 704 | } |
| 705 | }) |
| 706 | } |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 707 | } |