Joe Tsai | 90fe996 | 2018-10-18 11:06:29 -0700 | [diff] [blame] | 1 | // Copyright 2018 The Go Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style |
| 3 | // license that can be found in the LICENSE file. |
| 4 | |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 5 | package impl_test |
Joe Tsai | 90fe996 | 2018-10-18 11:06:29 -0700 | [diff] [blame] | 6 | |
| 7 | import ( |
| 8 | "reflect" |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 9 | "sync" |
Joe Tsai | 90fe996 | 2018-10-18 11:06:29 -0700 | [diff] [blame] | 10 | "testing" |
| 11 | |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 12 | "github.com/google/go-cmp/cmp" |
| 13 | "github.com/google/go-cmp/cmp/cmpopts" |
Damien Neil | e89e624 | 2019-05-13 23:55:40 -0700 | [diff] [blame] | 14 | pimpl "google.golang.org/protobuf/internal/impl" |
Damien Neil | e89e624 | 2019-05-13 23:55:40 -0700 | [diff] [blame] | 15 | pragma "google.golang.org/protobuf/internal/pragma" |
| 16 | ptype "google.golang.org/protobuf/internal/prototype" |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 17 | "google.golang.org/protobuf/internal/scalar" |
Damien Neil | e89e624 | 2019-05-13 23:55:40 -0700 | [diff] [blame] | 18 | pref "google.golang.org/protobuf/reflect/protoreflect" |
| 19 | preg "google.golang.org/protobuf/reflect/protoregistry" |
| 20 | piface "google.golang.org/protobuf/runtime/protoiface" |
Joe Tsai | ea11813 | 2018-11-11 17:56:21 -0800 | [diff] [blame] | 21 | |
Damien Neil | e89e624 | 2019-05-13 23:55:40 -0700 | [diff] [blame] | 22 | proto2_20180125 "google.golang.org/protobuf/internal/testprotos/legacy/proto2.v1.0.0-20180125-92554152" |
Joe Tsai | 90fe996 | 2018-10-18 11:06:29 -0700 | [diff] [blame] | 23 | ) |
| 24 | |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 25 | type legacyTestMessage struct { |
Joe Tsai | 4fddeba | 2019-03-20 18:29:32 -0700 | [diff] [blame] | 26 | XXX_unrecognized []byte |
Joe Tsai | 89d4963 | 2019-06-04 16:20:00 -0700 | [diff] [blame] | 27 | XXX_InternalExtensions map[int32]pimpl.ExtensionField |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 28 | } |
| 29 | |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 30 | func (*legacyTestMessage) Reset() {} |
| 31 | func (*legacyTestMessage) String() string { return "" } |
| 32 | func (*legacyTestMessage) ProtoMessage() {} |
Joe Tsai | 4fddeba | 2019-03-20 18:29:32 -0700 | [diff] [blame] | 33 | func (*legacyTestMessage) ExtensionRangeArray() []piface.ExtensionRangeV1 { |
| 34 | return []piface.ExtensionRangeV1{{Start: 10, End: 20}, {Start: 40, End: 80}, {Start: 10000, End: 20000}} |
Joe Tsai | 95b0290 | 2018-10-31 18:23:42 -0700 | [diff] [blame] | 35 | } |
| 36 | |
Joe Tsai | 0fc49f8 | 2019-05-01 12:29:25 -0700 | [diff] [blame] | 37 | func init() { |
| 38 | mt := pimpl.Export{}.MessageTypeOf(&legacyTestMessage{}) |
| 39 | preg.GlobalTypes.Register(mt) |
| 40 | } |
| 41 | |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 42 | var ( |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 43 | testParentDesc = pimpl.Export{}.MessageDescriptorOf((*legacyTestMessage)(nil)) |
| 44 | testEnumV1Desc = pimpl.Export{}.EnumDescriptorOf(proto2_20180125.Message_ChildEnum(0)) |
| 45 | testMessageV1Desc = pimpl.Export{}.MessageDescriptorOf((*proto2_20180125.Message_ChildMessage)(nil)) |
| 46 | testEnumV2Desc = enumProto2Type.Descriptor() |
| 47 | testMessageV2Desc = enumMessagesType.PBType.Descriptor() |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 48 | |
| 49 | extensionTypes = []pref.ExtensionType{ |
| 50 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 51 | FullName: "fizz.buzz.optional_bool", |
| 52 | Number: 10000, |
| 53 | Cardinality: pref.Optional, |
| 54 | Kind: pref.BoolKind, |
| 55 | Default: pref.ValueOf(true), |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 56 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 57 | }, nil), |
| 58 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 59 | FullName: "fizz.buzz.optional_int32", |
| 60 | Number: 10001, |
| 61 | Cardinality: pref.Optional, |
| 62 | Kind: pref.Int32Kind, |
| 63 | Default: pref.ValueOf(int32(-12345)), |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 64 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 65 | }, nil), |
| 66 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 67 | FullName: "fizz.buzz.optional_uint32", |
| 68 | Number: 10002, |
| 69 | Cardinality: pref.Optional, |
| 70 | Kind: pref.Uint32Kind, |
| 71 | Default: pref.ValueOf(uint32(3200)), |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 72 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 73 | }, nil), |
| 74 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 75 | FullName: "fizz.buzz.optional_float", |
| 76 | Number: 10003, |
| 77 | Cardinality: pref.Optional, |
| 78 | Kind: pref.FloatKind, |
| 79 | Default: pref.ValueOf(float32(3.14159)), |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 80 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 81 | }, nil), |
| 82 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 83 | FullName: "fizz.buzz.optional_string", |
| 84 | Number: 10004, |
| 85 | Cardinality: pref.Optional, |
| 86 | Kind: pref.StringKind, |
| 87 | Default: pref.ValueOf(string("hello, \"world!\"\n")), |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 88 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 89 | }, nil), |
| 90 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 91 | FullName: "fizz.buzz.optional_bytes", |
| 92 | Number: 10005, |
| 93 | Cardinality: pref.Optional, |
| 94 | Kind: pref.BytesKind, |
| 95 | Default: pref.ValueOf([]byte("dead\xde\xad\xbe\xefbeef")), |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 96 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 97 | }, nil), |
| 98 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 99 | FullName: "fizz.buzz.optional_enum_v1", |
| 100 | Number: 10006, |
| 101 | Cardinality: pref.Optional, |
| 102 | Kind: pref.EnumKind, |
| 103 | Default: pref.ValueOf(pref.EnumNumber(0)), |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 104 | EnumType: testEnumV1Desc, |
| 105 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 106 | }, proto2_20180125.Message_ChildEnum(0)), |
| 107 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 108 | FullName: "fizz.buzz.optional_message_v1", |
| 109 | Number: 10007, |
| 110 | Cardinality: pref.Optional, |
| 111 | Kind: pref.MessageKind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 112 | MessageType: testMessageV1Desc, |
| 113 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 114 | }, (*proto2_20180125.Message_ChildMessage)(nil)), |
| 115 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 116 | FullName: "fizz.buzz.optional_enum_v2", |
| 117 | Number: 10008, |
| 118 | Cardinality: pref.Optional, |
| 119 | Kind: pref.EnumKind, |
| 120 | Default: pref.ValueOf(pref.EnumNumber(57005)), |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 121 | EnumType: testEnumV2Desc, |
| 122 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 123 | }, EnumProto2(0)), |
| 124 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 125 | FullName: "fizz.buzz.optional_message_v2", |
| 126 | Number: 10009, |
| 127 | Cardinality: pref.Optional, |
| 128 | Kind: pref.MessageKind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 129 | MessageType: testMessageV2Desc, |
| 130 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 131 | }, (*EnumMessages)(nil)), |
| 132 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 133 | FullName: "fizz.buzz.repeated_bool", |
| 134 | Number: 10010, |
| 135 | Cardinality: pref.Repeated, |
| 136 | Kind: pref.BoolKind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 137 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 138 | }, nil), |
| 139 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 140 | FullName: "fizz.buzz.repeated_int32", |
| 141 | Number: 10011, |
| 142 | Cardinality: pref.Repeated, |
| 143 | Kind: pref.Int32Kind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 144 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 145 | }, nil), |
| 146 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 147 | FullName: "fizz.buzz.repeated_uint32", |
| 148 | Number: 10012, |
| 149 | Cardinality: pref.Repeated, |
| 150 | Kind: pref.Uint32Kind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 151 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 152 | }, nil), |
| 153 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 154 | FullName: "fizz.buzz.repeated_float", |
| 155 | Number: 10013, |
| 156 | Cardinality: pref.Repeated, |
| 157 | Kind: pref.FloatKind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 158 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 159 | }, nil), |
| 160 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 161 | FullName: "fizz.buzz.repeated_string", |
| 162 | Number: 10014, |
| 163 | Cardinality: pref.Repeated, |
| 164 | Kind: pref.StringKind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 165 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 166 | }, nil), |
| 167 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 168 | FullName: "fizz.buzz.repeated_bytes", |
| 169 | Number: 10015, |
| 170 | Cardinality: pref.Repeated, |
| 171 | Kind: pref.BytesKind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 172 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 173 | }, nil), |
| 174 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 175 | FullName: "fizz.buzz.repeated_enum_v1", |
| 176 | Number: 10016, |
| 177 | Cardinality: pref.Repeated, |
| 178 | Kind: pref.EnumKind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 179 | EnumType: testEnumV1Desc, |
| 180 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 181 | }, proto2_20180125.Message_ChildEnum(0)), |
| 182 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 183 | FullName: "fizz.buzz.repeated_message_v1", |
| 184 | Number: 10017, |
| 185 | Cardinality: pref.Repeated, |
| 186 | Kind: pref.MessageKind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 187 | MessageType: testMessageV1Desc, |
| 188 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 189 | }, (*proto2_20180125.Message_ChildMessage)(nil)), |
| 190 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 191 | FullName: "fizz.buzz.repeated_enum_v2", |
| 192 | Number: 10018, |
| 193 | Cardinality: pref.Repeated, |
| 194 | Kind: pref.EnumKind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 195 | EnumType: testEnumV2Desc, |
| 196 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 197 | }, EnumProto2(0)), |
| 198 | mustMakeExtensionType(&ptype.StandaloneExtension{ |
| 199 | FullName: "fizz.buzz.repeated_message_v2", |
| 200 | Number: 10019, |
| 201 | Cardinality: pref.Repeated, |
| 202 | Kind: pref.MessageKind, |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 203 | MessageType: testMessageV2Desc, |
| 204 | ExtendedType: testParentDesc, |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 205 | }, (*EnumMessages)(nil)), |
| 206 | } |
| 207 | |
Joe Tsai | 4fddeba | 2019-03-20 18:29:32 -0700 | [diff] [blame] | 208 | extensionDescs = []*piface.ExtensionDescV1{{ |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 209 | ExtendedType: (*legacyTestMessage)(nil), |
| 210 | ExtensionType: (*bool)(nil), |
| 211 | Field: 10000, |
| 212 | Name: "fizz.buzz.optional_bool", |
| 213 | Tag: "varint,10000,opt,name=optional_bool,def=1", |
| 214 | }, { |
| 215 | ExtendedType: (*legacyTestMessage)(nil), |
| 216 | ExtensionType: (*int32)(nil), |
| 217 | Field: 10001, |
| 218 | Name: "fizz.buzz.optional_int32", |
| 219 | Tag: "varint,10001,opt,name=optional_int32,def=-12345", |
| 220 | }, { |
| 221 | ExtendedType: (*legacyTestMessage)(nil), |
| 222 | ExtensionType: (*uint32)(nil), |
| 223 | Field: 10002, |
| 224 | Name: "fizz.buzz.optional_uint32", |
| 225 | Tag: "varint,10002,opt,name=optional_uint32,def=3200", |
| 226 | }, { |
| 227 | ExtendedType: (*legacyTestMessage)(nil), |
| 228 | ExtensionType: (*float32)(nil), |
| 229 | Field: 10003, |
| 230 | Name: "fizz.buzz.optional_float", |
| 231 | Tag: "fixed32,10003,opt,name=optional_float,def=3.14159", |
| 232 | }, { |
| 233 | ExtendedType: (*legacyTestMessage)(nil), |
| 234 | ExtensionType: (*string)(nil), |
| 235 | Field: 10004, |
| 236 | Name: "fizz.buzz.optional_string", |
| 237 | Tag: "bytes,10004,opt,name=optional_string,def=hello, \"world!\"\n", |
| 238 | }, { |
| 239 | ExtendedType: (*legacyTestMessage)(nil), |
| 240 | ExtensionType: ([]byte)(nil), |
| 241 | Field: 10005, |
| 242 | Name: "fizz.buzz.optional_bytes", |
| 243 | Tag: "bytes,10005,opt,name=optional_bytes,def=dead\\336\\255\\276\\357beef", |
| 244 | }, { |
| 245 | ExtendedType: (*legacyTestMessage)(nil), |
| 246 | ExtensionType: (*proto2_20180125.Message_ChildEnum)(nil), |
| 247 | Field: 10006, |
| 248 | Name: "fizz.buzz.optional_enum_v1", |
| 249 | Tag: "varint,10006,opt,name=optional_enum_v1,enum=google.golang.org.proto2_20180125.Message_ChildEnum,def=0", |
| 250 | }, { |
| 251 | ExtendedType: (*legacyTestMessage)(nil), |
| 252 | ExtensionType: (*proto2_20180125.Message_ChildMessage)(nil), |
| 253 | Field: 10007, |
| 254 | Name: "fizz.buzz.optional_message_v1", |
| 255 | Tag: "bytes,10007,opt,name=optional_message_v1", |
| 256 | }, { |
| 257 | ExtendedType: (*legacyTestMessage)(nil), |
| 258 | ExtensionType: (*EnumProto2)(nil), |
| 259 | Field: 10008, |
| 260 | Name: "fizz.buzz.optional_enum_v2", |
| 261 | Tag: "varint,10008,opt,name=optional_enum_v2,enum=EnumProto2,def=57005", |
| 262 | }, { |
| 263 | ExtendedType: (*legacyTestMessage)(nil), |
| 264 | ExtensionType: (*EnumMessages)(nil), |
| 265 | Field: 10009, |
| 266 | Name: "fizz.buzz.optional_message_v2", |
| 267 | Tag: "bytes,10009,opt,name=optional_message_v2", |
| 268 | }, { |
| 269 | ExtendedType: (*legacyTestMessage)(nil), |
| 270 | ExtensionType: ([]bool)(nil), |
| 271 | Field: 10010, |
| 272 | Name: "fizz.buzz.repeated_bool", |
| 273 | Tag: "varint,10010,rep,name=repeated_bool", |
| 274 | }, { |
| 275 | ExtendedType: (*legacyTestMessage)(nil), |
| 276 | ExtensionType: ([]int32)(nil), |
| 277 | Field: 10011, |
| 278 | Name: "fizz.buzz.repeated_int32", |
| 279 | Tag: "varint,10011,rep,name=repeated_int32", |
| 280 | }, { |
| 281 | ExtendedType: (*legacyTestMessage)(nil), |
| 282 | ExtensionType: ([]uint32)(nil), |
| 283 | Field: 10012, |
| 284 | Name: "fizz.buzz.repeated_uint32", |
| 285 | Tag: "varint,10012,rep,name=repeated_uint32", |
| 286 | }, { |
| 287 | ExtendedType: (*legacyTestMessage)(nil), |
| 288 | ExtensionType: ([]float32)(nil), |
| 289 | Field: 10013, |
| 290 | Name: "fizz.buzz.repeated_float", |
| 291 | Tag: "fixed32,10013,rep,name=repeated_float", |
| 292 | }, { |
| 293 | ExtendedType: (*legacyTestMessage)(nil), |
| 294 | ExtensionType: ([]string)(nil), |
| 295 | Field: 10014, |
| 296 | Name: "fizz.buzz.repeated_string", |
| 297 | Tag: "bytes,10014,rep,name=repeated_string", |
| 298 | }, { |
| 299 | ExtendedType: (*legacyTestMessage)(nil), |
| 300 | ExtensionType: ([][]byte)(nil), |
| 301 | Field: 10015, |
| 302 | Name: "fizz.buzz.repeated_bytes", |
| 303 | Tag: "bytes,10015,rep,name=repeated_bytes", |
| 304 | }, { |
| 305 | ExtendedType: (*legacyTestMessage)(nil), |
| 306 | ExtensionType: ([]proto2_20180125.Message_ChildEnum)(nil), |
| 307 | Field: 10016, |
| 308 | Name: "fizz.buzz.repeated_enum_v1", |
| 309 | Tag: "varint,10016,rep,name=repeated_enum_v1,enum=google.golang.org.proto2_20180125.Message_ChildEnum", |
| 310 | }, { |
| 311 | ExtendedType: (*legacyTestMessage)(nil), |
| 312 | ExtensionType: ([]*proto2_20180125.Message_ChildMessage)(nil), |
| 313 | Field: 10017, |
| 314 | Name: "fizz.buzz.repeated_message_v1", |
| 315 | Tag: "bytes,10017,rep,name=repeated_message_v1", |
| 316 | }, { |
| 317 | ExtendedType: (*legacyTestMessage)(nil), |
| 318 | ExtensionType: ([]EnumProto2)(nil), |
| 319 | Field: 10018, |
| 320 | Name: "fizz.buzz.repeated_enum_v2", |
| 321 | Tag: "varint,10018,rep,name=repeated_enum_v2,enum=EnumProto2", |
| 322 | }, { |
| 323 | ExtendedType: (*legacyTestMessage)(nil), |
| 324 | ExtensionType: ([]*EnumMessages)(nil), |
| 325 | Field: 10019, |
| 326 | Name: "fizz.buzz.repeated_message_v2", |
| 327 | Tag: "bytes,10019,rep,name=repeated_message_v2", |
| 328 | }} |
| 329 | ) |
| 330 | |
| 331 | func TestLegacyExtensions(t *testing.T) { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 332 | opts := cmp.Options{cmp.Comparer(func(x, y *proto2_20180125.Message_ChildMessage) bool { |
| 333 | return x == y // pointer compare messages for object identity |
| 334 | })} |
| 335 | |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 336 | m := pimpl.Export{}.MessageOf(new(legacyTestMessage)) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 337 | |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 338 | if n := m.Len(); n != 0 { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 339 | t.Errorf("KnownFields.Len() = %v, want 0", n) |
| 340 | } |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 341 | |
| 342 | // Check that getting the zero value returns the default value for scalars, |
Joe Tsai | 4b7aff6 | 2018-11-14 14:05:19 -0800 | [diff] [blame] | 343 | // nil for singular messages, and an empty list for repeated fields. |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 344 | defaultValues := map[int]interface{}{ |
| 345 | 0: bool(true), |
| 346 | 1: int32(-12345), |
| 347 | 2: uint32(3200), |
| 348 | 3: float32(3.14159), |
| 349 | 4: string("hello, \"world!\"\n"), |
| 350 | 5: []byte("dead\xde\xad\xbe\xefbeef"), |
| 351 | 6: proto2_20180125.Message_ALPHA, |
| 352 | 7: nil, |
| 353 | 8: EnumProto2(0xdead), |
| 354 | 9: nil, |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 355 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 356 | for i, xt := range extensionTypes { |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 357 | var got interface{} |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 358 | if !(xt.IsList() || xt.IsMap() || xt.Message() != nil) { |
| 359 | got = xt.InterfaceOf(m.Get(xt)) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 360 | } |
| 361 | want := defaultValues[i] |
| 362 | if diff := cmp.Diff(want, got, opts); diff != "" { |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 363 | t.Errorf("Message.Get(%d) mismatch (-want +got):\n%v", xt.Number(), diff) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 364 | } |
| 365 | } |
| 366 | |
| 367 | // All fields should be unpopulated. |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 368 | for _, xt := range extensionTypes { |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 369 | if m.Has(xt) { |
| 370 | t.Errorf("Message.Has(%d) = true, want false", xt.Number()) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 371 | } |
| 372 | } |
| 373 | |
Joe Tsai | 4b7aff6 | 2018-11-14 14:05:19 -0800 | [diff] [blame] | 374 | // Set some values and append to values to the lists. |
Joe Tsai | 009e067 | 2018-11-27 18:45:07 -0800 | [diff] [blame] | 375 | m1a := &proto2_20180125.Message_ChildMessage{F1: scalar.String("m1a")} |
| 376 | m1b := &proto2_20180125.Message_ChildMessage{F1: scalar.String("m2b")} |
Joe Tsai | 87b955b | 2018-11-14 21:59:49 -0800 | [diff] [blame] | 377 | m2a := &EnumMessages{EnumP2: EnumProto2(0x1b).Enum()} |
| 378 | m2b := &EnumMessages{EnumP2: EnumProto2(0x2b).Enum()} |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 379 | setValues := map[int]interface{}{ |
| 380 | 0: bool(false), |
| 381 | 1: int32(-54321), |
| 382 | 2: uint32(6400), |
| 383 | 3: float32(2.71828), |
| 384 | 4: string("goodbye, \"world!\"\n"), |
| 385 | 5: []byte("live\xde\xad\xbe\xefchicken"), |
| 386 | 6: proto2_20180125.Message_CHARLIE, |
| 387 | 7: m1a, |
| 388 | 8: EnumProto2(0xbeef), |
| 389 | 9: m2a, |
| 390 | 10: &[]bool{true}, |
| 391 | 11: &[]int32{-1000}, |
| 392 | 12: &[]uint32{1280}, |
| 393 | 13: &[]float32{1.6180}, |
| 394 | 14: &[]string{"zero"}, |
| 395 | 15: &[][]byte{[]byte("zero")}, |
| 396 | 16: &[]proto2_20180125.Message_ChildEnum{proto2_20180125.Message_BRAVO}, |
| 397 | 17: &[]*proto2_20180125.Message_ChildMessage{m1b}, |
| 398 | 18: &[]EnumProto2{0xdead}, |
| 399 | 19: &[]*EnumMessages{m2b}, |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 400 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 401 | for i, xt := range extensionTypes { |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 402 | m.Set(xt, xt.ValueOf(setValues[i])) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 403 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 404 | for i, xt := range extensionTypes[len(extensionTypes)/2:] { |
| 405 | v := extensionTypes[i].ValueOf(setValues[i]) |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 406 | m.Get(xt).List().Append(v) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 407 | } |
| 408 | |
| 409 | // Get the values and check for equality. |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 410 | getValues := map[int]interface{}{ |
| 411 | 0: bool(false), |
| 412 | 1: int32(-54321), |
| 413 | 2: uint32(6400), |
| 414 | 3: float32(2.71828), |
| 415 | 4: string("goodbye, \"world!\"\n"), |
| 416 | 5: []byte("live\xde\xad\xbe\xefchicken"), |
| 417 | 6: proto2_20180125.Message_ChildEnum(proto2_20180125.Message_CHARLIE), |
| 418 | 7: m1a, |
| 419 | 8: EnumProto2(0xbeef), |
| 420 | 9: m2a, |
| 421 | 10: &[]bool{true, false}, |
| 422 | 11: &[]int32{-1000, -54321}, |
| 423 | 12: &[]uint32{1280, 6400}, |
| 424 | 13: &[]float32{1.6180, 2.71828}, |
| 425 | 14: &[]string{"zero", "goodbye, \"world!\"\n"}, |
| 426 | 15: &[][]byte{[]byte("zero"), []byte("live\xde\xad\xbe\xefchicken")}, |
| 427 | 16: &[]proto2_20180125.Message_ChildEnum{proto2_20180125.Message_BRAVO, proto2_20180125.Message_CHARLIE}, |
| 428 | 17: &[]*proto2_20180125.Message_ChildMessage{m1b, m1a}, |
| 429 | 18: &[]EnumProto2{0xdead, 0xbeef}, |
| 430 | 19: &[]*EnumMessages{m2b, m2a}, |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 431 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 432 | for i, xt := range extensionTypes { |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 433 | got := xt.InterfaceOf(m.Get(xt)) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 434 | want := getValues[i] |
| 435 | if diff := cmp.Diff(want, got, opts); diff != "" { |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 436 | t.Errorf("Message.Get(%d) mismatch (-want +got):\n%v", xt.Number(), diff) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 437 | } |
| 438 | } |
| 439 | |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 440 | if n := m.Len(); n != 20 { |
| 441 | t.Errorf("Message.Len() = %v, want 0", n) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 442 | } |
| 443 | |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 444 | // Clear all singular fields and truncate all repeated fields. |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 445 | for _, xt := range extensionTypes[:len(extensionTypes)/2] { |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 446 | m.Clear(xt) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 447 | } |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 448 | for _, xt := range extensionTypes[len(extensionTypes)/2:] { |
| 449 | m.Get(xt).List().Truncate(0) |
Joe Tsai | f6d4a42 | 2018-11-19 14:26:06 -0800 | [diff] [blame] | 450 | } |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 451 | if n := m.Len(); n != 10 { |
| 452 | t.Errorf("Message.Len() = %v, want 10", n) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 453 | } |
| 454 | |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 455 | // Clear all repeated fields. |
| 456 | for _, xt := range extensionTypes[len(extensionTypes)/2:] { |
| 457 | m.Clear(xt) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 458 | } |
Joe Tsai | 378c132 | 2019-04-25 23:48:08 -0700 | [diff] [blame] | 459 | if n := m.Len(); n != 0 { |
| 460 | t.Errorf("Message.Len() = %v, want 0", n) |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 461 | } |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 462 | } |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 463 | |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 464 | func TestExtensionConvert(t *testing.T) { |
| 465 | for i := range extensionTypes { |
| 466 | i := i |
| 467 | t.Run("", func(t *testing.T) { |
| 468 | t.Parallel() |
| 469 | |
| 470 | wantType := extensionTypes[i] |
| 471 | wantDesc := extensionDescs[i] |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 472 | gotType := pimpl.Export{}.ExtensionTypeFromDesc(wantDesc) |
| 473 | gotDesc := pimpl.Export{}.ExtensionDescFromType(wantType) |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 474 | |
| 475 | // TODO: We need a test package to compare descriptors. |
| 476 | type list interface { |
| 477 | Len() int |
| 478 | pragma.DoNotImplement |
| 479 | } |
| 480 | opts := cmp.Options{ |
| 481 | cmp.Comparer(func(x, y reflect.Type) bool { |
| 482 | return x == y |
| 483 | }), |
| 484 | cmp.Transformer("", func(x list) []interface{} { |
| 485 | out := make([]interface{}, x.Len()) |
| 486 | v := reflect.ValueOf(x) |
| 487 | for i := 0; i < x.Len(); i++ { |
| 488 | m := v.MethodByName("Get") |
| 489 | out[i] = m.Call([]reflect.Value{reflect.ValueOf(i)})[0].Interface() |
| 490 | } |
| 491 | return out |
| 492 | }), |
Joe Tsai | 0fc49f8 | 2019-05-01 12:29:25 -0700 | [diff] [blame] | 493 | // TODO: Add this when ExtensionType no longer implements |
| 494 | // ExtensionDescriptor. |
| 495 | /* |
| 496 | cmp.Transformer("", func(x pref.ExtensionType) pref.ExtensionDescriptor { |
| 497 | return x.Descriptor() |
| 498 | }), |
| 499 | */ |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 500 | cmp.Transformer("", func(x pref.Descriptor) map[string]interface{} { |
| 501 | out := make(map[string]interface{}) |
| 502 | v := reflect.ValueOf(x) |
| 503 | for i := 0; i < v.NumMethod(); i++ { |
| 504 | name := v.Type().Method(i).Name |
| 505 | if m := v.Method(i); m.Type().NumIn() == 0 && m.Type().NumOut() == 1 { |
| 506 | switch name { |
Joe Tsai | a93fdf5 | 2019-05-08 18:50:41 -0700 | [diff] [blame] | 507 | case "ParentFile", "Parent": |
| 508 | // Ignore parents to avoid recursive cycle. |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 509 | case "New": |
| 510 | // Ignore New since it a constructor. |
| 511 | case "Options": |
| 512 | // Ignore descriptor options since protos are not cmperable. |
Joe Tsai | ac31a35 | 2019-05-13 14:32:56 -0700 | [diff] [blame] | 513 | case "ContainingOneof", "ContainingMessage", "Enum", "Message": |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 514 | // Avoid descending into a dependency to avoid a cycle. |
| 515 | // Just record the full name if available. |
| 516 | // |
| 517 | // TODO: Cycle support in cmp would be useful here. |
| 518 | v := m.Call(nil)[0] |
| 519 | if !v.IsNil() { |
| 520 | out[name] = v.Interface().(pref.Descriptor).FullName() |
| 521 | } |
| 522 | default: |
| 523 | out[name] = m.Call(nil)[0].Interface() |
| 524 | } |
| 525 | } |
| 526 | } |
| 527 | return out |
| 528 | }), |
| 529 | cmp.Transformer("", func(v pref.Value) interface{} { |
| 530 | return v.Interface() |
| 531 | }), |
| 532 | } |
| 533 | if diff := cmp.Diff(&wantType, &gotType, opts); diff != "" { |
| 534 | t.Errorf("ExtensionType mismatch (-want, +got):\n%v", diff) |
| 535 | } |
| 536 | |
| 537 | opts = cmp.Options{ |
Joe Tsai | 4fddeba | 2019-03-20 18:29:32 -0700 | [diff] [blame] | 538 | cmpopts.IgnoreFields(piface.ExtensionDescV1{}, "Type"), |
Joe Tsai | 08e0030 | 2018-11-26 22:32:06 -0800 | [diff] [blame] | 539 | } |
| 540 | if diff := cmp.Diff(wantDesc, gotDesc, opts); diff != "" { |
| 541 | t.Errorf("ExtensionDesc mismatch (-want, +got):\n%v", diff) |
| 542 | } |
| 543 | }) |
| 544 | } |
Joe Tsai | f0c01e4 | 2018-11-06 13:05:20 -0800 | [diff] [blame] | 545 | } |
Joe Tsai | 21ade49 | 2019-05-22 13:42:54 -0400 | [diff] [blame] | 546 | |
| 547 | type ( |
| 548 | MessageA struct { |
| 549 | A1 *MessageA `protobuf:"bytes,1,req,name=a1"` |
| 550 | A2 *MessageB `protobuf:"bytes,2,req,name=a2"` |
| 551 | A3 Enum `protobuf:"varint,3,opt,name=a3,enum=legacy.Enum"` |
| 552 | } |
| 553 | MessageB struct { |
| 554 | B1 *MessageA `protobuf:"bytes,1,req,name=b1"` |
| 555 | B2 *MessageB `protobuf:"bytes,2,req,name=b2"` |
| 556 | B3 Enum `protobuf:"varint,3,opt,name=b3,enum=legacy.Enum"` |
| 557 | } |
| 558 | Enum int32 |
| 559 | ) |
| 560 | |
| 561 | // TestConcurrentInit tests that concurrent wrapping of multiple legacy types |
| 562 | // results in the exact same descriptor being created. |
| 563 | func TestConcurrentInit(t *testing.T) { |
| 564 | const numParallel = 5 |
| 565 | var messageATypes [numParallel]pref.MessageType |
| 566 | var messageBTypes [numParallel]pref.MessageType |
| 567 | var enumDescs [numParallel]pref.EnumDescriptor |
| 568 | |
| 569 | // Concurrently load message and enum types. |
| 570 | var wg sync.WaitGroup |
| 571 | for i := 0; i < numParallel; i++ { |
| 572 | i := i |
| 573 | wg.Add(3) |
| 574 | go func() { |
| 575 | defer wg.Done() |
| 576 | messageATypes[i] = pimpl.Export{}.MessageTypeOf((*MessageA)(nil)) |
| 577 | }() |
| 578 | go func() { |
| 579 | defer wg.Done() |
| 580 | messageBTypes[i] = pimpl.Export{}.MessageTypeOf((*MessageB)(nil)) |
| 581 | }() |
| 582 | go func() { |
| 583 | defer wg.Done() |
| 584 | enumDescs[i] = pimpl.Export{}.EnumDescriptorOf(Enum(0)) |
| 585 | }() |
| 586 | } |
| 587 | wg.Wait() |
| 588 | |
| 589 | var ( |
| 590 | wantMTA = messageATypes[0] |
| 591 | wantMDA = messageATypes[0].Descriptor().Fields().ByNumber(1).Message() |
| 592 | wantMTB = messageBTypes[0] |
| 593 | wantMDB = messageBTypes[0].Descriptor().Fields().ByNumber(2).Message() |
| 594 | wantED = messageATypes[0].Descriptor().Fields().ByNumber(3).Enum() |
| 595 | ) |
| 596 | |
| 597 | for _, gotMT := range messageATypes[1:] { |
| 598 | if gotMT != wantMTA { |
| 599 | t.Error("MessageType(MessageA) mismatch") |
| 600 | } |
| 601 | if gotMDA := gotMT.Descriptor().Fields().ByNumber(1).Message(); gotMDA != wantMDA { |
| 602 | t.Error("MessageDescriptor(MessageA) mismatch") |
| 603 | } |
| 604 | if gotMDB := gotMT.Descriptor().Fields().ByNumber(2).Message(); gotMDB != wantMDB { |
| 605 | t.Error("MessageDescriptor(MessageB) mismatch") |
| 606 | } |
| 607 | if gotED := gotMT.Descriptor().Fields().ByNumber(3).Enum(); gotED != wantED { |
| 608 | t.Error("EnumDescriptor(Enum) mismatch") |
| 609 | } |
| 610 | } |
| 611 | for _, gotMT := range messageBTypes[1:] { |
| 612 | if gotMT != wantMTB { |
| 613 | t.Error("MessageType(MessageB) mismatch") |
| 614 | } |
| 615 | if gotMDA := gotMT.Descriptor().Fields().ByNumber(1).Message(); gotMDA != wantMDA { |
| 616 | t.Error("MessageDescriptor(MessageA) mismatch") |
| 617 | } |
| 618 | if gotMDB := gotMT.Descriptor().Fields().ByNumber(2).Message(); gotMDB != wantMDB { |
| 619 | t.Error("MessageDescriptor(MessageB) mismatch") |
| 620 | } |
| 621 | if gotED := gotMT.Descriptor().Fields().ByNumber(3).Enum(); gotED != wantED { |
| 622 | t.Error("EnumDescriptor(Enum) mismatch") |
| 623 | } |
| 624 | } |
| 625 | for _, gotED := range enumDescs[1:] { |
| 626 | if gotED != wantED { |
| 627 | t.Error("EnumType(Enum) mismatch") |
| 628 | } |
| 629 | } |
| 630 | } |