commit f274c503e1630739e9619aa72ca08735d01ffc1c
author Roman Lebedev <lebedev.ri@gmail.com> Mon Sep 10 23:30:40 2018 +0300
committer Eric <eric@efcs.ca> Mon Sep 10 16:30:40 2018 -0400
tree 2c0181246cff984d2f585556d7051428bbbd97e9
parent f0901417c89d123474e6b91365029cfe32cf89dc

Backport LLVM's r341717 "Fix flags used to compile benchmark library with clang-cl" (#673)

`MSVC` is true for clang-cl, but `"${CMAKE_CXX_COMPILER_ID}" STREQUAL
"MSVC"` is false, so we would enable -Wall, which means -Weverything
with clang-cl, and we get tons of undesired warnings.

Use the simpler condition to fix things.

Patch by: Reid Kleckner @rnk

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8631199..fff85b1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -94,7 +94,7 @@
   add_required_cxx_compiler_flag(-m32)
 endif()
 
-if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
+if (MSVC)
   # Turn compiler warnings up to 11
   string(REGEX REPLACE "[-/]W[1-4]" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4")