blob: 7c624f2ada5fcf99417b7b6cd21e2c2955184fa9 [file] [log] [blame]
avakulenko@google.com554223d2014-12-04 22:00:20 +00001#!/usr/bin/env python
erg@google.com4e00b9a2009-01-12 23:05:11 +00002#
erg@google.com8f91ab22011-09-06 21:04:45 +00003# Copyright (c) 2009 Google Inc. All rights reserved.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004#
erg@google.com969161c2009-06-26 22:06:46 +00005# Redistribution and use in source and binary forms, with or without
6# modification, are permitted provided that the following conditions are
7# met:
erg@google.com4e00b9a2009-01-12 23:05:11 +00008#
erg@google.com969161c2009-06-26 22:06:46 +00009# * Redistributions of source code must retain the above copyright
10# notice, this list of conditions and the following disclaimer.
11# * Redistributions in binary form must reproduce the above
12# copyright notice, this list of conditions and the following disclaimer
13# in the documentation and/or other materials provided with the
14# distribution.
15# * Neither the name of Google Inc. nor the names of its
16# contributors may be used to endorse or promote products derived from
17# this software without specific prior written permission.
erg@google.com4e00b9a2009-01-12 23:05:11 +000018#
erg@google.com969161c2009-06-26 22:06:46 +000019# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
20# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
21# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
22# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
23# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
24# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
25# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
26# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
27# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
erg@google.com4e00b9a2009-01-12 23:05:11 +000030
erg@google.com4e00b9a2009-01-12 23:05:11 +000031"""Does google-lint on c++ files.
32
33The goal of this script is to identify places in the code that *may*
34be in non-compliance with google style. It does not attempt to fix
35up these problems -- the point is to educate. It does also not
36attempt to find all problems, or to ensure that everything it does
37find is legitimately a problem.
38
39In particular, we can get very confused by /* and // inside strings!
40We do a small hack, which is to ignore //'s with "'s after them on the
41same line, but it is far from perfect (in either direction).
42"""
43
44import codecs
erg@google.comd350fe52013-01-14 17:51:48 +000045import copy
erg@google.com4e00b9a2009-01-12 23:05:11 +000046import getopt
47import math # for log
48import os
49import re
50import sre_compile
51import string
52import sys
53import unicodedata
54
55
56_USAGE = """
57Syntax: cpplint.py [--verbose=#] [--output=vs7] [--filter=-x,+y,...]
erg@google.comab53edf2013-11-05 22:23:37 +000058 [--counting=total|toplevel|detailed] [--root=subdir]
LukeCz7197a242016-09-24 13:27:35 -050059 [--linelength=digits] [--headers=x,y,...]
erg@google.com4e00b9a2009-01-12 23:05:11 +000060 <file> [file] ...
61
62 The style guidelines this tries to follow are those in
Ackermann Yuriy79692902016-04-01 21:41:34 +130063 https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
erg@google.com4e00b9a2009-01-12 23:05:11 +000064
65 Every problem is given a confidence score from 1-5, with 5 meaning we are
66 certain of the problem, and 1 meaning it could be a legitimate construct.
67 This will miss some errors, and is not a substitute for a code review.
68
erg+personal@google.com05189642010-04-30 20:43:03 +000069 To suppress false-positive errors of a certain category, add a
70 'NOLINT(category)' comment to the line. NOLINT or NOLINT(*)
71 suppresses errors of all categories on that line.
erg@google.com4e00b9a2009-01-12 23:05:11 +000072
73 The files passed in will be linted; at least one file must be provided.
erg@google.com19680272013-12-16 22:48:54 +000074 Default linted extensions are .cc, .cpp, .cu, .cuh and .h. Change the
75 extensions with the --extensions flag.
erg@google.com4e00b9a2009-01-12 23:05:11 +000076
77 Flags:
78
79 output=vs7
80 By default, the output is formatted to ease emacs parsing. Visual Studio
81 compatible output (vs7) may also be used. Other formats are unsupported.
82
83 verbose=#
84 Specify a number 0-5 to restrict errors to certain verbosity levels.
85
86 filter=-x,+y,...
87 Specify a comma-separated list of category-filters to apply: only
88 error messages whose category names pass the filters will be printed.
89 (Category names are printed with the message and look like
90 "[whitespace/indent]".) Filters are evaluated left to right.
91 "-FOO" and "FOO" means "do not print categories that start with FOO".
92 "+FOO" means "do print categories that start with FOO".
93
94 Examples: --filter=-whitespace,+whitespace/braces
95 --filter=whitespace,runtime/printf,+runtime/printf_format
96 --filter=-,+build/include_what_you_use
97
98 To see a list of all the categories used in cpplint, pass no arg:
99 --filter=
erg@google.coma868d2d2009-10-09 21:18:45 +0000100
101 counting=total|toplevel|detailed
102 The total number of errors found is always printed. If
103 'toplevel' is provided, then the count of errors in each of
104 the top-level categories like 'build' and 'whitespace' will
105 also be printed. If 'detailed' is provided, then a count
106 is provided for each category like 'build/class'.
erg@google.com4d70a882013-04-16 21:06:32 +0000107
108 root=subdir
109 The root directory used for deriving header guard CPP variable.
110 By default, the header guard CPP variable is calculated as the relative
111 path to the directory that contains .git, .hg, or .svn. When this flag
112 is specified, the relative path is calculated from the specified
113 directory. If the specified directory does not exist, this flag is
114 ignored.
115
116 Examples:
avakulenko@google.com02af6282014-06-04 18:53:25 +0000117 Assuming that src/.git exists, the header guard CPP variables for
erg@google.com4d70a882013-04-16 21:06:32 +0000118 src/chrome/browser/ui/browser.h are:
119
120 No flag => CHROME_BROWSER_UI_BROWSER_H_
121 --root=chrome => BROWSER_UI_BROWSER_H_
122 --root=chrome/browser => UI_BROWSER_H_
erg@google.comab53edf2013-11-05 22:23:37 +0000123
124 linelength=digits
125 This is the allowed line length for the project. The default value is
126 80 characters.
127
128 Examples:
129 --linelength=120
erg@google.com19680272013-12-16 22:48:54 +0000130
131 extensions=extension,extension,...
132 The allowed file extensions that cpplint will check
133
134 Examples:
135 --extensions=hpp,cpp
erg@google.com7430eef2014-07-28 22:33:46 +0000136
LukeCz7197a242016-09-24 13:27:35 -0500137 headers=x,y,...
138 The header extensions that cpplint will treat as .h in checks. Values are
139 automatically added to --extensions list.
140
141 Examples:
142 --headers=hpp,hxx
143 --headers=hpp
144
erg@google.com7430eef2014-07-28 22:33:46 +0000145 cpplint.py supports per-directory configurations specified in CPPLINT.cfg
146 files. CPPLINT.cfg file can contain a number of key=value pairs.
147 Currently the following options are supported:
148
149 set noparent
150 filter=+filter1,-filter2,...
151 exclude_files=regex
avakulenko@google.com310681b2014-08-22 19:38:55 +0000152 linelength=80
Fabian Guera2322e4f2016-05-01 17:36:30 +0200153 root=subdir
LukeCz7197a242016-09-24 13:27:35 -0500154 headers=x,y,...
erg@google.com7430eef2014-07-28 22:33:46 +0000155
156 "set noparent" option prevents cpplint from traversing directory tree
157 upwards looking for more .cfg files in parent directories. This option
158 is usually placed in the top-level project directory.
159
160 The "filter" option is similar in function to --filter flag. It specifies
161 message filters in addition to the |_DEFAULT_FILTERS| and those specified
162 through --filter command-line flag.
163
164 "exclude_files" allows to specify a regular expression to be matched against
165 a file name. If the expression matches, the file is skipped and not run
166 through liner.
167
avakulenko@google.com310681b2014-08-22 19:38:55 +0000168 "linelength" allows to specify the allowed line length for the project.
169
Fabian Guera2322e4f2016-05-01 17:36:30 +0200170 The "root" option is similar in function to the --root flag (see example
171 above).
LukeCz7197a242016-09-24 13:27:35 -0500172
173 The "headers" option is similar in function to the --headers flag
174 (see example above).
Fabian Guera2322e4f2016-05-01 17:36:30 +0200175
erg@google.com7430eef2014-07-28 22:33:46 +0000176 CPPLINT.cfg has an effect on files in the same directory and all
177 sub-directories, unless overridden by a nested configuration file.
178
179 Example file:
180 filter=-build/include_order,+build/include_alpha
181 exclude_files=.*\.cc
182
183 The above example disables build/include_order warning and enables
184 build/include_alpha as well as excludes all .cc from being
185 processed by linter, in the current directory (where the .cfg
186 file is located) and all sub-directories.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000187"""
188
189# We categorize each error message we print. Here are the categories.
190# We want an explicit list so we can list them all in cpplint --filter=.
191# If you add a new error message with a new category, add it to the list
192# here! cpplint_unittest.py should tell you if you forget to do this.
erg+personal@google.com05189642010-04-30 20:43:03 +0000193_ERROR_CATEGORIES = [
avakulenko@google.com554223d2014-12-04 22:00:20 +0000194 'build/class',
195 'build/c++11',
Alex Vakulenko01e47232016-05-06 13:54:15 -0700196 'build/c++14',
197 'build/c++tr1',
avakulenko@google.com554223d2014-12-04 22:00:20 +0000198 'build/deprecated',
199 'build/endif_comment',
200 'build/explicit_make_pair',
201 'build/forward_decl',
202 'build/header_guard',
203 'build/include',
204 'build/include_alpha',
205 'build/include_order',
206 'build/include_what_you_use',
207 'build/namespaces',
208 'build/printf_format',
209 'build/storage_class',
210 'legal/copyright',
211 'readability/alt_tokens',
212 'readability/braces',
213 'readability/casting',
214 'readability/check',
215 'readability/constructors',
216 'readability/fn_size',
avakulenko@google.com554223d2014-12-04 22:00:20 +0000217 'readability/inheritance',
218 'readability/multiline_comment',
219 'readability/multiline_string',
220 'readability/namespace',
221 'readability/nolint',
222 'readability/nul',
223 'readability/strings',
224 'readability/todo',
225 'readability/utf8',
226 'runtime/arrays',
227 'runtime/casting',
228 'runtime/explicit',
229 'runtime/int',
230 'runtime/init',
231 'runtime/invalid_increment',
232 'runtime/member_string_references',
233 'runtime/memset',
234 'runtime/indentation_namespace',
235 'runtime/operator',
236 'runtime/printf',
237 'runtime/printf_format',
238 'runtime/references',
239 'runtime/string',
240 'runtime/threadsafe_fn',
241 'runtime/vlog',
242 'whitespace/blank_line',
243 'whitespace/braces',
244 'whitespace/comma',
245 'whitespace/comments',
246 'whitespace/empty_conditional_body',
Alex Vakulenko01e47232016-05-06 13:54:15 -0700247 'whitespace/empty_if_body',
avakulenko@google.com554223d2014-12-04 22:00:20 +0000248 'whitespace/empty_loop_body',
249 'whitespace/end_of_line',
250 'whitespace/ending_newline',
251 'whitespace/forcolon',
252 'whitespace/indent',
253 'whitespace/line_length',
254 'whitespace/newline',
255 'whitespace/operators',
256 'whitespace/parens',
257 'whitespace/semicolon',
258 'whitespace/tab',
259 'whitespace/todo',
260 ]
261
262# These error categories are no longer enforced by cpplint, but for backwards-
263# compatibility they may still appear in NOLINT comments.
264_LEGACY_ERROR_CATEGORIES = [
265 'readability/streams',
Alex Vakulenko01e47232016-05-06 13:54:15 -0700266 'readability/function',
avakulenko@google.com554223d2014-12-04 22:00:20 +0000267 ]
erg@google.com4e00b9a2009-01-12 23:05:11 +0000268
avakulenko@google.com02af6282014-06-04 18:53:25 +0000269# The default state of the category filter. This is overridden by the --filter=
erg@google.come35f7652009-06-19 20:52:09 +0000270# flag. By default all errors are on, so only add here categories that should be
271# off by default (i.e., categories that must be enabled by the --filter= flags).
272# All entries here should start with a '-' or '+', as in the --filter= flag.
erg@google.com8a95ecc2011-09-08 00:45:54 +0000273_DEFAULT_FILTERS = ['-build/include_alpha']
erg@google.come35f7652009-06-19 20:52:09 +0000274
Alex Vakulenko01e47232016-05-06 13:54:15 -0700275# The default list of categories suppressed for C (not C++) files.
276_DEFAULT_C_SUPPRESSED_CATEGORIES = [
277 'readability/casting',
278 ]
279
280# The default list of categories suppressed for Linux Kernel files.
281_DEFAULT_KERNEL_SUPPRESSED_CATEGORIES = [
282 'whitespace/tab',
283 ]
284
erg@google.com4e00b9a2009-01-12 23:05:11 +0000285# We used to check for high-bit characters, but after much discussion we
286# decided those were OK, as long as they were in UTF-8 and didn't represent
erg@google.com8a95ecc2011-09-08 00:45:54 +0000287# hard-coded international strings, which belong in a separate i18n file.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000288
erg@google.comfd5da632013-10-25 17:39:45 +0000289# C++ headers
erg@google.com4e00b9a2009-01-12 23:05:11 +0000290_CPP_HEADERS = frozenset([
erg@google.comfd5da632013-10-25 17:39:45 +0000291 # Legacy
292 'algobase.h',
293 'algo.h',
294 'alloc.h',
295 'builtinbuf.h',
296 'bvector.h',
297 'complex.h',
298 'defalloc.h',
299 'deque.h',
300 'editbuf.h',
301 'fstream.h',
302 'function.h',
303 'hash_map',
304 'hash_map.h',
305 'hash_set',
306 'hash_set.h',
307 'hashtable.h',
308 'heap.h',
309 'indstream.h',
310 'iomanip.h',
311 'iostream.h',
312 'istream.h',
313 'iterator.h',
314 'list.h',
315 'map.h',
316 'multimap.h',
317 'multiset.h',
318 'ostream.h',
319 'pair.h',
320 'parsestream.h',
321 'pfstream.h',
322 'procbuf.h',
323 'pthread_alloc',
324 'pthread_alloc.h',
325 'rope',
326 'rope.h',
327 'ropeimpl.h',
328 'set.h',
329 'slist',
330 'slist.h',
331 'stack.h',
332 'stdiostream.h',
333 'stl_alloc.h',
334 'stl_relops.h',
335 'streambuf.h',
336 'stream.h',
337 'strfile.h',
338 'strstream.h',
339 'tempbuf.h',
340 'tree.h',
341 'type_traits.h',
342 'vector.h',
343 # 17.6.1.2 C++ library headers
344 'algorithm',
345 'array',
346 'atomic',
347 'bitset',
348 'chrono',
349 'codecvt',
350 'complex',
351 'condition_variable',
352 'deque',
353 'exception',
354 'forward_list',
355 'fstream',
356 'functional',
357 'future',
358 'initializer_list',
359 'iomanip',
360 'ios',
361 'iosfwd',
362 'iostream',
363 'istream',
364 'iterator',
365 'limits',
366 'list',
367 'locale',
368 'map',
369 'memory',
370 'mutex',
371 'new',
372 'numeric',
373 'ostream',
374 'queue',
375 'random',
376 'ratio',
377 'regex',
Alex Vakulenko01e47232016-05-06 13:54:15 -0700378 'scoped_allocator',
erg@google.comfd5da632013-10-25 17:39:45 +0000379 'set',
380 'sstream',
381 'stack',
382 'stdexcept',
383 'streambuf',
384 'string',
385 'strstream',
386 'system_error',
387 'thread',
388 'tuple',
389 'typeindex',
390 'typeinfo',
391 'type_traits',
392 'unordered_map',
393 'unordered_set',
394 'utility',
erg@google.com5d00c562013-07-12 19:57:05 +0000395 'valarray',
erg@google.comfd5da632013-10-25 17:39:45 +0000396 'vector',
397 # 17.6.1.2 C++ headers for C library facilities
398 'cassert',
399 'ccomplex',
400 'cctype',
401 'cerrno',
402 'cfenv',
403 'cfloat',
404 'cinttypes',
405 'ciso646',
406 'climits',
407 'clocale',
408 'cmath',
409 'csetjmp',
410 'csignal',
411 'cstdalign',
412 'cstdarg',
413 'cstdbool',
414 'cstddef',
415 'cstdint',
416 'cstdio',
417 'cstdlib',
418 'cstring',
419 'ctgmath',
420 'ctime',
421 'cuchar',
422 'cwchar',
423 'cwctype',
erg@google.com4e00b9a2009-01-12 23:05:11 +0000424 ])
425
Alex Vakulenko01e47232016-05-06 13:54:15 -0700426# Type names
427_TYPES = re.compile(
428 r'^(?:'
429 # [dcl.type.simple]
430 r'(char(16_t|32_t)?)|wchar_t|'
431 r'bool|short|int|long|signed|unsigned|float|double|'
432 # [support.types]
433 r'(ptrdiff_t|size_t|max_align_t|nullptr_t)|'
434 # [cstdint.syn]
435 r'(u?int(_fast|_least)?(8|16|32|64)_t)|'
436 r'(u?int(max|ptr)_t)|'
437 r')$')
438
avakulenko@google.com02af6282014-06-04 18:53:25 +0000439
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000440# These headers are excluded from [build/include] and [build/include_order]
441# checks:
442# - Anything not following google file name conventions (containing an
443# uppercase character, such as Python.h or nsStringAPI.h, for example).
444# - Lua headers.
445_THIRD_PARTY_HEADERS_PATTERN = re.compile(
446 r'^(?:[^/]*[A-Z][^/]*\.h|lua\.h|lauxlib\.h|lualib\.h)$')
447
Alex Vakulenko01e47232016-05-06 13:54:15 -0700448# Pattern for matching FileInfo.BaseName() against test file name
449_TEST_FILE_SUFFIX = r'(_test|_unittest|_regtest)$'
450
451# Pattern that matches only complete whitespace, possibly across multiple lines.
452_EMPTY_CONDITIONAL_BODY_PATTERN = re.compile(r'^\s*$', re.DOTALL)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000453
erg@google.com4e00b9a2009-01-12 23:05:11 +0000454# Assertion macros. These are defined in base/logging.h and
Alex Vakulenko01e47232016-05-06 13:54:15 -0700455# testing/base/public/gunit.h.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000456_CHECK_MACROS = [
erg@google.come35f7652009-06-19 20:52:09 +0000457 'DCHECK', 'CHECK',
Alex Vakulenko01e47232016-05-06 13:54:15 -0700458 'EXPECT_TRUE', 'ASSERT_TRUE',
459 'EXPECT_FALSE', 'ASSERT_FALSE',
erg@google.com4e00b9a2009-01-12 23:05:11 +0000460 ]
461
erg@google.come35f7652009-06-19 20:52:09 +0000462# Replacement macros for CHECK/DCHECK/EXPECT_TRUE/EXPECT_FALSE
erg@google.com4e00b9a2009-01-12 23:05:11 +0000463_CHECK_REPLACEMENT = dict([(m, {}) for m in _CHECK_MACROS])
464
465for op, replacement in [('==', 'EQ'), ('!=', 'NE'),
466 ('>=', 'GE'), ('>', 'GT'),
467 ('<=', 'LE'), ('<', 'LT')]:
erg@google.come35f7652009-06-19 20:52:09 +0000468 _CHECK_REPLACEMENT['DCHECK'][op] = 'DCHECK_%s' % replacement
erg@google.com4e00b9a2009-01-12 23:05:11 +0000469 _CHECK_REPLACEMENT['CHECK'][op] = 'CHECK_%s' % replacement
470 _CHECK_REPLACEMENT['EXPECT_TRUE'][op] = 'EXPECT_%s' % replacement
471 _CHECK_REPLACEMENT['ASSERT_TRUE'][op] = 'ASSERT_%s' % replacement
erg@google.com4e00b9a2009-01-12 23:05:11 +0000472
473for op, inv_replacement in [('==', 'NE'), ('!=', 'EQ'),
474 ('>=', 'LT'), ('>', 'LE'),
475 ('<=', 'GT'), ('<', 'GE')]:
476 _CHECK_REPLACEMENT['EXPECT_FALSE'][op] = 'EXPECT_%s' % inv_replacement
477 _CHECK_REPLACEMENT['ASSERT_FALSE'][op] = 'ASSERT_%s' % inv_replacement
erg@google.com4e00b9a2009-01-12 23:05:11 +0000478
erg@google.comd350fe52013-01-14 17:51:48 +0000479# Alternative tokens and their replacements. For full list, see section 2.5
480# Alternative tokens [lex.digraph] in the C++ standard.
481#
482# Digraphs (such as '%:') are not included here since it's a mess to
483# match those on a word boundary.
484_ALT_TOKEN_REPLACEMENT = {
485 'and': '&&',
486 'bitor': '|',
487 'or': '||',
488 'xor': '^',
489 'compl': '~',
490 'bitand': '&',
491 'and_eq': '&=',
492 'or_eq': '|=',
493 'xor_eq': '^=',
494 'not': '!',
495 'not_eq': '!='
496 }
497
498# Compile regular expression that matches all the above keywords. The "[ =()]"
499# bit is meant to avoid matching these keywords outside of boolean expressions.
500#
erg@google.comc6671232013-10-25 21:44:03 +0000501# False positives include C-style multi-line comments and multi-line strings
502# but those have always been troublesome for cpplint.
erg@google.comd350fe52013-01-14 17:51:48 +0000503_ALT_TOKEN_REPLACEMENT_PATTERN = re.compile(
504 r'[ =()](' + ('|'.join(_ALT_TOKEN_REPLACEMENT.keys())) + r')(?=[ (]|$)')
505
erg@google.com4e00b9a2009-01-12 23:05:11 +0000506
507# These constants define types of headers for use with
508# _IncludeState.CheckNextIncludeOrder().
509_C_SYS_HEADER = 1
510_CPP_SYS_HEADER = 2
511_LIKELY_MY_HEADER = 3
512_POSSIBLE_MY_HEADER = 4
513_OTHER_HEADER = 5
514
erg@google.comd350fe52013-01-14 17:51:48 +0000515# These constants define the current inline assembly state
516_NO_ASM = 0 # Outside of inline assembly block
517_INSIDE_ASM = 1 # Inside inline assembly block
518_END_ASM = 2 # Last line of inline assembly block
519_BLOCK_ASM = 3 # The whole block is an inline assembly block
520
521# Match start of assembly blocks
522_MATCH_ASM = re.compile(r'^\s*(?:asm|_asm|__asm|__asm__)'
523 r'(?:\s+(volatile|__volatile__))?'
524 r'\s*[{(]')
525
Alex Vakulenko01e47232016-05-06 13:54:15 -0700526# Match strings that indicate we're working on a C (not C++) file.
527_SEARCH_C_FILE = re.compile(r'\b(?:LINT_C_FILE|'
528 r'vim?:\s*.*(\s*|:)filetype=c(\s*|:|$))')
529
530# Match string that indicates we're working on a Linux Kernel file.
531_SEARCH_KERNEL_FILE = re.compile(r'\b(?:LINT_KERNEL_FILE)')
erg@google.com4e00b9a2009-01-12 23:05:11 +0000532
533_regexp_compile_cache = {}
534
erg+personal@google.com05189642010-04-30 20:43:03 +0000535# {str, set(int)}: a map from error categories to sets of linenumbers
536# on which those errors are expected and should be suppressed.
537_error_suppressions = {}
538
erg@google.com4d70a882013-04-16 21:06:32 +0000539# The root directory used for deriving header guard CPP variable.
540# This is set by --root flag.
541_root = None
542
erg@google.comab53edf2013-11-05 22:23:37 +0000543# The allowed line length of files.
544# This is set by --linelength flag.
545_line_length = 80
546
erg@google.com19680272013-12-16 22:48:54 +0000547# The allowed extensions for file names
548# This is set by --extensions flag.
549_valid_extensions = set(['cc', 'h', 'cpp', 'cu', 'cuh'])
550
LukeCz7197a242016-09-24 13:27:35 -0500551# Treat all headers starting with 'h' equally: .h, .hpp, .hxx etc.
552# This is set by --headers flag.
LukeCz8920b132016-09-26 19:40:47 -0500553_hpp_headers = set(['h'])
LukeCz7197a242016-09-24 13:27:35 -0500554
Alex Vakulenko01e47232016-05-06 13:54:15 -0700555# {str, bool}: a map from error categories to booleans which indicate if the
556# category should be suppressed for every line.
557_global_error_suppressions = {}
558
LukeCz7197a242016-09-24 13:27:35 -0500559def ProcessHppHeadersOption(val):
560 global _hpp_headers
561 try:
562 _hpp_headers = set(val.split(','))
563 # Automatically append to extensions list so it does not have to be set 2 times
564 _valid_extensions.update(_hpp_headers)
565 except ValueError:
566 PrintUsage('Header extensions must be comma seperated list.')
567
568def IsHeaderExtension(file_extension):
LukeCz8920b132016-09-26 19:40:47 -0500569 return file_extension in _hpp_headers
Alex Vakulenko01e47232016-05-06 13:54:15 -0700570
erg+personal@google.com05189642010-04-30 20:43:03 +0000571def ParseNolintSuppressions(filename, raw_line, linenum, error):
Alex Vakulenko01e47232016-05-06 13:54:15 -0700572 """Updates the global list of line error-suppressions.
erg+personal@google.com05189642010-04-30 20:43:03 +0000573
574 Parses any NOLINT comments on the current line, updating the global
575 error_suppressions store. Reports an error if the NOLINT comment
576 was malformed.
577
578 Args:
579 filename: str, the name of the input file.
580 raw_line: str, the line of input text, with comments.
581 linenum: int, the number of the current line.
582 error: function, an error handler.
583 """
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000584 matched = Search(r'\bNOLINT(NEXTLINE)?\b(\([^)]+\))?', raw_line)
erg@google.com8a95ecc2011-09-08 00:45:54 +0000585 if matched:
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000586 if matched.group(1):
587 suppressed_line = linenum + 1
588 else:
589 suppressed_line = linenum
590 category = matched.group(2)
erg+personal@google.com05189642010-04-30 20:43:03 +0000591 if category in (None, '(*)'): # => "suppress all"
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000592 _error_suppressions.setdefault(None, set()).add(suppressed_line)
erg+personal@google.com05189642010-04-30 20:43:03 +0000593 else:
594 if category.startswith('(') and category.endswith(')'):
595 category = category[1:-1]
596 if category in _ERROR_CATEGORIES:
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000597 _error_suppressions.setdefault(category, set()).add(suppressed_line)
avakulenko@google.com554223d2014-12-04 22:00:20 +0000598 elif category not in _LEGACY_ERROR_CATEGORIES:
erg+personal@google.com05189642010-04-30 20:43:03 +0000599 error(filename, linenum, 'readability/nolint', 5,
erg@google.com8a95ecc2011-09-08 00:45:54 +0000600 'Unknown NOLINT error category: %s' % category)
erg+personal@google.com05189642010-04-30 20:43:03 +0000601
602
Alex Vakulenko01e47232016-05-06 13:54:15 -0700603def ProcessGlobalSuppresions(lines):
604 """Updates the list of global error suppressions.
605
606 Parses any lint directives in the file that have global effect.
607
608 Args:
609 lines: An array of strings, each representing a line of the file, with the
610 last element being empty if the file is terminated with a newline.
611 """
612 for line in lines:
613 if _SEARCH_C_FILE.search(line):
614 for category in _DEFAULT_C_SUPPRESSED_CATEGORIES:
615 _global_error_suppressions[category] = True
616 if _SEARCH_KERNEL_FILE.search(line):
617 for category in _DEFAULT_KERNEL_SUPPRESSED_CATEGORIES:
618 _global_error_suppressions[category] = True
619
620
erg+personal@google.com05189642010-04-30 20:43:03 +0000621def ResetNolintSuppressions():
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000622 """Resets the set of NOLINT suppressions to empty."""
erg+personal@google.com05189642010-04-30 20:43:03 +0000623 _error_suppressions.clear()
Alex Vakulenko01e47232016-05-06 13:54:15 -0700624 _global_error_suppressions.clear()
erg+personal@google.com05189642010-04-30 20:43:03 +0000625
626
627def IsErrorSuppressedByNolint(category, linenum):
628 """Returns true if the specified error category is suppressed on this line.
629
630 Consults the global error_suppressions map populated by
Alex Vakulenko01e47232016-05-06 13:54:15 -0700631 ParseNolintSuppressions/ProcessGlobalSuppresions/ResetNolintSuppressions.
erg+personal@google.com05189642010-04-30 20:43:03 +0000632
633 Args:
634 category: str, the category of the error.
635 linenum: int, the current line number.
636 Returns:
Alex Vakulenko01e47232016-05-06 13:54:15 -0700637 bool, True iff the error should be suppressed due to a NOLINT comment or
638 global suppression.
erg+personal@google.com05189642010-04-30 20:43:03 +0000639 """
Alex Vakulenko01e47232016-05-06 13:54:15 -0700640 return (_global_error_suppressions.get(category, False) or
641 linenum in _error_suppressions.get(category, set()) or
erg+personal@google.com05189642010-04-30 20:43:03 +0000642 linenum in _error_suppressions.get(None, set()))
erg@google.com4e00b9a2009-01-12 23:05:11 +0000643
avakulenko@google.com02af6282014-06-04 18:53:25 +0000644
erg@google.com4e00b9a2009-01-12 23:05:11 +0000645def Match(pattern, s):
646 """Matches the string with the pattern, caching the compiled regexp."""
647 # The regexp compilation caching is inlined in both Match and Search for
648 # performance reasons; factoring it out into a separate function turns out
649 # to be noticeably expensive.
erg@google.comc6671232013-10-25 21:44:03 +0000650 if pattern not in _regexp_compile_cache:
erg@google.com4e00b9a2009-01-12 23:05:11 +0000651 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
652 return _regexp_compile_cache[pattern].match(s)
653
654
erg@google.comfd5da632013-10-25 17:39:45 +0000655def ReplaceAll(pattern, rep, s):
656 """Replaces instances of pattern in a string with a replacement.
657
658 The compiled regex is kept in a cache shared by Match and Search.
659
660 Args:
661 pattern: regex pattern
662 rep: replacement text
663 s: search string
664
665 Returns:
666 string with replacements made (or original string if no replacements)
667 """
668 if pattern not in _regexp_compile_cache:
669 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
670 return _regexp_compile_cache[pattern].sub(rep, s)
671
672
erg@google.com4e00b9a2009-01-12 23:05:11 +0000673def Search(pattern, s):
674 """Searches the string for the pattern, caching the compiled regexp."""
erg@google.comc6671232013-10-25 21:44:03 +0000675 if pattern not in _regexp_compile_cache:
erg@google.com4e00b9a2009-01-12 23:05:11 +0000676 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
677 return _regexp_compile_cache[pattern].search(s)
678
679
Alex Vakulenko01e47232016-05-06 13:54:15 -0700680def _IsSourceExtension(s):
681 """File extension (excluding dot) matches a source file extension."""
682 return s in ('c', 'cc', 'cpp', 'cxx')
683
684
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000685class _IncludeState(object):
erg@google.com4e00b9a2009-01-12 23:05:11 +0000686 """Tracks line numbers for includes, and the order in which includes appear.
687
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000688 include_list contains list of lists of (header, line number) pairs.
689 It's a lists of lists rather than just one flat list to make it
690 easier to update across preprocessor boundaries.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000691
692 Call CheckNextIncludeOrder() once for each header in the file, passing
693 in the type constants defined above. Calls in an illegal order will
694 raise an _IncludeError with an appropriate error message.
695
696 """
697 # self._section will move monotonically through this set. If it ever
698 # needs to move backwards, CheckNextIncludeOrder will raise an error.
699 _INITIAL_SECTION = 0
700 _MY_H_SECTION = 1
701 _C_SECTION = 2
702 _CPP_SECTION = 3
703 _OTHER_H_SECTION = 4
704
705 _TYPE_NAMES = {
706 _C_SYS_HEADER: 'C system header',
707 _CPP_SYS_HEADER: 'C++ system header',
708 _LIKELY_MY_HEADER: 'header this file implements',
709 _POSSIBLE_MY_HEADER: 'header this file may implement',
710 _OTHER_HEADER: 'other header',
711 }
712 _SECTION_NAMES = {
713 _INITIAL_SECTION: "... nothing. (This can't be an error.)",
714 _MY_H_SECTION: 'a header this file implements',
715 _C_SECTION: 'C system header',
716 _CPP_SECTION: 'C++ system header',
717 _OTHER_H_SECTION: 'other header',
718 }
719
720 def __init__(self):
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000721 self.include_list = [[]]
722 self.ResetSection('')
erg@google.com2aa59982013-10-28 19:09:25 +0000723
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000724 def FindHeader(self, header):
725 """Check if a header has already been included.
726
727 Args:
728 header: header to check.
729 Returns:
730 Line number of previous occurrence, or -1 if the header has not
731 been seen before.
732 """
733 for section_list in self.include_list:
734 for f in section_list:
735 if f[0] == header:
736 return f[1]
737 return -1
738
739 def ResetSection(self, directive):
740 """Reset section checking for preprocessor directive.
741
742 Args:
743 directive: preprocessor directive (e.g. "if", "else").
744 """
erg@google.coma868d2d2009-10-09 21:18:45 +0000745 # The name of the current section.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000746 self._section = self._INITIAL_SECTION
erg@google.coma868d2d2009-10-09 21:18:45 +0000747 # The path of last found header.
748 self._last_header = ''
749
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +0000750 # Update list of includes. Note that we never pop from the
751 # include list.
752 if directive in ('if', 'ifdef', 'ifndef'):
753 self.include_list.append([])
754 elif directive in ('else', 'elif'):
755 self.include_list[-1] = []
756
erg@google.comfd5da632013-10-25 17:39:45 +0000757 def SetLastHeader(self, header_path):
758 self._last_header = header_path
759
erg@google.coma868d2d2009-10-09 21:18:45 +0000760 def CanonicalizeAlphabeticalOrder(self, header_path):
erg@google.com8a95ecc2011-09-08 00:45:54 +0000761 """Returns a path canonicalized for alphabetical comparison.
erg@google.coma868d2d2009-10-09 21:18:45 +0000762
763 - replaces "-" with "_" so they both cmp the same.
764 - removes '-inl' since we don't require them to be after the main header.
765 - lowercase everything, just in case.
766
767 Args:
768 header_path: Path to be canonicalized.
769
770 Returns:
771 Canonicalized path.
772 """
773 return header_path.replace('-inl.h', '.h').replace('-', '_').lower()
774
erg@google.comfd5da632013-10-25 17:39:45 +0000775 def IsInAlphabeticalOrder(self, clean_lines, linenum, header_path):
erg@google.coma868d2d2009-10-09 21:18:45 +0000776 """Check if a header is in alphabetical order with the previous header.
777
778 Args:
erg@google.comfd5da632013-10-25 17:39:45 +0000779 clean_lines: A CleansedLines instance containing the file.
780 linenum: The number of the line to check.
781 header_path: Canonicalized header to be checked.
erg@google.coma868d2d2009-10-09 21:18:45 +0000782
783 Returns:
784 Returns true if the header is in alphabetical order.
785 """
erg@google.comfd5da632013-10-25 17:39:45 +0000786 # If previous section is different from current section, _last_header will
787 # be reset to empty string, so it's always less than current header.
788 #
789 # If previous line was a blank line, assume that the headers are
790 # intentionally sorted the way they are.
791 if (self._last_header > header_path and
avakulenko@google.com554223d2014-12-04 22:00:20 +0000792 Match(r'^\s*#\s*include\b', clean_lines.elided[linenum - 1])):
erg@google.coma868d2d2009-10-09 21:18:45 +0000793 return False
erg@google.coma868d2d2009-10-09 21:18:45 +0000794 return True
erg@google.com4e00b9a2009-01-12 23:05:11 +0000795
796 def CheckNextIncludeOrder(self, header_type):
797 """Returns a non-empty error message if the next header is out of order.
798
799 This function also updates the internal state to be ready to check
800 the next include.
801
802 Args:
803 header_type: One of the _XXX_HEADER constants defined above.
804
805 Returns:
806 The empty string if the header is in the right order, or an
807 error message describing what's wrong.
808
809 """
810 error_message = ('Found %s after %s' %
811 (self._TYPE_NAMES[header_type],
812 self._SECTION_NAMES[self._section]))
813
erg@google.coma868d2d2009-10-09 21:18:45 +0000814 last_section = self._section
815
erg@google.com4e00b9a2009-01-12 23:05:11 +0000816 if header_type == _C_SYS_HEADER:
817 if self._section <= self._C_SECTION:
818 self._section = self._C_SECTION
819 else:
erg@google.coma868d2d2009-10-09 21:18:45 +0000820 self._last_header = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +0000821 return error_message
822 elif header_type == _CPP_SYS_HEADER:
823 if self._section <= self._CPP_SECTION:
824 self._section = self._CPP_SECTION
825 else:
erg@google.coma868d2d2009-10-09 21:18:45 +0000826 self._last_header = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +0000827 return error_message
828 elif header_type == _LIKELY_MY_HEADER:
829 if self._section <= self._MY_H_SECTION:
830 self._section = self._MY_H_SECTION
831 else:
832 self._section = self._OTHER_H_SECTION
833 elif header_type == _POSSIBLE_MY_HEADER:
834 if self._section <= self._MY_H_SECTION:
835 self._section = self._MY_H_SECTION
836 else:
837 # This will always be the fallback because we're not sure
838 # enough that the header is associated with this file.
839 self._section = self._OTHER_H_SECTION
840 else:
841 assert header_type == _OTHER_HEADER
842 self._section = self._OTHER_H_SECTION
843
erg@google.coma868d2d2009-10-09 21:18:45 +0000844 if last_section != self._section:
845 self._last_header = ''
846
erg@google.com4e00b9a2009-01-12 23:05:11 +0000847 return ''
848
849
850class _CppLintState(object):
851 """Maintains module-wide state.."""
852
853 def __init__(self):
854 self.verbose_level = 1 # global setting.
855 self.error_count = 0 # global count of reported errors
erg@google.come35f7652009-06-19 20:52:09 +0000856 # filters to apply when emitting error messages
857 self.filters = _DEFAULT_FILTERS[:]
erg@google.com7430eef2014-07-28 22:33:46 +0000858 # backup of filter list. Used to restore the state after each file.
859 self._filters_backup = self.filters[:]
erg@google.coma868d2d2009-10-09 21:18:45 +0000860 self.counting = 'total' # In what way are we counting errors?
861 self.errors_by_category = {} # string to int dict storing error counts
erg@google.com4e00b9a2009-01-12 23:05:11 +0000862
863 # output format:
864 # "emacs" - format that emacs can parse (default)
865 # "vs7" - format that Microsoft Visual Studio 7 can parse
866 self.output_format = 'emacs'
867
868 def SetOutputFormat(self, output_format):
869 """Sets the output format for errors."""
870 self.output_format = output_format
871
872 def SetVerboseLevel(self, level):
873 """Sets the module's verbosity, and returns the previous setting."""
874 last_verbose_level = self.verbose_level
875 self.verbose_level = level
876 return last_verbose_level
877
erg@google.coma868d2d2009-10-09 21:18:45 +0000878 def SetCountingStyle(self, counting_style):
879 """Sets the module's counting options."""
880 self.counting = counting_style
881
erg@google.com4e00b9a2009-01-12 23:05:11 +0000882 def SetFilters(self, filters):
883 """Sets the error-message filters.
884
885 These filters are applied when deciding whether to emit a given
886 error message.
887
888 Args:
889 filters: A string of comma-separated filters (eg "+whitespace/indent").
890 Each filter should start with + or -; else we die.
erg@google.coma87abb82009-02-24 01:41:01 +0000891
892 Raises:
893 ValueError: The comma-separated filters did not all start with '+' or '-'.
894 E.g. "-,+whitespace,-whitespace/indent,whitespace/badfilter"
erg@google.com4e00b9a2009-01-12 23:05:11 +0000895 """
erg@google.come35f7652009-06-19 20:52:09 +0000896 # Default filters always have less priority than the flag ones.
897 self.filters = _DEFAULT_FILTERS[:]
erg@google.com7430eef2014-07-28 22:33:46 +0000898 self.AddFilters(filters)
899
900 def AddFilters(self, filters):
901 """ Adds more filters to the existing list of error-message filters. """
erg@google.come35f7652009-06-19 20:52:09 +0000902 for filt in filters.split(','):
903 clean_filt = filt.strip()
904 if clean_filt:
905 self.filters.append(clean_filt)
erg@google.com4e00b9a2009-01-12 23:05:11 +0000906 for filt in self.filters:
907 if not (filt.startswith('+') or filt.startswith('-')):
908 raise ValueError('Every filter in --filters must start with + or -'
909 ' (%s does not)' % filt)
910
erg@google.com7430eef2014-07-28 22:33:46 +0000911 def BackupFilters(self):
912 """ Saves the current filter list to backup storage."""
913 self._filters_backup = self.filters[:]
914
915 def RestoreFilters(self):
916 """ Restores filters previously backed up."""
917 self.filters = self._filters_backup[:]
918
erg@google.coma868d2d2009-10-09 21:18:45 +0000919 def ResetErrorCounts(self):
erg@google.com4e00b9a2009-01-12 23:05:11 +0000920 """Sets the module's error statistic back to zero."""
921 self.error_count = 0
erg@google.coma868d2d2009-10-09 21:18:45 +0000922 self.errors_by_category = {}
erg@google.com4e00b9a2009-01-12 23:05:11 +0000923
erg@google.coma868d2d2009-10-09 21:18:45 +0000924 def IncrementErrorCount(self, category):
erg@google.com4e00b9a2009-01-12 23:05:11 +0000925 """Bumps the module's error statistic."""
926 self.error_count += 1
erg@google.coma868d2d2009-10-09 21:18:45 +0000927 if self.counting in ('toplevel', 'detailed'):
928 if self.counting != 'detailed':
929 category = category.split('/')[0]
930 if category not in self.errors_by_category:
931 self.errors_by_category[category] = 0
932 self.errors_by_category[category] += 1
erg@google.com4e00b9a2009-01-12 23:05:11 +0000933
erg@google.coma868d2d2009-10-09 21:18:45 +0000934 def PrintErrorCounts(self):
935 """Print a summary of errors by category, and the total."""
936 for category, count in self.errors_by_category.iteritems():
937 sys.stderr.write('Category \'%s\' errors found: %d\n' %
938 (category, count))
LukeCze09f4782016-09-28 19:13:37 -0500939 sys.stdout.write('Total errors found: %d\n' % self.error_count)
erg@google.com4e00b9a2009-01-12 23:05:11 +0000940
941_cpplint_state = _CppLintState()
942
943
944def _OutputFormat():
945 """Gets the module's output format."""
946 return _cpplint_state.output_format
947
948
949def _SetOutputFormat(output_format):
950 """Sets the module's output format."""
951 _cpplint_state.SetOutputFormat(output_format)
952
953
954def _VerboseLevel():
955 """Returns the module's verbosity setting."""
956 return _cpplint_state.verbose_level
957
958
959def _SetVerboseLevel(level):
960 """Sets the module's verbosity, and returns the previous setting."""
961 return _cpplint_state.SetVerboseLevel(level)
962
963
erg@google.coma868d2d2009-10-09 21:18:45 +0000964def _SetCountingStyle(level):
965 """Sets the module's counting options."""
966 _cpplint_state.SetCountingStyle(level)
967
968
erg@google.com4e00b9a2009-01-12 23:05:11 +0000969def _Filters():
970 """Returns the module's list of output filters, as a list."""
971 return _cpplint_state.filters
972
973
974def _SetFilters(filters):
975 """Sets the module's error-message filters.
976
977 These filters are applied when deciding whether to emit a given
978 error message.
979
980 Args:
981 filters: A string of comma-separated filters (eg "whitespace/indent").
982 Each filter should start with + or -; else we die.
983 """
984 _cpplint_state.SetFilters(filters)
985
erg@google.com7430eef2014-07-28 22:33:46 +0000986def _AddFilters(filters):
987 """Adds more filter overrides.
988
989 Unlike _SetFilters, this function does not reset the current list of filters
990 available.
991
992 Args:
993 filters: A string of comma-separated filters (eg "whitespace/indent").
994 Each filter should start with + or -; else we die.
995 """
996 _cpplint_state.AddFilters(filters)
997
998def _BackupFilters():
999 """ Saves the current filter list to backup storage."""
1000 _cpplint_state.BackupFilters()
1001
1002def _RestoreFilters():
1003 """ Restores filters previously backed up."""
1004 _cpplint_state.RestoreFilters()
erg@google.com4e00b9a2009-01-12 23:05:11 +00001005
1006class _FunctionState(object):
1007 """Tracks current function name and the number of lines in its body."""
1008
1009 _NORMAL_TRIGGER = 250 # for --v=0, 500 for --v=1, etc.
1010 _TEST_TRIGGER = 400 # about 50% more than _NORMAL_TRIGGER.
1011
1012 def __init__(self):
1013 self.in_a_function = False
1014 self.lines_in_function = 0
1015 self.current_function = ''
1016
1017 def Begin(self, function_name):
1018 """Start analyzing function body.
1019
1020 Args:
1021 function_name: The name of the function being tracked.
1022 """
1023 self.in_a_function = True
1024 self.lines_in_function = 0
1025 self.current_function = function_name
1026
1027 def Count(self):
1028 """Count line in current function body."""
1029 if self.in_a_function:
1030 self.lines_in_function += 1
1031
1032 def Check(self, error, filename, linenum):
1033 """Report if too many lines in function body.
1034
1035 Args:
1036 error: The function to call with any errors found.
1037 filename: The name of the current file.
1038 linenum: The number of the line to check.
1039 """
Alex Vakulenko01e47232016-05-06 13:54:15 -07001040 if not self.in_a_function:
1041 return
1042
erg@google.com4e00b9a2009-01-12 23:05:11 +00001043 if Match(r'T(EST|est)', self.current_function):
1044 base_trigger = self._TEST_TRIGGER
1045 else:
1046 base_trigger = self._NORMAL_TRIGGER
1047 trigger = base_trigger * 2**_VerboseLevel()
1048
1049 if self.lines_in_function > trigger:
1050 error_level = int(math.log(self.lines_in_function / base_trigger, 2))
1051 # 50 => 0, 100 => 1, 200 => 2, 400 => 3, 800 => 4, 1600 => 5, ...
1052 if error_level > 5:
1053 error_level = 5
1054 error(filename, linenum, 'readability/fn_size', error_level,
1055 'Small and focused functions are preferred:'
1056 ' %s has %d non-comment lines'
1057 ' (error triggered by exceeding %d lines).' % (
1058 self.current_function, self.lines_in_function, trigger))
1059
1060 def End(self):
erg@google.com8a95ecc2011-09-08 00:45:54 +00001061 """Stop analyzing function body."""
erg@google.com4e00b9a2009-01-12 23:05:11 +00001062 self.in_a_function = False
1063
1064
1065class _IncludeError(Exception):
1066 """Indicates a problem with the include order in a file."""
1067 pass
1068
1069
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00001070class FileInfo(object):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001071 """Provides utility functions for filenames.
1072
1073 FileInfo provides easy access to the components of a file's path
1074 relative to the project root.
1075 """
1076
1077 def __init__(self, filename):
1078 self._filename = filename
1079
1080 def FullName(self):
1081 """Make Windows paths like Unix."""
1082 return os.path.abspath(self._filename).replace('\\', '/')
1083
1084 def RepositoryName(self):
1085 """FullName after removing the local path to the repository.
1086
1087 If we have a real absolute path name here we can try to do something smart:
1088 detecting the root of the checkout and truncating /path/to/checkout from
1089 the name so that we get header guards that don't include things like
1090 "C:\Documents and Settings\..." or "/home/username/..." in them and thus
1091 people on different computers who have checked the source out to different
1092 locations won't see bogus errors.
1093 """
1094 fullname = self.FullName()
1095
1096 if os.path.exists(fullname):
1097 project_dir = os.path.dirname(fullname)
1098
1099 if os.path.exists(os.path.join(project_dir, ".svn")):
1100 # If there's a .svn file in the current directory, we recursively look
1101 # up the directory tree for the top of the SVN checkout
1102 root_dir = project_dir
1103 one_up_dir = os.path.dirname(root_dir)
1104 while os.path.exists(os.path.join(one_up_dir, ".svn")):
1105 root_dir = os.path.dirname(root_dir)
1106 one_up_dir = os.path.dirname(one_up_dir)
1107
1108 prefix = os.path.commonprefix([root_dir, project_dir])
1109 return fullname[len(prefix) + 1:]
1110
erg@google.com3dc74262011-11-30 01:12:00 +00001111 # Not SVN <= 1.6? Try to find a git, hg, or svn top level directory by
1112 # searching up from the current path.
Alex Vakulenko01e47232016-05-06 13:54:15 -07001113 root_dir = current_dir = os.path.dirname(fullname)
1114 while current_dir != os.path.dirname(current_dir):
1115 if (os.path.exists(os.path.join(current_dir, ".git")) or
1116 os.path.exists(os.path.join(current_dir, ".hg")) or
1117 os.path.exists(os.path.join(current_dir, ".svn"))):
1118 root_dir = current_dir
1119 current_dir = os.path.dirname(current_dir)
erg@google.com42e59b02010-10-04 22:18:07 +00001120
1121 if (os.path.exists(os.path.join(root_dir, ".git")) or
erg@google.com3dc74262011-11-30 01:12:00 +00001122 os.path.exists(os.path.join(root_dir, ".hg")) or
1123 os.path.exists(os.path.join(root_dir, ".svn"))):
erg@google.com42e59b02010-10-04 22:18:07 +00001124 prefix = os.path.commonprefix([root_dir, project_dir])
1125 return fullname[len(prefix) + 1:]
erg@google.com4e00b9a2009-01-12 23:05:11 +00001126
1127 # Don't know what to do; header guard warnings may be wrong...
1128 return fullname
1129
1130 def Split(self):
1131 """Splits the file into the directory, basename, and extension.
1132
1133 For 'chrome/browser/browser.cc', Split() would
1134 return ('chrome/browser', 'browser', '.cc')
1135
1136 Returns:
1137 A tuple of (directory, basename, extension).
1138 """
1139
1140 googlename = self.RepositoryName()
1141 project, rest = os.path.split(googlename)
1142 return (project,) + os.path.splitext(rest)
1143
1144 def BaseName(self):
1145 """File base name - text after the final slash, before the final period."""
1146 return self.Split()[1]
1147
1148 def Extension(self):
1149 """File extension - text following the final period."""
1150 return self.Split()[2]
1151
1152 def NoExtension(self):
1153 """File has no source file extension."""
1154 return '/'.join(self.Split()[0:2])
1155
1156 def IsSource(self):
1157 """File has a source file extension."""
Alex Vakulenko01e47232016-05-06 13:54:15 -07001158 return _IsSourceExtension(self.Extension()[1:])
erg@google.com4e00b9a2009-01-12 23:05:11 +00001159
1160
erg+personal@google.com05189642010-04-30 20:43:03 +00001161def _ShouldPrintError(category, confidence, linenum):
erg@google.com8a95ecc2011-09-08 00:45:54 +00001162 """If confidence >= verbose, category passes filter and is not suppressed."""
erg+personal@google.com05189642010-04-30 20:43:03 +00001163
1164 # There are three ways we might decide not to print an error message:
1165 # a "NOLINT(category)" comment appears in the source,
erg@google.com4e00b9a2009-01-12 23:05:11 +00001166 # the verbosity level isn't high enough, or the filters filter it out.
erg+personal@google.com05189642010-04-30 20:43:03 +00001167 if IsErrorSuppressedByNolint(category, linenum):
1168 return False
avakulenko@google.com02af6282014-06-04 18:53:25 +00001169
erg@google.com4e00b9a2009-01-12 23:05:11 +00001170 if confidence < _cpplint_state.verbose_level:
1171 return False
1172
1173 is_filtered = False
1174 for one_filter in _Filters():
1175 if one_filter.startswith('-'):
1176 if category.startswith(one_filter[1:]):
1177 is_filtered = True
1178 elif one_filter.startswith('+'):
1179 if category.startswith(one_filter[1:]):
1180 is_filtered = False
1181 else:
1182 assert False # should have been checked for in SetFilter.
1183 if is_filtered:
1184 return False
1185
1186 return True
1187
1188
1189def Error(filename, linenum, category, confidence, message):
1190 """Logs the fact we've found a lint error.
1191
1192 We log where the error was found, and also our confidence in the error,
1193 that is, how certain we are this is a legitimate style regression, and
1194 not a misidentification or a use that's sometimes justified.
1195
erg+personal@google.com05189642010-04-30 20:43:03 +00001196 False positives can be suppressed by the use of
1197 "cpplint(category)" comments on the offending line. These are
1198 parsed into _error_suppressions.
1199
erg@google.com4e00b9a2009-01-12 23:05:11 +00001200 Args:
1201 filename: The name of the file containing the error.
1202 linenum: The number of the line containing the error.
1203 category: A string used to describe the "category" this bug
1204 falls under: "whitespace", say, or "runtime". Categories
1205 may have a hierarchy separated by slashes: "whitespace/indent".
1206 confidence: A number from 1-5 representing a confidence score for
1207 the error, with 5 meaning that we are certain of the problem,
1208 and 1 meaning that it could be a legitimate construct.
1209 message: The error message.
1210 """
erg+personal@google.com05189642010-04-30 20:43:03 +00001211 if _ShouldPrintError(category, confidence, linenum):
erg@google.coma868d2d2009-10-09 21:18:45 +00001212 _cpplint_state.IncrementErrorCount(category)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001213 if _cpplint_state.output_format == 'vs7':
schoetbi819c5722017-05-03 10:09:12 +02001214 sys.stderr.write('%s(%s): error cpplint: [%s] %s [%d]\n' % (
1215 filename, linenum, category, message, confidence))
erg@google.com02c27fd2013-05-28 21:34:34 +00001216 elif _cpplint_state.output_format == 'eclipse':
1217 sys.stderr.write('%s:%s: warning: %s [%s] [%d]\n' % (
1218 filename, linenum, message, category, confidence))
erg@google.com4e00b9a2009-01-12 23:05:11 +00001219 else:
1220 sys.stderr.write('%s:%s: %s [%s] [%d]\n' % (
1221 filename, linenum, message, category, confidence))
1222
1223
erg@google.com2aa59982013-10-28 19:09:25 +00001224# Matches standard C++ escape sequences per 2.13.2.3 of the C++ standard.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001225_RE_PATTERN_CLEANSE_LINE_ESCAPES = re.compile(
1226 r'\\([abfnrtv?"\\\']|\d+|x[0-9a-fA-F]+)')
avakulenko@google.com02af6282014-06-04 18:53:25 +00001227# Match a single C style comment on the same line.
1228_RE_PATTERN_C_COMMENTS = r'/\*(?:[^*]|\*(?!/))*\*/'
1229# Matches multi-line C style comments.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001230# This RE is a little bit more complicated than one might expect, because we
1231# have to take care of space removals tools so we can handle comments inside
1232# statements better.
1233# The current rule is: We only clear spaces from both sides when we're at the
1234# end of the line. Otherwise, we try to remove spaces from the right side,
1235# if this doesn't work we try on left side but only if there's a non-character
1236# on the right.
1237_RE_PATTERN_CLEANSE_LINE_C_COMMENTS = re.compile(
avakulenko@google.com02af6282014-06-04 18:53:25 +00001238 r'(\s*' + _RE_PATTERN_C_COMMENTS + r'\s*$|' +
1239 _RE_PATTERN_C_COMMENTS + r'\s+|' +
1240 r'\s+' + _RE_PATTERN_C_COMMENTS + r'(?=\W)|' +
1241 _RE_PATTERN_C_COMMENTS + r')')
erg@google.com4e00b9a2009-01-12 23:05:11 +00001242
1243
1244def IsCppString(line):
1245 """Does line terminate so, that the next symbol is in string constant.
1246
1247 This function does not consider single-line nor multi-line comments.
1248
1249 Args:
1250 line: is a partial line of code starting from the 0..n.
1251
1252 Returns:
1253 True, if next character appended to 'line' is inside a
1254 string constant.
1255 """
1256
1257 line = line.replace(r'\\', 'XX') # after this, \\" does not match to \"
1258 return ((line.count('"') - line.count(r'\"') - line.count("'\"'")) & 1) == 1
1259
1260
erg@google.com2aa59982013-10-28 19:09:25 +00001261def CleanseRawStrings(raw_lines):
1262 """Removes C++11 raw strings from lines.
1263
1264 Before:
1265 static const char kData[] = R"(
1266 multi-line string
1267 )";
1268
1269 After:
1270 static const char kData[] = ""
1271 (replaced by blank line)
1272 "";
1273
1274 Args:
1275 raw_lines: list of raw lines.
1276
1277 Returns:
1278 list of lines with C++11 raw strings replaced by empty strings.
1279 """
1280
1281 delimiter = None
1282 lines_without_raw_strings = []
1283 for line in raw_lines:
1284 if delimiter:
1285 # Inside a raw string, look for the end
1286 end = line.find(delimiter)
1287 if end >= 0:
1288 # Found the end of the string, match leading space for this
1289 # line and resume copying the original lines, and also insert
1290 # a "" on the last line.
1291 leading_space = Match(r'^(\s*)\S', line)
1292 line = leading_space.group(1) + '""' + line[end + len(delimiter):]
1293 delimiter = None
1294 else:
1295 # Haven't found the end yet, append a blank line.
avakulenko@google.com02af6282014-06-04 18:53:25 +00001296 line = '""'
erg@google.com2aa59982013-10-28 19:09:25 +00001297
avakulenko@google.com02af6282014-06-04 18:53:25 +00001298 # Look for beginning of a raw string, and replace them with
1299 # empty strings. This is done in a loop to handle multiple raw
1300 # strings on the same line.
1301 while delimiter is None:
erg@google.com2aa59982013-10-28 19:09:25 +00001302 # Look for beginning of a raw string.
1303 # See 2.14.15 [lex.string] for syntax.
Alex Vakulenko01e47232016-05-06 13:54:15 -07001304 #
1305 # Once we have matched a raw string, we check the prefix of the
1306 # line to make sure that the line is not part of a single line
1307 # comment. It's done this way because we remove raw strings
1308 # before removing comments as opposed to removing comments
1309 # before removing raw strings. This is because there are some
1310 # cpplint checks that requires the comments to be preserved, but
1311 # we don't want to check comments that are inside raw strings.
1312 matched = Match(r'^(.*?)\b(?:R|u8R|uR|UR|LR)"([^\s\\()]*)\((.*)$', line)
1313 if (matched and
1314 not Match(r'^([^\'"]|\'(\\.|[^\'])*\'|"(\\.|[^"])*")*//',
1315 matched.group(1))):
erg@google.com2aa59982013-10-28 19:09:25 +00001316 delimiter = ')' + matched.group(2) + '"'
1317
1318 end = matched.group(3).find(delimiter)
1319 if end >= 0:
1320 # Raw string ended on same line
1321 line = (matched.group(1) + '""' +
1322 matched.group(3)[end + len(delimiter):])
1323 delimiter = None
1324 else:
1325 # Start of a multi-line raw string
1326 line = matched.group(1) + '""'
avakulenko@google.com02af6282014-06-04 18:53:25 +00001327 else:
1328 break
erg@google.com2aa59982013-10-28 19:09:25 +00001329
1330 lines_without_raw_strings.append(line)
1331
1332 # TODO(unknown): if delimiter is not None here, we might want to
1333 # emit a warning for unterminated string.
1334 return lines_without_raw_strings
1335
1336
erg@google.com4e00b9a2009-01-12 23:05:11 +00001337def FindNextMultiLineCommentStart(lines, lineix):
1338 """Find the beginning marker for a multiline comment."""
1339 while lineix < len(lines):
1340 if lines[lineix].strip().startswith('/*'):
1341 # Only return this marker if the comment goes beyond this line
1342 if lines[lineix].strip().find('*/', 2) < 0:
1343 return lineix
1344 lineix += 1
1345 return len(lines)
1346
1347
1348def FindNextMultiLineCommentEnd(lines, lineix):
1349 """We are inside a comment, find the end marker."""
1350 while lineix < len(lines):
1351 if lines[lineix].strip().endswith('*/'):
1352 return lineix
1353 lineix += 1
1354 return len(lines)
1355
1356
1357def RemoveMultiLineCommentsFromRange(lines, begin, end):
1358 """Clears a range of lines for multi-line comments."""
1359 # Having // dummy comments makes the lines non-empty, so we will not get
1360 # unnecessary blank line warnings later in the code.
1361 for i in range(begin, end):
avakulenko@google.com554223d2014-12-04 22:00:20 +00001362 lines[i] = '/**/'
erg@google.com4e00b9a2009-01-12 23:05:11 +00001363
1364
1365def RemoveMultiLineComments(filename, lines, error):
1366 """Removes multiline (c-style) comments from lines."""
1367 lineix = 0
1368 while lineix < len(lines):
1369 lineix_begin = FindNextMultiLineCommentStart(lines, lineix)
1370 if lineix_begin >= len(lines):
1371 return
1372 lineix_end = FindNextMultiLineCommentEnd(lines, lineix_begin)
1373 if lineix_end >= len(lines):
1374 error(filename, lineix_begin + 1, 'readability/multiline_comment', 5,
1375 'Could not find end of multi-line comment')
1376 return
1377 RemoveMultiLineCommentsFromRange(lines, lineix_begin, lineix_end + 1)
1378 lineix = lineix_end + 1
1379
1380
1381def CleanseComments(line):
1382 """Removes //-comments and single-line C-style /* */ comments.
1383
1384 Args:
1385 line: A line of C++ source.
1386
1387 Returns:
1388 The line with single-line comments removed.
1389 """
1390 commentpos = line.find('//')
1391 if commentpos != -1 and not IsCppString(line[:commentpos]):
erg@google.comd7d27472011-09-07 17:36:35 +00001392 line = line[:commentpos].rstrip()
erg@google.com4e00b9a2009-01-12 23:05:11 +00001393 # get rid of /* ... */
1394 return _RE_PATTERN_CLEANSE_LINE_C_COMMENTS.sub('', line)
1395
1396
erg@google.coma87abb82009-02-24 01:41:01 +00001397class CleansedLines(object):
avakulenko@google.com554223d2014-12-04 22:00:20 +00001398 """Holds 4 copies of all lines with different preprocessing applied to them.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001399
avakulenko@google.com554223d2014-12-04 22:00:20 +00001400 1) elided member contains lines without strings and comments.
1401 2) lines member contains lines without comments.
erg@google.comd350fe52013-01-14 17:51:48 +00001402 3) raw_lines member contains all the lines without processing.
avakulenko@google.com554223d2014-12-04 22:00:20 +00001403 4) lines_without_raw_strings member is same as raw_lines, but with C++11 raw
1404 strings removed.
1405 All these members are of <type 'list'>, and of the same length.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001406 """
1407
1408 def __init__(self, lines):
1409 self.elided = []
1410 self.lines = []
1411 self.raw_lines = lines
1412 self.num_lines = len(lines)
erg@google.com2aa59982013-10-28 19:09:25 +00001413 self.lines_without_raw_strings = CleanseRawStrings(lines)
1414 for linenum in range(len(self.lines_without_raw_strings)):
1415 self.lines.append(CleanseComments(
1416 self.lines_without_raw_strings[linenum]))
1417 elided = self._CollapseStrings(self.lines_without_raw_strings[linenum])
erg@google.com4e00b9a2009-01-12 23:05:11 +00001418 self.elided.append(CleanseComments(elided))
1419
1420 def NumLines(self):
1421 """Returns the number of lines represented."""
1422 return self.num_lines
1423
1424 @staticmethod
1425 def _CollapseStrings(elided):
1426 """Collapses strings and chars on a line to simple "" or '' blocks.
1427
1428 We nix strings first so we're not fooled by text like '"http://"'
1429
1430 Args:
1431 elided: The line being processed.
1432
1433 Returns:
1434 The line with collapsed strings.
1435 """
avakulenko@google.com02af6282014-06-04 18:53:25 +00001436 if _RE_PATTERN_INCLUDE.match(elided):
1437 return elided
1438
1439 # Remove escaped characters first to make quote/single quote collapsing
1440 # basic. Things that look like escaped characters shouldn't occur
1441 # outside of strings and chars.
1442 elided = _RE_PATTERN_CLEANSE_LINE_ESCAPES.sub('', elided)
1443
1444 # Replace quoted strings and digit separators. Both single quotes
1445 # and double quotes are processed in the same loop, otherwise
1446 # nested quotes wouldn't work.
1447 collapsed = ''
1448 while True:
1449 # Find the first quote character
1450 match = Match(r'^([^\'"]*)([\'"])(.*)$', elided)
1451 if not match:
1452 collapsed += elided
1453 break
1454 head, quote, tail = match.groups()
1455
1456 if quote == '"':
1457 # Collapse double quoted strings
1458 second_quote = tail.find('"')
1459 if second_quote >= 0:
1460 collapsed += head + '""'
1461 elided = tail[second_quote + 1:]
1462 else:
1463 # Unmatched double quote, don't bother processing the rest
1464 # of the line since this is probably a multiline string.
1465 collapsed += elided
1466 break
1467 else:
1468 # Found single quote, check nearby text to eliminate digit separators.
1469 #
1470 # There is no special handling for floating point here, because
1471 # the integer/fractional/exponent parts would all be parsed
1472 # correctly as long as there are digits on both sides of the
1473 # separator. So we are fine as long as we don't see something
1474 # like "0.'3" (gcc 4.9.0 will not allow this literal).
1475 if Search(r'\b(?:0[bBxX]?|[1-9])[0-9a-fA-F]*$', head):
1476 match_literal = Match(r'^((?:\'?[0-9a-zA-Z_])*)(.*)$', "'" + tail)
1477 collapsed += head + match_literal.group(1).replace("'", '')
1478 elided = match_literal.group(2)
1479 else:
1480 second_quote = tail.find('\'')
1481 if second_quote >= 0:
1482 collapsed += head + "''"
1483 elided = tail[second_quote + 1:]
1484 else:
1485 # Unmatched single quote
1486 collapsed += elided
1487 break
1488
1489 return collapsed
erg@google.com4e00b9a2009-01-12 23:05:11 +00001490
1491
avakulenko@google.com02af6282014-06-04 18:53:25 +00001492def FindEndOfExpressionInLine(line, startpos, stack):
1493 """Find the position just after the end of current parenthesized expression.
erg@google.comd350fe52013-01-14 17:51:48 +00001494
1495 Args:
1496 line: a CleansedLines line.
1497 startpos: start searching at this position.
avakulenko@google.com02af6282014-06-04 18:53:25 +00001498 stack: nesting stack at startpos.
erg@google.comd350fe52013-01-14 17:51:48 +00001499
1500 Returns:
avakulenko@google.com02af6282014-06-04 18:53:25 +00001501 On finding matching end: (index just after matching end, None)
1502 On finding an unclosed expression: (-1, None)
1503 Otherwise: (-1, new stack at end of this line)
erg@google.comd350fe52013-01-14 17:51:48 +00001504 """
1505 for i in xrange(startpos, len(line)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00001506 char = line[i]
1507 if char in '([{':
1508 # Found start of parenthesized expression, push to expression stack
1509 stack.append(char)
1510 elif char == '<':
1511 # Found potential start of template argument list
1512 if i > 0 and line[i - 1] == '<':
1513 # Left shift operator
1514 if stack and stack[-1] == '<':
1515 stack.pop()
1516 if not stack:
1517 return (-1, None)
1518 elif i > 0 and Search(r'\boperator\s*$', line[0:i]):
1519 # operator<, don't add to stack
1520 continue
1521 else:
1522 # Tentative start of template argument list
1523 stack.append('<')
1524 elif char in ')]}':
1525 # Found end of parenthesized expression.
1526 #
1527 # If we are currently expecting a matching '>', the pending '<'
1528 # must have been an operator. Remove them from expression stack.
1529 while stack and stack[-1] == '<':
1530 stack.pop()
1531 if not stack:
1532 return (-1, None)
1533 if ((stack[-1] == '(' and char == ')') or
1534 (stack[-1] == '[' and char == ']') or
1535 (stack[-1] == '{' and char == '}')):
1536 stack.pop()
1537 if not stack:
1538 return (i + 1, None)
1539 else:
1540 # Mismatched parentheses
1541 return (-1, None)
1542 elif char == '>':
1543 # Found potential end of template argument list.
1544
1545 # Ignore "->" and operator functions
1546 if (i > 0 and
1547 (line[i - 1] == '-' or Search(r'\boperator\s*$', line[0:i - 1]))):
1548 continue
1549
1550 # Pop the stack if there is a matching '<'. Otherwise, ignore
1551 # this '>' since it must be an operator.
1552 if stack:
1553 if stack[-1] == '<':
1554 stack.pop()
1555 if not stack:
1556 return (i + 1, None)
1557 elif char == ';':
1558 # Found something that look like end of statements. If we are currently
1559 # expecting a '>', the matching '<' must have been an operator, since
1560 # template argument list should not contain statements.
1561 while stack and stack[-1] == '<':
1562 stack.pop()
1563 if not stack:
1564 return (-1, None)
1565
1566 # Did not find end of expression or unbalanced parentheses on this line
1567 return (-1, stack)
erg@google.comd350fe52013-01-14 17:51:48 +00001568
1569
erg@google.com4e00b9a2009-01-12 23:05:11 +00001570def CloseExpression(clean_lines, linenum, pos):
erg@google.com2aa59982013-10-28 19:09:25 +00001571 """If input points to ( or { or [ or <, finds the position that closes it.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001572
erg@google.com2aa59982013-10-28 19:09:25 +00001573 If lines[linenum][pos] points to a '(' or '{' or '[' or '<', finds the
erg@google.com4e00b9a2009-01-12 23:05:11 +00001574 linenum/pos that correspond to the closing of the expression.
1575
avakulenko@google.com02af6282014-06-04 18:53:25 +00001576 TODO(unknown): cpplint spends a fair bit of time matching parentheses.
1577 Ideally we would want to index all opening and closing parentheses once
1578 and have CloseExpression be just a simple lookup, but due to preprocessor
1579 tricks, this is not so easy.
1580
erg@google.com4e00b9a2009-01-12 23:05:11 +00001581 Args:
1582 clean_lines: A CleansedLines instance containing the file.
1583 linenum: The number of the line to check.
1584 pos: A position on the line.
1585
1586 Returns:
1587 A tuple (line, linenum, pos) pointer *past* the closing brace, or
1588 (line, len(lines), -1) if we never find a close. Note we ignore
1589 strings and comments when matching; and the line we return is the
1590 'cleansed' line at linenum.
1591 """
1592
1593 line = clean_lines.elided[linenum]
avakulenko@google.com02af6282014-06-04 18:53:25 +00001594 if (line[pos] not in '({[<') or Match(r'<[<=]', line[pos:]):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001595 return (line, clean_lines.NumLines(), -1)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001596
erg@google.comd350fe52013-01-14 17:51:48 +00001597 # Check first line
avakulenko@google.com02af6282014-06-04 18:53:25 +00001598 (end_pos, stack) = FindEndOfExpressionInLine(line, pos, [])
erg@google.comd350fe52013-01-14 17:51:48 +00001599 if end_pos > -1:
1600 return (line, linenum, end_pos)
erg@google.com2aa59982013-10-28 19:09:25 +00001601
1602 # Continue scanning forward
avakulenko@google.com02af6282014-06-04 18:53:25 +00001603 while stack and linenum < clean_lines.NumLines() - 1:
erg@google.com4e00b9a2009-01-12 23:05:11 +00001604 linenum += 1
1605 line = clean_lines.elided[linenum]
avakulenko@google.com02af6282014-06-04 18:53:25 +00001606 (end_pos, stack) = FindEndOfExpressionInLine(line, 0, stack)
erg@google.com2aa59982013-10-28 19:09:25 +00001607 if end_pos > -1:
1608 return (line, linenum, end_pos)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001609
avakulenko@google.com02af6282014-06-04 18:53:25 +00001610 # Did not find end of expression before end of file, give up
erg@google.comd350fe52013-01-14 17:51:48 +00001611 return (line, clean_lines.NumLines(), -1)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001612
erg@google.com2aa59982013-10-28 19:09:25 +00001613
avakulenko@google.com02af6282014-06-04 18:53:25 +00001614def FindStartOfExpressionInLine(line, endpos, stack):
1615 """Find position at the matching start of current expression.
erg@google.com2aa59982013-10-28 19:09:25 +00001616
1617 This is almost the reverse of FindEndOfExpressionInLine, but note
1618 that the input position and returned position differs by 1.
1619
1620 Args:
1621 line: a CleansedLines line.
1622 endpos: start searching at this position.
avakulenko@google.com02af6282014-06-04 18:53:25 +00001623 stack: nesting stack at endpos.
erg@google.com2aa59982013-10-28 19:09:25 +00001624
1625 Returns:
avakulenko@google.com02af6282014-06-04 18:53:25 +00001626 On finding matching start: (index at matching start, None)
1627 On finding an unclosed expression: (-1, None)
1628 Otherwise: (-1, new stack at beginning of this line)
erg@google.com2aa59982013-10-28 19:09:25 +00001629 """
avakulenko@google.com02af6282014-06-04 18:53:25 +00001630 i = endpos
1631 while i >= 0:
1632 char = line[i]
1633 if char in ')]}':
1634 # Found end of expression, push to expression stack
1635 stack.append(char)
1636 elif char == '>':
1637 # Found potential end of template argument list.
1638 #
1639 # Ignore it if it's a "->" or ">=" or "operator>"
1640 if (i > 0 and
1641 (line[i - 1] == '-' or
1642 Match(r'\s>=\s', line[i - 1:]) or
1643 Search(r'\boperator\s*$', line[0:i]))):
1644 i -= 1
1645 else:
1646 stack.append('>')
1647 elif char == '<':
1648 # Found potential start of template argument list
1649 if i > 0 and line[i - 1] == '<':
1650 # Left shift operator
1651 i -= 1
1652 else:
1653 # If there is a matching '>', we can pop the expression stack.
1654 # Otherwise, ignore this '<' since it must be an operator.
1655 if stack and stack[-1] == '>':
1656 stack.pop()
1657 if not stack:
1658 return (i, None)
1659 elif char in '([{':
1660 # Found start of expression.
1661 #
1662 # If there are any unmatched '>' on the stack, they must be
1663 # operators. Remove those.
1664 while stack and stack[-1] == '>':
1665 stack.pop()
1666 if not stack:
1667 return (-1, None)
1668 if ((char == '(' and stack[-1] == ')') or
1669 (char == '[' and stack[-1] == ']') or
1670 (char == '{' and stack[-1] == '}')):
1671 stack.pop()
1672 if not stack:
1673 return (i, None)
1674 else:
1675 # Mismatched parentheses
1676 return (-1, None)
1677 elif char == ';':
1678 # Found something that look like end of statements. If we are currently
1679 # expecting a '<', the matching '>' must have been an operator, since
1680 # template argument list should not contain statements.
1681 while stack and stack[-1] == '>':
1682 stack.pop()
1683 if not stack:
1684 return (-1, None)
1685
1686 i -= 1
1687
1688 return (-1, stack)
erg@google.com2aa59982013-10-28 19:09:25 +00001689
1690
1691def ReverseCloseExpression(clean_lines, linenum, pos):
1692 """If input points to ) or } or ] or >, finds the position that opens it.
1693
1694 If lines[linenum][pos] points to a ')' or '}' or ']' or '>', finds the
1695 linenum/pos that correspond to the opening of the expression.
1696
1697 Args:
1698 clean_lines: A CleansedLines instance containing the file.
1699 linenum: The number of the line to check.
1700 pos: A position on the line.
1701
1702 Returns:
1703 A tuple (line, linenum, pos) pointer *at* the opening brace, or
1704 (line, 0, -1) if we never find the matching opening brace. Note
1705 we ignore strings and comments when matching; and the line we
1706 return is the 'cleansed' line at linenum.
1707 """
1708 line = clean_lines.elided[linenum]
avakulenko@google.com02af6282014-06-04 18:53:25 +00001709 if line[pos] not in ')}]>':
erg@google.com2aa59982013-10-28 19:09:25 +00001710 return (line, 0, -1)
erg@google.com2aa59982013-10-28 19:09:25 +00001711
1712 # Check last line
avakulenko@google.com02af6282014-06-04 18:53:25 +00001713 (start_pos, stack) = FindStartOfExpressionInLine(line, pos, [])
erg@google.com2aa59982013-10-28 19:09:25 +00001714 if start_pos > -1:
1715 return (line, linenum, start_pos)
1716
1717 # Continue scanning backward
avakulenko@google.com02af6282014-06-04 18:53:25 +00001718 while stack and linenum > 0:
erg@google.com2aa59982013-10-28 19:09:25 +00001719 linenum -= 1
1720 line = clean_lines.elided[linenum]
avakulenko@google.com02af6282014-06-04 18:53:25 +00001721 (start_pos, stack) = FindStartOfExpressionInLine(line, len(line) - 1, stack)
erg@google.com2aa59982013-10-28 19:09:25 +00001722 if start_pos > -1:
1723 return (line, linenum, start_pos)
1724
avakulenko@google.com02af6282014-06-04 18:53:25 +00001725 # Did not find start of expression before beginning of file, give up
erg@google.com2aa59982013-10-28 19:09:25 +00001726 return (line, 0, -1)
1727
1728
erg@google.com4e00b9a2009-01-12 23:05:11 +00001729def CheckForCopyright(filename, lines, error):
1730 """Logs an error if no Copyright message appears at the top of the file."""
1731
1732 # We'll say it should occur by line 10. Don't forget there's a
1733 # dummy line at the front.
1734 for line in xrange(1, min(len(lines), 11)):
1735 if re.search(r'Copyright', lines[line], re.I): break
1736 else: # means no copyright line was found
1737 error(filename, 0, 'legal/copyright', 5,
1738 'No copyright message found. '
1739 'You should have a line: "Copyright [year] <Copyright Owner>"')
1740
1741
avakulenko@google.com02af6282014-06-04 18:53:25 +00001742def GetIndentLevel(line):
1743 """Return the number of leading spaces in line.
1744
1745 Args:
1746 line: A string to check.
1747
1748 Returns:
1749 An integer count of leading spaces, possibly zero.
1750 """
1751 indent = Match(r'^( *)\S', line)
1752 if indent:
1753 return len(indent.group(1))
1754 else:
1755 return 0
1756
Igor Murashkine7ddd2a2017-11-06 15:00:05 -08001757def PathSplitToList(path):
1758 """Returns the path split into a list by the separator.
1759
1760 Args:
1761 path: An absolute or relative path (e.g. '/a/b/c/' or '../a')
1762
1763 Returns:
1764 A list of path components (e.g. ['a', 'b', 'c]).
1765 """
1766 lst = []
1767 while True:
1768 (head, tail) = os.path.split(path)
1769 if head == path: # absolute paths end
1770 lst.append(head)
1771 break
1772 if tail == path: # relative paths end
1773 lst.append(tail)
1774 break
1775
1776 path = head
1777 lst.append(tail)
1778
1779 lst.reverse()
1780 return lst
avakulenko@google.com02af6282014-06-04 18:53:25 +00001781
erg@google.com4e00b9a2009-01-12 23:05:11 +00001782def GetHeaderGuardCPPVariable(filename):
1783 """Returns the CPP variable that should be used as a header guard.
1784
1785 Args:
1786 filename: The name of a C++ header file.
1787
1788 Returns:
1789 The CPP variable that should be used as a header guard in the
1790 named file.
1791
1792 """
1793
erg+personal@google.com05189642010-04-30 20:43:03 +00001794 # Restores original filename in case that cpplint is invoked from Emacs's
1795 # flymake.
1796 filename = re.sub(r'_flymake\.h$', '.h', filename)
erg@google.comd350fe52013-01-14 17:51:48 +00001797 filename = re.sub(r'/\.flymake/([^/]*)$', r'/\1', filename)
avakulenko@google.com554223d2014-12-04 22:00:20 +00001798 # Replace 'c++' with 'cpp'.
1799 filename = filename.replace('C++', 'cpp').replace('c++', 'cpp')
Alex Vakulenko01e47232016-05-06 13:54:15 -07001800
erg@google.com4e00b9a2009-01-12 23:05:11 +00001801 fileinfo = FileInfo(filename)
erg@google.com4d70a882013-04-16 21:06:32 +00001802 file_path_from_root = fileinfo.RepositoryName()
Igor Murashkine7ddd2a2017-11-06 15:00:05 -08001803
1804 def FixupPathFromRoot():
1805 # Process the file path with the --root flag if it was set.
1806 if not _root:
1807 return file_path_from_root
1808
1809 def StripListPrefix(lst, prefix):
1810 # f(['x', 'y'], ['w, z']) -> None (not a valid prefix)
1811 if lst[:len(prefix)] != prefix:
1812 return None
1813 # f(['a, 'b', 'c', 'd'], ['a', 'b']) -> ['c', 'd']
1814 return lst[(len(prefix)):]
1815
1816 # root behavior:
1817 # --root=subdir , lstrips subdir from the header guard
1818 maybe_path = StripListPrefix(PathSplitToList(file_path_from_root),
1819 PathSplitToList(_root))
1820 if maybe_path:
1821 return os.path.join(*maybe_path)
1822
1823 # --root=.. , will prepend the outer directory to the header guard
1824 full_path = fileinfo.FullName()
1825 root_abspath = os.path.abspath(_root)
1826
1827 maybe_path = StripListPrefix(PathSplitToList(full_path),
1828 PathSplitToList(root_abspath))
1829 if maybe_path:
1830 return os.path.join(*maybe_path)
1831
1832 # --root=FAKE_DIR is ignored
1833 return file_path_from_root
1834
1835 file_path_from_root = FixupPathFromRoot()
avakulenko@google.com554223d2014-12-04 22:00:20 +00001836 return re.sub(r'[^a-zA-Z0-9]', '_', file_path_from_root).upper() + '_'
erg@google.com4e00b9a2009-01-12 23:05:11 +00001837
1838
avakulenko@google.com554223d2014-12-04 22:00:20 +00001839def CheckForHeaderGuard(filename, clean_lines, error):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001840 """Checks that the file contains a header guard.
1841
erg@google.coma87abb82009-02-24 01:41:01 +00001842 Logs an error if no #ifndef header guard is present. For other
erg@google.com4e00b9a2009-01-12 23:05:11 +00001843 headers, checks that the full pathname is used.
1844
1845 Args:
1846 filename: The name of the C++ header file.
avakulenko@google.com554223d2014-12-04 22:00:20 +00001847 clean_lines: A CleansedLines instance containing the file.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001848 error: The function to call with any errors found.
1849 """
1850
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00001851 # Don't check for header guards if there are error suppression
1852 # comments somewhere in this file.
1853 #
1854 # Because this is silencing a warning for a nonexistent line, we
1855 # only support the very specific NOLINT(build/header_guard) syntax,
1856 # and not the general NOLINT or NOLINT(*) syntax.
avakulenko@google.com554223d2014-12-04 22:00:20 +00001857 raw_lines = clean_lines.lines_without_raw_strings
1858 for i in raw_lines:
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00001859 if Search(r'//\s*NOLINT\(build/header_guard\)', i):
1860 return
1861
erg@google.com4e00b9a2009-01-12 23:05:11 +00001862 cppvar = GetHeaderGuardCPPVariable(filename)
1863
avakulenko@google.com554223d2014-12-04 22:00:20 +00001864 ifndef = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +00001865 ifndef_linenum = 0
avakulenko@google.com554223d2014-12-04 22:00:20 +00001866 define = ''
1867 endif = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +00001868 endif_linenum = 0
avakulenko@google.com554223d2014-12-04 22:00:20 +00001869 for linenum, line in enumerate(raw_lines):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001870 linesplit = line.split()
1871 if len(linesplit) >= 2:
1872 # find the first occurrence of #ifndef and #define, save arg
1873 if not ifndef and linesplit[0] == '#ifndef':
1874 # set ifndef to the header guard presented on the #ifndef line.
1875 ifndef = linesplit[1]
1876 ifndef_linenum = linenum
1877 if not define and linesplit[0] == '#define':
1878 define = linesplit[1]
1879 # find the last occurrence of #endif, save entire line
1880 if line.startswith('#endif'):
1881 endif = line
1882 endif_linenum = linenum
1883
avakulenko@google.com554223d2014-12-04 22:00:20 +00001884 if not ifndef or not define or ifndef != define:
erg@google.com4e00b9a2009-01-12 23:05:11 +00001885 error(filename, 0, 'build/header_guard', 5,
1886 'No #ifndef header guard found, suggested CPP variable is: %s' %
1887 cppvar)
1888 return
1889
1890 # The guard should be PATH_FILE_H_, but we also allow PATH_FILE_H__
1891 # for backward compatibility.
erg+personal@google.com05189642010-04-30 20:43:03 +00001892 if ifndef != cppvar:
erg@google.com4e00b9a2009-01-12 23:05:11 +00001893 error_level = 0
1894 if ifndef != cppvar + '_':
1895 error_level = 5
1896
avakulenko@google.com554223d2014-12-04 22:00:20 +00001897 ParseNolintSuppressions(filename, raw_lines[ifndef_linenum], ifndef_linenum,
erg+personal@google.com05189642010-04-30 20:43:03 +00001898 error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001899 error(filename, ifndef_linenum, 'build/header_guard', error_level,
1900 '#ifndef header guard has wrong style, please use: %s' % cppvar)
1901
avakulenko@google.com554223d2014-12-04 22:00:20 +00001902 # Check for "//" comments on endif line.
1903 ParseNolintSuppressions(filename, raw_lines[endif_linenum], endif_linenum,
1904 error)
1905 match = Match(r'#endif\s*//\s*' + cppvar + r'(_)?\b', endif)
1906 if match:
1907 if match.group(1) == '_':
1908 # Issue low severity warning for deprecated double trailing underscore
1909 error(filename, endif_linenum, 'build/header_guard', 0,
1910 '#endif line should be "#endif // %s"' % cppvar)
erg@google.comdc289702012-01-26 20:30:03 +00001911 return
1912
avakulenko@google.com554223d2014-12-04 22:00:20 +00001913 # Didn't find the corresponding "//" comment. If this file does not
1914 # contain any "//" comments at all, it could be that the compiler
1915 # only wants "/**/" comments, look for those instead.
1916 no_single_line_comments = True
1917 for i in xrange(1, len(raw_lines) - 1):
1918 line = raw_lines[i]
1919 if Match(r'^(?:(?:\'(?:\.|[^\'])*\')|(?:"(?:\.|[^"])*")|[^\'"])*//', line):
1920 no_single_line_comments = False
1921 break
erg@google.com4e00b9a2009-01-12 23:05:11 +00001922
avakulenko@google.com554223d2014-12-04 22:00:20 +00001923 if no_single_line_comments:
1924 match = Match(r'#endif\s*/\*\s*' + cppvar + r'(_)?\s*\*/', endif)
1925 if match:
1926 if match.group(1) == '_':
1927 # Low severity warning for double trailing underscore
1928 error(filename, endif_linenum, 'build/header_guard', 0,
1929 '#endif line should be "#endif /* %s */"' % cppvar)
1930 return
1931
1932 # Didn't find anything
1933 error(filename, endif_linenum, 'build/header_guard', 5,
1934 '#endif line should be "#endif // %s"' % cppvar)
1935
1936
1937def CheckHeaderFileIncluded(filename, include_state, error):
1938 """Logs an error if a .cc file does not include its header."""
1939
1940 # Do not check test files
Alex Vakulenko01e47232016-05-06 13:54:15 -07001941 fileinfo = FileInfo(filename)
1942 if Search(_TEST_FILE_SUFFIX, fileinfo.BaseName()):
avakulenko@google.com554223d2014-12-04 22:00:20 +00001943 return
1944
Alex Vakulenko01e47232016-05-06 13:54:15 -07001945 headerfile = filename[0:len(filename) - len(fileinfo.Extension())] + '.h'
avakulenko@google.com554223d2014-12-04 22:00:20 +00001946 if not os.path.exists(headerfile):
1947 return
1948 headername = FileInfo(headerfile).RepositoryName()
1949 first_include = 0
1950 for section_list in include_state.include_list:
1951 for f in section_list:
1952 if headername in f[0] or f[0] in headername:
1953 return
1954 if not first_include:
1955 first_include = f[1]
1956
1957 error(filename, first_include, 'build/include', 5,
1958 '%s should include its header file %s' % (fileinfo.RepositoryName(),
1959 headername))
erg@google.com4e00b9a2009-01-12 23:05:11 +00001960
1961
erg@google.com2aa59982013-10-28 19:09:25 +00001962def CheckForBadCharacters(filename, lines, error):
1963 """Logs an error for each line containing bad characters.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001964
erg@google.com2aa59982013-10-28 19:09:25 +00001965 Two kinds of bad characters:
1966
1967 1. Unicode replacement characters: These indicate that either the file
1968 contained invalid UTF-8 (likely) or Unicode replacement characters (which
1969 it shouldn't). Note that it's possible for this to throw off line
1970 numbering if the invalid UTF-8 occurred adjacent to a newline.
1971
1972 2. NUL bytes. These are problematic for some tools.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001973
1974 Args:
1975 filename: The name of the current file.
1976 lines: An array of strings, each representing a line of the file.
1977 error: The function to call with any errors found.
1978 """
1979 for linenum, line in enumerate(lines):
1980 if u'\ufffd' in line:
1981 error(filename, linenum, 'readability/utf8', 5,
1982 'Line contains invalid UTF-8 (or Unicode replacement character).')
erg@google.com2aa59982013-10-28 19:09:25 +00001983 if '\0' in line:
1984 error(filename, linenum, 'readability/nul', 5, 'Line contains NUL byte.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00001985
1986
1987def CheckForNewlineAtEOF(filename, lines, error):
1988 """Logs an error if there is no newline char at the end of the file.
1989
1990 Args:
1991 filename: The name of the current file.
1992 lines: An array of strings, each representing a line of the file.
1993 error: The function to call with any errors found.
1994 """
1995
1996 # The array lines() was created by adding two newlines to the
1997 # original file (go figure), then splitting on \n.
1998 # To verify that the file ends in \n, we just have to make sure the
1999 # last-but-two element of lines() exists and is empty.
2000 if len(lines) < 3 or lines[-2]:
2001 error(filename, len(lines) - 2, 'whitespace/ending_newline', 5,
2002 'Could not find a newline character at the end of the file.')
2003
2004
2005def CheckForMultilineCommentsAndStrings(filename, clean_lines, linenum, error):
2006 """Logs an error if we see /* ... */ or "..." that extend past one line.
2007
2008 /* ... */ comments are legit inside macros, for one line.
2009 Otherwise, we prefer // comments, so it's ok to warn about the
2010 other. Likewise, it's ok for strings to extend across multiple
2011 lines, as long as a line continuation character (backslash)
2012 terminates each line. Although not currently prohibited by the C++
2013 style guide, it's ugly and unnecessary. We don't do well with either
2014 in this lint program, so we warn about both.
2015
2016 Args:
2017 filename: The name of the current file.
2018 clean_lines: A CleansedLines instance containing the file.
2019 linenum: The number of the line to check.
2020 error: The function to call with any errors found.
2021 """
2022 line = clean_lines.elided[linenum]
2023
2024 # Remove all \\ (escaped backslashes) from the line. They are OK, and the
2025 # second (escaped) slash may trigger later \" detection erroneously.
2026 line = line.replace('\\\\', '')
2027
2028 if line.count('/*') > line.count('*/'):
2029 error(filename, linenum, 'readability/multiline_comment', 5,
2030 'Complex multi-line /*...*/-style comment found. '
2031 'Lint may give bogus warnings. '
2032 'Consider replacing these with //-style comments, '
2033 'with #if 0...#endif, '
2034 'or with more clearly structured multi-line comments.')
2035
2036 if (line.count('"') - line.count('\\"')) % 2:
2037 error(filename, linenum, 'readability/multiline_string', 5,
2038 'Multi-line string ("...") found. This lint script doesn\'t '
erg@google.com2aa59982013-10-28 19:09:25 +00002039 'do well with such strings, and may give bogus warnings. '
2040 'Use C++11 raw strings or concatenation instead.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00002041
2042
avakulenko@google.com02af6282014-06-04 18:53:25 +00002043# (non-threadsafe name, thread-safe alternative, validation pattern)
2044#
2045# The validation pattern is used to eliminate false positives such as:
2046# _rand(); // false positive due to substring match.
2047# ->rand(); // some member function rand().
2048# ACMRandom rand(seed); // some variable named rand.
2049# ISAACRandom rand(); // another variable named rand.
2050#
2051# Basically we require the return value of these functions to be used
2052# in some expression context on the same line by matching on some
2053# operator before the function name. This eliminates constructors and
2054# member function calls.
2055_UNSAFE_FUNC_PREFIX = r'(?:[-+*/=%^&|(<]\s*|>\s+)'
2056_THREADING_LIST = (
2057 ('asctime(', 'asctime_r(', _UNSAFE_FUNC_PREFIX + r'asctime\([^)]+\)'),
2058 ('ctime(', 'ctime_r(', _UNSAFE_FUNC_PREFIX + r'ctime\([^)]+\)'),
2059 ('getgrgid(', 'getgrgid_r(', _UNSAFE_FUNC_PREFIX + r'getgrgid\([^)]+\)'),
2060 ('getgrnam(', 'getgrnam_r(', _UNSAFE_FUNC_PREFIX + r'getgrnam\([^)]+\)'),
2061 ('getlogin(', 'getlogin_r(', _UNSAFE_FUNC_PREFIX + r'getlogin\(\)'),
2062 ('getpwnam(', 'getpwnam_r(', _UNSAFE_FUNC_PREFIX + r'getpwnam\([^)]+\)'),
2063 ('getpwuid(', 'getpwuid_r(', _UNSAFE_FUNC_PREFIX + r'getpwuid\([^)]+\)'),
2064 ('gmtime(', 'gmtime_r(', _UNSAFE_FUNC_PREFIX + r'gmtime\([^)]+\)'),
2065 ('localtime(', 'localtime_r(', _UNSAFE_FUNC_PREFIX + r'localtime\([^)]+\)'),
2066 ('rand(', 'rand_r(', _UNSAFE_FUNC_PREFIX + r'rand\(\)'),
2067 ('strtok(', 'strtok_r(',
2068 _UNSAFE_FUNC_PREFIX + r'strtok\([^)]+\)'),
2069 ('ttyname(', 'ttyname_r(', _UNSAFE_FUNC_PREFIX + r'ttyname\([^)]+\)'),
erg@google.com4e00b9a2009-01-12 23:05:11 +00002070 )
2071
2072
2073def CheckPosixThreading(filename, clean_lines, linenum, error):
2074 """Checks for calls to thread-unsafe functions.
2075
2076 Much code has been originally written without consideration of
2077 multi-threading. Also, engineers are relying on their old experience;
2078 they have learned posix before threading extensions were added. These
2079 tests guide the engineers to use thread-safe functions (when using
2080 posix directly).
2081
2082 Args:
2083 filename: The name of the current file.
2084 clean_lines: A CleansedLines instance containing the file.
2085 linenum: The number of the line to check.
2086 error: The function to call with any errors found.
2087 """
2088 line = clean_lines.elided[linenum]
avakulenko@google.com02af6282014-06-04 18:53:25 +00002089 for single_thread_func, multithread_safe_func, pattern in _THREADING_LIST:
2090 # Additional pattern matching check to confirm that this is the
2091 # function we are looking for
2092 if Search(pattern, line):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002093 error(filename, linenum, 'runtime/threadsafe_fn', 2,
avakulenko@google.com02af6282014-06-04 18:53:25 +00002094 'Consider using ' + multithread_safe_func +
2095 '...) instead of ' + single_thread_func +
erg@google.com4e00b9a2009-01-12 23:05:11 +00002096 '...) for improved thread safety.')
2097
2098
erg@google.com2aa59982013-10-28 19:09:25 +00002099def CheckVlogArguments(filename, clean_lines, linenum, error):
2100 """Checks that VLOG() is only used for defining a logging level.
2101
2102 For example, VLOG(2) is correct. VLOG(INFO), VLOG(WARNING), VLOG(ERROR), and
2103 VLOG(FATAL) are not.
2104
2105 Args:
2106 filename: The name of the current file.
2107 clean_lines: A CleansedLines instance containing the file.
2108 linenum: The number of the line to check.
2109 error: The function to call with any errors found.
2110 """
2111 line = clean_lines.elided[linenum]
2112 if Search(r'\bVLOG\((INFO|ERROR|WARNING|DFATAL|FATAL)\)', line):
2113 error(filename, linenum, 'runtime/vlog', 5,
2114 'VLOG() should be used with numeric verbosity level. '
2115 'Use LOG() if you want symbolic severity levels.')
2116
erg@google.coma868d2d2009-10-09 21:18:45 +00002117# Matches invalid increment: *count++, which moves pointer instead of
erg@google.com36649102009-03-25 21:18:36 +00002118# incrementing a value.
erg@google.coma868d2d2009-10-09 21:18:45 +00002119_RE_PATTERN_INVALID_INCREMENT = re.compile(
erg@google.com36649102009-03-25 21:18:36 +00002120 r'^\s*\*\w+(\+\+|--);')
2121
2122
2123def CheckInvalidIncrement(filename, clean_lines, linenum, error):
erg@google.coma868d2d2009-10-09 21:18:45 +00002124 """Checks for invalid increment *count++.
erg@google.com36649102009-03-25 21:18:36 +00002125
2126 For example following function:
2127 void increment_counter(int* count) {
2128 *count++;
2129 }
2130 is invalid, because it effectively does count++, moving pointer, and should
2131 be replaced with ++*count, (*count)++ or *count += 1.
2132
2133 Args:
2134 filename: The name of the current file.
2135 clean_lines: A CleansedLines instance containing the file.
2136 linenum: The number of the line to check.
2137 error: The function to call with any errors found.
2138 """
2139 line = clean_lines.elided[linenum]
erg@google.coma868d2d2009-10-09 21:18:45 +00002140 if _RE_PATTERN_INVALID_INCREMENT.match(line):
erg@google.com36649102009-03-25 21:18:36 +00002141 error(filename, linenum, 'runtime/invalid_increment', 5,
2142 'Changing pointer instead of value (or unused value of operator*).')
2143
2144
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002145def IsMacroDefinition(clean_lines, linenum):
2146 if Search(r'^#define', clean_lines[linenum]):
2147 return True
2148
2149 if linenum > 0 and Search(r'\\$', clean_lines[linenum - 1]):
2150 return True
2151
2152 return False
2153
2154
2155def IsForwardClassDeclaration(clean_lines, linenum):
2156 return Match(r'^\s*(\btemplate\b)*.*class\s+\w+;\s*$', clean_lines[linenum])
2157
2158
erg@google.comd350fe52013-01-14 17:51:48 +00002159class _BlockInfo(object):
2160 """Stores information about a generic block of code."""
2161
Alex Vakulenko01e47232016-05-06 13:54:15 -07002162 def __init__(self, linenum, seen_open_brace):
2163 self.starting_linenum = linenum
erg@google.comd350fe52013-01-14 17:51:48 +00002164 self.seen_open_brace = seen_open_brace
2165 self.open_parentheses = 0
2166 self.inline_asm = _NO_ASM
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002167 self.check_namespace_indentation = False
erg@google.comd350fe52013-01-14 17:51:48 +00002168
2169 def CheckBegin(self, filename, clean_lines, linenum, error):
2170 """Run checks that applies to text up to the opening brace.
2171
2172 This is mostly for checking the text after the class identifier
2173 and the "{", usually where the base class is specified. For other
2174 blocks, there isn't much to check, so we always pass.
2175
2176 Args:
2177 filename: The name of the current file.
2178 clean_lines: A CleansedLines instance containing the file.
2179 linenum: The number of the line to check.
2180 error: The function to call with any errors found.
2181 """
2182 pass
2183
2184 def CheckEnd(self, filename, clean_lines, linenum, error):
2185 """Run checks that applies to text after the closing brace.
2186
2187 This is mostly used for checking end of namespace comments.
2188
2189 Args:
2190 filename: The name of the current file.
2191 clean_lines: A CleansedLines instance containing the file.
2192 linenum: The number of the line to check.
2193 error: The function to call with any errors found.
2194 """
2195 pass
2196
avakulenko@google.com02af6282014-06-04 18:53:25 +00002197 def IsBlockInfo(self):
2198 """Returns true if this block is a _BlockInfo.
2199
2200 This is convenient for verifying that an object is an instance of
2201 a _BlockInfo, but not an instance of any of the derived classes.
2202
2203 Returns:
2204 True for this class, False for derived classes.
2205 """
2206 return self.__class__ == _BlockInfo
2207
2208
2209class _ExternCInfo(_BlockInfo):
2210 """Stores information about an 'extern "C"' block."""
2211
Alex Vakulenko01e47232016-05-06 13:54:15 -07002212 def __init__(self, linenum):
2213 _BlockInfo.__init__(self, linenum, True)
avakulenko@google.com02af6282014-06-04 18:53:25 +00002214
erg@google.comd350fe52013-01-14 17:51:48 +00002215
2216class _ClassInfo(_BlockInfo):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002217 """Stores information about a class."""
2218
erg@google.comd350fe52013-01-14 17:51:48 +00002219 def __init__(self, name, class_or_struct, clean_lines, linenum):
Alex Vakulenko01e47232016-05-06 13:54:15 -07002220 _BlockInfo.__init__(self, linenum, False)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002221 self.name = name
erg@google.com4e00b9a2009-01-12 23:05:11 +00002222 self.is_derived = False
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002223 self.check_namespace_indentation = True
erg@google.comd350fe52013-01-14 17:51:48 +00002224 if class_or_struct == 'struct':
2225 self.access = 'public'
erg@google.comfd5da632013-10-25 17:39:45 +00002226 self.is_struct = True
erg@google.comd350fe52013-01-14 17:51:48 +00002227 else:
2228 self.access = 'private'
erg@google.comfd5da632013-10-25 17:39:45 +00002229 self.is_struct = False
2230
2231 # Remember initial indentation level for this class. Using raw_lines here
erg@google.comc6671232013-10-25 21:44:03 +00002232 # instead of elided to account for leading comments.
avakulenko@google.com02af6282014-06-04 18:53:25 +00002233 self.class_indent = GetIndentLevel(clean_lines.raw_lines[linenum])
erg@google.com4e00b9a2009-01-12 23:05:11 +00002234
erg@google.com8a95ecc2011-09-08 00:45:54 +00002235 # Try to find the end of the class. This will be confused by things like:
2236 # class A {
2237 # } *x = { ...
2238 #
2239 # But it's still good enough for CheckSectionSpacing.
2240 self.last_line = 0
2241 depth = 0
2242 for i in range(linenum, clean_lines.NumLines()):
erg@google.comd350fe52013-01-14 17:51:48 +00002243 line = clean_lines.elided[i]
erg@google.com8a95ecc2011-09-08 00:45:54 +00002244 depth += line.count('{') - line.count('}')
2245 if not depth:
2246 self.last_line = i
2247 break
2248
erg@google.comd350fe52013-01-14 17:51:48 +00002249 def CheckBegin(self, filename, clean_lines, linenum, error):
2250 # Look for a bare ':'
2251 if Search('(^|[^:]):($|[^:])', clean_lines.elided[linenum]):
2252 self.is_derived = True
erg@google.com4e00b9a2009-01-12 23:05:11 +00002253
erg@google.comfd5da632013-10-25 17:39:45 +00002254 def CheckEnd(self, filename, clean_lines, linenum, error):
avakulenko@google.com554223d2014-12-04 22:00:20 +00002255 # If there is a DISALLOW macro, it should appear near the end of
2256 # the class.
2257 seen_last_thing_in_class = False
2258 for i in xrange(linenum - 1, self.starting_linenum, -1):
2259 match = Search(
2260 r'\b(DISALLOW_COPY_AND_ASSIGN|DISALLOW_IMPLICIT_CONSTRUCTORS)\(' +
2261 self.name + r'\)',
2262 clean_lines.elided[i])
2263 if match:
2264 if seen_last_thing_in_class:
2265 error(filename, i, 'readability/constructors', 3,
2266 match.group(1) + ' should be the last thing in the class')
2267 break
2268
2269 if not Match(r'^\s*$', clean_lines.elided[i]):
2270 seen_last_thing_in_class = True
2271
erg@google.comfd5da632013-10-25 17:39:45 +00002272 # Check that closing brace is aligned with beginning of the class.
2273 # Only do this if the closing brace is indented by only whitespaces.
2274 # This means we will not check single-line class definitions.
2275 indent = Match(r'^( *)\}', clean_lines.elided[linenum])
2276 if indent and len(indent.group(1)) != self.class_indent:
2277 if self.is_struct:
2278 parent = 'struct ' + self.name
2279 else:
2280 parent = 'class ' + self.name
2281 error(filename, linenum, 'whitespace/indent', 3,
2282 'Closing brace should be aligned with beginning of %s' % parent)
2283
erg@google.com4e00b9a2009-01-12 23:05:11 +00002284
erg@google.comd350fe52013-01-14 17:51:48 +00002285class _NamespaceInfo(_BlockInfo):
2286 """Stores information about a namespace."""
2287
2288 def __init__(self, name, linenum):
Alex Vakulenko01e47232016-05-06 13:54:15 -07002289 _BlockInfo.__init__(self, linenum, False)
erg@google.comd350fe52013-01-14 17:51:48 +00002290 self.name = name or ''
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002291 self.check_namespace_indentation = True
erg@google.comd350fe52013-01-14 17:51:48 +00002292
2293 def CheckEnd(self, filename, clean_lines, linenum, error):
2294 """Check end of namespace comments."""
2295 line = clean_lines.raw_lines[linenum]
2296
2297 # Check how many lines is enclosed in this namespace. Don't issue
2298 # warning for missing namespace comments if there aren't enough
2299 # lines. However, do apply checks if there is already an end of
2300 # namespace comment and it's incorrect.
2301 #
2302 # TODO(unknown): We always want to check end of namespace comments
2303 # if a namespace is large, but sometimes we also want to apply the
2304 # check if a short namespace contained nontrivial things (something
2305 # other than forward declarations). There is currently no logic on
2306 # deciding what these nontrivial things are, so this check is
2307 # triggered by namespace size only, which works most of the time.
2308 if (linenum - self.starting_linenum < 10
Alex Vakulenko01e47232016-05-06 13:54:15 -07002309 and not Match(r'^\s*};*\s*(//|/\*).*\bnamespace\b', line)):
erg@google.comd350fe52013-01-14 17:51:48 +00002310 return
2311
2312 # Look for matching comment at end of namespace.
2313 #
2314 # Note that we accept C style "/* */" comments for terminating
2315 # namespaces, so that code that terminate namespaces inside
erg@google.comc6671232013-10-25 21:44:03 +00002316 # preprocessor macros can be cpplint clean.
erg@google.comd350fe52013-01-14 17:51:48 +00002317 #
2318 # We also accept stuff like "// end of namespace <name>." with the
2319 # period at the end.
2320 #
2321 # Besides these, we don't accept anything else, otherwise we might
2322 # get false negatives when existing comment is a substring of the
erg@google.comc6671232013-10-25 21:44:03 +00002323 # expected namespace.
erg@google.comd350fe52013-01-14 17:51:48 +00002324 if self.name:
2325 # Named namespace
Alex Vakulenko01e47232016-05-06 13:54:15 -07002326 if not Match((r'^\s*};*\s*(//|/\*).*\bnamespace\s+' +
2327 re.escape(self.name) + r'[\*/\.\\\s]*$'),
erg@google.comd350fe52013-01-14 17:51:48 +00002328 line):
2329 error(filename, linenum, 'readability/namespace', 5,
2330 'Namespace should be terminated with "// namespace %s"' %
2331 self.name)
2332 else:
2333 # Anonymous namespace
Alex Vakulenko01e47232016-05-06 13:54:15 -07002334 if not Match(r'^\s*};*\s*(//|/\*).*\bnamespace[\*/\.\\\s]*$', line):
avakulenko@google.com02af6282014-06-04 18:53:25 +00002335 # If "// namespace anonymous" or "// anonymous namespace (more text)",
2336 # mention "// anonymous namespace" as an acceptable form
Alex Vakulenko01e47232016-05-06 13:54:15 -07002337 if Match(r'^\s*}.*\b(namespace anonymous|anonymous namespace)\b', line):
avakulenko@google.com02af6282014-06-04 18:53:25 +00002338 error(filename, linenum, 'readability/namespace', 5,
2339 'Anonymous namespace should be terminated with "// namespace"'
2340 ' or "// anonymous namespace"')
2341 else:
2342 error(filename, linenum, 'readability/namespace', 5,
2343 'Anonymous namespace should be terminated with "// namespace"')
erg@google.comd350fe52013-01-14 17:51:48 +00002344
2345
2346class _PreprocessorInfo(object):
2347 """Stores checkpoints of nesting stacks when #if/#else is seen."""
2348
2349 def __init__(self, stack_before_if):
2350 # The entire nesting stack before #if
2351 self.stack_before_if = stack_before_if
2352
2353 # The entire nesting stack up to #else
2354 self.stack_before_else = []
2355
2356 # Whether we have already seen #else or #elif
2357 self.seen_else = False
2358
2359
avakulenko@google.com02af6282014-06-04 18:53:25 +00002360class NestingState(object):
erg@google.comd350fe52013-01-14 17:51:48 +00002361 """Holds states related to parsing braces."""
erg@google.com4e00b9a2009-01-12 23:05:11 +00002362
2363 def __init__(self):
erg@google.comd350fe52013-01-14 17:51:48 +00002364 # Stack for tracking all braces. An object is pushed whenever we
2365 # see a "{", and popped when we see a "}". Only 3 types of
2366 # objects are possible:
2367 # - _ClassInfo: a class or struct.
2368 # - _NamespaceInfo: a namespace.
2369 # - _BlockInfo: some other type of block.
2370 self.stack = []
erg@google.com4e00b9a2009-01-12 23:05:11 +00002371
avakulenko@google.com02af6282014-06-04 18:53:25 +00002372 # Top of the previous stack before each Update().
2373 #
2374 # Because the nesting_stack is updated at the end of each line, we
2375 # had to do some convoluted checks to find out what is the current
2376 # scope at the beginning of the line. This check is simplified by
2377 # saving the previous top of nesting stack.
2378 #
2379 # We could save the full stack, but we only need the top. Copying
2380 # the full nesting stack would slow down cpplint by ~10%.
2381 self.previous_stack_top = []
2382
erg@google.comd350fe52013-01-14 17:51:48 +00002383 # Stack of _PreprocessorInfo objects.
2384 self.pp_stack = []
2385
2386 def SeenOpenBrace(self):
2387 """Check if we have seen the opening brace for the innermost block.
2388
2389 Returns:
2390 True if we have seen the opening brace, False if the innermost
2391 block is still expecting an opening brace.
2392 """
2393 return (not self.stack) or self.stack[-1].seen_open_brace
2394
2395 def InNamespaceBody(self):
2396 """Check if we are currently one level inside a namespace body.
2397
2398 Returns:
2399 True if top of the stack is a namespace block, False otherwise.
2400 """
2401 return self.stack and isinstance(self.stack[-1], _NamespaceInfo)
2402
avakulenko@google.com02af6282014-06-04 18:53:25 +00002403 def InExternC(self):
2404 """Check if we are currently one level inside an 'extern "C"' block.
2405
2406 Returns:
2407 True if top of the stack is an extern block, False otherwise.
2408 """
2409 return self.stack and isinstance(self.stack[-1], _ExternCInfo)
2410
2411 def InClassDeclaration(self):
2412 """Check if we are currently one level inside a class or struct declaration.
2413
2414 Returns:
2415 True if top of the stack is a class/struct, False otherwise.
2416 """
2417 return self.stack and isinstance(self.stack[-1], _ClassInfo)
2418
2419 def InAsmBlock(self):
2420 """Check if we are currently one level inside an inline ASM block.
2421
2422 Returns:
2423 True if the top of the stack is a block containing inline ASM.
2424 """
2425 return self.stack and self.stack[-1].inline_asm != _NO_ASM
2426
2427 def InTemplateArgumentList(self, clean_lines, linenum, pos):
2428 """Check if current position is inside template argument list.
2429
2430 Args:
2431 clean_lines: A CleansedLines instance containing the file.
2432 linenum: The number of the line to check.
2433 pos: position just after the suspected template argument.
2434 Returns:
2435 True if (linenum, pos) is inside template arguments.
2436 """
2437 while linenum < clean_lines.NumLines():
2438 # Find the earliest character that might indicate a template argument
2439 line = clean_lines.elided[linenum]
2440 match = Match(r'^[^{};=\[\]\.<>]*(.)', line[pos:])
2441 if not match:
2442 linenum += 1
2443 pos = 0
2444 continue
2445 token = match.group(1)
2446 pos += len(match.group(0))
2447
2448 # These things do not look like template argument list:
2449 # class Suspect {
2450 # class Suspect x; }
2451 if token in ('{', '}', ';'): return False
2452
2453 # These things look like template argument list:
2454 # template <class Suspect>
2455 # template <class Suspect = default_value>
2456 # template <class Suspect[]>
2457 # template <class Suspect...>
2458 if token in ('>', '=', '[', ']', '.'): return True
2459
2460 # Check if token is an unmatched '<'.
2461 # If not, move on to the next character.
2462 if token != '<':
2463 pos += 1
2464 if pos >= len(line):
2465 linenum += 1
2466 pos = 0
2467 continue
2468
2469 # We can't be sure if we just find a single '<', and need to
2470 # find the matching '>'.
2471 (_, end_line, end_pos) = CloseExpression(clean_lines, linenum, pos - 1)
2472 if end_pos < 0:
2473 # Not sure if template argument list or syntax error in file
2474 return False
2475 linenum = end_line
2476 pos = end_pos
2477 return False
2478
erg@google.comd350fe52013-01-14 17:51:48 +00002479 def UpdatePreprocessor(self, line):
2480 """Update preprocessor stack.
2481
2482 We need to handle preprocessors due to classes like this:
2483 #ifdef SWIG
2484 struct ResultDetailsPageElementExtensionPoint {
2485 #else
2486 struct ResultDetailsPageElementExtensionPoint : public Extension {
2487 #endif
erg@google.comd350fe52013-01-14 17:51:48 +00002488
2489 We make the following assumptions (good enough for most files):
2490 - Preprocessor condition evaluates to true from #if up to first
2491 #else/#elif/#endif.
2492
2493 - Preprocessor condition evaluates to false from #else/#elif up
2494 to #endif. We still perform lint checks on these lines, but
2495 these do not affect nesting stack.
2496
2497 Args:
2498 line: current line to check.
2499 """
2500 if Match(r'^\s*#\s*(if|ifdef|ifndef)\b', line):
2501 # Beginning of #if block, save the nesting stack here. The saved
2502 # stack will allow us to restore the parsing state in the #else case.
2503 self.pp_stack.append(_PreprocessorInfo(copy.deepcopy(self.stack)))
2504 elif Match(r'^\s*#\s*(else|elif)\b', line):
2505 # Beginning of #else block
2506 if self.pp_stack:
2507 if not self.pp_stack[-1].seen_else:
2508 # This is the first #else or #elif block. Remember the
2509 # whole nesting stack up to this point. This is what we
2510 # keep after the #endif.
2511 self.pp_stack[-1].seen_else = True
2512 self.pp_stack[-1].stack_before_else = copy.deepcopy(self.stack)
2513
2514 # Restore the stack to how it was before the #if
2515 self.stack = copy.deepcopy(self.pp_stack[-1].stack_before_if)
2516 else:
2517 # TODO(unknown): unexpected #else, issue warning?
2518 pass
2519 elif Match(r'^\s*#\s*endif\b', line):
2520 # End of #if or #else blocks.
2521 if self.pp_stack:
2522 # If we saw an #else, we will need to restore the nesting
2523 # stack to its former state before the #else, otherwise we
2524 # will just continue from where we left off.
2525 if self.pp_stack[-1].seen_else:
2526 # Here we can just use a shallow copy since we are the last
2527 # reference to it.
2528 self.stack = self.pp_stack[-1].stack_before_else
2529 # Drop the corresponding #if
2530 self.pp_stack.pop()
2531 else:
2532 # TODO(unknown): unexpected #endif, issue warning?
2533 pass
2534
avakulenko@google.com02af6282014-06-04 18:53:25 +00002535 # TODO(unknown): Update() is too long, but we will refactor later.
erg@google.comd350fe52013-01-14 17:51:48 +00002536 def Update(self, filename, clean_lines, linenum, error):
2537 """Update nesting state with current line.
2538
2539 Args:
2540 filename: The name of the current file.
2541 clean_lines: A CleansedLines instance containing the file.
2542 linenum: The number of the line to check.
2543 error: The function to call with any errors found.
2544 """
2545 line = clean_lines.elided[linenum]
2546
avakulenko@google.com02af6282014-06-04 18:53:25 +00002547 # Remember top of the previous nesting stack.
2548 #
2549 # The stack is always pushed/popped and not modified in place, so
2550 # we can just do a shallow copy instead of copy.deepcopy. Using
2551 # deepcopy would slow down cpplint by ~28%.
2552 if self.stack:
2553 self.previous_stack_top = self.stack[-1]
2554 else:
2555 self.previous_stack_top = None
2556
2557 # Update pp_stack
erg@google.comd350fe52013-01-14 17:51:48 +00002558 self.UpdatePreprocessor(line)
2559
2560 # Count parentheses. This is to avoid adding struct arguments to
2561 # the nesting stack.
2562 if self.stack:
2563 inner_block = self.stack[-1]
2564 depth_change = line.count('(') - line.count(')')
2565 inner_block.open_parentheses += depth_change
2566
2567 # Also check if we are starting or ending an inline assembly block.
2568 if inner_block.inline_asm in (_NO_ASM, _END_ASM):
2569 if (depth_change != 0 and
2570 inner_block.open_parentheses == 1 and
2571 _MATCH_ASM.match(line)):
2572 # Enter assembly block
2573 inner_block.inline_asm = _INSIDE_ASM
2574 else:
2575 # Not entering assembly block. If previous line was _END_ASM,
2576 # we will now shift to _NO_ASM state.
2577 inner_block.inline_asm = _NO_ASM
2578 elif (inner_block.inline_asm == _INSIDE_ASM and
2579 inner_block.open_parentheses == 0):
2580 # Exit assembly block
2581 inner_block.inline_asm = _END_ASM
2582
2583 # Consume namespace declaration at the beginning of the line. Do
2584 # this in a loop so that we catch same line declarations like this:
2585 # namespace proto2 { namespace bridge { class MessageSet; } }
2586 while True:
2587 # Match start of namespace. The "\b\s*" below catches namespace
2588 # declarations even if it weren't followed by a whitespace, this
2589 # is so that we don't confuse our namespace checker. The
2590 # missing spaces will be flagged by CheckSpacing.
2591 namespace_decl_match = Match(r'^\s*namespace\b\s*([:\w]+)?(.*)$', line)
2592 if not namespace_decl_match:
2593 break
2594
2595 new_namespace = _NamespaceInfo(namespace_decl_match.group(1), linenum)
2596 self.stack.append(new_namespace)
2597
2598 line = namespace_decl_match.group(2)
2599 if line.find('{') != -1:
2600 new_namespace.seen_open_brace = True
2601 line = line[line.find('{') + 1:]
2602
2603 # Look for a class declaration in whatever is left of the line
2604 # after parsing namespaces. The regexp accounts for decorated classes
2605 # such as in:
2606 # class LOCKABLE API Object {
2607 # };
erg@google.comd350fe52013-01-14 17:51:48 +00002608 class_decl_match = Match(
avakulenko@google.com02af6282014-06-04 18:53:25 +00002609 r'^(\s*(?:template\s*<[\w\s<>,:]*>\s*)?'
2610 r'(class|struct)\s+(?:[A-Z_]+\s+)*(\w+(?:::\w+)*))'
2611 r'(.*)$', line)
erg@google.comd350fe52013-01-14 17:51:48 +00002612 if (class_decl_match and
2613 (not self.stack or self.stack[-1].open_parentheses == 0)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00002614 # We do not want to accept classes that are actually template arguments:
2615 # template <class Ignore1,
2616 # class Ignore2 = Default<Args>,
2617 # template <Args> class Ignore3>
2618 # void Function() {};
2619 #
2620 # To avoid template argument cases, we scan forward and look for
2621 # an unmatched '>'. If we see one, assume we are inside a
2622 # template argument list.
2623 end_declaration = len(class_decl_match.group(1))
2624 if not self.InTemplateArgumentList(clean_lines, linenum, end_declaration):
2625 self.stack.append(_ClassInfo(
2626 class_decl_match.group(3), class_decl_match.group(2),
2627 clean_lines, linenum))
2628 line = class_decl_match.group(4)
erg@google.comd350fe52013-01-14 17:51:48 +00002629
2630 # If we have not yet seen the opening brace for the innermost block,
2631 # run checks here.
2632 if not self.SeenOpenBrace():
2633 self.stack[-1].CheckBegin(filename, clean_lines, linenum, error)
2634
2635 # Update access control if we are inside a class/struct
2636 if self.stack and isinstance(self.stack[-1], _ClassInfo):
erg@google.comfd5da632013-10-25 17:39:45 +00002637 classinfo = self.stack[-1]
2638 access_match = Match(
2639 r'^(.*)\b(public|private|protected|signals)(\s+(?:slots\s*)?)?'
2640 r':(?:[^:]|$)',
2641 line)
erg@google.comd350fe52013-01-14 17:51:48 +00002642 if access_match:
erg@google.comfd5da632013-10-25 17:39:45 +00002643 classinfo.access = access_match.group(2)
2644
2645 # Check that access keywords are indented +1 space. Skip this
erg@google.comc6671232013-10-25 21:44:03 +00002646 # check if the keywords are not preceded by whitespaces.
erg@google.comfd5da632013-10-25 17:39:45 +00002647 indent = access_match.group(1)
2648 if (len(indent) != classinfo.class_indent + 1 and
2649 Match(r'^\s*$', indent)):
2650 if classinfo.is_struct:
2651 parent = 'struct ' + classinfo.name
2652 else:
2653 parent = 'class ' + classinfo.name
2654 slots = ''
2655 if access_match.group(3):
2656 slots = access_match.group(3)
2657 error(filename, linenum, 'whitespace/indent', 3,
2658 '%s%s: should be indented +1 space inside %s' % (
2659 access_match.group(2), slots, parent))
erg@google.comd350fe52013-01-14 17:51:48 +00002660
2661 # Consume braces or semicolons from what's left of the line
2662 while True:
2663 # Match first brace, semicolon, or closed parenthesis.
2664 matched = Match(r'^[^{;)}]*([{;)}])(.*)$', line)
2665 if not matched:
2666 break
2667
2668 token = matched.group(1)
2669 if token == '{':
2670 # If namespace or class hasn't seen a opening brace yet, mark
2671 # namespace/class head as complete. Push a new block onto the
2672 # stack otherwise.
2673 if not self.SeenOpenBrace():
2674 self.stack[-1].seen_open_brace = True
avakulenko@google.com02af6282014-06-04 18:53:25 +00002675 elif Match(r'^extern\s*"[^"]*"\s*\{', line):
Alex Vakulenko01e47232016-05-06 13:54:15 -07002676 self.stack.append(_ExternCInfo(linenum))
erg@google.comd350fe52013-01-14 17:51:48 +00002677 else:
Alex Vakulenko01e47232016-05-06 13:54:15 -07002678 self.stack.append(_BlockInfo(linenum, True))
erg@google.comd350fe52013-01-14 17:51:48 +00002679 if _MATCH_ASM.match(line):
2680 self.stack[-1].inline_asm = _BLOCK_ASM
avakulenko@google.com02af6282014-06-04 18:53:25 +00002681
erg@google.comd350fe52013-01-14 17:51:48 +00002682 elif token == ';' or token == ')':
2683 # If we haven't seen an opening brace yet, but we already saw
2684 # a semicolon, this is probably a forward declaration. Pop
2685 # the stack for these.
2686 #
2687 # Similarly, if we haven't seen an opening brace yet, but we
2688 # already saw a closing parenthesis, then these are probably
2689 # function arguments with extra "class" or "struct" keywords.
2690 # Also pop these stack for these.
2691 if not self.SeenOpenBrace():
2692 self.stack.pop()
2693 else: # token == '}'
2694 # Perform end of block checks and pop the stack.
2695 if self.stack:
2696 self.stack[-1].CheckEnd(filename, clean_lines, linenum, error)
2697 self.stack.pop()
2698 line = matched.group(2)
2699
2700 def InnermostClass(self):
2701 """Get class info on the top of the stack.
2702
2703 Returns:
2704 A _ClassInfo object if we are inside a class, or None otherwise.
2705 """
2706 for i in range(len(self.stack), 0, -1):
2707 classinfo = self.stack[i - 1]
2708 if isinstance(classinfo, _ClassInfo):
2709 return classinfo
2710 return None
2711
erg@google.com2aa59982013-10-28 19:09:25 +00002712 def CheckCompletedBlocks(self, filename, error):
2713 """Checks that all classes and namespaces have been completely parsed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002714
2715 Call this when all lines in a file have been processed.
2716 Args:
2717 filename: The name of the current file.
2718 error: The function to call with any errors found.
2719 """
erg@google.comd350fe52013-01-14 17:51:48 +00002720 # Note: This test can result in false positives if #ifdef constructs
2721 # get in the way of brace matching. See the testBuildClass test in
2722 # cpplint_unittest.py for an example of this.
2723 for obj in self.stack:
2724 if isinstance(obj, _ClassInfo):
2725 error(filename, obj.starting_linenum, 'build/class', 5,
2726 'Failed to find complete declaration of class %s' %
2727 obj.name)
erg@google.com2aa59982013-10-28 19:09:25 +00002728 elif isinstance(obj, _NamespaceInfo):
2729 error(filename, obj.starting_linenum, 'build/namespaces', 5,
2730 'Failed to find complete declaration of namespace %s' %
2731 obj.name)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002732
2733
2734def CheckForNonStandardConstructs(filename, clean_lines, linenum,
erg@google.comd350fe52013-01-14 17:51:48 +00002735 nesting_state, error):
erg@google.com2aa59982013-10-28 19:09:25 +00002736 r"""Logs an error if we see certain non-ANSI constructs ignored by gcc-2.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002737
2738 Complain about several constructs which gcc-2 accepts, but which are
2739 not standard C++. Warning about these in lint is one way to ease the
2740 transition to new compilers.
2741 - put storage class first (e.g. "static const" instead of "const static").
2742 - "%lld" instead of %qd" in printf-type functions.
2743 - "%1$d" is non-standard in printf-type functions.
2744 - "\%" is an undefined character escape sequence.
2745 - text after #endif is not allowed.
2746 - invalid inner-style forward declaration.
2747 - >? and <? operators, and their >?= and <?= cousins.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002748
erg@google.coma868d2d2009-10-09 21:18:45 +00002749 Additionally, check for constructor/destructor style violations and reference
2750 members, as it is very convenient to do so while checking for
2751 gcc-2 compliance.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002752
2753 Args:
2754 filename: The name of the current file.
2755 clean_lines: A CleansedLines instance containing the file.
2756 linenum: The number of the line to check.
avakulenko@google.com02af6282014-06-04 18:53:25 +00002757 nesting_state: A NestingState instance which maintains information about
erg@google.comd350fe52013-01-14 17:51:48 +00002758 the current stack of nested blocks being parsed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002759 error: A callable to which errors are reported, which takes 4 arguments:
2760 filename, line number, error level, and message
2761 """
2762
2763 # Remove comments from the line, but leave in strings for now.
2764 line = clean_lines.lines[linenum]
2765
2766 if Search(r'printf\s*\(.*".*%[-+ ]?\d*q', line):
2767 error(filename, linenum, 'runtime/printf_format', 3,
2768 '%q in format strings is deprecated. Use %ll instead.')
2769
2770 if Search(r'printf\s*\(.*".*%\d+\$', line):
2771 error(filename, linenum, 'runtime/printf_format', 2,
2772 '%N$ formats are unconventional. Try rewriting to avoid them.')
2773
2774 # Remove escaped backslashes before looking for undefined escapes.
2775 line = line.replace('\\\\', '')
2776
2777 if Search(r'("|\').*\\(%|\[|\(|{)', line):
2778 error(filename, linenum, 'build/printf_format', 3,
2779 '%, [, (, and { are undefined character escapes. Unescape them.')
2780
2781 # For the rest, work with both comments and strings removed.
2782 line = clean_lines.elided[linenum]
2783
2784 if Search(r'\b(const|volatile|void|char|short|int|long'
2785 r'|float|double|signed|unsigned'
2786 r'|schar|u?int8|u?int16|u?int32|u?int64)'
erg@google.comd350fe52013-01-14 17:51:48 +00002787 r'\s+(register|static|extern|typedef)\b',
erg@google.com4e00b9a2009-01-12 23:05:11 +00002788 line):
2789 error(filename, linenum, 'build/storage_class', 5,
Alex Vakulenko01e47232016-05-06 13:54:15 -07002790 'Storage-class specifier (static, extern, typedef, etc) should be '
2791 'at the beginning of the declaration.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00002792
Elliot Glaysherae118112016-09-30 15:34:26 -07002793 if Match(r'\s*#\s*endif\s*[^/\s]+', line):
2794 error(filename, linenum, 'build/endif_comment', 5,
2795 'Uncommented text after #endif is non-standard. Use a comment.')
2796
erg@google.com4e00b9a2009-01-12 23:05:11 +00002797 if Match(r'\s*class\s+(\w+\s*::\s*)+\w+\s*;', line):
2798 error(filename, linenum, 'build/forward_decl', 5,
2799 'Inner-style forward declarations are invalid. Remove this line.')
2800
2801 if Search(r'(\w+|[+-]?\d+(\.\d*)?)\s*(<|>)\?=?\s*(\w+|[+-]?\d+)(\.\d*)?',
2802 line):
2803 error(filename, linenum, 'build/deprecated', 3,
2804 '>? and <? (max and min) operators are non-standard and deprecated.')
2805
erg@google.coma868d2d2009-10-09 21:18:45 +00002806 if Search(r'^\s*const\s*string\s*&\s*\w+\s*;', line):
2807 # TODO(unknown): Could it be expanded safely to arbitrary references,
2808 # without triggering too many false positives? The first
2809 # attempt triggered 5 warnings for mostly benign code in the regtest, hence
2810 # the restriction.
2811 # Here's the original regexp, for the reference:
2812 # type_name = r'\w+((\s*::\s*\w+)|(\s*<\s*\w+?\s*>))?'
2813 # r'\s*const\s*' + type_name + '\s*&\s*\w+\s*;'
2814 error(filename, linenum, 'runtime/member_string_references', 2,
2815 'const string& members are dangerous. It is much better to use '
2816 'alternatives, such as pointers or simple constants.')
2817
erg@google.comd350fe52013-01-14 17:51:48 +00002818 # Everything else in this function operates on class declarations.
2819 # Return early if the top of the nesting stack is not a class, or if
2820 # the class head is not completed yet.
2821 classinfo = nesting_state.InnermostClass()
2822 if not classinfo or not classinfo.seen_open_brace:
erg@google.com4e00b9a2009-01-12 23:05:11 +00002823 return
2824
erg@google.com4e00b9a2009-01-12 23:05:11 +00002825 # The class may have been declared with namespace or classname qualifiers.
2826 # The constructor and destructor will not have those qualifiers.
2827 base_classname = classinfo.name.split('::')[-1]
2828
2829 # Look for single-argument constructors that aren't marked explicit.
Alex Vakulenko01e47232016-05-06 13:54:15 -07002830 # Technically a valid construct, but against style.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002831 explicit_constructor_match = Match(
Dana Jansenscf4071c2017-02-22 12:02:39 -05002832 r'\s+(?:(?:inline|constexpr)\s+)*(explicit\s+)?'
2833 r'(?:(?:inline|constexpr)\s+)*%s\s*'
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002834 r'\(((?:[^()]|\([^()]*\))*)\)'
2835 % re.escape(base_classname),
2836 line)
2837
2838 if explicit_constructor_match:
2839 is_marked_explicit = explicit_constructor_match.group(1)
2840
2841 if not explicit_constructor_match.group(2):
2842 constructor_args = []
2843 else:
2844 constructor_args = explicit_constructor_match.group(2).split(',')
2845
2846 # collapse arguments so that commas in template parameter lists and function
2847 # argument parameter lists don't split arguments in two
2848 i = 0
2849 while i < len(constructor_args):
2850 constructor_arg = constructor_args[i]
2851 while (constructor_arg.count('<') > constructor_arg.count('>') or
2852 constructor_arg.count('(') > constructor_arg.count(')')):
2853 constructor_arg += ',' + constructor_args[i + 1]
2854 del constructor_args[i + 1]
2855 constructor_args[i] = constructor_arg
2856 i += 1
2857
2858 defaulted_args = [arg for arg in constructor_args if '=' in arg]
2859 noarg_constructor = (not constructor_args or # empty arg list
2860 # 'void' arg specifier
2861 (len(constructor_args) == 1 and
2862 constructor_args[0].strip() == 'void'))
2863 onearg_constructor = ((len(constructor_args) == 1 and # exactly one arg
2864 not noarg_constructor) or
2865 # all but at most one arg defaulted
2866 (len(constructor_args) >= 1 and
2867 not noarg_constructor and
2868 len(defaulted_args) >= len(constructor_args) - 1))
2869 initializer_list_constructor = bool(
2870 onearg_constructor and
2871 Search(r'\bstd\s*::\s*initializer_list\b', constructor_args[0]))
2872 copy_constructor = bool(
2873 onearg_constructor and
2874 Match(r'(const\s+)?%s(\s*<[^>]*>)?(\s+const)?\s*(?:<\w+>\s*)?&'
2875 % re.escape(base_classname), constructor_args[0].strip()))
2876
2877 if (not is_marked_explicit and
2878 onearg_constructor and
2879 not initializer_list_constructor and
2880 not copy_constructor):
2881 if defaulted_args:
2882 error(filename, linenum, 'runtime/explicit', 5,
2883 'Constructors callable with one argument '
2884 'should be marked explicit.')
2885 else:
2886 error(filename, linenum, 'runtime/explicit', 5,
2887 'Single-parameter constructors should be marked explicit.')
2888 elif is_marked_explicit and not onearg_constructor:
2889 if noarg_constructor:
2890 error(filename, linenum, 'runtime/explicit', 5,
2891 'Zero-parameter constructors should not be marked explicit.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00002892
erg@google.com4e00b9a2009-01-12 23:05:11 +00002893
avakulenko@google.com02af6282014-06-04 18:53:25 +00002894def CheckSpacingForFunctionCall(filename, clean_lines, linenum, error):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002895 """Checks for the correctness of various spacing around function calls.
2896
2897 Args:
2898 filename: The name of the current file.
avakulenko@google.com02af6282014-06-04 18:53:25 +00002899 clean_lines: A CleansedLines instance containing the file.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002900 linenum: The number of the line to check.
2901 error: The function to call with any errors found.
2902 """
avakulenko@google.com02af6282014-06-04 18:53:25 +00002903 line = clean_lines.elided[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00002904
2905 # Since function calls often occur inside if/for/while/switch
2906 # expressions - which have their own, more liberal conventions - we
2907 # first see if we should be looking inside such an expression for a
2908 # function call, to which we can apply more strict standards.
2909 fncall = line # if there's no control flow construct, look at whole line
2910 for pattern in (r'\bif\s*\((.*)\)\s*{',
2911 r'\bfor\s*\((.*)\)\s*{',
2912 r'\bwhile\s*\((.*)\)\s*[{;]',
2913 r'\bswitch\s*\((.*)\)\s*{'):
2914 match = Search(pattern, line)
2915 if match:
2916 fncall = match.group(1) # look inside the parens for function calls
2917 break
2918
2919 # Except in if/for/while/switch, there should never be space
2920 # immediately inside parens (eg "f( 3, 4 )"). We make an exception
2921 # for nested parens ( (a+b) + c ). Likewise, there should never be
2922 # a space before a ( when it's a function argument. I assume it's a
2923 # function argument when the char before the whitespace is legal in
2924 # a function name (alnum + _) and we're not starting a macro. Also ignore
2925 # pointers and references to arrays and functions coz they're too tricky:
2926 # we use a very simple way to recognize these:
2927 # " (something)(maybe-something)" or
2928 # " (something)(maybe-something," or
2929 # " (something)[something]"
2930 # Note that we assume the contents of [] to be short enough that
2931 # they'll never need to wrap.
2932 if ( # Ignore control structures.
erg@google.com2aa59982013-10-28 19:09:25 +00002933 not Search(r'\b(if|for|while|switch|return|new|delete|catch|sizeof)\b',
erg@google.comc6671232013-10-25 21:44:03 +00002934 fncall) and
erg@google.com4e00b9a2009-01-12 23:05:11 +00002935 # Ignore pointers/references to functions.
2936 not Search(r' \([^)]+\)\([^)]*(\)|,$)', fncall) and
2937 # Ignore pointers/references to arrays.
2938 not Search(r' \([^)]+\)\[[^\]]+\]', fncall)):
erg@google.com36649102009-03-25 21:18:36 +00002939 if Search(r'\w\s*\(\s(?!\s*\\$)', fncall): # a ( used for a fn call
erg@google.com4e00b9a2009-01-12 23:05:11 +00002940 error(filename, linenum, 'whitespace/parens', 4,
2941 'Extra space after ( in function call')
erg@google.com36649102009-03-25 21:18:36 +00002942 elif Search(r'\(\s+(?!(\s*\\)|\()', fncall):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002943 error(filename, linenum, 'whitespace/parens', 2,
2944 'Extra space after (')
2945 if (Search(r'\w\s+\(', fncall) and
Alex Vakulenko01e47232016-05-06 13:54:15 -07002946 not Search(r'_{0,2}asm_{0,2}\s+_{0,2}volatile_{0,2}\s+\(', fncall) and
avakulenko@google.com02af6282014-06-04 18:53:25 +00002947 not Search(r'#\s*define|typedef|using\s+\w+\s*=', fncall) and
avakulenko@google.com554223d2014-12-04 22:00:20 +00002948 not Search(r'\w\s+\((\w+::)*\*\w+\)\(', fncall) and
2949 not Search(r'\bcase\s+\(', fncall)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00002950 # TODO(unknown): Space after an operator function seem to be a common
2951 # error, silence those for now by restricting them to highest verbosity.
2952 if Search(r'\boperator_*\b', line):
2953 error(filename, linenum, 'whitespace/parens', 0,
2954 'Extra space before ( in function call')
2955 else:
2956 error(filename, linenum, 'whitespace/parens', 4,
2957 'Extra space before ( in function call')
erg@google.com4e00b9a2009-01-12 23:05:11 +00002958 # If the ) is followed only by a newline or a { + newline, assume it's
2959 # part of a control statement (if/while/etc), and don't complain
2960 if Search(r'[^)]\s+\)\s*[^{\s]', fncall):
erg@google.com8a95ecc2011-09-08 00:45:54 +00002961 # If the closing parenthesis is preceded by only whitespaces,
2962 # try to give a more descriptive error message.
2963 if Search(r'^\s+\)', fncall):
2964 error(filename, linenum, 'whitespace/parens', 2,
2965 'Closing ) should be moved to the previous line')
2966 else:
2967 error(filename, linenum, 'whitespace/parens', 2,
2968 'Extra space before )')
erg@google.com4e00b9a2009-01-12 23:05:11 +00002969
2970
2971def IsBlankLine(line):
2972 """Returns true if the given line is blank.
2973
2974 We consider a line to be blank if the line is empty or consists of
2975 only white spaces.
2976
2977 Args:
2978 line: A line of a string.
2979
2980 Returns:
2981 True, if the given line is blank.
2982 """
2983 return not line or line.isspace()
2984
2985
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00002986def CheckForNamespaceIndentation(filename, nesting_state, clean_lines, line,
2987 error):
2988 is_namespace_indent_item = (
2989 len(nesting_state.stack) > 1 and
2990 nesting_state.stack[-1].check_namespace_indentation and
2991 isinstance(nesting_state.previous_stack_top, _NamespaceInfo) and
2992 nesting_state.previous_stack_top == nesting_state.stack[-2])
2993
2994 if ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item,
2995 clean_lines.elided, line):
2996 CheckItemIndentationInNamespace(filename, clean_lines.elided,
2997 line, error)
2998
2999
erg@google.com4e00b9a2009-01-12 23:05:11 +00003000def CheckForFunctionLengths(filename, clean_lines, linenum,
3001 function_state, error):
3002 """Reports for long function bodies.
3003
3004 For an overview why this is done, see:
Ackermann Yuriy79692902016-04-01 21:41:34 +13003005 https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Write_Short_Functions
erg@google.com4e00b9a2009-01-12 23:05:11 +00003006
3007 Uses a simplistic algorithm assuming other style guidelines
3008 (especially spacing) are followed.
3009 Only checks unindented functions, so class members are unchecked.
3010 Trivial bodies are unchecked, so constructors with huge initializer lists
3011 may be missed.
3012 Blank/comment lines are not counted so as to avoid encouraging the removal
erg@google.com8a95ecc2011-09-08 00:45:54 +00003013 of vertical space and comments just to get through a lint check.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003014 NOLINT *on the last line of a function* disables this check.
3015
3016 Args:
3017 filename: The name of the current file.
3018 clean_lines: A CleansedLines instance containing the file.
3019 linenum: The number of the line to check.
3020 function_state: Current function name and lines in body so far.
3021 error: The function to call with any errors found.
3022 """
3023 lines = clean_lines.lines
3024 line = lines[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00003025 joined_line = ''
3026
3027 starting_func = False
erg@google.coma87abb82009-02-24 01:41:01 +00003028 regexp = r'(\w(\w|::|\*|\&|\s)*)\(' # decls * & space::name( ...
erg@google.com4e00b9a2009-01-12 23:05:11 +00003029 match_result = Match(regexp, line)
3030 if match_result:
3031 # If the name is all caps and underscores, figure it's a macro and
3032 # ignore it, unless it's TEST or TEST_F.
3033 function_name = match_result.group(1).split()[-1]
3034 if function_name == 'TEST' or function_name == 'TEST_F' or (
3035 not Match(r'[A-Z_]+$', function_name)):
3036 starting_func = True
3037
3038 if starting_func:
3039 body_found = False
erg@google.coma87abb82009-02-24 01:41:01 +00003040 for start_linenum in xrange(linenum, clean_lines.NumLines()):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003041 start_line = lines[start_linenum]
3042 joined_line += ' ' + start_line.lstrip()
3043 if Search(r'(;|})', start_line): # Declarations and trivial functions
3044 body_found = True
3045 break # ... ignore
3046 elif Search(r'{', start_line):
3047 body_found = True
3048 function = Search(r'((\w|:)*)\(', line).group(1)
3049 if Match(r'TEST', function): # Handle TEST... macros
3050 parameter_regexp = Search(r'(\(.*\))', joined_line)
3051 if parameter_regexp: # Ignore bad syntax
3052 function += parameter_regexp.group(1)
3053 else:
3054 function += '()'
3055 function_state.Begin(function)
3056 break
3057 if not body_found:
erg@google.coma87abb82009-02-24 01:41:01 +00003058 # No body for the function (or evidence of a non-function) was found.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003059 error(filename, linenum, 'readability/fn_size', 5,
3060 'Lint failed to find start of function body.')
3061 elif Match(r'^\}\s*$', line): # function end
erg+personal@google.com05189642010-04-30 20:43:03 +00003062 function_state.Check(error, filename, linenum)
erg@google.com4e00b9a2009-01-12 23:05:11 +00003063 function_state.End()
3064 elif not Match(r'^\s*$', line):
3065 function_state.Count() # Count non-blank/non-comment lines.
3066
3067
3068_RE_PATTERN_TODO = re.compile(r'^//(\s*)TODO(\(.+?\))?:?(\s|$)?')
3069
3070
avakulenko@google.com02af6282014-06-04 18:53:25 +00003071def CheckComment(line, filename, linenum, next_line_start, error):
3072 """Checks for common mistakes in comments.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003073
3074 Args:
avakulenko@google.com02af6282014-06-04 18:53:25 +00003075 line: The line in question.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003076 filename: The name of the current file.
3077 linenum: The number of the line to check.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003078 next_line_start: The first non-whitespace column of the next line.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003079 error: The function to call with any errors found.
3080 """
avakulenko@google.com02af6282014-06-04 18:53:25 +00003081 commentpos = line.find('//')
3082 if commentpos != -1:
3083 # Check if the // may be in quotes. If so, ignore it
Alex Vakulenko01e47232016-05-06 13:54:15 -07003084 if re.sub(r'\\.', '', line[0:commentpos]).count('"') % 2 == 0:
avakulenko@google.com02af6282014-06-04 18:53:25 +00003085 # Allow one space for new scopes, two spaces otherwise:
3086 if (not (Match(r'^.*{ *//', line) and next_line_start == commentpos) and
3087 ((commentpos >= 1 and
3088 line[commentpos-1] not in string.whitespace) or
3089 (commentpos >= 2 and
3090 line[commentpos-2] not in string.whitespace))):
3091 error(filename, linenum, 'whitespace/comments', 2,
3092 'At least two spaces is best between code and comments')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003093
avakulenko@google.com02af6282014-06-04 18:53:25 +00003094 # Checks for common mistakes in TODO comments.
3095 comment = line[commentpos:]
3096 match = _RE_PATTERN_TODO.match(comment)
3097 if match:
3098 # One whitespace is correct; zero whitespace is handled elsewhere.
3099 leading_whitespace = match.group(1)
3100 if len(leading_whitespace) > 1:
3101 error(filename, linenum, 'whitespace/todo', 2,
3102 'Too many spaces before TODO')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003103
avakulenko@google.com02af6282014-06-04 18:53:25 +00003104 username = match.group(2)
3105 if not username:
3106 error(filename, linenum, 'readability/todo', 2,
3107 'Missing username in TODO; it should look like '
3108 '"// TODO(my_username): Stuff."')
3109
3110 middle_whitespace = match.group(3)
3111 # Comparisons made explicit for correctness -- pylint: disable=g-explicit-bool-comparison
3112 if middle_whitespace != ' ' and middle_whitespace != '':
3113 error(filename, linenum, 'whitespace/todo', 2,
3114 'TODO(my_username) should be followed by a space')
3115
3116 # If the comment contains an alphanumeric character, there
avakulenko@google.com554223d2014-12-04 22:00:20 +00003117 # should be a space somewhere between it and the // unless
3118 # it's a /// or //! Doxygen comment.
3119 if (Match(r'//[^ ]*\w', comment) and
3120 not Match(r'(///|//\!)(\s+|$)', comment)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00003121 error(filename, linenum, 'whitespace/comments', 4,
3122 'Should have a space between // and comment')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003123
avakulenko@google.com554223d2014-12-04 22:00:20 +00003124
erg@google.comd350fe52013-01-14 17:51:48 +00003125def CheckSpacing(filename, clean_lines, linenum, nesting_state, error):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003126 """Checks for the correctness of various spacing issues in the code.
3127
3128 Things we check for: spaces around operators, spaces after
3129 if/for/while/switch, no spaces around parens in function calls, two
3130 spaces between code and comment, don't start a block with a blank
erg@google.com8a95ecc2011-09-08 00:45:54 +00003131 line, don't end a function with a blank line, don't add a blank line
3132 after public/protected/private, don't have too many blank lines in a row.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003133
3134 Args:
3135 filename: The name of the current file.
3136 clean_lines: A CleansedLines instance containing the file.
3137 linenum: The number of the line to check.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003138 nesting_state: A NestingState instance which maintains information about
erg@google.comd350fe52013-01-14 17:51:48 +00003139 the current stack of nested blocks being parsed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003140 error: The function to call with any errors found.
3141 """
3142
erg@google.com2aa59982013-10-28 19:09:25 +00003143 # Don't use "elided" lines here, otherwise we can't check commented lines.
3144 # Don't want to use "raw" either, because we don't want to check inside C++11
3145 # raw strings,
3146 raw = clean_lines.lines_without_raw_strings
erg@google.com4e00b9a2009-01-12 23:05:11 +00003147 line = raw[linenum]
3148
3149 # Before nixing comments, check if the line is blank for no good
3150 # reason. This includes the first line after a block is opened, and
3151 # blank lines at the end of a function (ie, right before a line like '}'
erg@google.comd350fe52013-01-14 17:51:48 +00003152 #
3153 # Skip all the blank line checks if we are immediately inside a
3154 # namespace body. In other words, don't issue blank line warnings
3155 # for this block:
3156 # namespace {
3157 #
3158 # }
3159 #
3160 # A warning about missing end of namespace comments will be issued instead.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003161 #
3162 # Also skip blank line checks for 'extern "C"' blocks, which are formatted
3163 # like namespaces.
3164 if (IsBlankLine(line) and
3165 not nesting_state.InNamespaceBody() and
3166 not nesting_state.InExternC()):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003167 elided = clean_lines.elided
3168 prev_line = elided[linenum - 1]
3169 prevbrace = prev_line.rfind('{')
3170 # TODO(unknown): Don't complain if line before blank line, and line after,
3171 # both start with alnums and are indented the same amount.
3172 # This ignores whitespace at the start of a namespace block
3173 # because those are not usually indented.
erg@google.comd350fe52013-01-14 17:51:48 +00003174 if prevbrace != -1 and prev_line[prevbrace:].find('}') == -1:
erg@google.com4e00b9a2009-01-12 23:05:11 +00003175 # OK, we have a blank line at the start of a code block. Before we
3176 # complain, we check if it is an exception to the rule: The previous
erg@google.com8a95ecc2011-09-08 00:45:54 +00003177 # non-empty line has the parameters of a function header that are indented
erg@google.com4e00b9a2009-01-12 23:05:11 +00003178 # 4 spaces (because they did not fit in a 80 column line when placed on
3179 # the same line as the function name). We also check for the case where
3180 # the previous line is indented 6 spaces, which may happen when the
3181 # initializers of a constructor do not fit into a 80 column line.
3182 exception = False
3183 if Match(r' {6}\w', prev_line): # Initializer list?
3184 # We are looking for the opening column of initializer list, which
3185 # should be indented 4 spaces to cause 6 space indentation afterwards.
3186 search_position = linenum-2
3187 while (search_position >= 0
3188 and Match(r' {6}\w', elided[search_position])):
3189 search_position -= 1
3190 exception = (search_position >= 0
3191 and elided[search_position][:5] == ' :')
3192 else:
3193 # Search for the function arguments or an initializer list. We use a
3194 # simple heuristic here: If the line is indented 4 spaces; and we have a
3195 # closing paren, without the opening paren, followed by an opening brace
3196 # or colon (for initializer lists) we assume that it is the last line of
3197 # a function header. If we have a colon indented 4 spaces, it is an
3198 # initializer list.
3199 exception = (Match(r' {4}\w[^\(]*\)\s*(const\s*)?(\{\s*$|:)',
3200 prev_line)
3201 or Match(r' {4}:', prev_line))
3202
3203 if not exception:
3204 error(filename, linenum, 'whitespace/blank_line', 2,
erg@google.com2aa59982013-10-28 19:09:25 +00003205 'Redundant blank line at the start of a code block '
3206 'should be deleted.')
erg@google.comd350fe52013-01-14 17:51:48 +00003207 # Ignore blank lines at the end of a block in a long if-else
erg@google.com4e00b9a2009-01-12 23:05:11 +00003208 # chain, like this:
3209 # if (condition1) {
3210 # // Something followed by a blank line
3211 #
3212 # } else if (condition2) {
3213 # // Something else
3214 # }
3215 if linenum + 1 < clean_lines.NumLines():
3216 next_line = raw[linenum + 1]
3217 if (next_line
3218 and Match(r'\s*}', next_line)
erg@google.com4e00b9a2009-01-12 23:05:11 +00003219 and next_line.find('} else ') == -1):
3220 error(filename, linenum, 'whitespace/blank_line', 3,
erg@google.com2aa59982013-10-28 19:09:25 +00003221 'Redundant blank line at the end of a code block '
3222 'should be deleted.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003223
erg@google.com8a95ecc2011-09-08 00:45:54 +00003224 matched = Match(r'\s*(public|protected|private):', prev_line)
3225 if matched:
3226 error(filename, linenum, 'whitespace/blank_line', 3,
3227 'Do not leave a blank line after "%s:"' % matched.group(1))
3228
avakulenko@google.com02af6282014-06-04 18:53:25 +00003229 # Next, check comments
3230 next_line_start = 0
3231 if linenum + 1 < clean_lines.NumLines():
3232 next_line = raw[linenum + 1]
3233 next_line_start = len(next_line) - len(next_line.lstrip())
3234 CheckComment(line, filename, linenum, next_line_start, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00003235
avakulenko@google.com02af6282014-06-04 18:53:25 +00003236 # get rid of comments and strings
3237 line = clean_lines.elided[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00003238
avakulenko@google.com02af6282014-06-04 18:53:25 +00003239 # You shouldn't have spaces before your brackets, except maybe after
3240 # 'delete []' or 'return []() {};'
3241 if Search(r'\w\s+\[', line) and not Search(r'(?:delete|return)\s+\[', line):
3242 error(filename, linenum, 'whitespace/braces', 5,
3243 'Extra space before [')
3244
3245 # In range-based for, we wanted spaces before and after the colon, but
3246 # not around "::" tokens that might appear.
3247 if (Search(r'for *\(.*[^:]:[^: ]', line) or
3248 Search(r'for *\(.*[^: ]:[^:]', line)):
3249 error(filename, linenum, 'whitespace/forcolon', 2,
3250 'Missing space around colon in range-based for loop')
3251
3252
3253def CheckOperatorSpacing(filename, clean_lines, linenum, error):
3254 """Checks for horizontal spacing around operators.
3255
3256 Args:
3257 filename: The name of the current file.
3258 clean_lines: A CleansedLines instance containing the file.
3259 linenum: The number of the line to check.
3260 error: The function to call with any errors found.
3261 """
3262 line = clean_lines.elided[linenum]
3263
3264 # Don't try to do spacing checks for operator methods. Do this by
3265 # replacing the troublesome characters with something else,
3266 # preserving column position for all other characters.
3267 #
3268 # The replacement is done repeatedly to avoid false positives from
3269 # operators that call operators.
3270 while True:
3271 match = Match(r'^(.*\boperator\b)(\S+)(\s*\(.*)$', line)
3272 if match:
3273 line = match.group(1) + ('_' * len(match.group(2))) + match.group(3)
3274 else:
3275 break
erg@google.com4e00b9a2009-01-12 23:05:11 +00003276
3277 # We allow no-spaces around = within an if: "if ( (a=Foo()) == 0 )".
3278 # Otherwise not. Note we only check for non-spaces on *both* sides;
3279 # sometimes people put non-spaces on one side when aligning ='s among
3280 # many lines (not that this is behavior that I approve of...)
avakulenko@google.com554223d2014-12-04 22:00:20 +00003281 if ((Search(r'[\w.]=', line) or
3282 Search(r'=[\w.]', line))
3283 and not Search(r'\b(if|while|for) ', line)
3284 # Operators taken from [lex.operators] in C++11 standard.
3285 and not Search(r'(>=|<=|==|!=|&=|\^=|\|=|\+=|\*=|\/=|\%=)', line)
3286 and not Search(r'operator=', line)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003287 error(filename, linenum, 'whitespace/operators', 4,
3288 'Missing spaces around =')
3289
3290 # It's ok not to have spaces around binary operators like + - * /, but if
3291 # there's too little whitespace, we get concerned. It's hard to tell,
3292 # though, so we punt on this one for now. TODO.
3293
3294 # You should always have whitespace around binary operators.
erg@google.comd350fe52013-01-14 17:51:48 +00003295 #
3296 # Check <= and >= first to avoid false positives with < and >, then
3297 # check non-include lines for spacing around < and >.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003298 #
3299 # If the operator is followed by a comma, assume it's be used in a
3300 # macro context and don't do any checks. This avoids false
3301 # positives.
3302 #
Alex Vakulenko01e47232016-05-06 13:54:15 -07003303 # Note that && is not included here. This is because there are too
3304 # many false positives due to RValue references.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003305 match = Search(r'[^<>=!\s](==|!=|<=|>=|\|\|)[^<>=!\s,;\)]', line)
erg@google.com4e00b9a2009-01-12 23:05:11 +00003306 if match:
3307 error(filename, linenum, 'whitespace/operators', 3,
3308 'Missing spaces around %s' % match.group(1))
erg@google.comd350fe52013-01-14 17:51:48 +00003309 elif not Match(r'#.*include', line):
erg@google.comd350fe52013-01-14 17:51:48 +00003310 # Look for < that is not surrounded by spaces. This is only
3311 # triggered if both sides are missing spaces, even though
3312 # technically should should flag if at least one side is missing a
3313 # space. This is done to avoid some false positives with shifts.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003314 match = Match(r'^(.*[^\s<])<[^\s=<,]', line)
3315 if match:
3316 (_, _, end_pos) = CloseExpression(
3317 clean_lines, linenum, len(match.group(1)))
3318 if end_pos <= -1:
3319 error(filename, linenum, 'whitespace/operators', 3,
3320 'Missing spaces around <')
erg@google.comd350fe52013-01-14 17:51:48 +00003321
3322 # Look for > that is not surrounded by spaces. Similar to the
3323 # above, we only trigger if both sides are missing spaces to avoid
3324 # false positives with shifts.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003325 match = Match(r'^(.*[^-\s>])>[^\s=>,]', line)
3326 if match:
3327 (_, _, start_pos) = ReverseCloseExpression(
3328 clean_lines, linenum, len(match.group(1)))
3329 if start_pos <= -1:
3330 error(filename, linenum, 'whitespace/operators', 3,
3331 'Missing spaces around >')
3332
3333 # We allow no-spaces around << when used like this: 10<<20, but
3334 # not otherwise (particularly, not when used as streams)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00003335 #
avakulenko@google.com02af6282014-06-04 18:53:25 +00003336 # We also allow operators following an opening parenthesis, since
3337 # those tend to be macros that deal with operators.
Alex Vakulenko01e47232016-05-06 13:54:15 -07003338 match = Search(r'(operator|[^\s(<])(?:L|UL|LL|ULL|l|ul|ll|ull)?<<([^\s,=<])', line)
avakulenko@google.com554223d2014-12-04 22:00:20 +00003339 if (match and not (match.group(1).isdigit() and match.group(2).isdigit()) and
avakulenko@google.com02af6282014-06-04 18:53:25 +00003340 not (match.group(1) == 'operator' and match.group(2) == ';')):
3341 error(filename, linenum, 'whitespace/operators', 3,
3342 'Missing spaces around <<')
erg@google.comd350fe52013-01-14 17:51:48 +00003343
3344 # We allow no-spaces around >> for almost anything. This is because
3345 # C++11 allows ">>" to close nested templates, which accounts for
3346 # most cases when ">>" is not followed by a space.
3347 #
3348 # We still warn on ">>" followed by alpha character, because that is
3349 # likely due to ">>" being used for right shifts, e.g.:
3350 # value >> alpha
3351 #
3352 # When ">>" is used to close templates, the alphanumeric letter that
3353 # follows would be part of an identifier, and there should still be
3354 # a space separating the template type and the identifier.
3355 # type<type<type>> alpha
3356 match = Search(r'>>[a-zA-Z_]', line)
erg@google.com4e00b9a2009-01-12 23:05:11 +00003357 if match:
3358 error(filename, linenum, 'whitespace/operators', 3,
erg@google.comd350fe52013-01-14 17:51:48 +00003359 'Missing spaces around >>')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003360
3361 # There shouldn't be space around unary operators
3362 match = Search(r'(!\s|~\s|[\s]--[\s;]|[\s]\+\+[\s;])', line)
3363 if match:
3364 error(filename, linenum, 'whitespace/operators', 4,
3365 'Extra space for operator %s' % match.group(1))
3366
avakulenko@google.com02af6282014-06-04 18:53:25 +00003367
3368def CheckParenthesisSpacing(filename, clean_lines, linenum, error):
3369 """Checks for horizontal spacing around parentheses.
3370
3371 Args:
3372 filename: The name of the current file.
3373 clean_lines: A CleansedLines instance containing the file.
3374 linenum: The number of the line to check.
3375 error: The function to call with any errors found.
3376 """
3377 line = clean_lines.elided[linenum]
3378
3379 # No spaces after an if, while, switch, or for
erg@google.com4e00b9a2009-01-12 23:05:11 +00003380 match = Search(r' (if\(|for\(|while\(|switch\()', line)
3381 if match:
3382 error(filename, linenum, 'whitespace/parens', 5,
3383 'Missing space before ( in %s' % match.group(1))
3384
3385 # For if/for/while/switch, the left and right parens should be
3386 # consistent about how many spaces are inside the parens, and
3387 # there should either be zero or one spaces inside the parens.
3388 # We don't want: "if ( foo)" or "if ( foo )".
erg@google.come35f7652009-06-19 20:52:09 +00003389 # Exception: "for ( ; foo; bar)" and "for (foo; bar; )" are allowed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003390 match = Search(r'\b(if|for|while|switch)\s*'
3391 r'\(([ ]*)(.).*[^ ]+([ ]*)\)\s*{\s*$',
3392 line)
3393 if match:
3394 if len(match.group(2)) != len(match.group(4)):
3395 if not (match.group(3) == ';' and
erg@google.come35f7652009-06-19 20:52:09 +00003396 len(match.group(2)) == 1 + len(match.group(4)) or
3397 not match.group(2) and Search(r'\bfor\s*\(.*; \)', line)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003398 error(filename, linenum, 'whitespace/parens', 5,
3399 'Mismatching spaces inside () in %s' % match.group(1))
erg@google.comc6671232013-10-25 21:44:03 +00003400 if len(match.group(2)) not in [0, 1]:
erg@google.com4e00b9a2009-01-12 23:05:11 +00003401 error(filename, linenum, 'whitespace/parens', 5,
3402 'Should have zero or one spaces inside ( and ) in %s' %
3403 match.group(1))
3404
avakulenko@google.com02af6282014-06-04 18:53:25 +00003405
3406def CheckCommaSpacing(filename, clean_lines, linenum, error):
3407 """Checks for horizontal spacing near commas and semicolons.
3408
3409 Args:
3410 filename: The name of the current file.
3411 clean_lines: A CleansedLines instance containing the file.
3412 linenum: The number of the line to check.
3413 error: The function to call with any errors found.
3414 """
3415 raw = clean_lines.lines_without_raw_strings
3416 line = clean_lines.elided[linenum]
3417
erg@google.com4e00b9a2009-01-12 23:05:11 +00003418 # You should always have a space after a comma (either as fn arg or operator)
erg@google.comc6671232013-10-25 21:44:03 +00003419 #
3420 # This does not apply when the non-space character following the
3421 # comma is another comma, since the only time when that happens is
3422 # for empty macro arguments.
erg@google.com2aa59982013-10-28 19:09:25 +00003423 #
3424 # We run this check in two passes: first pass on elided lines to
3425 # verify that lines contain missing whitespaces, second pass on raw
3426 # lines to confirm that those missing whitespaces are not due to
3427 # elided comments.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00003428 if (Search(r',[^,\s]', ReplaceAll(r'\boperator\s*,\s*\(', 'F(', line)) and
3429 Search(r',[^,\s]', raw[linenum])):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003430 error(filename, linenum, 'whitespace/comma', 3,
3431 'Missing space after ,')
3432
erg@google.comd7d27472011-09-07 17:36:35 +00003433 # You should always have a space after a semicolon
3434 # except for few corner cases
3435 # TODO(unknown): clarify if 'if (1) { return 1;}' is requires one more
3436 # space after ;
3437 if Search(r';[^\s};\\)/]', line):
3438 error(filename, linenum, 'whitespace/semicolon', 3,
3439 'Missing space after ;')
3440
avakulenko@google.com02af6282014-06-04 18:53:25 +00003441
Alex Vakulenko01e47232016-05-06 13:54:15 -07003442def _IsType(clean_lines, nesting_state, expr):
3443 """Check if expression looks like a type name, returns true if so.
3444
3445 Args:
3446 clean_lines: A CleansedLines instance containing the file.
3447 nesting_state: A NestingState instance which maintains information about
3448 the current stack of nested blocks being parsed.
3449 expr: The expression to check.
3450 Returns:
3451 True, if token looks like a type.
3452 """
3453 # Keep only the last token in the expression
3454 last_word = Match(r'^.*(\b\S+)$', expr)
3455 if last_word:
3456 token = last_word.group(1)
3457 else:
3458 token = expr
3459
3460 # Match native types and stdint types
3461 if _TYPES.match(token):
3462 return True
3463
3464 # Try a bit harder to match templated types. Walk up the nesting
3465 # stack until we find something that resembles a typename
3466 # declaration for what we are looking for.
3467 typename_pattern = (r'\b(?:typename|class|struct)\s+' + re.escape(token) +
3468 r'\b')
3469 block_index = len(nesting_state.stack) - 1
3470 while block_index >= 0:
3471 if isinstance(nesting_state.stack[block_index], _NamespaceInfo):
3472 return False
3473
3474 # Found where the opening brace is. We want to scan from this
3475 # line up to the beginning of the function, minus a few lines.
3476 # template <typename Type1, // stop scanning here
3477 # ...>
3478 # class C
3479 # : public ... { // start scanning here
3480 last_line = nesting_state.stack[block_index].starting_linenum
3481
3482 next_block_start = 0
3483 if block_index > 0:
3484 next_block_start = nesting_state.stack[block_index - 1].starting_linenum
3485 first_line = last_line
3486 while first_line >= next_block_start:
3487 if clean_lines.elided[first_line].find('template') >= 0:
3488 break
3489 first_line -= 1
3490 if first_line < next_block_start:
3491 # Didn't find any "template" keyword before reaching the next block,
3492 # there are probably no template things to check for this block
3493 block_index -= 1
3494 continue
3495
3496 # Look for typename in the specified range
3497 for i in xrange(first_line, last_line + 1, 1):
3498 if Search(typename_pattern, clean_lines.elided[i]):
3499 return True
3500 block_index -= 1
3501
3502 return False
3503
3504
3505def CheckBracesSpacing(filename, clean_lines, linenum, nesting_state, error):
avakulenko@google.com02af6282014-06-04 18:53:25 +00003506 """Checks for horizontal spacing near commas.
3507
3508 Args:
3509 filename: The name of the current file.
3510 clean_lines: A CleansedLines instance containing the file.
3511 linenum: The number of the line to check.
Alex Vakulenko01e47232016-05-06 13:54:15 -07003512 nesting_state: A NestingState instance which maintains information about
3513 the current stack of nested blocks being parsed.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003514 error: The function to call with any errors found.
3515 """
3516 line = clean_lines.elided[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00003517
erg@google.com8a95ecc2011-09-08 00:45:54 +00003518 # Except after an opening paren, or after another opening brace (in case of
3519 # an initializer list, for instance), you should have spaces before your
Alex Vakulenko01e47232016-05-06 13:54:15 -07003520 # braces when they are delimiting blocks, classes, namespaces etc.
3521 # And since you should never have braces at the beginning of a line,
3522 # this is an easy test. Except that braces used for initialization don't
3523 # follow the same rule; we often don't want spaces before those.
avakulenko@google.com554223d2014-12-04 22:00:20 +00003524 match = Match(r'^(.*[^ ({>]){', line)
Alex Vakulenko01e47232016-05-06 13:54:15 -07003525
erg@google.com2aa59982013-10-28 19:09:25 +00003526 if match:
3527 # Try a bit harder to check for brace initialization. This
3528 # happens in one of the following forms:
3529 # Constructor() : initializer_list_{} { ... }
3530 # Constructor{}.MemberFunction()
3531 # Type variable{};
3532 # FunctionCall(type{}, ...);
3533 # LastArgument(..., type{});
3534 # LOG(INFO) << type{} << " ...";
3535 # map_of_type[{...}] = ...;
avakulenko@google.com02af6282014-06-04 18:53:25 +00003536 # ternary = expr ? new type{} : nullptr;
3537 # OuterTemplate<InnerTemplateConstructor<Type>{}>
erg@google.com2aa59982013-10-28 19:09:25 +00003538 #
3539 # We check for the character following the closing brace, and
3540 # silence the warning if it's one of those listed above, i.e.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003541 # "{.;,)<>]:".
erg@google.com2aa59982013-10-28 19:09:25 +00003542 #
3543 # To account for nested initializer list, we allow any number of
3544 # closing braces up to "{;,)<". We can't simply silence the
3545 # warning on first sight of closing brace, because that would
3546 # cause false negatives for things that are not initializer lists.
3547 # Silence this: But not this:
3548 # Outer{ if (...) {
3549 # Inner{...} if (...){ // Missing space before {
3550 # }; }
3551 #
3552 # There is a false negative with this approach if people inserted
3553 # spurious semicolons, e.g. "if (cond){};", but we will catch the
3554 # spurious semicolon with a separate check.
Alex Vakulenko01e47232016-05-06 13:54:15 -07003555 leading_text = match.group(1)
erg@google.com2aa59982013-10-28 19:09:25 +00003556 (endline, endlinenum, endpos) = CloseExpression(
3557 clean_lines, linenum, len(match.group(1)))
3558 trailing_text = ''
3559 if endpos > -1:
3560 trailing_text = endline[endpos:]
3561 for offset in xrange(endlinenum + 1,
3562 min(endlinenum + 3, clean_lines.NumLines() - 1)):
3563 trailing_text += clean_lines.elided[offset]
Alex Vakulenko01e47232016-05-06 13:54:15 -07003564 # We also suppress warnings for `uint64_t{expression}` etc., as the style
3565 # guide recommends brace initialization for integral types to avoid
3566 # overflow/truncation.
3567 if (not Match(r'^[\s}]*[{.;,)<>\]:]', trailing_text)
3568 and not _IsType(clean_lines, nesting_state, leading_text)):
erg@google.com2aa59982013-10-28 19:09:25 +00003569 error(filename, linenum, 'whitespace/braces', 5,
3570 'Missing space before {')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003571
3572 # Make sure '} else {' has spaces.
3573 if Search(r'}else', line):
3574 error(filename, linenum, 'whitespace/braces', 5,
3575 'Missing space before else')
3576
erg@google.com4e00b9a2009-01-12 23:05:11 +00003577 # You shouldn't have a space before a semicolon at the end of the line.
3578 # There's a special case for "for" since the style guide allows space before
3579 # the semicolon there.
3580 if Search(r':\s*;\s*$', line):
3581 error(filename, linenum, 'whitespace/semicolon', 5,
erg@google.comd350fe52013-01-14 17:51:48 +00003582 'Semicolon defining empty statement. Use {} instead.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003583 elif Search(r'^\s*;\s*$', line):
3584 error(filename, linenum, 'whitespace/semicolon', 5,
3585 'Line contains only semicolon. If this should be an empty statement, '
erg@google.comd350fe52013-01-14 17:51:48 +00003586 'use {} instead.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003587 elif (Search(r'\s+;\s*$', line) and
3588 not Search(r'\bfor\b', line)):
3589 error(filename, linenum, 'whitespace/semicolon', 5,
3590 'Extra space before last semicolon. If this should be an empty '
erg@google.comd350fe52013-01-14 17:51:48 +00003591 'statement, use {} instead.')
3592
avakulenko@google.com02af6282014-06-04 18:53:25 +00003593
3594def IsDecltype(clean_lines, linenum, column):
3595 """Check if the token ending on (linenum, column) is decltype().
3596
3597 Args:
3598 clean_lines: A CleansedLines instance containing the file.
3599 linenum: the number of the line to check.
3600 column: end column of the token to check.
3601 Returns:
3602 True if this token is decltype() expression, False otherwise.
3603 """
3604 (text, _, start_col) = ReverseCloseExpression(clean_lines, linenum, column)
3605 if start_col < 0:
3606 return False
3607 if Search(r'\bdecltype\s*$', text[0:start_col]):
3608 return True
3609 return False
3610
3611
erg@google.com8a95ecc2011-09-08 00:45:54 +00003612def CheckSectionSpacing(filename, clean_lines, class_info, linenum, error):
3613 """Checks for additional blank line issues related to sections.
3614
3615 Currently the only thing checked here is blank line before protected/private.
3616
3617 Args:
3618 filename: The name of the current file.
3619 clean_lines: A CleansedLines instance containing the file.
3620 class_info: A _ClassInfo objects.
3621 linenum: The number of the line to check.
3622 error: The function to call with any errors found.
3623 """
3624 # Skip checks if the class is small, where small means 25 lines or less.
3625 # 25 lines seems like a good cutoff since that's the usual height of
3626 # terminals, and any class that can't fit in one screen can't really
3627 # be considered "small".
3628 #
3629 # Also skip checks if we are on the first line. This accounts for
3630 # classes that look like
3631 # class Foo { public: ... };
3632 #
3633 # If we didn't find the end of the class, last_line would be zero,
3634 # and the check will be skipped by the first condition.
erg@google.comd350fe52013-01-14 17:51:48 +00003635 if (class_info.last_line - class_info.starting_linenum <= 24 or
3636 linenum <= class_info.starting_linenum):
erg@google.com8a95ecc2011-09-08 00:45:54 +00003637 return
3638
3639 matched = Match(r'\s*(public|protected|private):', clean_lines.lines[linenum])
3640 if matched:
3641 # Issue warning if the line before public/protected/private was
3642 # not a blank line, but don't do this if the previous line contains
3643 # "class" or "struct". This can happen two ways:
3644 # - We are at the beginning of the class.
3645 # - We are forward-declaring an inner class that is semantically
3646 # private, but needed to be public for implementation reasons.
erg@google.comd350fe52013-01-14 17:51:48 +00003647 # Also ignores cases where the previous line ends with a backslash as can be
3648 # common when defining classes in C macros.
erg@google.com8a95ecc2011-09-08 00:45:54 +00003649 prev_line = clean_lines.lines[linenum - 1]
3650 if (not IsBlankLine(prev_line) and
erg@google.comd350fe52013-01-14 17:51:48 +00003651 not Search(r'\b(class|struct)\b', prev_line) and
3652 not Search(r'\\$', prev_line)):
erg@google.com8a95ecc2011-09-08 00:45:54 +00003653 # Try a bit harder to find the beginning of the class. This is to
3654 # account for multi-line base-specifier lists, e.g.:
3655 # class Derived
3656 # : public Base {
erg@google.comd350fe52013-01-14 17:51:48 +00003657 end_class_head = class_info.starting_linenum
3658 for i in range(class_info.starting_linenum, linenum):
erg@google.com8a95ecc2011-09-08 00:45:54 +00003659 if Search(r'\{\s*$', clean_lines.lines[i]):
3660 end_class_head = i
3661 break
3662 if end_class_head < linenum - 1:
3663 error(filename, linenum, 'whitespace/blank_line', 3,
3664 '"%s:" should be preceded by a blank line' % matched.group(1))
3665
3666
erg@google.com4e00b9a2009-01-12 23:05:11 +00003667def GetPreviousNonBlankLine(clean_lines, linenum):
3668 """Return the most recent non-blank line and its line number.
3669
3670 Args:
3671 clean_lines: A CleansedLines instance containing the file contents.
3672 linenum: The number of the line to check.
3673
3674 Returns:
3675 A tuple with two elements. The first element is the contents of the last
3676 non-blank line before the current line, or the empty string if this is the
3677 first non-blank line. The second is the line number of that line, or -1
3678 if this is the first non-blank line.
3679 """
3680
3681 prevlinenum = linenum - 1
3682 while prevlinenum >= 0:
3683 prevline = clean_lines.elided[prevlinenum]
3684 if not IsBlankLine(prevline): # if not a blank line...
3685 return (prevline, prevlinenum)
3686 prevlinenum -= 1
3687 return ('', -1)
3688
3689
3690def CheckBraces(filename, clean_lines, linenum, error):
3691 """Looks for misplaced braces (e.g. at the end of line).
3692
3693 Args:
3694 filename: The name of the current file.
3695 clean_lines: A CleansedLines instance containing the file.
3696 linenum: The number of the line to check.
3697 error: The function to call with any errors found.
3698 """
3699
3700 line = clean_lines.elided[linenum] # get rid of comments and strings
3701
3702 if Match(r'\s*{\s*$', line):
erg@google.com2aa59982013-10-28 19:09:25 +00003703 # We allow an open brace to start a line in the case where someone is using
3704 # braces in a block to explicitly create a new scope, which is commonly used
3705 # to control the lifetime of stack-allocated variables. Braces are also
3706 # used for brace initializers inside function calls. We don't detect this
3707 # perfectly: we just don't complain if the last non-whitespace character on
3708 # the previous non-blank line is ',', ';', ':', '(', '{', or '}', or if the
Alex Vakulenko01e47232016-05-06 13:54:15 -07003709 # previous line starts a preprocessor block. We also allow a brace on the
3710 # following line if it is part of an array initialization and would not fit
3711 # within the 80 character limit of the preceding line.
erg@google.com4e00b9a2009-01-12 23:05:11 +00003712 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
erg@google.com2aa59982013-10-28 19:09:25 +00003713 if (not Search(r'[,;:}{(]\s*$', prevline) and
Alex Vakulenko01e47232016-05-06 13:54:15 -07003714 not Match(r'\s*#', prevline) and
3715 not (GetLineWidth(prevline) > _line_length - 2 and '[]' in prevline)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003716 error(filename, linenum, 'whitespace/braces', 4,
3717 '{ should almost always be at the end of the previous line')
3718
3719 # An else clause should be on the same line as the preceding closing brace.
avakulenko@google.com02af6282014-06-04 18:53:25 +00003720 if Match(r'\s*else\b\s*(?:if\b|\{|$)', line):
erg@google.com4e00b9a2009-01-12 23:05:11 +00003721 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
3722 if Match(r'\s*}\s*$', prevline):
3723 error(filename, linenum, 'whitespace/newline', 4,
3724 'An else should appear on the same line as the preceding }')
3725
3726 # If braces come on one side of an else, they should be on both.
3727 # However, we have to worry about "else if" that spans multiple lines!
avakulenko@google.com02af6282014-06-04 18:53:25 +00003728 if Search(r'else if\s*\(', line): # could be multi-line if
3729 brace_on_left = bool(Search(r'}\s*else if\s*\(', line))
3730 # find the ( after the if
3731 pos = line.find('else if')
3732 pos = line.find('(', pos)
3733 if pos > 0:
3734 (endline, _, endpos) = CloseExpression(clean_lines, linenum, pos)
3735 brace_on_right = endline[endpos:].find('{') != -1
3736 if brace_on_left != brace_on_right: # must be brace after if
3737 error(filename, linenum, 'readability/braces', 5,
3738 'If an else has a brace on one side, it should have it on both')
3739 elif Search(r'}\s*else[^{]*$', line) or Match(r'[^}]*else\s*{', line):
3740 error(filename, linenum, 'readability/braces', 5,
3741 'If an else has a brace on one side, it should have it on both')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003742
3743 # Likewise, an else should never have the else clause on the same line
3744 if Search(r'\belse [^\s{]', line) and not Search(r'\belse if\b', line):
3745 error(filename, linenum, 'whitespace/newline', 4,
3746 'Else clause should never be on same line as else (use 2 lines)')
3747
3748 # In the same way, a do/while should never be on one line
3749 if Match(r'\s*do [^\s{]', line):
3750 error(filename, linenum, 'whitespace/newline', 4,
3751 'do/while clauses should not be on a single line')
3752
avakulenko@google.com02af6282014-06-04 18:53:25 +00003753 # Check single-line if/else bodies. The style guide says 'curly braces are not
3754 # required for single-line statements'. We additionally allow multi-line,
3755 # single statements, but we reject anything with more than one semicolon in
3756 # it. This means that the first semicolon after the if should be at the end of
3757 # its line, and the line after that should have an indent level equal to or
3758 # lower than the if. We also check for ambiguous if/else nesting without
3759 # braces.
3760 if_else_match = Search(r'\b(if\s*\(|else\b)', line)
3761 if if_else_match and not Match(r'\s*#', line):
3762 if_indent = GetIndentLevel(line)
3763 endline, endlinenum, endpos = line, linenum, if_else_match.end()
3764 if_match = Search(r'\bif\s*\(', line)
3765 if if_match:
3766 # This could be a multiline if condition, so find the end first.
3767 pos = if_match.end() - 1
3768 (endline, endlinenum, endpos) = CloseExpression(clean_lines, linenum, pos)
3769 # Check for an opening brace, either directly after the if or on the next
3770 # line. If found, this isn't a single-statement conditional.
3771 if (not Match(r'\s*{', endline[endpos:])
3772 and not (Match(r'\s*$', endline[endpos:])
3773 and endlinenum < (len(clean_lines.elided) - 1)
3774 and Match(r'\s*{', clean_lines.elided[endlinenum + 1]))):
3775 while (endlinenum < len(clean_lines.elided)
3776 and ';' not in clean_lines.elided[endlinenum][endpos:]):
3777 endlinenum += 1
3778 endpos = 0
3779 if endlinenum < len(clean_lines.elided):
3780 endline = clean_lines.elided[endlinenum]
3781 # We allow a mix of whitespace and closing braces (e.g. for one-liner
3782 # methods) and a single \ after the semicolon (for macros)
3783 endpos = endline.find(';')
3784 if not Match(r';[\s}]*(\\?)$', endline[endpos:]):
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00003785 # Semicolon isn't the last character, there's something trailing.
3786 # Output a warning if the semicolon is not contained inside
3787 # a lambda expression.
3788 if not Match(r'^[^{};]*\[[^\[\]]*\][^{}]*\{[^{}]*\}\s*\)*[;,]\s*$',
3789 endline):
3790 error(filename, linenum, 'readability/braces', 4,
3791 'If/else bodies with multiple statements require braces')
avakulenko@google.com02af6282014-06-04 18:53:25 +00003792 elif endlinenum < len(clean_lines.elided) - 1:
3793 # Make sure the next line is dedented
3794 next_line = clean_lines.elided[endlinenum + 1]
3795 next_indent = GetIndentLevel(next_line)
3796 # With ambiguous nested if statements, this will error out on the
3797 # if that *doesn't* match the else, regardless of whether it's the
3798 # inner one or outer one.
3799 if (if_match and Match(r'\s*else\b', next_line)
3800 and next_indent != if_indent):
3801 error(filename, linenum, 'readability/braces', 4,
3802 'Else clause should be indented at the same level as if. '
3803 'Ambiguous nested if/else chains require braces.')
3804 elif next_indent > if_indent:
3805 error(filename, linenum, 'readability/braces', 4,
3806 'If/else bodies with multiple statements require braces')
3807
3808
3809def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
3810 """Looks for redundant trailing semicolon.
3811
3812 Args:
3813 filename: The name of the current file.
3814 clean_lines: A CleansedLines instance containing the file.
3815 linenum: The number of the line to check.
3816 error: The function to call with any errors found.
3817 """
3818
3819 line = clean_lines.elided[linenum]
3820
erg@google.com2aa59982013-10-28 19:09:25 +00003821 # Block bodies should not be followed by a semicolon. Due to C++11
3822 # brace initialization, there are more places where semicolons are
3823 # required than not, so we use a whitelist approach to check these
3824 # rather than a blacklist. These are the places where "};" should
3825 # be replaced by just "}":
3826 # 1. Some flavor of block following closing parenthesis:
3827 # for (;;) {};
3828 # while (...) {};
3829 # switch (...) {};
3830 # Function(...) {};
3831 # if (...) {};
3832 # if (...) else if (...) {};
3833 #
3834 # 2. else block:
3835 # if (...) else {};
3836 #
3837 # 3. const member function:
3838 # Function(...) const {};
3839 #
3840 # 4. Block following some statement:
3841 # x = 42;
3842 # {};
3843 #
3844 # 5. Block at the beginning of a function:
3845 # Function(...) {
3846 # {};
3847 # }
3848 #
3849 # Note that naively checking for the preceding "{" will also match
3850 # braces inside multi-dimensional arrays, but this is fine since
3851 # that expression will not contain semicolons.
3852 #
3853 # 6. Block following another block:
3854 # while (true) {}
3855 # {};
3856 #
3857 # 7. End of namespaces:
3858 # namespace {};
3859 #
3860 # These semicolons seems far more common than other kinds of
3861 # redundant semicolons, possibly due to people converting classes
3862 # to namespaces. For now we do not warn for this case.
3863 #
3864 # Try matching case 1 first.
3865 match = Match(r'^(.*\)\s*)\{', line)
3866 if match:
3867 # Matched closing parenthesis (case 1). Check the token before the
3868 # matching opening parenthesis, and don't warn if it looks like a
3869 # macro. This avoids these false positives:
3870 # - macro that defines a base class
3871 # - multi-line macro that defines a base class
3872 # - macro that defines the whole class-head
3873 #
3874 # But we still issue warnings for macros that we know are safe to
3875 # warn, specifically:
3876 # - TEST, TEST_F, TEST_P, MATCHER, MATCHER_P
3877 # - TYPED_TEST
3878 # - INTERFACE_DEF
3879 # - EXCLUSIVE_LOCKS_REQUIRED, SHARED_LOCKS_REQUIRED, LOCKS_EXCLUDED:
3880 #
3881 # We implement a whitelist of safe macros instead of a blacklist of
3882 # unsafe macros, even though the latter appears less frequently in
3883 # google code and would have been easier to implement. This is because
3884 # the downside for getting the whitelist wrong means some extra
3885 # semicolons, while the downside for getting the blacklist wrong
3886 # would result in compile errors.
3887 #
avakulenko@google.com554223d2014-12-04 22:00:20 +00003888 # In addition to macros, we also don't want to warn on
3889 # - Compound literals
3890 # - Lambdas
Alex Vakulenko01e47232016-05-06 13:54:15 -07003891 # - alignas specifier with anonymous structs
3892 # - decltype
erg@google.com2aa59982013-10-28 19:09:25 +00003893 closing_brace_pos = match.group(1).rfind(')')
3894 opening_parenthesis = ReverseCloseExpression(
3895 clean_lines, linenum, closing_brace_pos)
3896 if opening_parenthesis[2] > -1:
3897 line_prefix = opening_parenthesis[0][0:opening_parenthesis[2]]
Alex Vakulenko01e47232016-05-06 13:54:15 -07003898 macro = Search(r'\b([A-Z_][A-Z0-9_]*)\s*$', line_prefix)
avakulenko@google.com02af6282014-06-04 18:53:25 +00003899 func = Match(r'^(.*\])\s*$', line_prefix)
erg@google.com2aa59982013-10-28 19:09:25 +00003900 if ((macro and
3901 macro.group(1) not in (
3902 'TEST', 'TEST_F', 'MATCHER', 'MATCHER_P', 'TYPED_TEST',
3903 'EXCLUSIVE_LOCKS_REQUIRED', 'SHARED_LOCKS_REQUIRED',
3904 'LOCKS_EXCLUDED', 'INTERFACE_DEF')) or
avakulenko@google.com02af6282014-06-04 18:53:25 +00003905 (func and not Search(r'\boperator\s*\[\s*\]', func.group(1))) or
avakulenko@google.com554223d2014-12-04 22:00:20 +00003906 Search(r'\b(?:struct|union)\s+alignas\s*$', line_prefix) or
Alex Vakulenko01e47232016-05-06 13:54:15 -07003907 Search(r'\bdecltype$', line_prefix) or
erg@google.com2aa59982013-10-28 19:09:25 +00003908 Search(r'\s+=\s*$', line_prefix)):
3909 match = None
avakulenko@google.com02af6282014-06-04 18:53:25 +00003910 if (match and
3911 opening_parenthesis[1] > 1 and
3912 Search(r'\]\s*$', clean_lines.elided[opening_parenthesis[1] - 1])):
3913 # Multi-line lambda-expression
3914 match = None
erg@google.com2aa59982013-10-28 19:09:25 +00003915
3916 else:
3917 # Try matching cases 2-3.
3918 match = Match(r'^(.*(?:else|\)\s*const)\s*)\{', line)
3919 if not match:
3920 # Try matching cases 4-6. These are always matched on separate lines.
3921 #
3922 # Note that we can't simply concatenate the previous line to the
3923 # current line and do a single match, otherwise we may output
3924 # duplicate warnings for the blank line case:
3925 # if (cond) {
3926 # // blank line
3927 # }
3928 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
3929 if prevline and Search(r'[;{}]\s*$', prevline):
3930 match = Match(r'^(\s*)\{', line)
3931
3932 # Check matching closing brace
3933 if match:
3934 (endline, endlinenum, endpos) = CloseExpression(
3935 clean_lines, linenum, len(match.group(1)))
3936 if endpos > -1 and Match(r'^\s*;', endline[endpos:]):
3937 # Current {} pair is eligible for semicolon check, and we have found
3938 # the redundant semicolon, output warning here.
3939 #
3940 # Note: because we are scanning forward for opening braces, and
3941 # outputting warnings for the matching closing brace, if there are
3942 # nested blocks with trailing semicolons, we will get the error
3943 # messages in reversed order.
Piotr Semenovb7e2ef62016-05-20 18:39:34 +03003944
3945 # We need to check the line forward for NOLINT
3946 raw_lines = clean_lines.raw_lines
3947 ParseNolintSuppressions(filename, raw_lines[endlinenum-1], endlinenum-1,
3948 error)
3949 ParseNolintSuppressions(filename, raw_lines[endlinenum], endlinenum,
3950 error)
3951
erg@google.com2aa59982013-10-28 19:09:25 +00003952 error(filename, endlinenum, 'readability/braces', 4,
3953 "You don't need a ; after a }")
erg@google.com4e00b9a2009-01-12 23:05:11 +00003954
3955
erg@google.comc6671232013-10-25 21:44:03 +00003956def CheckEmptyBlockBody(filename, clean_lines, linenum, error):
3957 """Look for empty loop/conditional body with only a single semicolon.
erg@google.comd350fe52013-01-14 17:51:48 +00003958
3959 Args:
3960 filename: The name of the current file.
3961 clean_lines: A CleansedLines instance containing the file.
3962 linenum: The number of the line to check.
3963 error: The function to call with any errors found.
3964 """
3965
3966 # Search for loop keywords at the beginning of the line. Because only
3967 # whitespaces are allowed before the keywords, this will also ignore most
3968 # do-while-loops, since those lines should start with closing brace.
erg@google.comc6671232013-10-25 21:44:03 +00003969 #
3970 # We also check "if" blocks here, since an empty conditional block
3971 # is likely an error.
erg@google.comd350fe52013-01-14 17:51:48 +00003972 line = clean_lines.elided[linenum]
erg@google.comc6671232013-10-25 21:44:03 +00003973 matched = Match(r'\s*(for|while|if)\s*\(', line)
3974 if matched:
Alex Vakulenko01e47232016-05-06 13:54:15 -07003975 # Find the end of the conditional expression.
erg@google.comd350fe52013-01-14 17:51:48 +00003976 (end_line, end_linenum, end_pos) = CloseExpression(
3977 clean_lines, linenum, line.find('('))
3978
3979 # Output warning if what follows the condition expression is a semicolon.
3980 # No warning for all other cases, including whitespace or newline, since we
3981 # have a separate check for semicolons preceded by whitespace.
3982 if end_pos >= 0 and Match(r';', end_line[end_pos:]):
erg@google.comc6671232013-10-25 21:44:03 +00003983 if matched.group(1) == 'if':
3984 error(filename, end_linenum, 'whitespace/empty_conditional_body', 5,
3985 'Empty conditional bodies should use {}')
3986 else:
3987 error(filename, end_linenum, 'whitespace/empty_loop_body', 5,
3988 'Empty loop bodies should use {} or continue')
erg@google.com4e00b9a2009-01-12 23:05:11 +00003989
Alex Vakulenko01e47232016-05-06 13:54:15 -07003990 # Check for if statements that have completely empty bodies (no comments)
3991 # and no else clauses.
3992 if end_pos >= 0 and matched.group(1) == 'if':
3993 # Find the position of the opening { for the if statement.
3994 # Return without logging an error if it has no brackets.
3995 opening_linenum = end_linenum
3996 opening_line_fragment = end_line[end_pos:]
3997 # Loop until EOF or find anything that's not whitespace or opening {.
3998 while not Search(r'^\s*\{', opening_line_fragment):
3999 if Search(r'^(?!\s*$)', opening_line_fragment):
4000 # Conditional has no brackets.
4001 return
4002 opening_linenum += 1
4003 if opening_linenum == len(clean_lines.elided):
4004 # Couldn't find conditional's opening { or any code before EOF.
4005 return
4006 opening_line_fragment = clean_lines.elided[opening_linenum]
4007 # Set opening_line (opening_line_fragment may not be entire opening line).
4008 opening_line = clean_lines.elided[opening_linenum]
4009
4010 # Find the position of the closing }.
4011 opening_pos = opening_line_fragment.find('{')
4012 if opening_linenum == end_linenum:
4013 # We need to make opening_pos relative to the start of the entire line.
4014 opening_pos += end_pos
4015 (closing_line, closing_linenum, closing_pos) = CloseExpression(
4016 clean_lines, opening_linenum, opening_pos)
4017 if closing_pos < 0:
4018 return
4019
4020 # Now construct the body of the conditional. This consists of the portion
4021 # of the opening line after the {, all lines until the closing line,
4022 # and the portion of the closing line before the }.
4023 if (clean_lines.raw_lines[opening_linenum] !=
4024 CleanseComments(clean_lines.raw_lines[opening_linenum])):
4025 # Opening line ends with a comment, so conditional isn't empty.
4026 return
4027 if closing_linenum > opening_linenum:
4028 # Opening line after the {. Ignore comments here since we checked above.
4029 body = list(opening_line[opening_pos+1:])
4030 # All lines until closing line, excluding closing line, with comments.
4031 body.extend(clean_lines.raw_lines[opening_linenum+1:closing_linenum])
4032 # Closing line before the }. Won't (and can't) have comments.
4033 body.append(clean_lines.elided[closing_linenum][:closing_pos-1])
4034 body = '\n'.join(body)
4035 else:
4036 # If statement has brackets and fits on a single line.
4037 body = opening_line[opening_pos+1:closing_pos-1]
4038
4039 # Check if the body is empty
4040 if not _EMPTY_CONDITIONAL_BODY_PATTERN.search(body):
4041 return
4042 # The body is empty. Now make sure there's not an else clause.
4043 current_linenum = closing_linenum
4044 current_line_fragment = closing_line[closing_pos:]
4045 # Loop until EOF or find anything that's not whitespace or else clause.
4046 while Search(r'^\s*$|^(?=\s*else)', current_line_fragment):
4047 if Search(r'^(?=\s*else)', current_line_fragment):
4048 # Found an else clause, so don't log an error.
4049 return
4050 current_linenum += 1
4051 if current_linenum == len(clean_lines.elided):
4052 break
4053 current_line_fragment = clean_lines.elided[current_linenum]
4054
4055 # The body is empty and there's no else clause until EOF or other code.
4056 error(filename, end_linenum, 'whitespace/empty_if_body', 4,
4057 ('If statement had no body and no else clause'))
4058
erg@google.com4e00b9a2009-01-12 23:05:11 +00004059
avakulenko@google.com02af6282014-06-04 18:53:25 +00004060def FindCheckMacro(line):
4061 """Find a replaceable CHECK-like macro.
4062
4063 Args:
4064 line: line to search on.
4065 Returns:
4066 (macro name, start position), or (None, -1) if no replaceable
4067 macro is found.
4068 """
4069 for macro in _CHECK_MACROS:
4070 i = line.find(macro)
4071 if i >= 0:
4072 # Find opening parenthesis. Do a regular expression match here
4073 # to make sure that we are matching the expected CHECK macro, as
4074 # opposed to some other macro that happens to contain the CHECK
4075 # substring.
4076 matched = Match(r'^(.*\b' + macro + r'\s*)\(', line)
4077 if not matched:
4078 continue
4079 return (macro, len(matched.group(1)))
4080 return (None, -1)
4081
4082
erg@google.com4e00b9a2009-01-12 23:05:11 +00004083def CheckCheck(filename, clean_lines, linenum, error):
4084 """Checks the use of CHECK and EXPECT macros.
4085
4086 Args:
4087 filename: The name of the current file.
4088 clean_lines: A CleansedLines instance containing the file.
4089 linenum: The number of the line to check.
4090 error: The function to call with any errors found.
4091 """
4092
4093 # Decide the set of replacement macros that should be suggested
erg@google.comc6671232013-10-25 21:44:03 +00004094 lines = clean_lines.elided
avakulenko@google.com02af6282014-06-04 18:53:25 +00004095 (check_macro, start_pos) = FindCheckMacro(lines[linenum])
4096 if not check_macro:
erg@google.com4e00b9a2009-01-12 23:05:11 +00004097 return
4098
erg@google.comc6671232013-10-25 21:44:03 +00004099 # Find end of the boolean expression by matching parentheses
4100 (last_line, end_line, end_pos) = CloseExpression(
4101 clean_lines, linenum, start_pos)
4102 if end_pos < 0:
4103 return
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004104
4105 # If the check macro is followed by something other than a
4106 # semicolon, assume users will log their own custom error messages
4107 # and don't suggest any replacements.
4108 if not Match(r'\s*;', last_line[end_pos:]):
4109 return
4110
erg@google.comc6671232013-10-25 21:44:03 +00004111 if linenum == end_line:
4112 expression = lines[linenum][start_pos + 1:end_pos - 1]
4113 else:
4114 expression = lines[linenum][start_pos + 1:]
4115 for i in xrange(linenum + 1, end_line):
4116 expression += lines[i]
4117 expression += last_line[0:end_pos - 1]
erg@google.com4e00b9a2009-01-12 23:05:11 +00004118
erg@google.comc6671232013-10-25 21:44:03 +00004119 # Parse expression so that we can take parentheses into account.
4120 # This avoids false positives for inputs like "CHECK((a < 4) == b)",
4121 # which is not replaceable by CHECK_LE.
4122 lhs = ''
4123 rhs = ''
4124 operator = None
4125 while expression:
4126 matched = Match(r'^\s*(<<|<<=|>>|>>=|->\*|->|&&|\|\||'
4127 r'==|!=|>=|>|<=|<|\()(.*)$', expression)
4128 if matched:
4129 token = matched.group(1)
4130 if token == '(':
4131 # Parenthesized operand
4132 expression = matched.group(2)
avakulenko@google.com02af6282014-06-04 18:53:25 +00004133 (end, _) = FindEndOfExpressionInLine(expression, 0, ['('])
erg@google.comc6671232013-10-25 21:44:03 +00004134 if end < 0:
4135 return # Unmatched parenthesis
4136 lhs += '(' + expression[0:end]
4137 expression = expression[end:]
4138 elif token in ('&&', '||'):
4139 # Logical and/or operators. This means the expression
4140 # contains more than one term, for example:
4141 # CHECK(42 < a && a < b);
4142 #
4143 # These are not replaceable with CHECK_LE, so bail out early.
4144 return
4145 elif token in ('<<', '<<=', '>>', '>>=', '->*', '->'):
4146 # Non-relational operator
4147 lhs += token
4148 expression = matched.group(2)
4149 else:
4150 # Relational operator
4151 operator = token
4152 rhs = matched.group(2)
4153 break
4154 else:
4155 # Unparenthesized operand. Instead of appending to lhs one character
4156 # at a time, we do another regular expression match to consume several
4157 # characters at once if possible. Trivial benchmark shows that this
4158 # is more efficient when the operands are longer than a single
4159 # character, which is generally the case.
4160 matched = Match(r'^([^-=!<>()&|]+)(.*)$', expression)
4161 if not matched:
4162 matched = Match(r'^(\s*\S)(.*)$', expression)
4163 if not matched:
4164 break
4165 lhs += matched.group(1)
4166 expression = matched.group(2)
4167
4168 # Only apply checks if we got all parts of the boolean expression
4169 if not (lhs and operator and rhs):
4170 return
4171
4172 # Check that rhs do not contain logical operators. We already know
4173 # that lhs is fine since the loop above parses out && and ||.
4174 if rhs.find('&&') > -1 or rhs.find('||') > -1:
4175 return
4176
4177 # At least one of the operands must be a constant literal. This is
4178 # to avoid suggesting replacements for unprintable things like
4179 # CHECK(variable != iterator)
4180 #
4181 # The following pattern matches decimal, hex integers, strings, and
4182 # characters (in that order).
4183 lhs = lhs.strip()
4184 rhs = rhs.strip()
4185 match_constant = r'^([-+]?(\d+|0[xX][0-9a-fA-F]+)[lLuU]{0,3}|".*"|\'.*\')$'
4186 if Match(match_constant, lhs) or Match(match_constant, rhs):
4187 # Note: since we know both lhs and rhs, we can provide a more
4188 # descriptive error message like:
4189 # Consider using CHECK_EQ(x, 42) instead of CHECK(x == 42)
4190 # Instead of:
4191 # Consider using CHECK_EQ instead of CHECK(a == b)
4192 #
4193 # We are still keeping the less descriptive message because if lhs
4194 # or rhs gets long, the error message might become unreadable.
4195 error(filename, linenum, 'readability/check', 2,
4196 'Consider using %s instead of %s(a %s b)' % (
4197 _CHECK_REPLACEMENT[check_macro][operator],
4198 check_macro, operator))
erg@google.com4e00b9a2009-01-12 23:05:11 +00004199
4200
erg@google.comd350fe52013-01-14 17:51:48 +00004201def CheckAltTokens(filename, clean_lines, linenum, error):
4202 """Check alternative keywords being used in boolean expressions.
4203
4204 Args:
4205 filename: The name of the current file.
4206 clean_lines: A CleansedLines instance containing the file.
4207 linenum: The number of the line to check.
4208 error: The function to call with any errors found.
4209 """
4210 line = clean_lines.elided[linenum]
4211
4212 # Avoid preprocessor lines
4213 if Match(r'^\s*#', line):
4214 return
4215
4216 # Last ditch effort to avoid multi-line comments. This will not help
4217 # if the comment started before the current line or ended after the
4218 # current line, but it catches most of the false positives. At least,
4219 # it provides a way to workaround this warning for people who use
4220 # multi-line comments in preprocessor macros.
4221 #
4222 # TODO(unknown): remove this once cpplint has better support for
4223 # multi-line comments.
4224 if line.find('/*') >= 0 or line.find('*/') >= 0:
4225 return
4226
4227 for match in _ALT_TOKEN_REPLACEMENT_PATTERN.finditer(line):
4228 error(filename, linenum, 'readability/alt_tokens', 2,
4229 'Use operator %s instead of %s' % (
4230 _ALT_TOKEN_REPLACEMENT[match.group(1)], match.group(1)))
4231
4232
erg@google.com4e00b9a2009-01-12 23:05:11 +00004233def GetLineWidth(line):
4234 """Determines the width of the line in column positions.
4235
4236 Args:
4237 line: A string, which may be a Unicode string.
4238
4239 Returns:
4240 The width of the line in column positions, accounting for Unicode
4241 combining characters and wide characters.
4242 """
4243 if isinstance(line, unicode):
4244 width = 0
erg@google.com8a95ecc2011-09-08 00:45:54 +00004245 for uc in unicodedata.normalize('NFC', line):
4246 if unicodedata.east_asian_width(uc) in ('W', 'F'):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004247 width += 2
erg@google.com8a95ecc2011-09-08 00:45:54 +00004248 elif not unicodedata.combining(uc):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004249 width += 1
4250 return width
4251 else:
4252 return len(line)
4253
4254
erg@google.comd350fe52013-01-14 17:51:48 +00004255def CheckStyle(filename, clean_lines, linenum, file_extension, nesting_state,
erg@google.com8a95ecc2011-09-08 00:45:54 +00004256 error):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004257 """Checks rules from the 'C++ style rules' section of cppguide.html.
4258
4259 Most of these rules are hard to test (naming, comment style), but we
4260 do what we can. In particular we check for 2-space indents, line lengths,
4261 tab usage, spaces inside code, etc.
4262
4263 Args:
4264 filename: The name of the current file.
4265 clean_lines: A CleansedLines instance containing the file.
4266 linenum: The number of the line to check.
4267 file_extension: The extension (without the dot) of the filename.
avakulenko@google.com02af6282014-06-04 18:53:25 +00004268 nesting_state: A NestingState instance which maintains information about
erg@google.comd350fe52013-01-14 17:51:48 +00004269 the current stack of nested blocks being parsed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004270 error: The function to call with any errors found.
4271 """
4272
erg@google.com2aa59982013-10-28 19:09:25 +00004273 # Don't use "elided" lines here, otherwise we can't check commented lines.
4274 # Don't want to use "raw" either, because we don't want to check inside C++11
4275 # raw strings,
4276 raw_lines = clean_lines.lines_without_raw_strings
erg@google.com4e00b9a2009-01-12 23:05:11 +00004277 line = raw_lines[linenum]
Alex Vakulenko01e47232016-05-06 13:54:15 -07004278 prev = raw_lines[linenum - 1] if linenum > 0 else ''
erg@google.com4e00b9a2009-01-12 23:05:11 +00004279
4280 if line.find('\t') != -1:
4281 error(filename, linenum, 'whitespace/tab', 1,
4282 'Tab found; better to use spaces')
4283
4284 # One or three blank spaces at the beginning of the line is weird; it's
4285 # hard to reconcile that with 2-space indents.
4286 # NOTE: here are the conditions rob pike used for his tests. Mine aren't
4287 # as sophisticated, but it may be worth becoming so: RLENGTH==initial_spaces
4288 # if(RLENGTH > 20) complain = 0;
4289 # if(match($0, " +(error|private|public|protected):")) complain = 0;
4290 # if(match(prev, "&& *$")) complain = 0;
4291 # if(match(prev, "\\|\\| *$")) complain = 0;
4292 # if(match(prev, "[\",=><] *$")) complain = 0;
4293 # if(match($0, " <<")) complain = 0;
4294 # if(match(prev, " +for \\(")) complain = 0;
4295 # if(prevodd && match(prevprev, " +for \\(")) complain = 0;
avakulenko@google.com02af6282014-06-04 18:53:25 +00004296 scope_or_label_pattern = r'\s*\w+\s*:\s*\\?$'
4297 classinfo = nesting_state.InnermostClass()
erg@google.com4e00b9a2009-01-12 23:05:11 +00004298 initial_spaces = 0
4299 cleansed_line = clean_lines.elided[linenum]
4300 while initial_spaces < len(line) and line[initial_spaces] == ' ':
4301 initial_spaces += 1
avakulenko@google.com02af6282014-06-04 18:53:25 +00004302 # There are certain situations we allow one space, notably for
4303 # section labels, and also lines containing multi-line raw strings.
Alex Vakulenko01e47232016-05-06 13:54:15 -07004304 # We also don't check for lines that look like continuation lines
4305 # (of lines ending in double quotes, commas, equals, or angle brackets)
4306 # because the rules for how to indent those are non-trivial.
4307 if (not Search(r'[",=><] *$', prev) and
4308 (initial_spaces == 1 or initial_spaces == 3) and
4309 not Match(scope_or_label_pattern, cleansed_line) and
4310 not (clean_lines.raw_lines[linenum] != line and
4311 Match(r'^\s*""', line))):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004312 error(filename, linenum, 'whitespace/indent', 3,
4313 'Weird number of spaces at line-start. '
4314 'Are you using a 2-space indent?')
erg@google.com4e00b9a2009-01-12 23:05:11 +00004315
Alex Vakulenko01e47232016-05-06 13:54:15 -07004316 if line and line[-1].isspace():
4317 error(filename, linenum, 'whitespace/end_of_line', 4,
4318 'Line ends in whitespace. Consider deleting these extra spaces.')
4319
erg@google.com4e00b9a2009-01-12 23:05:11 +00004320 # Check if the line is a header guard.
4321 is_header_guard = False
LukeCz7197a242016-09-24 13:27:35 -05004322 if IsHeaderExtension(file_extension):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004323 cppvar = GetHeaderGuardCPPVariable(filename)
4324 if (line.startswith('#ifndef %s' % cppvar) or
4325 line.startswith('#define %s' % cppvar) or
4326 line.startswith('#endif // %s' % cppvar)):
4327 is_header_guard = True
4328 # #include lines and header guards can be long, since there's no clean way to
4329 # split them.
erg@google.coma87abb82009-02-24 01:41:01 +00004330 #
4331 # URLs can be long too. It's possible to split these, but it makes them
4332 # harder to cut&paste.
erg@google.comd7d27472011-09-07 17:36:35 +00004333 #
4334 # The "$Id:...$" comment may also get very long without it being the
4335 # developers fault.
erg@google.coma87abb82009-02-24 01:41:01 +00004336 if (not line.startswith('#include') and not is_header_guard and
erg@google.comd7d27472011-09-07 17:36:35 +00004337 not Match(r'^\s*//.*http(s?)://\S*$', line) and
Alex Vakulenko01e47232016-05-06 13:54:15 -07004338 not Match(r'^\s*//\s*[^\s]*$', line) and
erg@google.comd7d27472011-09-07 17:36:35 +00004339 not Match(r'^// \$Id:.*#[0-9]+ \$$', line)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004340 line_width = GetLineWidth(line)
Alex Vakulenko01e47232016-05-06 13:54:15 -07004341 if line_width > _line_length:
erg@google.com4e00b9a2009-01-12 23:05:11 +00004342 error(filename, linenum, 'whitespace/line_length', 2,
erg@google.comab53edf2013-11-05 22:23:37 +00004343 'Lines should be <= %i characters long' % _line_length)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004344
4345 if (cleansed_line.count(';') > 1 and
4346 # for loops are allowed two ;'s (and may run over two lines).
4347 cleansed_line.find('for') == -1 and
4348 (GetPreviousNonBlankLine(clean_lines, linenum)[0].find('for') == -1 or
4349 GetPreviousNonBlankLine(clean_lines, linenum)[0].find(';') != -1) and
4350 # It's ok to have many commands in a switch case that fits in 1 line
4351 not ((cleansed_line.find('case ') != -1 or
4352 cleansed_line.find('default:') != -1) and
4353 cleansed_line.find('break;') != -1)):
erg@google.comd350fe52013-01-14 17:51:48 +00004354 error(filename, linenum, 'whitespace/newline', 0,
erg@google.com4e00b9a2009-01-12 23:05:11 +00004355 'More than one command on the same line')
4356
4357 # Some more style checks
4358 CheckBraces(filename, clean_lines, linenum, error)
avakulenko@google.com02af6282014-06-04 18:53:25 +00004359 CheckTrailingSemicolon(filename, clean_lines, linenum, error)
erg@google.comc6671232013-10-25 21:44:03 +00004360 CheckEmptyBlockBody(filename, clean_lines, linenum, error)
erg@google.comd350fe52013-01-14 17:51:48 +00004361 CheckSpacing(filename, clean_lines, linenum, nesting_state, error)
avakulenko@google.com02af6282014-06-04 18:53:25 +00004362 CheckOperatorSpacing(filename, clean_lines, linenum, error)
4363 CheckParenthesisSpacing(filename, clean_lines, linenum, error)
4364 CheckCommaSpacing(filename, clean_lines, linenum, error)
Alex Vakulenko01e47232016-05-06 13:54:15 -07004365 CheckBracesSpacing(filename, clean_lines, linenum, nesting_state, error)
avakulenko@google.com02af6282014-06-04 18:53:25 +00004366 CheckSpacingForFunctionCall(filename, clean_lines, linenum, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004367 CheckCheck(filename, clean_lines, linenum, error)
erg@google.comd350fe52013-01-14 17:51:48 +00004368 CheckAltTokens(filename, clean_lines, linenum, error)
4369 classinfo = nesting_state.InnermostClass()
4370 if classinfo:
4371 CheckSectionSpacing(filename, clean_lines, classinfo, linenum, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004372
4373
erg@google.com4e00b9a2009-01-12 23:05:11 +00004374_RE_PATTERN_INCLUDE = re.compile(r'^\s*#\s*include\s*([<"])([^>"]*)[>"].*$')
4375# Matches the first component of a filename delimited by -s and _s. That is:
4376# _RE_FIRST_COMPONENT.match('foo').group(0) == 'foo'
4377# _RE_FIRST_COMPONENT.match('foo.cc').group(0) == 'foo'
4378# _RE_FIRST_COMPONENT.match('foo-bar_baz.cc').group(0) == 'foo'
4379# _RE_FIRST_COMPONENT.match('foo_bar-baz.cc').group(0) == 'foo'
4380_RE_FIRST_COMPONENT = re.compile(r'^[^-_.]+')
4381
4382
4383def _DropCommonSuffixes(filename):
4384 """Drops common suffixes like _test.cc or -inl.h from filename.
4385
4386 For example:
4387 >>> _DropCommonSuffixes('foo/foo-inl.h')
4388 'foo/foo'
4389 >>> _DropCommonSuffixes('foo/bar/foo.cc')
4390 'foo/bar/foo'
4391 >>> _DropCommonSuffixes('foo/foo_internal.h')
4392 'foo/foo'
4393 >>> _DropCommonSuffixes('foo/foo_unusualinternal.h')
4394 'foo/foo_unusualinternal'
4395
4396 Args:
4397 filename: The input filename.
4398
4399 Returns:
4400 The filename with the common suffix removed.
4401 """
4402 for suffix in ('test.cc', 'regtest.cc', 'unittest.cc',
4403 'inl.h', 'impl.h', 'internal.h'):
4404 if (filename.endswith(suffix) and len(filename) > len(suffix) and
4405 filename[-len(suffix) - 1] in ('-', '_')):
4406 return filename[:-len(suffix) - 1]
4407 return os.path.splitext(filename)[0]
4408
4409
erg@google.com4e00b9a2009-01-12 23:05:11 +00004410def _ClassifyInclude(fileinfo, include, is_system):
4411 """Figures out what kind of header 'include' is.
4412
4413 Args:
4414 fileinfo: The current file cpplint is running over. A FileInfo instance.
4415 include: The path to a #included file.
4416 is_system: True if the #include used <> rather than "".
4417
4418 Returns:
4419 One of the _XXX_HEADER constants.
4420
4421 For example:
4422 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'stdio.h', True)
4423 _C_SYS_HEADER
4424 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'string', True)
4425 _CPP_SYS_HEADER
4426 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/foo.h', False)
4427 _LIKELY_MY_HEADER
4428 >>> _ClassifyInclude(FileInfo('foo/foo_unknown_extension.cc'),
4429 ... 'bar/foo_other_ext.h', False)
4430 _POSSIBLE_MY_HEADER
4431 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/bar.h', False)
4432 _OTHER_HEADER
4433 """
4434 # This is a list of all standard c++ header files, except
4435 # those already checked for above.
erg@google.comfd5da632013-10-25 17:39:45 +00004436 is_cpp_h = include in _CPP_HEADERS
erg@google.com4e00b9a2009-01-12 23:05:11 +00004437
4438 if is_system:
4439 if is_cpp_h:
4440 return _CPP_SYS_HEADER
4441 else:
4442 return _C_SYS_HEADER
4443
4444 # If the target file and the include we're checking share a
4445 # basename when we drop common extensions, and the include
4446 # lives in . , then it's likely to be owned by the target file.
4447 target_dir, target_base = (
4448 os.path.split(_DropCommonSuffixes(fileinfo.RepositoryName())))
4449 include_dir, include_base = os.path.split(_DropCommonSuffixes(include))
4450 if target_base == include_base and (
4451 include_dir == target_dir or
4452 include_dir == os.path.normpath(target_dir + '/../public')):
4453 return _LIKELY_MY_HEADER
4454
4455 # If the target and include share some initial basename
4456 # component, it's possible the target is implementing the
4457 # include, so it's allowed to be first, but we'll never
4458 # complain if it's not there.
4459 target_first_component = _RE_FIRST_COMPONENT.match(target_base)
4460 include_first_component = _RE_FIRST_COMPONENT.match(include_base)
4461 if (target_first_component and include_first_component and
4462 target_first_component.group(0) ==
4463 include_first_component.group(0)):
4464 return _POSSIBLE_MY_HEADER
4465
4466 return _OTHER_HEADER
4467
4468
erg@google.coma87abb82009-02-24 01:41:01 +00004469
erg@google.come35f7652009-06-19 20:52:09 +00004470def CheckIncludeLine(filename, clean_lines, linenum, include_state, error):
4471 """Check rules that are applicable to #include lines.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004472
erg@google.come35f7652009-06-19 20:52:09 +00004473 Strings on #include lines are NOT removed from elided line, to make
4474 certain tasks easier. However, to prevent false positives, checks
4475 applicable to #include lines in CheckLanguage must be put here.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004476
4477 Args:
4478 filename: The name of the current file.
4479 clean_lines: A CleansedLines instance containing the file.
4480 linenum: The number of the line to check.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004481 include_state: An _IncludeState instance in which the headers are inserted.
4482 error: The function to call with any errors found.
4483 """
4484 fileinfo = FileInfo(filename)
erg@google.come35f7652009-06-19 20:52:09 +00004485 line = clean_lines.lines[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00004486
4487 # "include" should use the new style "foo/bar.h" instead of just "bar.h"
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004488 # Only do this check if the included header follows google naming
4489 # conventions. If not, assume that it's a 3rd party API that
4490 # requires special include conventions.
4491 #
4492 # We also make an exception for Lua headers, which follow google
4493 # naming convention but not the include convention.
4494 match = Match(r'#include\s*"([^/]+\.h)"', line)
4495 if match and not _THIRD_PARTY_HEADERS_PATTERN.match(match.group(1)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004496 error(filename, linenum, 'build/include', 4,
4497 'Include the directory when naming .h files')
4498
4499 # we shouldn't include a file more than once. actually, there are a
4500 # handful of instances where doing so is okay, but in general it's
4501 # not.
erg@google.come35f7652009-06-19 20:52:09 +00004502 match = _RE_PATTERN_INCLUDE.search(line)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004503 if match:
4504 include = match.group(2)
4505 is_system = (match.group(1) == '<')
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004506 duplicate_line = include_state.FindHeader(include)
4507 if duplicate_line >= 0:
erg@google.com4e00b9a2009-01-12 23:05:11 +00004508 error(filename, linenum, 'build/include', 4,
4509 '"%s" already included at %s:%s' %
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004510 (include, filename, duplicate_line))
avakulenko@google.com554223d2014-12-04 22:00:20 +00004511 elif (include.endswith('.cc') and
4512 os.path.dirname(fileinfo.RepositoryName()) != os.path.dirname(include)):
4513 error(filename, linenum, 'build/include', 4,
4514 'Do not include .cc files from other packages')
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004515 elif not _THIRD_PARTY_HEADERS_PATTERN.match(include):
4516 include_state.include_list[-1].append((include, linenum))
erg@google.com4e00b9a2009-01-12 23:05:11 +00004517
4518 # We want to ensure that headers appear in the right order:
4519 # 1) for foo.cc, foo.h (preferred location)
4520 # 2) c system files
4521 # 3) cpp system files
4522 # 4) for foo.cc, foo.h (deprecated location)
4523 # 5) other google headers
4524 #
4525 # We classify each include statement as one of those 5 types
4526 # using a number of techniques. The include_state object keeps
4527 # track of the highest type seen, and complains if we see a
4528 # lower type after that.
4529 error_message = include_state.CheckNextIncludeOrder(
4530 _ClassifyInclude(fileinfo, include, is_system))
4531 if error_message:
4532 error(filename, linenum, 'build/include_order', 4,
4533 '%s. Should be: %s.h, c system, c++ system, other.' %
4534 (error_message, fileinfo.BaseName()))
erg@google.comfd5da632013-10-25 17:39:45 +00004535 canonical_include = include_state.CanonicalizeAlphabeticalOrder(include)
4536 if not include_state.IsInAlphabeticalOrder(
4537 clean_lines, linenum, canonical_include):
erg@google.coma868d2d2009-10-09 21:18:45 +00004538 error(filename, linenum, 'build/include_alpha', 4,
4539 'Include "%s" not in alphabetical order' % include)
erg@google.comfd5da632013-10-25 17:39:45 +00004540 include_state.SetLastHeader(canonical_include)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004541
erg@google.come35f7652009-06-19 20:52:09 +00004542
erg@google.com8a95ecc2011-09-08 00:45:54 +00004543
4544def _GetTextInside(text, start_pattern):
erg@google.com2aa59982013-10-28 19:09:25 +00004545 r"""Retrieves all the text between matching open and close parentheses.
erg@google.com8a95ecc2011-09-08 00:45:54 +00004546
4547 Given a string of lines and a regular expression string, retrieve all the text
4548 following the expression and between opening punctuation symbols like
4549 (, [, or {, and the matching close-punctuation symbol. This properly nested
4550 occurrences of the punctuations, so for the text like
4551 printf(a(), b(c()));
4552 a call to _GetTextInside(text, r'printf\(') will return 'a(), b(c())'.
4553 start_pattern must match string having an open punctuation symbol at the end.
4554
4555 Args:
4556 text: The lines to extract text. Its comments and strings must be elided.
4557 It can be single line and can span multiple lines.
4558 start_pattern: The regexp string indicating where to start extracting
4559 the text.
4560 Returns:
4561 The extracted text.
4562 None if either the opening string or ending punctuation could not be found.
4563 """
avakulenko@google.com02af6282014-06-04 18:53:25 +00004564 # TODO(unknown): Audit cpplint.py to see what places could be profitably
erg@google.com8a95ecc2011-09-08 00:45:54 +00004565 # rewritten to use _GetTextInside (and use inferior regexp matching today).
4566
4567 # Give opening punctuations to get the matching close-punctuations.
4568 matching_punctuation = {'(': ')', '{': '}', '[': ']'}
4569 closing_punctuation = set(matching_punctuation.itervalues())
4570
4571 # Find the position to start extracting text.
4572 match = re.search(start_pattern, text, re.M)
4573 if not match: # start_pattern not found in text.
4574 return None
4575 start_position = match.end(0)
4576
4577 assert start_position > 0, (
4578 'start_pattern must ends with an opening punctuation.')
4579 assert text[start_position - 1] in matching_punctuation, (
4580 'start_pattern must ends with an opening punctuation.')
4581 # Stack of closing punctuations we expect to have in text after position.
4582 punctuation_stack = [matching_punctuation[text[start_position - 1]]]
4583 position = start_position
4584 while punctuation_stack and position < len(text):
4585 if text[position] == punctuation_stack[-1]:
4586 punctuation_stack.pop()
4587 elif text[position] in closing_punctuation:
4588 # A closing punctuation without matching opening punctuations.
4589 return None
4590 elif text[position] in matching_punctuation:
4591 punctuation_stack.append(matching_punctuation[text[position]])
4592 position += 1
4593 if punctuation_stack:
4594 # Opening punctuations left without matching close-punctuations.
4595 return None
4596 # punctuations match.
4597 return text[start_position:position - 1]
4598
4599
erg@google.comfd5da632013-10-25 17:39:45 +00004600# Patterns for matching call-by-reference parameters.
erg@google.com2aa59982013-10-28 19:09:25 +00004601#
4602# Supports nested templates up to 2 levels deep using this messy pattern:
4603# < (?: < (?: < [^<>]*
4604# >
4605# | [^<>] )*
4606# >
4607# | [^<>] )*
4608# >
erg@google.comfd5da632013-10-25 17:39:45 +00004609_RE_PATTERN_IDENT = r'[_a-zA-Z]\w*' # =~ [[:alpha:]][[:alnum:]]*
4610_RE_PATTERN_TYPE = (
4611 r'(?:const\s+)?(?:typename\s+|class\s+|struct\s+|union\s+|enum\s+)?'
erg@google.com2aa59982013-10-28 19:09:25 +00004612 r'(?:\w|'
4613 r'\s*<(?:<(?:<[^<>]*>|[^<>])*>|[^<>])*>|'
4614 r'::)+')
erg@google.comfd5da632013-10-25 17:39:45 +00004615# A call-by-reference parameter ends with '& identifier'.
4616_RE_PATTERN_REF_PARAM = re.compile(
4617 r'(' + _RE_PATTERN_TYPE + r'(?:\s*(?:\bconst\b|[*]))*\s*'
4618 r'&\s*' + _RE_PATTERN_IDENT + r')\s*(?:=[^,()]+)?[,)]')
4619# A call-by-const-reference parameter either ends with 'const& identifier'
4620# or looks like 'const type& identifier' when 'type' is atomic.
4621_RE_PATTERN_CONST_REF_PARAM = (
4622 r'(?:.*\s*\bconst\s*&\s*' + _RE_PATTERN_IDENT +
4623 r'|const\s+' + _RE_PATTERN_TYPE + r'\s*&\s*' + _RE_PATTERN_IDENT + r')')
Alex Vakulenko01e47232016-05-06 13:54:15 -07004624# Stream types.
4625_RE_PATTERN_REF_STREAM_PARAM = (
4626 r'(?:.*stream\s*&\s*' + _RE_PATTERN_IDENT + r')')
erg@google.comfd5da632013-10-25 17:39:45 +00004627
4628
4629def CheckLanguage(filename, clean_lines, linenum, file_extension,
4630 include_state, nesting_state, error):
erg@google.come35f7652009-06-19 20:52:09 +00004631 """Checks rules from the 'C++ language rules' section of cppguide.html.
4632
4633 Some of these rules are hard to test (function overloading, using
4634 uint32 inappropriately), but we do the best we can.
4635
4636 Args:
4637 filename: The name of the current file.
4638 clean_lines: A CleansedLines instance containing the file.
4639 linenum: The number of the line to check.
4640 file_extension: The extension (without the dot) of the filename.
4641 include_state: An _IncludeState instance in which the headers are inserted.
avakulenko@google.com02af6282014-06-04 18:53:25 +00004642 nesting_state: A NestingState instance which maintains information about
erg@google.comfd5da632013-10-25 17:39:45 +00004643 the current stack of nested blocks being parsed.
erg@google.come35f7652009-06-19 20:52:09 +00004644 error: The function to call with any errors found.
4645 """
erg@google.com4e00b9a2009-01-12 23:05:11 +00004646 # If the line is empty or consists of entirely a comment, no need to
4647 # check it.
4648 line = clean_lines.elided[linenum]
4649 if not line:
4650 return
4651
erg@google.come35f7652009-06-19 20:52:09 +00004652 match = _RE_PATTERN_INCLUDE.search(line)
4653 if match:
4654 CheckIncludeLine(filename, clean_lines, linenum, include_state, error)
4655 return
4656
erg@google.com2aa59982013-10-28 19:09:25 +00004657 # Reset include state across preprocessor directives. This is meant
4658 # to silence warnings for conditional includes.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004659 match = Match(r'^\s*#\s*(if|ifdef|ifndef|elif|else|endif)\b', line)
4660 if match:
4661 include_state.ResetSection(match.group(1))
erg@google.com2aa59982013-10-28 19:09:25 +00004662
erg@google.com4e00b9a2009-01-12 23:05:11 +00004663 # Make Windows paths like Unix.
4664 fullname = os.path.abspath(filename).replace('\\', '/')
Alex Vakulenko01e47232016-05-06 13:54:15 -07004665
avakulenko@google.com02af6282014-06-04 18:53:25 +00004666 # Perform other checks now that we are sure that this is not an include line
4667 CheckCasts(filename, clean_lines, linenum, error)
4668 CheckGlobalStatic(filename, clean_lines, linenum, error)
4669 CheckPrintf(filename, clean_lines, linenum, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004670
LukeCz7197a242016-09-24 13:27:35 -05004671 if IsHeaderExtension(file_extension):
erg@google.com4e00b9a2009-01-12 23:05:11 +00004672 # TODO(unknown): check that 1-arg constructors are explicit.
4673 # How to tell it's a constructor?
4674 # (handled in CheckForNonStandardConstructs for now)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004675 # TODO(unknown): check that classes declare or disable copy/assign
erg@google.com4e00b9a2009-01-12 23:05:11 +00004676 # (level 1 error)
4677 pass
4678
4679 # Check if people are using the verboten C basic types. The only exception
4680 # we regularly allow is "unsigned short port" for port.
4681 if Search(r'\bshort port\b', line):
4682 if not Search(r'\bunsigned short port\b', line):
4683 error(filename, linenum, 'runtime/int', 4,
4684 'Use "unsigned short" for ports, not "short"')
4685 else:
4686 match = Search(r'\b(short|long(?! +double)|long long)\b', line)
4687 if match:
4688 error(filename, linenum, 'runtime/int', 4,
4689 'Use int16/int64/etc, rather than the C type %s' % match.group(1))
4690
erg@google.coma868d2d2009-10-09 21:18:45 +00004691 # Check if some verboten operator overloading is going on
4692 # TODO(unknown): catch out-of-line unary operator&:
4693 # class X {};
4694 # int operator&(const X& x) { return 42; } // unary operator&
4695 # The trick is it's hard to tell apart from binary operator&:
4696 # class Y { int operator&(const Y& x) { return 23; } }; // binary operator&
4697 if Search(r'\boperator\s*&\s*\(\s*\)', line):
4698 error(filename, linenum, 'runtime/operator', 4,
4699 'Unary operator& is dangerous. Do not use it.')
4700
erg@google.com4e00b9a2009-01-12 23:05:11 +00004701 # Check for suspicious usage of "if" like
4702 # } if (a == b) {
4703 if Search(r'\}\s*if\s*\(', line):
4704 error(filename, linenum, 'readability/braces', 4,
4705 'Did you mean "else if"? If not, start a new line for "if".')
4706
4707 # Check for potential format string bugs like printf(foo).
4708 # We constrain the pattern not to pick things like DocidForPrintf(foo).
4709 # Not perfect but it can catch printf(foo.c_str()) and printf(foo->c_str())
avakulenko@google.com02af6282014-06-04 18:53:25 +00004710 # TODO(unknown): Catch the following case. Need to change the calling
erg@google.com8a95ecc2011-09-08 00:45:54 +00004711 # convention of the whole function to process multiple line to handle it.
4712 # printf(
4713 # boy_this_is_a_really_long_variable_that_cannot_fit_on_the_prev_line);
4714 printf_args = _GetTextInside(line, r'(?i)\b(string)?printf\s*\(')
4715 if printf_args:
4716 match = Match(r'([\w.\->()]+)$', printf_args)
erg@google.comd350fe52013-01-14 17:51:48 +00004717 if match and match.group(1) != '__VA_ARGS__':
erg@google.com8a95ecc2011-09-08 00:45:54 +00004718 function_name = re.search(r'\b((?:string)?printf)\s*\(',
4719 line, re.I).group(1)
4720 error(filename, linenum, 'runtime/printf', 4,
4721 'Potential format string bug. Do %s("%%s", %s) instead.'
4722 % (function_name, match.group(1)))
erg@google.com4e00b9a2009-01-12 23:05:11 +00004723
4724 # Check for potential memset bugs like memset(buf, sizeof(buf), 0).
4725 match = Search(r'memset\s*\(([^,]*),\s*([^,]*),\s*0\s*\)', line)
4726 if match and not Match(r"^''|-?[0-9]+|0x[0-9A-Fa-f]$", match.group(2)):
4727 error(filename, linenum, 'runtime/memset', 4,
4728 'Did you mean "memset(%s, 0, %s)"?'
4729 % (match.group(1), match.group(2)))
4730
4731 if Search(r'\busing namespace\b', line):
4732 error(filename, linenum, 'build/namespaces', 5,
4733 'Do not use namespace using-directives. '
4734 'Use using-declarations instead.')
4735
4736 # Detect variable-length arrays.
4737 match = Match(r'\s*(.+::)?(\w+) [a-z]\w*\[(.+)];', line)
4738 if (match and match.group(2) != 'return' and match.group(2) != 'delete' and
4739 match.group(3).find(']') == -1):
4740 # Split the size using space and arithmetic operators as delimiters.
4741 # If any of the resulting tokens are not compile time constants then
4742 # report the error.
4743 tokens = re.split(r'\s|\+|\-|\*|\/|<<|>>]', match.group(3))
4744 is_const = True
4745 skip_next = False
4746 for tok in tokens:
4747 if skip_next:
4748 skip_next = False
4749 continue
4750
4751 if Search(r'sizeof\(.+\)', tok): continue
4752 if Search(r'arraysize\(\w+\)', tok): continue
4753
4754 tok = tok.lstrip('(')
4755 tok = tok.rstrip(')')
4756 if not tok: continue
4757 if Match(r'\d+', tok): continue
4758 if Match(r'0[xX][0-9a-fA-F]+', tok): continue
4759 if Match(r'k[A-Z0-9]\w*', tok): continue
4760 if Match(r'(.+::)?k[A-Z0-9]\w*', tok): continue
4761 if Match(r'(.+::)?[A-Z][A-Z0-9_]*', tok): continue
4762 # A catch all for tricky sizeof cases, including 'sizeof expression',
4763 # 'sizeof(*type)', 'sizeof(const type)', 'sizeof(struct StructName)'
erg@google.com8a95ecc2011-09-08 00:45:54 +00004764 # requires skipping the next token because we split on ' ' and '*'.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004765 if tok.startswith('sizeof'):
4766 skip_next = True
4767 continue
4768 is_const = False
4769 break
4770 if not is_const:
4771 error(filename, linenum, 'runtime/arrays', 1,
4772 'Do not use variable-length arrays. Use an appropriately named '
4773 "('k' followed by CamelCase) compile-time constant for the size.")
4774
erg@google.com4e00b9a2009-01-12 23:05:11 +00004775 # Check for use of unnamed namespaces in header files. Registration
4776 # macros are typically OK, so we allow use of "namespace {" on lines
4777 # that end with backslashes.
LukeCz7197a242016-09-24 13:27:35 -05004778 if (IsHeaderExtension(file_extension)
erg@google.com4e00b9a2009-01-12 23:05:11 +00004779 and Search(r'\bnamespace\s*{', line)
4780 and line[-1] != '\\'):
4781 error(filename, linenum, 'build/namespaces', 4,
4782 'Do not use unnamed namespaces in header files. See '
Ackermann Yuriy79692902016-04-01 21:41:34 +13004783 'https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces'
erg@google.com4e00b9a2009-01-12 23:05:11 +00004784 ' for more information.')
4785
avakulenko@google.com02af6282014-06-04 18:53:25 +00004786
4787def CheckGlobalStatic(filename, clean_lines, linenum, error):
4788 """Check for unsafe global or static objects.
4789
4790 Args:
4791 filename: The name of the current file.
4792 clean_lines: A CleansedLines instance containing the file.
4793 linenum: The number of the line to check.
4794 error: The function to call with any errors found.
4795 """
4796 line = clean_lines.elided[linenum]
4797
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004798 # Match two lines at a time to support multiline declarations
4799 if linenum + 1 < clean_lines.NumLines() and not Search(r'[;({]', line):
4800 line += clean_lines.elided[linenum + 1].strip()
4801
avakulenko@google.com02af6282014-06-04 18:53:25 +00004802 # Check for people declaring static/global STL strings at the top level.
4803 # This is dangerous because the C++ language does not guarantee that
Alex Vakulenko01e47232016-05-06 13:54:15 -07004804 # globals with constructors are initialized before the first access, and
4805 # also because globals can be destroyed when some threads are still running.
4806 # TODO(unknown): Generalize this to also find static unique_ptr instances.
4807 # TODO(unknown): File bugs for clang-tidy to find these.
avakulenko@google.com02af6282014-06-04 18:53:25 +00004808 match = Match(
Alex Vakulenko01e47232016-05-06 13:54:15 -07004809 r'((?:|static +)(?:|const +))(?::*std::)?string( +const)? +'
4810 r'([a-zA-Z0-9_:]+)\b(.*)',
avakulenko@google.com02af6282014-06-04 18:53:25 +00004811 line)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004812
avakulenko@google.com02af6282014-06-04 18:53:25 +00004813 # Remove false positives:
4814 # - String pointers (as opposed to values).
4815 # string *pointer
4816 # const string *pointer
4817 # string const *pointer
4818 # string *const pointer
4819 #
4820 # - Functions and template specializations.
4821 # string Function<Type>(...
4822 # string Class<Type>::Method(...
4823 #
4824 # - Operators. These are matched separately because operator names
4825 # cross non-word boundaries, and trying to match both operators
4826 # and functions at the same time would decrease accuracy of
4827 # matching identifiers.
4828 # string Class::operator*()
4829 if (match and
Alex Vakulenko01e47232016-05-06 13:54:15 -07004830 not Search(r'\bstring\b(\s+const)?\s*[\*\&]\s*(const\s+)?\w', line) and
avakulenko@google.com02af6282014-06-04 18:53:25 +00004831 not Search(r'\boperator\W', line) and
Alex Vakulenko01e47232016-05-06 13:54:15 -07004832 not Match(r'\s*(<.*>)?(::[a-zA-Z0-9_]+)*\s*\(([^"]|$)', match.group(4))):
4833 if Search(r'\bconst\b', line):
4834 error(filename, linenum, 'runtime/string', 4,
4835 'For a static/global string constant, use a C style string '
4836 'instead: "%schar%s %s[]".' %
4837 (match.group(1), match.group(2) or '', match.group(3)))
4838 else:
4839 error(filename, linenum, 'runtime/string', 4,
4840 'Static/global string variables are not permitted.')
avakulenko@google.com02af6282014-06-04 18:53:25 +00004841
Alex Vakulenko01e47232016-05-06 13:54:15 -07004842 if (Search(r'\b([A-Za-z0-9_]*_)\(\1\)', line) or
4843 Search(r'\b([A-Za-z0-9_]*_)\(CHECK_NOTNULL\(\1\)\)', line)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00004844 error(filename, linenum, 'runtime/init', 4,
4845 'You seem to be initializing a member variable with itself.')
4846
4847
4848def CheckPrintf(filename, clean_lines, linenum, error):
4849 """Check for printf related issues.
4850
4851 Args:
4852 filename: The name of the current file.
4853 clean_lines: A CleansedLines instance containing the file.
4854 linenum: The number of the line to check.
4855 error: The function to call with any errors found.
4856 """
4857 line = clean_lines.elided[linenum]
4858
4859 # When snprintf is used, the second argument shouldn't be a literal.
4860 match = Search(r'snprintf\s*\(([^,]*),\s*([0-9]*)\s*,', line)
4861 if match and match.group(2) != '0':
4862 # If 2nd arg is zero, snprintf is used to calculate size.
4863 error(filename, linenum, 'runtime/printf', 3,
4864 'If you can, use sizeof(%s) instead of %s as the 2nd arg '
4865 'to snprintf.' % (match.group(1), match.group(2)))
4866
4867 # Check if some verboten C functions are being used.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004868 if Search(r'\bsprintf\s*\(', line):
avakulenko@google.com02af6282014-06-04 18:53:25 +00004869 error(filename, linenum, 'runtime/printf', 5,
4870 'Never use sprintf. Use snprintf instead.')
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004871 match = Search(r'\b(strcpy|strcat)\s*\(', line)
avakulenko@google.com02af6282014-06-04 18:53:25 +00004872 if match:
4873 error(filename, linenum, 'runtime/printf', 4,
4874 'Almost always, snprintf is better than %s' % match.group(1))
4875
4876
4877def IsDerivedFunction(clean_lines, linenum):
4878 """Check if current line contains an inherited function.
4879
4880 Args:
4881 clean_lines: A CleansedLines instance containing the file.
4882 linenum: The number of the line to check.
4883 Returns:
4884 True if current line contains a function with "override"
4885 virt-specifier.
4886 """
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00004887 # Scan back a few lines for start of current function
4888 for i in xrange(linenum, max(-1, linenum - 10), -1):
4889 match = Match(r'^([^()]*\w+)\(', clean_lines.elided[i])
4890 if match:
4891 # Look for "override" after the matching closing parenthesis
4892 line, _, closing_paren = CloseExpression(
4893 clean_lines, i, len(match.group(1)))
4894 return (closing_paren >= 0 and
4895 Search(r'\boverride\b', line[closing_paren:]))
4896 return False
avakulenko@google.com02af6282014-06-04 18:53:25 +00004897
4898
avakulenko@google.com554223d2014-12-04 22:00:20 +00004899def IsOutOfLineMethodDefinition(clean_lines, linenum):
4900 """Check if current line contains an out-of-line method definition.
4901
4902 Args:
4903 clean_lines: A CleansedLines instance containing the file.
4904 linenum: The number of the line to check.
4905 Returns:
4906 True if current line contains an out-of-line method definition.
4907 """
4908 # Scan back a few lines for start of current function
4909 for i in xrange(linenum, max(-1, linenum - 10), -1):
4910 if Match(r'^([^()]*\w+)\(', clean_lines.elided[i]):
4911 return Match(r'^[^()]*\w+::\w+\(', clean_lines.elided[i]) is not None
4912 return False
4913
4914
avakulenko@google.com02af6282014-06-04 18:53:25 +00004915def IsInitializerList(clean_lines, linenum):
4916 """Check if current line is inside constructor initializer list.
4917
4918 Args:
4919 clean_lines: A CleansedLines instance containing the file.
4920 linenum: The number of the line to check.
4921 Returns:
4922 True if current line appears to be inside constructor initializer
4923 list, False otherwise.
4924 """
4925 for i in xrange(linenum, 1, -1):
4926 line = clean_lines.elided[i]
4927 if i == linenum:
4928 remove_function_body = Match(r'^(.*)\{\s*$', line)
4929 if remove_function_body:
4930 line = remove_function_body.group(1)
4931
4932 if Search(r'\s:\s*\w+[({]', line):
4933 # A lone colon tend to indicate the start of a constructor
4934 # initializer list. It could also be a ternary operator, which
4935 # also tend to appear in constructor initializer lists as
4936 # opposed to parameter lists.
4937 return True
4938 if Search(r'\}\s*,\s*$', line):
4939 # A closing brace followed by a comma is probably the end of a
4940 # brace-initialized member in constructor initializer list.
4941 return True
4942 if Search(r'[{};]\s*$', line):
4943 # Found one of the following:
4944 # - A closing brace or semicolon, probably the end of the previous
4945 # function.
4946 # - An opening brace, probably the start of current class or namespace.
4947 #
4948 # Current line is probably not inside an initializer list since
4949 # we saw one of those things without seeing the starting colon.
4950 return False
4951
4952 # Got to the beginning of the file without seeing the start of
4953 # constructor initializer list.
4954 return False
4955
4956
erg@google.comc6671232013-10-25 21:44:03 +00004957def CheckForNonConstReference(filename, clean_lines, linenum,
4958 nesting_state, error):
4959 """Check for non-const references.
4960
4961 Separate from CheckLanguage since it scans backwards from current
4962 line, instead of scanning forward.
4963
4964 Args:
4965 filename: The name of the current file.
4966 clean_lines: A CleansedLines instance containing the file.
4967 linenum: The number of the line to check.
avakulenko@google.com02af6282014-06-04 18:53:25 +00004968 nesting_state: A NestingState instance which maintains information about
erg@google.comc6671232013-10-25 21:44:03 +00004969 the current stack of nested blocks being parsed.
4970 error: The function to call with any errors found.
4971 """
4972 # Do nothing if there is no '&' on current line.
4973 line = clean_lines.elided[linenum]
4974 if '&' not in line:
4975 return
4976
avakulenko@google.com02af6282014-06-04 18:53:25 +00004977 # If a function is inherited, current function doesn't have much of
4978 # a choice, so any non-const references should not be blamed on
4979 # derived function.
4980 if IsDerivedFunction(clean_lines, linenum):
4981 return
4982
avakulenko@google.com554223d2014-12-04 22:00:20 +00004983 # Don't warn on out-of-line method definitions, as we would warn on the
4984 # in-line declaration, if it isn't marked with 'override'.
4985 if IsOutOfLineMethodDefinition(clean_lines, linenum):
4986 return
4987
erg@google.com2aa59982013-10-28 19:09:25 +00004988 # Long type names may be broken across multiple lines, usually in one
4989 # of these forms:
4990 # LongType
4991 # ::LongTypeContinued &identifier
4992 # LongType::
4993 # LongTypeContinued &identifier
4994 # LongType<
4995 # ...>::LongTypeContinued &identifier
4996 #
4997 # If we detected a type split across two lines, join the previous
4998 # line to current line so that we can match const references
4999 # accordingly.
erg@google.comc6671232013-10-25 21:44:03 +00005000 #
5001 # Note that this only scans back one line, since scanning back
5002 # arbitrary number of lines would be expensive. If you have a type
5003 # that spans more than 2 lines, please use a typedef.
5004 if linenum > 1:
5005 previous = None
erg@google.com2aa59982013-10-28 19:09:25 +00005006 if Match(r'\s*::(?:[\w<>]|::)+\s*&\s*\S', line):
erg@google.comc6671232013-10-25 21:44:03 +00005007 # previous_line\n + ::current_line
erg@google.com2aa59982013-10-28 19:09:25 +00005008 previous = Search(r'\b((?:const\s*)?(?:[\w<>]|::)+[\w<>])\s*$',
erg@google.comc6671232013-10-25 21:44:03 +00005009 clean_lines.elided[linenum - 1])
erg@google.com2aa59982013-10-28 19:09:25 +00005010 elif Match(r'\s*[a-zA-Z_]([\w<>]|::)+\s*&\s*\S', line):
erg@google.comc6671232013-10-25 21:44:03 +00005011 # previous_line::\n + current_line
erg@google.com2aa59982013-10-28 19:09:25 +00005012 previous = Search(r'\b((?:const\s*)?(?:[\w<>]|::)+::)\s*$',
erg@google.comc6671232013-10-25 21:44:03 +00005013 clean_lines.elided[linenum - 1])
5014 if previous:
5015 line = previous.group(1) + line.lstrip()
erg@google.com2aa59982013-10-28 19:09:25 +00005016 else:
5017 # Check for templated parameter that is split across multiple lines
5018 endpos = line.rfind('>')
5019 if endpos > -1:
5020 (_, startline, startpos) = ReverseCloseExpression(
5021 clean_lines, linenum, endpos)
5022 if startpos > -1 and startline < linenum:
5023 # Found the matching < on an earlier line, collect all
5024 # pieces up to current line.
5025 line = ''
5026 for i in xrange(startline, linenum + 1):
5027 line += clean_lines.elided[i].strip()
erg@google.comc6671232013-10-25 21:44:03 +00005028
5029 # Check for non-const references in function parameters. A single '&' may
5030 # found in the following places:
5031 # inside expression: binary & for bitwise AND
5032 # inside expression: unary & for taking the address of something
5033 # inside declarators: reference parameter
5034 # We will exclude the first two cases by checking that we are not inside a
5035 # function body, including one that was just introduced by a trailing '{'.
erg@google.comc6671232013-10-25 21:44:03 +00005036 # TODO(unknown): Doesn't account for 'catch(Exception& e)' [rare].
avakulenko@google.com02af6282014-06-04 18:53:25 +00005037 if (nesting_state.previous_stack_top and
5038 not (isinstance(nesting_state.previous_stack_top, _ClassInfo) or
5039 isinstance(nesting_state.previous_stack_top, _NamespaceInfo))):
5040 # Not at toplevel, not within a class, and not within a namespace
5041 return
5042
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005043 # Avoid initializer lists. We only need to scan back from the
5044 # current line for something that starts with ':'.
5045 #
5046 # We don't need to check the current line, since the '&' would
5047 # appear inside the second set of parentheses on the current line as
5048 # opposed to the first set.
5049 if linenum > 0:
5050 for i in xrange(linenum - 1, max(0, linenum - 10), -1):
5051 previous_line = clean_lines.elided[i]
5052 if not Search(r'[),]\s*$', previous_line):
5053 break
5054 if Match(r'^\s*:\s+\S', previous_line):
5055 return
5056
avakulenko@google.com02af6282014-06-04 18:53:25 +00005057 # Avoid preprocessors
5058 if Search(r'\\\s*$', line):
5059 return
5060
5061 # Avoid constructor initializer lists
5062 if IsInitializerList(clean_lines, linenum):
5063 return
5064
erg@google.comc6671232013-10-25 21:44:03 +00005065 # We allow non-const references in a few standard places, like functions
5066 # called "swap()" or iostream operators like "<<" or ">>". Do not check
5067 # those function parameters.
5068 #
5069 # We also accept & in static_assert, which looks like a function but
5070 # it's actually a declaration expression.
5071 whitelisted_functions = (r'(?:[sS]wap(?:<\w:+>)?|'
5072 r'operator\s*[<>][<>]|'
5073 r'static_assert|COMPILE_ASSERT'
5074 r')\s*\(')
5075 if Search(whitelisted_functions, line):
avakulenko@google.com02af6282014-06-04 18:53:25 +00005076 return
erg@google.comc6671232013-10-25 21:44:03 +00005077 elif not Search(r'\S+\([^)]*$', line):
5078 # Don't see a whitelisted function on this line. Actually we
5079 # didn't see any function name on this line, so this is likely a
5080 # multi-line parameter list. Try a bit harder to catch this case.
5081 for i in xrange(2):
5082 if (linenum > i and
5083 Search(whitelisted_functions, clean_lines.elided[linenum - i - 1])):
avakulenko@google.com02af6282014-06-04 18:53:25 +00005084 return
erg@google.comc6671232013-10-25 21:44:03 +00005085
avakulenko@google.com02af6282014-06-04 18:53:25 +00005086 decls = ReplaceAll(r'{[^}]*}', ' ', line) # exclude function body
5087 for parameter in re.findall(_RE_PATTERN_REF_PARAM, decls):
Alex Vakulenko01e47232016-05-06 13:54:15 -07005088 if (not Match(_RE_PATTERN_CONST_REF_PARAM, parameter) and
5089 not Match(_RE_PATTERN_REF_STREAM_PARAM, parameter)):
avakulenko@google.com02af6282014-06-04 18:53:25 +00005090 error(filename, linenum, 'runtime/references', 2,
5091 'Is this a non-const reference? '
5092 'If so, make const or use a pointer: ' +
5093 ReplaceAll(' *<', '<', parameter))
5094
5095
5096def CheckCasts(filename, clean_lines, linenum, error):
5097 """Various cast related checks.
5098
5099 Args:
5100 filename: The name of the current file.
5101 clean_lines: A CleansedLines instance containing the file.
5102 linenum: The number of the line to check.
5103 error: The function to call with any errors found.
5104 """
5105 line = clean_lines.elided[linenum]
5106
5107 # Check to see if they're using an conversion function cast.
5108 # I just try to capture the most common basic types, though there are more.
5109 # Parameterless conversion functions, such as bool(), are allowed as they are
5110 # probably a member operator declaration or default constructor.
5111 match = Search(
Alex Vakulenko01e47232016-05-06 13:54:15 -07005112 r'(\bnew\s+(?:const\s+)?|\S<\s*(?:const\s+)?)?\b'
avakulenko@google.com02af6282014-06-04 18:53:25 +00005113 r'(int|float|double|bool|char|int32|uint32|int64|uint64)'
5114 r'(\([^)].*)', line)
5115 expecting_function = ExpectingFunctionArgs(clean_lines, linenum)
5116 if match and not expecting_function:
5117 matched_type = match.group(2)
5118
5119 # matched_new_or_template is used to silence two false positives:
5120 # - New operators
5121 # - Template arguments with function types
5122 #
5123 # For template arguments, we match on types immediately following
5124 # an opening bracket without any spaces. This is a fast way to
5125 # silence the common case where the function type is the first
5126 # template argument. False negative with less-than comparison is
5127 # avoided because those operators are usually followed by a space.
5128 #
5129 # function<double(double)> // bracket + no space = false positive
5130 # value < double(42) // bracket + space = true positive
5131 matched_new_or_template = match.group(1)
5132
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005133 # Avoid arrays by looking for brackets that come after the closing
5134 # parenthesis.
5135 if Match(r'\([^()]+\)\s*\[', match.group(3)):
5136 return
5137
avakulenko@google.com02af6282014-06-04 18:53:25 +00005138 # Other things to ignore:
5139 # - Function pointers
5140 # - Casts to pointer types
5141 # - Placement new
5142 # - Alias declarations
5143 matched_funcptr = match.group(3)
5144 if (matched_new_or_template is None and
5145 not (matched_funcptr and
5146 (Match(r'\((?:[^() ]+::\s*\*\s*)?[^() ]+\)\s*\(',
5147 matched_funcptr) or
5148 matched_funcptr.startswith('(*)'))) and
5149 not Match(r'\s*using\s+\S+\s*=\s*' + matched_type, line) and
5150 not Search(r'new\(\S+\)\s*' + matched_type, line)):
5151 error(filename, linenum, 'readability/casting', 4,
5152 'Using deprecated casting style. '
5153 'Use static_cast<%s>(...) instead' %
5154 matched_type)
5155
5156 if not expecting_function:
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005157 CheckCStyleCast(filename, clean_lines, linenum, 'static_cast',
avakulenko@google.com02af6282014-06-04 18:53:25 +00005158 r'\((int|float|double|bool|char|u?int(16|32|64))\)', error)
5159
5160 # This doesn't catch all cases. Consider (const char * const)"hello".
5161 #
5162 # (char *) "foo" should always be a const_cast (reinterpret_cast won't
5163 # compile).
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005164 if CheckCStyleCast(filename, clean_lines, linenum, 'const_cast',
5165 r'\((char\s?\*+\s?)\)\s*"', error):
avakulenko@google.com02af6282014-06-04 18:53:25 +00005166 pass
5167 else:
5168 # Check pointer casts for other than string constants
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005169 CheckCStyleCast(filename, clean_lines, linenum, 'reinterpret_cast',
5170 r'\((\w+\s?\*+\s?)\)', error)
avakulenko@google.com02af6282014-06-04 18:53:25 +00005171
5172 # In addition, we look for people taking the address of a cast. This
5173 # is dangerous -- casts can assign to temporaries, so the pointer doesn't
5174 # point where you think.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005175 #
5176 # Some non-identifier character is required before the '&' for the
5177 # expression to be recognized as a cast. These are casts:
5178 # expression = &static_cast<int*>(temporary());
5179 # function(&(int*)(temporary()));
5180 #
5181 # This is not a cast:
5182 # reference_type&(int* function_param);
avakulenko@google.com02af6282014-06-04 18:53:25 +00005183 match = Search(
avakulenko@google.com554223d2014-12-04 22:00:20 +00005184 r'(?:[^\w]&\(([^)*][^)]*)\)[\w(])|'
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005185 r'(?:[^\w]&(static|dynamic|down|reinterpret)_cast\b)', line)
avakulenko@google.com554223d2014-12-04 22:00:20 +00005186 if match:
avakulenko@google.com02af6282014-06-04 18:53:25 +00005187 # Try a better error message when the & is bound to something
5188 # dereferenced by the casted pointer, as opposed to the casted
5189 # pointer itself.
5190 parenthesis_error = False
5191 match = Match(r'^(.*&(?:static|dynamic|down|reinterpret)_cast\b)<', line)
5192 if match:
5193 _, y1, x1 = CloseExpression(clean_lines, linenum, len(match.group(1)))
5194 if x1 >= 0 and clean_lines.elided[y1][x1] == '(':
5195 _, y2, x2 = CloseExpression(clean_lines, y1, x1)
5196 if x2 >= 0:
5197 extended_line = clean_lines.elided[y2][x2:]
5198 if y2 < clean_lines.NumLines() - 1:
5199 extended_line += clean_lines.elided[y2 + 1]
5200 if Match(r'\s*(?:->|\[)', extended_line):
5201 parenthesis_error = True
5202
5203 if parenthesis_error:
5204 error(filename, linenum, 'readability/casting', 4,
5205 ('Are you taking an address of something dereferenced '
5206 'from a cast? Wrapping the dereferenced expression in '
5207 'parentheses will make the binding more obvious'))
5208 else:
5209 error(filename, linenum, 'runtime/casting', 4,
5210 ('Are you taking an address of a cast? '
5211 'This is dangerous: could be a temp var. '
5212 'Take the address before doing the cast, rather than after'))
erg@google.comc6671232013-10-25 21:44:03 +00005213
erg@google.com4e00b9a2009-01-12 23:05:11 +00005214
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005215def CheckCStyleCast(filename, clean_lines, linenum, cast_type, pattern, error):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005216 """Checks for a C-style cast by looking for the pattern.
5217
erg@google.com4e00b9a2009-01-12 23:05:11 +00005218 Args:
5219 filename: The name of the current file.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005220 clean_lines: A CleansedLines instance containing the file.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005221 linenum: The number of the line to check.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005222 cast_type: The string for the C++ cast to recommend. This is either
erg@google.com8a95ecc2011-09-08 00:45:54 +00005223 reinterpret_cast, static_cast, or const_cast, depending.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005224 pattern: The regular expression used to find C-style casts.
5225 error: The function to call with any errors found.
erg@google.com8a95ecc2011-09-08 00:45:54 +00005226
5227 Returns:
5228 True if an error was emitted.
5229 False otherwise.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005230 """
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005231 line = clean_lines.elided[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00005232 match = Search(pattern, line)
5233 if not match:
erg@google.com8a95ecc2011-09-08 00:45:54 +00005234 return False
erg@google.com4e00b9a2009-01-12 23:05:11 +00005235
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005236 # Exclude lines with keywords that tend to look like casts
5237 context = line[0:match.start(1) - 1]
5238 if Match(r'.*\b(?:sizeof|alignof|alignas|[_A-Z][_A-Z0-9]*)\s*$', context):
5239 return False
5240
5241 # Try expanding current context to see if we one level of
5242 # parentheses inside a macro.
5243 if linenum > 0:
5244 for i in xrange(linenum - 1, max(0, linenum - 5), -1):
5245 context = clean_lines.elided[i] + context
5246 if Match(r'.*\b[_A-Z][_A-Z0-9]*\s*\((?:\([^()]*\)|[^()])*$', context):
erg@google.comfd5da632013-10-25 17:39:45 +00005247 return False
erg@google.com4e00b9a2009-01-12 23:05:11 +00005248
erg@google.comd350fe52013-01-14 17:51:48 +00005249 # operator++(int) and operator--(int)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005250 if context.endswith(' operator++') or context.endswith(' operator--'):
erg@google.comd350fe52013-01-14 17:51:48 +00005251 return False
5252
Alex Vakulenko01e47232016-05-06 13:54:15 -07005253 # A single unnamed argument for a function tends to look like old style cast.
5254 # If we see those, don't issue warnings for deprecated casts.
erg@google.comc6671232013-10-25 21:44:03 +00005255 remainder = line[match.end(0):]
avakulenko@google.com554223d2014-12-04 22:00:20 +00005256 if Match(r'^\s*(?:;|const\b|throw\b|final\b|override\b|[=>{),]|->)',
avakulenko@google.com02af6282014-06-04 18:53:25 +00005257 remainder):
Alex Vakulenko01e47232016-05-06 13:54:15 -07005258 return False
erg@google.com4e00b9a2009-01-12 23:05:11 +00005259
5260 # At this point, all that should be left is actual casts.
5261 error(filename, linenum, 'readability/casting', 4,
5262 'Using C-style cast. Use %s<%s>(...) instead' %
5263 (cast_type, match.group(1)))
5264
erg@google.com8a95ecc2011-09-08 00:45:54 +00005265 return True
5266
erg@google.com4e00b9a2009-01-12 23:05:11 +00005267
avakulenko@google.com02af6282014-06-04 18:53:25 +00005268def ExpectingFunctionArgs(clean_lines, linenum):
5269 """Checks whether where function type arguments are expected.
5270
5271 Args:
5272 clean_lines: A CleansedLines instance containing the file.
5273 linenum: The number of the line to check.
5274
5275 Returns:
5276 True if the line at 'linenum' is inside something that expects arguments
5277 of function types.
5278 """
5279 line = clean_lines.elided[linenum]
5280 return (Match(r'^\s*MOCK_(CONST_)?METHOD\d+(_T)?\(', line) or
5281 (linenum >= 2 and
5282 (Match(r'^\s*MOCK_(?:CONST_)?METHOD\d+(?:_T)?\((?:\S+,)?\s*$',
5283 clean_lines.elided[linenum - 1]) or
5284 Match(r'^\s*MOCK_(?:CONST_)?METHOD\d+(?:_T)?\(\s*$',
5285 clean_lines.elided[linenum - 2]) or
5286 Search(r'\bstd::m?function\s*\<\s*$',
5287 clean_lines.elided[linenum - 1]))))
5288
5289
erg@google.com4e00b9a2009-01-12 23:05:11 +00005290_HEADERS_CONTAINING_TEMPLATES = (
5291 ('<deque>', ('deque',)),
5292 ('<functional>', ('unary_function', 'binary_function',
5293 'plus', 'minus', 'multiplies', 'divides', 'modulus',
5294 'negate',
5295 'equal_to', 'not_equal_to', 'greater', 'less',
5296 'greater_equal', 'less_equal',
5297 'logical_and', 'logical_or', 'logical_not',
5298 'unary_negate', 'not1', 'binary_negate', 'not2',
5299 'bind1st', 'bind2nd',
5300 'pointer_to_unary_function',
5301 'pointer_to_binary_function',
5302 'ptr_fun',
5303 'mem_fun_t', 'mem_fun', 'mem_fun1_t', 'mem_fun1_ref_t',
5304 'mem_fun_ref_t',
5305 'const_mem_fun_t', 'const_mem_fun1_t',
5306 'const_mem_fun_ref_t', 'const_mem_fun1_ref_t',
5307 'mem_fun_ref',
5308 )),
5309 ('<limits>', ('numeric_limits',)),
5310 ('<list>', ('list',)),
5311 ('<map>', ('map', 'multimap',)),
lhchavez2890dff2016-07-11 19:37:29 -07005312 ('<memory>', ('allocator', 'make_shared', 'make_unique', 'shared_ptr',
5313 'unique_ptr', 'weak_ptr')),
erg@google.com4e00b9a2009-01-12 23:05:11 +00005314 ('<queue>', ('queue', 'priority_queue',)),
5315 ('<set>', ('set', 'multiset',)),
5316 ('<stack>', ('stack',)),
5317 ('<string>', ('char_traits', 'basic_string',)),
avakulenko@google.com554223d2014-12-04 22:00:20 +00005318 ('<tuple>', ('tuple',)),
lhchavez2890dff2016-07-11 19:37:29 -07005319 ('<unordered_map>', ('unordered_map', 'unordered_multimap')),
5320 ('<unordered_set>', ('unordered_set', 'unordered_multiset')),
erg@google.com4e00b9a2009-01-12 23:05:11 +00005321 ('<utility>', ('pair',)),
5322 ('<vector>', ('vector',)),
5323
5324 # gcc extensions.
5325 # Note: std::hash is their hash, ::hash is our hash
5326 ('<hash_map>', ('hash_map', 'hash_multimap',)),
5327 ('<hash_set>', ('hash_set', 'hash_multiset',)),
5328 ('<slist>', ('slist',)),
5329 )
5330
Alex Vakulenko01e47232016-05-06 13:54:15 -07005331_HEADERS_MAYBE_TEMPLATES = (
5332 ('<algorithm>', ('copy', 'max', 'min', 'min_element', 'sort',
5333 'transform',
5334 )),
lhchavez2890dff2016-07-11 19:37:29 -07005335 ('<utility>', ('forward', 'make_pair', 'move', 'swap')),
Alex Vakulenko01e47232016-05-06 13:54:15 -07005336 )
5337
erg@google.com4e00b9a2009-01-12 23:05:11 +00005338_RE_PATTERN_STRING = re.compile(r'\bstring\b')
5339
Alex Vakulenko01e47232016-05-06 13:54:15 -07005340_re_pattern_headers_maybe_templates = []
5341for _header, _templates in _HEADERS_MAYBE_TEMPLATES:
5342 for _template in _templates:
5343 # Match max<type>(..., ...), max(..., ...), but not foo->max, foo.max or
5344 # type::max().
5345 _re_pattern_headers_maybe_templates.append(
5346 (re.compile(r'[^>.]\b' + _template + r'(<.*?>)?\([^\)]'),
5347 _template,
5348 _header))
erg@google.com4e00b9a2009-01-12 23:05:11 +00005349
Alex Vakulenko01e47232016-05-06 13:54:15 -07005350# Other scripts may reach in and modify this pattern.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005351_re_pattern_templates = []
5352for _header, _templates in _HEADERS_CONTAINING_TEMPLATES:
5353 for _template in _templates:
5354 _re_pattern_templates.append(
5355 (re.compile(r'(\<|\b)' + _template + r'\s*\<'),
5356 _template + '<>',
5357 _header))
5358
5359
erg@google.come35f7652009-06-19 20:52:09 +00005360def FilesBelongToSameModule(filename_cc, filename_h):
5361 """Check if these two filenames belong to the same module.
5362
5363 The concept of a 'module' here is a as follows:
5364 foo.h, foo-inl.h, foo.cc, foo_test.cc and foo_unittest.cc belong to the
5365 same 'module' if they are in the same directory.
5366 some/path/public/xyzzy and some/path/internal/xyzzy are also considered
5367 to belong to the same module here.
5368
5369 If the filename_cc contains a longer path than the filename_h, for example,
5370 '/absolute/path/to/base/sysinfo.cc', and this file would include
5371 'base/sysinfo.h', this function also produces the prefix needed to open the
5372 header. This is used by the caller of this function to more robustly open the
5373 header file. We don't have access to the real include paths in this context,
5374 so we need this guesswork here.
5375
5376 Known bugs: tools/base/bar.cc and base/bar.h belong to the same module
5377 according to this implementation. Because of this, this function gives
5378 some false positives. This should be sufficiently rare in practice.
5379
5380 Args:
5381 filename_cc: is the path for the .cc file
5382 filename_h: is the path for the header path
5383
5384 Returns:
5385 Tuple with a bool and a string:
5386 bool: True if filename_cc and filename_h belong to the same module.
5387 string: the additional prefix needed to open the header file.
5388 """
5389
Alex Vakulenko01e47232016-05-06 13:54:15 -07005390 fileinfo = FileInfo(filename_cc)
5391 if not fileinfo.IsSource():
erg@google.come35f7652009-06-19 20:52:09 +00005392 return (False, '')
Alex Vakulenko01e47232016-05-06 13:54:15 -07005393 filename_cc = filename_cc[:-len(fileinfo.Extension())]
5394 matched_test_suffix = Search(_TEST_FILE_SUFFIX, fileinfo.BaseName())
5395 if matched_test_suffix:
5396 filename_cc = filename_cc[:-len(matched_test_suffix.group(1))]
erg@google.come35f7652009-06-19 20:52:09 +00005397 filename_cc = filename_cc.replace('/public/', '/')
5398 filename_cc = filename_cc.replace('/internal/', '/')
5399
5400 if not filename_h.endswith('.h'):
5401 return (False, '')
5402 filename_h = filename_h[:-len('.h')]
5403 if filename_h.endswith('-inl'):
5404 filename_h = filename_h[:-len('-inl')]
5405 filename_h = filename_h.replace('/public/', '/')
5406 filename_h = filename_h.replace('/internal/', '/')
5407
5408 files_belong_to_same_module = filename_cc.endswith(filename_h)
5409 common_path = ''
5410 if files_belong_to_same_module:
5411 common_path = filename_cc[:-len(filename_h)]
5412 return files_belong_to_same_module, common_path
5413
5414
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005415def UpdateIncludeState(filename, include_dict, io=codecs):
5416 """Fill up the include_dict with new includes found from the file.
erg@google.come35f7652009-06-19 20:52:09 +00005417
5418 Args:
5419 filename: the name of the header to read.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005420 include_dict: a dictionary in which the headers are inserted.
erg@google.come35f7652009-06-19 20:52:09 +00005421 io: The io factory to use to read the file. Provided for testability.
5422
5423 Returns:
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005424 True if a header was successfully added. False otherwise.
erg@google.come35f7652009-06-19 20:52:09 +00005425 """
5426 headerfile = None
5427 try:
5428 headerfile = io.open(filename, 'r', 'utf8', 'replace')
5429 except IOError:
5430 return False
5431 linenum = 0
5432 for line in headerfile:
5433 linenum += 1
5434 clean_line = CleanseComments(line)
5435 match = _RE_PATTERN_INCLUDE.search(clean_line)
5436 if match:
5437 include = match.group(2)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005438 include_dict.setdefault(include, linenum)
erg@google.come35f7652009-06-19 20:52:09 +00005439 return True
5440
5441
5442def CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error,
5443 io=codecs):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005444 """Reports for missing stl includes.
5445
5446 This function will output warnings to make sure you are including the headers
5447 necessary for the stl containers and functions that you use. We only give one
5448 reason to include a header. For example, if you use both equal_to<> and
5449 less<> in a .h file, only one (the latter in the file) of these will be
5450 reported as a reason to include the <functional>.
5451
erg@google.com4e00b9a2009-01-12 23:05:11 +00005452 Args:
5453 filename: The name of the current file.
5454 clean_lines: A CleansedLines instance containing the file.
5455 include_state: An _IncludeState instance.
5456 error: The function to call with any errors found.
erg@google.come35f7652009-06-19 20:52:09 +00005457 io: The IO factory to use to read the header file. Provided for unittest
5458 injection.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005459 """
erg@google.com4e00b9a2009-01-12 23:05:11 +00005460 required = {} # A map of header name to linenumber and the template entity.
5461 # Example of required: { '<functional>': (1219, 'less<>') }
5462
5463 for linenum in xrange(clean_lines.NumLines()):
5464 line = clean_lines.elided[linenum]
5465 if not line or line[0] == '#':
5466 continue
5467
5468 # String is special -- it is a non-templatized type in STL.
erg@google.com8a95ecc2011-09-08 00:45:54 +00005469 matched = _RE_PATTERN_STRING.search(line)
5470 if matched:
erg+personal@google.com05189642010-04-30 20:43:03 +00005471 # Don't warn about strings in non-STL namespaces:
5472 # (We check only the first match per line; good enough.)
erg@google.com8a95ecc2011-09-08 00:45:54 +00005473 prefix = line[:matched.start()]
erg+personal@google.com05189642010-04-30 20:43:03 +00005474 if prefix.endswith('std::') or not prefix.endswith('::'):
5475 required['<string>'] = (linenum, 'string')
erg@google.com4e00b9a2009-01-12 23:05:11 +00005476
Alex Vakulenko01e47232016-05-06 13:54:15 -07005477 for pattern, template, header in _re_pattern_headers_maybe_templates:
erg@google.com4e00b9a2009-01-12 23:05:11 +00005478 if pattern.search(line):
5479 required[header] = (linenum, template)
5480
5481 # The following function is just a speed up, no semantics are changed.
5482 if not '<' in line: # Reduces the cpu time usage by skipping lines.
5483 continue
5484
5485 for pattern, template, header in _re_pattern_templates:
lhchavez3ae81f12016-07-11 19:00:34 -07005486 matched = pattern.search(line)
5487 if matched:
5488 # Don't warn about IWYU in non-STL namespaces:
5489 # (We check only the first match per line; good enough.)
5490 prefix = line[:matched.start()]
5491 if prefix.endswith('std::') or not prefix.endswith('::'):
5492 required[header] = (linenum, template)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005493
erg@google.come35f7652009-06-19 20:52:09 +00005494 # The policy is that if you #include something in foo.h you don't need to
5495 # include it again in foo.cc. Here, we will look at possible includes.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005496 # Let's flatten the include_state include_list and copy it into a dictionary.
5497 include_dict = dict([item for sublist in include_state.include_list
5498 for item in sublist])
erg@google.come35f7652009-06-19 20:52:09 +00005499
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005500 # Did we find the header for this file (if any) and successfully load it?
erg@google.come35f7652009-06-19 20:52:09 +00005501 header_found = False
5502
5503 # Use the absolute path so that matching works properly.
erg@google.com90ecb622012-01-30 19:34:23 +00005504 abs_filename = FileInfo(filename).FullName()
erg@google.come35f7652009-06-19 20:52:09 +00005505
5506 # For Emacs's flymake.
5507 # If cpplint is invoked from Emacs's flymake, a temporary file is generated
5508 # by flymake and that file name might end with '_flymake.cc'. In that case,
5509 # restore original file name here so that the corresponding header file can be
5510 # found.
5511 # e.g. If the file name is 'foo_flymake.cc', we should search for 'foo.h'
5512 # instead of 'foo_flymake.h'
erg+personal@google.com05189642010-04-30 20:43:03 +00005513 abs_filename = re.sub(r'_flymake\.cc$', '.cc', abs_filename)
erg@google.come35f7652009-06-19 20:52:09 +00005514
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005515 # include_dict is modified during iteration, so we iterate over a copy of
erg@google.come35f7652009-06-19 20:52:09 +00005516 # the keys.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005517 header_keys = include_dict.keys()
erg@google.com8a95ecc2011-09-08 00:45:54 +00005518 for header in header_keys:
erg@google.come35f7652009-06-19 20:52:09 +00005519 (same_module, common_path) = FilesBelongToSameModule(abs_filename, header)
5520 fullpath = common_path + header
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005521 if same_module and UpdateIncludeState(fullpath, include_dict, io):
erg@google.come35f7652009-06-19 20:52:09 +00005522 header_found = True
5523
5524 # If we can't find the header file for a .cc, assume it's because we don't
5525 # know where to look. In that case we'll give up as we're not sure they
5526 # didn't include it in the .h file.
5527 # TODO(unknown): Do a better job of finding .h files so we are confident that
5528 # not having the .h file means there isn't one.
5529 if filename.endswith('.cc') and not header_found:
5530 return
5531
erg@google.com4e00b9a2009-01-12 23:05:11 +00005532 # All the lines have been processed, report the errors found.
5533 for required_header_unstripped in required:
5534 template = required[required_header_unstripped][1]
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005535 if required_header_unstripped.strip('<>"') not in include_dict:
erg@google.com4e00b9a2009-01-12 23:05:11 +00005536 error(filename, required[required_header_unstripped][0],
5537 'build/include_what_you_use', 4,
5538 'Add #include ' + required_header_unstripped + ' for ' + template)
5539
5540
erg@google.com8a95ecc2011-09-08 00:45:54 +00005541_RE_PATTERN_EXPLICIT_MAKEPAIR = re.compile(r'\bmake_pair\s*<')
5542
5543
5544def CheckMakePairUsesDeduction(filename, clean_lines, linenum, error):
5545 """Check that make_pair's template arguments are deduced.
5546
avakulenko@google.com02af6282014-06-04 18:53:25 +00005547 G++ 4.6 in C++11 mode fails badly if make_pair's template arguments are
erg@google.com8a95ecc2011-09-08 00:45:54 +00005548 specified explicitly, and such use isn't intended in any case.
5549
5550 Args:
5551 filename: The name of the current file.
5552 clean_lines: A CleansedLines instance containing the file.
5553 linenum: The number of the line to check.
5554 error: The function to call with any errors found.
5555 """
erg@google.com2aa59982013-10-28 19:09:25 +00005556 line = clean_lines.elided[linenum]
erg@google.com8a95ecc2011-09-08 00:45:54 +00005557 match = _RE_PATTERN_EXPLICIT_MAKEPAIR.search(line)
5558 if match:
5559 error(filename, linenum, 'build/explicit_make_pair',
5560 4, # 4 = high confidence
erg@google.comd350fe52013-01-14 17:51:48 +00005561 'For C++11-compatibility, omit template arguments from make_pair'
5562 ' OR use pair directly OR if appropriate, construct a pair directly')
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005563
5564
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005565def CheckRedundantVirtual(filename, clean_lines, linenum, error):
5566 """Check if line contains a redundant "virtual" function-specifier.
5567
5568 Args:
5569 filename: The name of the current file.
5570 clean_lines: A CleansedLines instance containing the file.
5571 linenum: The number of the line to check.
5572 error: The function to call with any errors found.
5573 """
5574 # Look for "virtual" on current line.
5575 line = clean_lines.elided[linenum]
avakulenko@google.com554223d2014-12-04 22:00:20 +00005576 virtual = Match(r'^(.*)(\bvirtual\b)(.*)$', line)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005577 if not virtual: return
5578
avakulenko@google.com554223d2014-12-04 22:00:20 +00005579 # Ignore "virtual" keywords that are near access-specifiers. These
5580 # are only used in class base-specifier and do not apply to member
5581 # functions.
5582 if (Search(r'\b(public|protected|private)\s+$', virtual.group(1)) or
5583 Match(r'^\s+(public|protected|private)\b', virtual.group(3))):
5584 return
5585
5586 # Ignore the "virtual" keyword from virtual base classes. Usually
5587 # there is a column on the same line in these cases (virtual base
5588 # classes are rare in google3 because multiple inheritance is rare).
5589 if Match(r'^.*[^:]:[^:].*$', line): return
5590
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005591 # Look for the next opening parenthesis. This is the start of the
5592 # parameter list (possibly on the next line shortly after virtual).
5593 # TODO(unknown): doesn't work if there are virtual functions with
5594 # decltype() or other things that use parentheses, but csearch suggests
5595 # that this is rare.
5596 end_col = -1
5597 end_line = -1
avakulenko@google.com554223d2014-12-04 22:00:20 +00005598 start_col = len(virtual.group(2))
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005599 for start_line in xrange(linenum, min(linenum + 3, clean_lines.NumLines())):
5600 line = clean_lines.elided[start_line][start_col:]
5601 parameter_list = Match(r'^([^(]*)\(', line)
5602 if parameter_list:
5603 # Match parentheses to find the end of the parameter list
5604 (_, end_line, end_col) = CloseExpression(
5605 clean_lines, start_line, start_col + len(parameter_list.group(1)))
5606 break
5607 start_col = 0
5608
5609 if end_col < 0:
5610 return # Couldn't find end of parameter list, give up
5611
5612 # Look for "override" or "final" after the parameter list
5613 # (possibly on the next few lines).
5614 for i in xrange(end_line, min(end_line + 3, clean_lines.NumLines())):
5615 line = clean_lines.elided[i][end_col:]
5616 match = Search(r'\b(override|final)\b', line)
5617 if match:
5618 error(filename, linenum, 'readability/inheritance', 4,
5619 ('"virtual" is redundant since function is '
5620 'already declared as "%s"' % match.group(1)))
5621
5622 # Set end_col to check whole lines after we are done with the
5623 # first line.
5624 end_col = 0
5625 if Search(r'[^\w]\s*$', line):
5626 break
5627
5628
5629def CheckRedundantOverrideOrFinal(filename, clean_lines, linenum, error):
5630 """Check if line contains a redundant "override" or "final" virt-specifier.
5631
5632 Args:
5633 filename: The name of the current file.
5634 clean_lines: A CleansedLines instance containing the file.
5635 linenum: The number of the line to check.
5636 error: The function to call with any errors found.
5637 """
avakulenko@google.com554223d2014-12-04 22:00:20 +00005638 # Look for closing parenthesis nearby. We need one to confirm where
5639 # the declarator ends and where the virt-specifier starts to avoid
5640 # false positives.
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005641 line = clean_lines.elided[linenum]
avakulenko@google.com554223d2014-12-04 22:00:20 +00005642 declarator_end = line.rfind(')')
5643 if declarator_end >= 0:
5644 fragment = line[declarator_end:]
5645 else:
5646 if linenum > 1 and clean_lines.elided[linenum - 1].rfind(')') >= 0:
5647 fragment = line
5648 else:
5649 return
5650
5651 # Check that at most one of "override" or "final" is present, not both
5652 if Search(r'\boverride\b', fragment) and Search(r'\bfinal\b', fragment):
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005653 error(filename, linenum, 'readability/inheritance', 4,
5654 ('"override" is redundant since function is '
5655 'already declared as "final"'))
5656
5657
5658
5659
5660# Returns true if we are at a new block, and it is directly
5661# inside of a namespace.
5662def IsBlockInNameSpace(nesting_state, is_forward_declaration):
5663 """Checks that the new block is directly in a namespace.
5664
5665 Args:
5666 nesting_state: The _NestingState object that contains info about our state.
5667 is_forward_declaration: If the class is a forward declared class.
5668 Returns:
5669 Whether or not the new block is directly in a namespace.
5670 """
5671 if is_forward_declaration:
5672 if len(nesting_state.stack) >= 1 and (
5673 isinstance(nesting_state.stack[-1], _NamespaceInfo)):
5674 return True
5675 else:
5676 return False
5677
5678 return (len(nesting_state.stack) > 1 and
5679 nesting_state.stack[-1].check_namespace_indentation and
5680 isinstance(nesting_state.stack[-2], _NamespaceInfo))
5681
5682
5683def ShouldCheckNamespaceIndentation(nesting_state, is_namespace_indent_item,
5684 raw_lines_no_comments, linenum):
5685 """This method determines if we should apply our namespace indentation check.
5686
5687 Args:
5688 nesting_state: The current nesting state.
5689 is_namespace_indent_item: If we just put a new class on the stack, True.
5690 If the top of the stack is not a class, or we did not recently
5691 add the class, False.
5692 raw_lines_no_comments: The lines without the comments.
5693 linenum: The current line number we are processing.
5694
5695 Returns:
5696 True if we should apply our namespace indentation check. Currently, it
5697 only works for classes and namespaces inside of a namespace.
5698 """
5699
5700 is_forward_declaration = IsForwardClassDeclaration(raw_lines_no_comments,
5701 linenum)
5702
5703 if not (is_namespace_indent_item or is_forward_declaration):
5704 return False
5705
5706 # If we are in a macro, we do not want to check the namespace indentation.
5707 if IsMacroDefinition(raw_lines_no_comments, linenum):
5708 return False
5709
5710 return IsBlockInNameSpace(nesting_state, is_forward_declaration)
5711
5712
5713# Call this method if the line is directly inside of a namespace.
5714# If the line above is blank (excluding comments) or the start of
5715# an inner namespace, it cannot be indented.
5716def CheckItemIndentationInNamespace(filename, raw_lines_no_comments, linenum,
5717 error):
5718 line = raw_lines_no_comments[linenum]
5719 if Match(r'^\s+', line):
5720 error(filename, linenum, 'runtime/indentation_namespace', 4,
5721 'Do not indent within a namespace')
erg@google.com8a95ecc2011-09-08 00:45:54 +00005722
5723
erg@google.comd350fe52013-01-14 17:51:48 +00005724def ProcessLine(filename, file_extension, clean_lines, line,
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005725 include_state, function_state, nesting_state, error,
5726 extra_check_functions=[]):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005727 """Processes a single line in the file.
5728
5729 Args:
5730 filename: Filename of the file that is being processed.
5731 file_extension: The extension (dot not included) of the file.
5732 clean_lines: An array of strings, each representing a line of the file,
5733 with comments stripped.
5734 line: Number of line being processed.
5735 include_state: An _IncludeState instance in which the headers are inserted.
5736 function_state: A _FunctionState instance which counts function lines, etc.
avakulenko@google.com02af6282014-06-04 18:53:25 +00005737 nesting_state: A NestingState instance which maintains information about
erg@google.comd350fe52013-01-14 17:51:48 +00005738 the current stack of nested blocks being parsed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005739 error: A callable to which errors are reported, which takes 4 arguments:
5740 filename, line number, error level, and message
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005741 extra_check_functions: An array of additional check functions that will be
5742 run on each source line. Each function takes 4
5743 arguments: filename, clean_lines, line, error
erg@google.com4e00b9a2009-01-12 23:05:11 +00005744 """
5745 raw_lines = clean_lines.raw_lines
erg+personal@google.com05189642010-04-30 20:43:03 +00005746 ParseNolintSuppressions(filename, raw_lines[line], line, error)
erg@google.comd350fe52013-01-14 17:51:48 +00005747 nesting_state.Update(filename, clean_lines, line, error)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005748 CheckForNamespaceIndentation(filename, nesting_state, clean_lines, line,
5749 error)
avakulenko@google.com02af6282014-06-04 18:53:25 +00005750 if nesting_state.InAsmBlock(): return
erg@google.com4e00b9a2009-01-12 23:05:11 +00005751 CheckForFunctionLengths(filename, clean_lines, line, function_state, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005752 CheckForMultilineCommentsAndStrings(filename, clean_lines, line, error)
erg@google.comd350fe52013-01-14 17:51:48 +00005753 CheckStyle(filename, clean_lines, line, file_extension, nesting_state, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005754 CheckLanguage(filename, clean_lines, line, file_extension, include_state,
erg@google.comfd5da632013-10-25 17:39:45 +00005755 nesting_state, error)
erg@google.comc6671232013-10-25 21:44:03 +00005756 CheckForNonConstReference(filename, clean_lines, line, nesting_state, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005757 CheckForNonStandardConstructs(filename, clean_lines, line,
erg@google.comd350fe52013-01-14 17:51:48 +00005758 nesting_state, error)
erg@google.com2aa59982013-10-28 19:09:25 +00005759 CheckVlogArguments(filename, clean_lines, line, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005760 CheckPosixThreading(filename, clean_lines, line, error)
erg@google.com36649102009-03-25 21:18:36 +00005761 CheckInvalidIncrement(filename, clean_lines, line, error)
erg@google.com8a95ecc2011-09-08 00:45:54 +00005762 CheckMakePairUsesDeduction(filename, clean_lines, line, error)
avakulenko@google.coma8ee7ea2014-08-11 19:41:35 +00005763 CheckRedundantVirtual(filename, clean_lines, line, error)
5764 CheckRedundantOverrideOrFinal(filename, clean_lines, line, error)
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005765 for check_fn in extra_check_functions:
5766 check_fn(filename, clean_lines, line, error)
erg@google.com7430eef2014-07-28 22:33:46 +00005767
avakulenko@google.com02af6282014-06-04 18:53:25 +00005768def FlagCxx11Features(filename, clean_lines, linenum, error):
5769 """Flag those c++11 features that we only allow in certain places.
5770
5771 Args:
5772 filename: The name of the current file.
5773 clean_lines: A CleansedLines instance containing the file.
5774 linenum: The number of the line to check.
5775 error: The function to call with any errors found.
5776 """
5777 line = clean_lines.elided[linenum]
5778
avakulenko@google.com02af6282014-06-04 18:53:25 +00005779 include = Match(r'\s*#\s*include\s+[<"]([^<"]+)[">]', line)
Alex Vakulenko01e47232016-05-06 13:54:15 -07005780
5781 # Flag unapproved C++ TR1 headers.
5782 if include and include.group(1).startswith('tr1/'):
5783 error(filename, linenum, 'build/c++tr1', 5,
5784 ('C++ TR1 headers such as <%s> are unapproved.') % include.group(1))
5785
5786 # Flag unapproved C++11 headers.
avakulenko@google.com02af6282014-06-04 18:53:25 +00005787 if include and include.group(1) in ('cfenv',
5788 'condition_variable',
5789 'fenv.h',
5790 'future',
5791 'mutex',
5792 'thread',
5793 'chrono',
5794 'ratio',
5795 'regex',
5796 'system_error',
5797 ):
5798 error(filename, linenum, 'build/c++11', 5,
5799 ('<%s> is an unapproved C++11 header.') % include.group(1))
5800
5801 # The only place where we need to worry about C++11 keywords and library
5802 # features in preprocessor directives is in macro definitions.
5803 if Match(r'\s*#', line) and not Match(r'\s*#\s*define\b', line): return
5804
5805 # These are classes and free functions. The classes are always
5806 # mentioned as std::*, but we only catch the free functions if
5807 # they're not found by ADL. They're alphabetical by header.
5808 for top_name in (
5809 # type_traits
5810 'alignment_of',
5811 'aligned_union',
avakulenko@google.com02af6282014-06-04 18:53:25 +00005812 ):
5813 if Search(r'\bstd::%s\b' % top_name, line):
5814 error(filename, linenum, 'build/c++11', 5,
5815 ('std::%s is an unapproved C++11 class or function. Send c-style '
5816 'an example of where it would make your code more readable, and '
5817 'they may let you use it.') % top_name)
5818
5819
Alex Vakulenko01e47232016-05-06 13:54:15 -07005820def FlagCxx14Features(filename, clean_lines, linenum, error):
5821 """Flag those C++14 features that we restrict.
5822
5823 Args:
5824 filename: The name of the current file.
5825 clean_lines: A CleansedLines instance containing the file.
5826 linenum: The number of the line to check.
5827 error: The function to call with any errors found.
5828 """
5829 line = clean_lines.elided[linenum]
5830
5831 include = Match(r'\s*#\s*include\s+[<"]([^<"]+)[">]', line)
5832
5833 # Flag unapproved C++14 headers.
5834 if include and include.group(1) in ('scoped_allocator', 'shared_mutex'):
5835 error(filename, linenum, 'build/c++14', 5,
5836 ('<%s> is an unapproved C++14 header.') % include.group(1))
5837
5838
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005839def ProcessFileData(filename, file_extension, lines, error,
5840 extra_check_functions=[]):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005841 """Performs lint checks and reports any errors to the given error function.
5842
5843 Args:
5844 filename: Filename of the file that is being processed.
5845 file_extension: The extension (dot not included) of the file.
5846 lines: An array of strings, each representing a line of the file, with the
erg@google.com8a95ecc2011-09-08 00:45:54 +00005847 last element being empty if the file is terminated with a newline.
erg@google.com4e00b9a2009-01-12 23:05:11 +00005848 error: A callable to which errors are reported, which takes 4 arguments:
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005849 filename, line number, error level, and message
5850 extra_check_functions: An array of additional check functions that will be
5851 run on each source line. Each function takes 4
5852 arguments: filename, clean_lines, line, error
erg@google.com4e00b9a2009-01-12 23:05:11 +00005853 """
5854 lines = (['// marker so line numbers and indices both start at 1'] + lines +
5855 ['// marker so line numbers end in a known way'])
5856
5857 include_state = _IncludeState()
5858 function_state = _FunctionState()
avakulenko@google.com02af6282014-06-04 18:53:25 +00005859 nesting_state = NestingState()
erg@google.com4e00b9a2009-01-12 23:05:11 +00005860
erg+personal@google.com05189642010-04-30 20:43:03 +00005861 ResetNolintSuppressions()
5862
erg@google.com4e00b9a2009-01-12 23:05:11 +00005863 CheckForCopyright(filename, lines, error)
Alex Vakulenko01e47232016-05-06 13:54:15 -07005864 ProcessGlobalSuppresions(lines)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005865 RemoveMultiLineComments(filename, lines, error)
5866 clean_lines = CleansedLines(lines)
avakulenko@google.com554223d2014-12-04 22:00:20 +00005867
LukeCz7197a242016-09-24 13:27:35 -05005868 if IsHeaderExtension(file_extension):
avakulenko@google.com554223d2014-12-04 22:00:20 +00005869 CheckForHeaderGuard(filename, clean_lines, error)
5870
erg@google.com4e00b9a2009-01-12 23:05:11 +00005871 for line in xrange(clean_lines.NumLines()):
5872 ProcessLine(filename, file_extension, clean_lines, line,
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005873 include_state, function_state, nesting_state, error,
5874 extra_check_functions)
avakulenko@google.com02af6282014-06-04 18:53:25 +00005875 FlagCxx11Features(filename, clean_lines, line, error)
erg@google.com2aa59982013-10-28 19:09:25 +00005876 nesting_state.CheckCompletedBlocks(filename, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005877
5878 CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error)
Alex Vakulenko01e47232016-05-06 13:54:15 -07005879
avakulenko@google.com554223d2014-12-04 22:00:20 +00005880 # Check that the .cc file has included its header if it exists.
Alex Vakulenko01e47232016-05-06 13:54:15 -07005881 if _IsSourceExtension(file_extension):
avakulenko@google.com554223d2014-12-04 22:00:20 +00005882 CheckHeaderFileIncluded(filename, include_state, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005883
5884 # We check here rather than inside ProcessLine so that we see raw
5885 # lines rather than "cleaned" lines.
erg@google.com2aa59982013-10-28 19:09:25 +00005886 CheckForBadCharacters(filename, lines, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00005887
5888 CheckForNewlineAtEOF(filename, lines, error)
5889
erg@google.com7430eef2014-07-28 22:33:46 +00005890def ProcessConfigOverrides(filename):
5891 """ Loads the configuration files and processes the config overrides.
5892
5893 Args:
5894 filename: The name of the file being processed by the linter.
5895
5896 Returns:
5897 False if the current |filename| should not be processed further.
5898 """
5899
5900 abs_filename = os.path.abspath(filename)
5901 cfg_filters = []
5902 keep_looking = True
5903 while keep_looking:
5904 abs_path, base_name = os.path.split(abs_filename)
5905 if not base_name:
5906 break # Reached the root directory.
5907
5908 cfg_file = os.path.join(abs_path, "CPPLINT.cfg")
5909 abs_filename = abs_path
5910 if not os.path.isfile(cfg_file):
5911 continue
5912
5913 try:
5914 with open(cfg_file) as file_handle:
5915 for line in file_handle:
5916 line, _, _ = line.partition('#') # Remove comments.
5917 if not line.strip():
5918 continue
5919
5920 name, _, val = line.partition('=')
5921 name = name.strip()
5922 val = val.strip()
5923 if name == 'set noparent':
5924 keep_looking = False
5925 elif name == 'filter':
5926 cfg_filters.append(val)
5927 elif name == 'exclude_files':
5928 # When matching exclude_files pattern, use the base_name of
5929 # the current file name or the directory name we are processing.
5930 # For example, if we are checking for lint errors in /foo/bar/baz.cc
5931 # and we found the .cfg file at /foo/CPPLINT.cfg, then the config
5932 # file's "exclude_files" filter is meant to be checked against "bar"
5933 # and not "baz" nor "bar/baz.cc".
5934 if base_name:
5935 pattern = re.compile(val)
5936 if pattern.match(base_name):
5937 sys.stderr.write('Ignoring "%s": file excluded by "%s". '
5938 'File path component "%s" matches '
5939 'pattern "%s"\n' %
5940 (filename, cfg_file, base_name, val))
5941 return False
avakulenko@google.com310681b2014-08-22 19:38:55 +00005942 elif name == 'linelength':
5943 global _line_length
5944 try:
5945 _line_length = int(val)
5946 except ValueError:
5947 sys.stderr.write('Line length must be numeric.')
Fabian Guera2322e4f2016-05-01 17:36:30 +02005948 elif name == 'root':
5949 global _root
5950 _root = val
LukeCz7197a242016-09-24 13:27:35 -05005951 elif name == 'headers':
5952 ProcessHppHeadersOption(val)
erg@google.com7430eef2014-07-28 22:33:46 +00005953 else:
5954 sys.stderr.write(
5955 'Invalid configuration option (%s) in file %s\n' %
5956 (name, cfg_file))
5957
5958 except IOError:
5959 sys.stderr.write(
5960 "Skipping config file '%s': Can't open for reading\n" % cfg_file)
5961 keep_looking = False
5962
5963 # Apply all the accumulated filters in reverse order (top-level directory
5964 # config options having the least priority).
5965 for filter in reversed(cfg_filters):
5966 _AddFilters(filter)
5967
5968 return True
5969
avakulenko@google.com02af6282014-06-04 18:53:25 +00005970
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005971def ProcessFile(filename, vlevel, extra_check_functions=[]):
erg@google.com4e00b9a2009-01-12 23:05:11 +00005972 """Does google-lint on a single file.
5973
5974 Args:
5975 filename: The name of the file to parse.
5976
5977 vlevel: The level of errors to report. Every error of confidence
5978 >= verbose_level will be reported. 0 is a good default.
avakulenko@google.com4b957b22014-06-04 22:48:14 +00005979
5980 extra_check_functions: An array of additional check functions that will be
5981 run on each source line. Each function takes 4
5982 arguments: filename, clean_lines, line, error
erg@google.com4e00b9a2009-01-12 23:05:11 +00005983 """
5984
5985 _SetVerboseLevel(vlevel)
erg@google.com7430eef2014-07-28 22:33:46 +00005986 _BackupFilters()
5987
5988 if not ProcessConfigOverrides(filename):
5989 _RestoreFilters()
5990 return
erg@google.com4e00b9a2009-01-12 23:05:11 +00005991
avakulenko@google.com02af6282014-06-04 18:53:25 +00005992 lf_lines = []
5993 crlf_lines = []
erg@google.com4e00b9a2009-01-12 23:05:11 +00005994 try:
5995 # Support the UNIX convention of using "-" for stdin. Note that
5996 # we are not opening the file with universal newline support
5997 # (which codecs doesn't support anyway), so the resulting lines do
5998 # contain trailing '\r' characters if we are reading a file that
5999 # has CRLF endings.
6000 # If after the split a trailing '\r' is present, it is removed
avakulenko@google.com02af6282014-06-04 18:53:25 +00006001 # below.
erg@google.com4e00b9a2009-01-12 23:05:11 +00006002 if filename == '-':
6003 lines = codecs.StreamReaderWriter(sys.stdin,
6004 codecs.getreader('utf8'),
6005 codecs.getwriter('utf8'),
6006 'replace').read().split('\n')
6007 else:
6008 lines = codecs.open(filename, 'r', 'utf8', 'replace').read().split('\n')
6009
erg@google.com4e00b9a2009-01-12 23:05:11 +00006010 # Remove trailing '\r'.
avakulenko@google.com02af6282014-06-04 18:53:25 +00006011 # The -1 accounts for the extra trailing blank line we get from split()
6012 for linenum in range(len(lines) - 1):
erg@google.com4e00b9a2009-01-12 23:05:11 +00006013 if lines[linenum].endswith('\r'):
6014 lines[linenum] = lines[linenum].rstrip('\r')
avakulenko@google.com02af6282014-06-04 18:53:25 +00006015 crlf_lines.append(linenum + 1)
6016 else:
6017 lf_lines.append(linenum + 1)
erg@google.com4e00b9a2009-01-12 23:05:11 +00006018
6019 except IOError:
6020 sys.stderr.write(
6021 "Skipping input '%s': Can't open for reading\n" % filename)
erg@google.com7430eef2014-07-28 22:33:46 +00006022 _RestoreFilters()
erg@google.com4e00b9a2009-01-12 23:05:11 +00006023 return
6024
6025 # Note, if no dot is found, this will give the entire filename as the ext.
6026 file_extension = filename[filename.rfind('.') + 1:]
6027
6028 # When reading from stdin, the extension is unknown, so no cpplint tests
6029 # should rely on the extension.
erg@google.com19680272013-12-16 22:48:54 +00006030 if filename != '-' and file_extension not in _valid_extensions:
erg@google.com2aa59982013-10-28 19:09:25 +00006031 sys.stderr.write('Ignoring %s; not a valid file name '
erg@google.com19680272013-12-16 22:48:54 +00006032 '(%s)\n' % (filename, ', '.join(_valid_extensions)))
erg@google.com4e00b9a2009-01-12 23:05:11 +00006033 else:
avakulenko@google.com4b957b22014-06-04 22:48:14 +00006034 ProcessFileData(filename, file_extension, lines, Error,
6035 extra_check_functions)
avakulenko@google.com02af6282014-06-04 18:53:25 +00006036
6037 # If end-of-line sequences are a mix of LF and CR-LF, issue
6038 # warnings on the lines with CR.
6039 #
6040 # Don't issue any warnings if all lines are uniformly LF or CR-LF,
6041 # since critique can handle these just fine, and the style guide
6042 # doesn't dictate a particular end of line sequence.
6043 #
6044 # We can't depend on os.linesep to determine what the desired
6045 # end-of-line sequence should be, since that will return the
6046 # server-side end-of-line sequence.
6047 if lf_lines and crlf_lines:
6048 # Warn on every line with CR. An alternative approach might be to
6049 # check whether the file is mostly CRLF or just LF, and warn on the
6050 # minority, we bias toward LF here since most tools prefer LF.
6051 for linenum in crlf_lines:
6052 Error(filename, linenum, 'whitespace/newline', 1,
6053 'Unexpected \\r (^M) found; better to use only \\n')
erg@google.com4e00b9a2009-01-12 23:05:11 +00006054
LukeCze09f4782016-09-28 19:13:37 -05006055 sys.stdout.write('Done processing %s\n' % filename)
erg@google.com7430eef2014-07-28 22:33:46 +00006056 _RestoreFilters()
erg@google.com4e00b9a2009-01-12 23:05:11 +00006057
6058
6059def PrintUsage(message):
6060 """Prints a brief usage string and exits, optionally with an error message.
6061
6062 Args:
6063 message: The optional error message.
6064 """
6065 sys.stderr.write(_USAGE)
6066 if message:
6067 sys.exit('\nFATAL ERROR: ' + message)
6068 else:
6069 sys.exit(1)
6070
6071
6072def PrintCategories():
6073 """Prints a list of all the error-categories used by error messages.
6074
6075 These are the categories used to filter messages via --filter.
6076 """
erg+personal@google.com05189642010-04-30 20:43:03 +00006077 sys.stderr.write(''.join(' %s\n' % cat for cat in _ERROR_CATEGORIES))
erg@google.com4e00b9a2009-01-12 23:05:11 +00006078 sys.exit(0)
6079
6080
6081def ParseArguments(args):
6082 """Parses the command line arguments.
6083
6084 This may set the output format and verbosity level as side-effects.
6085
6086 Args:
6087 args: The command line arguments:
6088
6089 Returns:
6090 The list of filenames to lint.
6091 """
6092 try:
6093 (opts, filenames) = getopt.getopt(args, '', ['help', 'output=', 'verbose=',
erg@google.coma868d2d2009-10-09 21:18:45 +00006094 'counting=',
erg@google.com4d70a882013-04-16 21:06:32 +00006095 'filter=',
erg@google.comab53edf2013-11-05 22:23:37 +00006096 'root=',
erg@google.com19680272013-12-16 22:48:54 +00006097 'linelength=',
LukeCz7197a242016-09-24 13:27:35 -05006098 'extensions=',
6099 'headers='])
erg@google.com4e00b9a2009-01-12 23:05:11 +00006100 except getopt.GetoptError:
6101 PrintUsage('Invalid arguments.')
6102
6103 verbosity = _VerboseLevel()
6104 output_format = _OutputFormat()
6105 filters = ''
erg@google.coma868d2d2009-10-09 21:18:45 +00006106 counting_style = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +00006107
6108 for (opt, val) in opts:
6109 if opt == '--help':
6110 PrintUsage(None)
6111 elif opt == '--output':
erg@google.comc6671232013-10-25 21:44:03 +00006112 if val not in ('emacs', 'vs7', 'eclipse'):
erg@google.com02c27fd2013-05-28 21:34:34 +00006113 PrintUsage('The only allowed output formats are emacs, vs7 and eclipse.')
erg@google.com4e00b9a2009-01-12 23:05:11 +00006114 output_format = val
6115 elif opt == '--verbose':
6116 verbosity = int(val)
6117 elif opt == '--filter':
6118 filters = val
erg@google.coma87abb82009-02-24 01:41:01 +00006119 if not filters:
erg@google.com4e00b9a2009-01-12 23:05:11 +00006120 PrintCategories()
erg@google.coma868d2d2009-10-09 21:18:45 +00006121 elif opt == '--counting':
6122 if val not in ('total', 'toplevel', 'detailed'):
6123 PrintUsage('Valid counting options are total, toplevel, and detailed')
6124 counting_style = val
erg@google.com4d70a882013-04-16 21:06:32 +00006125 elif opt == '--root':
6126 global _root
6127 _root = val
erg@google.comab53edf2013-11-05 22:23:37 +00006128 elif opt == '--linelength':
6129 global _line_length
6130 try:
6131 _line_length = int(val)
6132 except ValueError:
6133 PrintUsage('Line length must be digits.')
erg@google.com19680272013-12-16 22:48:54 +00006134 elif opt == '--extensions':
6135 global _valid_extensions
6136 try:
6137 _valid_extensions = set(val.split(','))
6138 except ValueError:
6139 PrintUsage('Extensions must be comma seperated list.')
LukeCz7197a242016-09-24 13:27:35 -05006140 elif opt == '--headers':
6141 ProcessHppHeadersOption(val)
erg@google.com4e00b9a2009-01-12 23:05:11 +00006142
6143 if not filenames:
6144 PrintUsage('No files were specified.')
6145
6146 _SetOutputFormat(output_format)
6147 _SetVerboseLevel(verbosity)
6148 _SetFilters(filters)
erg@google.coma868d2d2009-10-09 21:18:45 +00006149 _SetCountingStyle(counting_style)
erg@google.com4e00b9a2009-01-12 23:05:11 +00006150
6151 return filenames
6152
6153
6154def main():
6155 filenames = ParseArguments(sys.argv[1:])
6156
6157 # Change stderr to write with replacement characters so we don't die
6158 # if we try to print something containing non-ASCII characters.
6159 sys.stderr = codecs.StreamReaderWriter(sys.stderr,
6160 codecs.getreader('utf8'),
6161 codecs.getwriter('utf8'),
6162 'replace')
6163
erg@google.coma868d2d2009-10-09 21:18:45 +00006164 _cpplint_state.ResetErrorCounts()
erg@google.com4e00b9a2009-01-12 23:05:11 +00006165 for filename in filenames:
6166 ProcessFile(filename, _cpplint_state.verbose_level)
erg@google.coma868d2d2009-10-09 21:18:45 +00006167 _cpplint_state.PrintErrorCounts()
6168
erg@google.com4e00b9a2009-01-12 23:05:11 +00006169 sys.exit(_cpplint_state.error_count > 0)
6170
6171
6172if __name__ == '__main__':
6173 main()