blob: be10764ebbd99e7bf63f4b21a1c7563a9085e85c [file] [log] [blame]
erg@google.com4e00b9a2009-01-12 23:05:11 +00001#!/usr/bin/python2.4
2#
erg@google.com969161c2009-06-26 22:06:46 +00003# Copyright (c) 2009 Google Inc. All rights reserved.
erg@google.com4e00b9a2009-01-12 23:05:11 +00004#
erg@google.com969161c2009-06-26 22:06:46 +00005# Redistribution and use in source and binary forms, with or without
6# modification, are permitted provided that the following conditions are
7# met:
erg@google.com4e00b9a2009-01-12 23:05:11 +00008#
erg@google.com969161c2009-06-26 22:06:46 +00009# * Redistributions of source code must retain the above copyright
10# notice, this list of conditions and the following disclaimer.
11# * Redistributions in binary form must reproduce the above
12# copyright notice, this list of conditions and the following disclaimer
13# in the documentation and/or other materials provided with the
14# distribution.
15# * Neither the name of Google Inc. nor the names of its
16# contributors may be used to endorse or promote products derived from
17# this software without specific prior written permission.
erg@google.com4e00b9a2009-01-12 23:05:11 +000018#
erg@google.com969161c2009-06-26 22:06:46 +000019# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
20# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
21# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
22# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
23# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
24# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
25# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
26# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
27# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
28# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
29# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
erg@google.com4e00b9a2009-01-12 23:05:11 +000030
31# Here are some issues that I've had people identify in my code during reviews,
32# that I think are possible to flag automatically in a lint tool. If these were
33# caught by lint, it would save time both for myself and that of my reviewers.
34# Most likely, some of these are beyond the scope of the current lint framework,
35# but I think it is valuable to retain these wish-list items even if they cannot
36# be immediately implemented.
37#
38# Suggestions
39# -----------
40# - Check for no 'explicit' for multi-arg ctor
41# - Check for boolean assign RHS in parens
42# - Check for ctor initializer-list colon position and spacing
43# - Check that if there's a ctor, there should be a dtor
44# - Check accessors that return non-pointer member variables are
45# declared const
46# - Check accessors that return non-const pointer member vars are
47# *not* declared const
48# - Check for using public includes for testing
49# - Check for spaces between brackets in one-line inline method
50# - Check for no assert()
51# - Check for spaces surrounding operators
52# - Check for 0 in pointer context (should be NULL)
53# - Check for 0 in char context (should be '\0')
54# - Check for camel-case method name conventions for methods
55# that are not simple inline getters and setters
56# - Check that base classes have virtual destructors
57# put " // namespace" after } that closes a namespace, with
58# namespace's name after 'namespace' if it is named.
59# - Do not indent namespace contents
60# - Avoid inlining non-trivial constructors in header files
61# include base/basictypes.h if DISALLOW_EVIL_CONSTRUCTORS is used
62# - Check for old-school (void) cast for call-sites of functions
63# ignored return value
64# - Check gUnit usage of anonymous namespace
65# - Check for class declaration order (typedefs, consts, enums,
66# ctor(s?), dtor, friend declarations, methods, member vars)
67#
68
69"""Does google-lint on c++ files.
70
71The goal of this script is to identify places in the code that *may*
72be in non-compliance with google style. It does not attempt to fix
73up these problems -- the point is to educate. It does also not
74attempt to find all problems, or to ensure that everything it does
75find is legitimately a problem.
76
77In particular, we can get very confused by /* and // inside strings!
78We do a small hack, which is to ignore //'s with "'s after them on the
79same line, but it is far from perfect (in either direction).
80"""
81
82import codecs
83import getopt
84import math # for log
85import os
86import re
87import sre_compile
88import string
89import sys
90import unicodedata
91
92
93_USAGE = """
94Syntax: cpplint.py [--verbose=#] [--output=vs7] [--filter=-x,+y,...]
erg@google.coma868d2d2009-10-09 21:18:45 +000095 [--counting=total|toplevel|detailed]
erg@google.com4e00b9a2009-01-12 23:05:11 +000096 <file> [file] ...
97
98 The style guidelines this tries to follow are those in
99 http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
100
101 Every problem is given a confidence score from 1-5, with 5 meaning we are
102 certain of the problem, and 1 meaning it could be a legitimate construct.
103 This will miss some errors, and is not a substitute for a code review.
104
erg+personal@google.com05189642010-04-30 20:43:03 +0000105 To suppress false-positive errors of a certain category, add a
106 'NOLINT(category)' comment to the line. NOLINT or NOLINT(*)
107 suppresses errors of all categories on that line.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000108
109 The files passed in will be linted; at least one file must be provided.
110 Linted extensions are .cc, .cpp, and .h. Other file types will be ignored.
111
112 Flags:
113
114 output=vs7
115 By default, the output is formatted to ease emacs parsing. Visual Studio
116 compatible output (vs7) may also be used. Other formats are unsupported.
117
118 verbose=#
119 Specify a number 0-5 to restrict errors to certain verbosity levels.
120
121 filter=-x,+y,...
122 Specify a comma-separated list of category-filters to apply: only
123 error messages whose category names pass the filters will be printed.
124 (Category names are printed with the message and look like
125 "[whitespace/indent]".) Filters are evaluated left to right.
126 "-FOO" and "FOO" means "do not print categories that start with FOO".
127 "+FOO" means "do print categories that start with FOO".
128
129 Examples: --filter=-whitespace,+whitespace/braces
130 --filter=whitespace,runtime/printf,+runtime/printf_format
131 --filter=-,+build/include_what_you_use
132
133 To see a list of all the categories used in cpplint, pass no arg:
134 --filter=
erg@google.coma868d2d2009-10-09 21:18:45 +0000135
136 counting=total|toplevel|detailed
137 The total number of errors found is always printed. If
138 'toplevel' is provided, then the count of errors in each of
139 the top-level categories like 'build' and 'whitespace' will
140 also be printed. If 'detailed' is provided, then a count
141 is provided for each category like 'build/class'.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000142"""
143
144# We categorize each error message we print. Here are the categories.
145# We want an explicit list so we can list them all in cpplint --filter=.
146# If you add a new error message with a new category, add it to the list
147# here! cpplint_unittest.py should tell you if you forget to do this.
erg@google.coma87abb82009-02-24 01:41:01 +0000148# \ used for clearer layout -- pylint: disable-msg=C6013
erg+personal@google.com05189642010-04-30 20:43:03 +0000149_ERROR_CATEGORIES = [
150 'build/class',
151 'build/deprecated',
152 'build/endif_comment',
153 'build/forward_decl',
154 'build/header_guard',
155 'build/include',
156 'build/include_alpha',
157 'build/include_order',
158 'build/include_what_you_use',
159 'build/namespaces',
160 'build/printf_format',
161 'build/storage_class',
162 'legal/copyright',
163 'readability/braces',
164 'readability/casting',
165 'readability/check',
166 'readability/constructors',
167 'readability/fn_size',
168 'readability/function',
169 'readability/multiline_comment',
170 'readability/multiline_string',
171 'readability/nolint',
172 'readability/streams',
173 'readability/todo',
174 'readability/utf8',
175 'runtime/arrays',
176 'runtime/casting',
177 'runtime/explicit',
178 'runtime/int',
179 'runtime/init',
180 'runtime/invalid_increment',
181 'runtime/member_string_references',
182 'runtime/memset',
183 'runtime/operator',
184 'runtime/printf',
185 'runtime/printf_format',
186 'runtime/references',
187 'runtime/rtti',
188 'runtime/sizeof',
189 'runtime/string',
190 'runtime/threadsafe_fn',
191 'runtime/virtual',
192 'whitespace/blank_line',
193 'whitespace/braces',
194 'whitespace/comma',
195 'whitespace/comments',
196 'whitespace/end_of_line',
197 'whitespace/ending_newline',
198 'whitespace/indent',
199 'whitespace/labels',
200 'whitespace/line_length',
201 'whitespace/newline',
202 'whitespace/operators',
203 'whitespace/parens',
204 'whitespace/semicolon',
205 'whitespace/tab',
206 'whitespace/todo'
207 ]
erg@google.com4e00b9a2009-01-12 23:05:11 +0000208
erg@google.come35f7652009-06-19 20:52:09 +0000209# The default state of the category filter. This is overrided by the --filter=
210# flag. By default all errors are on, so only add here categories that should be
211# off by default (i.e., categories that must be enabled by the --filter= flags).
212# All entries here should start with a '-' or '+', as in the --filter= flag.
erg@google.coma868d2d2009-10-09 21:18:45 +0000213_DEFAULT_FILTERS = [ '-build/include_alpha' ]
erg@google.come35f7652009-06-19 20:52:09 +0000214
erg@google.com4e00b9a2009-01-12 23:05:11 +0000215# We used to check for high-bit characters, but after much discussion we
216# decided those were OK, as long as they were in UTF-8 and didn't represent
217# hard-coded international strings, which belong in a seperate i18n file.
218
219# Headers that we consider STL headers.
220_STL_HEADERS = frozenset([
221 'algobase.h', 'algorithm', 'alloc.h', 'bitset', 'deque', 'exception',
222 'function.h', 'functional', 'hash_map', 'hash_map.h', 'hash_set',
erg+personal@google.com05189642010-04-30 20:43:03 +0000223 'hash_set.h', 'iterator', 'list', 'list.h', 'map', 'memory', 'new',
224 'pair.h', 'pthread_alloc', 'queue', 'set', 'set.h', 'sstream', 'stack',
erg@google.com4e00b9a2009-01-12 23:05:11 +0000225 'stl_alloc.h', 'stl_relops.h', 'type_traits.h',
226 'utility', 'vector', 'vector.h',
227 ])
228
229
230# Non-STL C++ system headers.
231_CPP_HEADERS = frozenset([
232 'algo.h', 'builtinbuf.h', 'bvector.h', 'cassert', 'cctype',
233 'cerrno', 'cfloat', 'ciso646', 'climits', 'clocale', 'cmath',
234 'complex', 'complex.h', 'csetjmp', 'csignal', 'cstdarg', 'cstddef',
235 'cstdio', 'cstdlib', 'cstring', 'ctime', 'cwchar', 'cwctype',
236 'defalloc.h', 'deque.h', 'editbuf.h', 'exception', 'fstream',
237 'fstream.h', 'hashtable.h', 'heap.h', 'indstream.h', 'iomanip',
238 'iomanip.h', 'ios', 'iosfwd', 'iostream', 'iostream.h', 'istream.h',
239 'iterator.h', 'limits', 'map.h', 'multimap.h', 'multiset.h',
240 'numeric', 'ostream.h', 'parsestream.h', 'pfstream.h', 'PlotFile.h',
241 'procbuf.h', 'pthread_alloc.h', 'rope', 'rope.h', 'ropeimpl.h',
242 'SFile.h', 'slist', 'slist.h', 'stack.h', 'stdexcept',
243 'stdiostream.h', 'streambuf.h', 'stream.h', 'strfile.h', 'string',
244 'strstream', 'strstream.h', 'tempbuf.h', 'tree.h', 'typeinfo', 'valarray',
245 ])
246
247
248# Assertion macros. These are defined in base/logging.h and
249# testing/base/gunit.h. Note that the _M versions need to come first
250# for substring matching to work.
251_CHECK_MACROS = [
erg@google.come35f7652009-06-19 20:52:09 +0000252 'DCHECK', 'CHECK',
erg@google.com4e00b9a2009-01-12 23:05:11 +0000253 'EXPECT_TRUE_M', 'EXPECT_TRUE',
254 'ASSERT_TRUE_M', 'ASSERT_TRUE',
255 'EXPECT_FALSE_M', 'EXPECT_FALSE',
256 'ASSERT_FALSE_M', 'ASSERT_FALSE',
257 ]
258
erg@google.come35f7652009-06-19 20:52:09 +0000259# Replacement macros for CHECK/DCHECK/EXPECT_TRUE/EXPECT_FALSE
erg@google.com4e00b9a2009-01-12 23:05:11 +0000260_CHECK_REPLACEMENT = dict([(m, {}) for m in _CHECK_MACROS])
261
262for op, replacement in [('==', 'EQ'), ('!=', 'NE'),
263 ('>=', 'GE'), ('>', 'GT'),
264 ('<=', 'LE'), ('<', 'LT')]:
erg@google.come35f7652009-06-19 20:52:09 +0000265 _CHECK_REPLACEMENT['DCHECK'][op] = 'DCHECK_%s' % replacement
erg@google.com4e00b9a2009-01-12 23:05:11 +0000266 _CHECK_REPLACEMENT['CHECK'][op] = 'CHECK_%s' % replacement
267 _CHECK_REPLACEMENT['EXPECT_TRUE'][op] = 'EXPECT_%s' % replacement
268 _CHECK_REPLACEMENT['ASSERT_TRUE'][op] = 'ASSERT_%s' % replacement
269 _CHECK_REPLACEMENT['EXPECT_TRUE_M'][op] = 'EXPECT_%s_M' % replacement
270 _CHECK_REPLACEMENT['ASSERT_TRUE_M'][op] = 'ASSERT_%s_M' % replacement
271
272for op, inv_replacement in [('==', 'NE'), ('!=', 'EQ'),
273 ('>=', 'LT'), ('>', 'LE'),
274 ('<=', 'GT'), ('<', 'GE')]:
275 _CHECK_REPLACEMENT['EXPECT_FALSE'][op] = 'EXPECT_%s' % inv_replacement
276 _CHECK_REPLACEMENT['ASSERT_FALSE'][op] = 'ASSERT_%s' % inv_replacement
277 _CHECK_REPLACEMENT['EXPECT_FALSE_M'][op] = 'EXPECT_%s_M' % inv_replacement
278 _CHECK_REPLACEMENT['ASSERT_FALSE_M'][op] = 'ASSERT_%s_M' % inv_replacement
279
280
281# These constants define types of headers for use with
282# _IncludeState.CheckNextIncludeOrder().
283_C_SYS_HEADER = 1
284_CPP_SYS_HEADER = 2
285_LIKELY_MY_HEADER = 3
286_POSSIBLE_MY_HEADER = 4
287_OTHER_HEADER = 5
288
289
290_regexp_compile_cache = {}
291
erg+personal@google.com05189642010-04-30 20:43:03 +0000292# Finds occurrences of NOLINT or NOLINT(...).
293_RE_SUPPRESSION = re.compile(r'\bNOLINT\b(\([^)]*\))?')
294
295# {str, set(int)}: a map from error categories to sets of linenumbers
296# on which those errors are expected and should be suppressed.
297_error_suppressions = {}
298
299def ParseNolintSuppressions(filename, raw_line, linenum, error):
300 """Updates the global list of error-suppressions.
301
302 Parses any NOLINT comments on the current line, updating the global
303 error_suppressions store. Reports an error if the NOLINT comment
304 was malformed.
305
306 Args:
307 filename: str, the name of the input file.
308 raw_line: str, the line of input text, with comments.
309 linenum: int, the number of the current line.
310 error: function, an error handler.
311 """
312 # FIXME(adonovan): "NOLINT(" is misparsed as NOLINT(*).
313 m = _RE_SUPPRESSION.search(raw_line)
314 if m:
315 category = m.group(1)
316 if category in (None, '(*)'): # => "suppress all"
317 _error_suppressions.setdefault(None, set()).add(linenum)
318 else:
319 if category.startswith('(') and category.endswith(')'):
320 category = category[1:-1]
321 if category in _ERROR_CATEGORIES:
322 _error_suppressions.setdefault(category, set()).add(linenum)
323 else:
324 error(filename, linenum, 'readability/nolint', 5,
325 'Unknown NOLINT error category: %s' % category)
326
327
328def ResetNolintSuppressions():
329 "Resets the set of NOLINT suppressions to empty."
330 _error_suppressions.clear()
331
332
333def IsErrorSuppressedByNolint(category, linenum):
334 """Returns true if the specified error category is suppressed on this line.
335
336 Consults the global error_suppressions map populated by
337 ParseNolintSuppressions/ResetNolintSuppressions.
338
339 Args:
340 category: str, the category of the error.
341 linenum: int, the current line number.
342 Returns:
343 bool, True iff the error should be suppressed due to a NOLINT comment.
344 """
345 return (linenum in _error_suppressions.get(category, set()) or
346 linenum in _error_suppressions.get(None, set()))
erg@google.com4e00b9a2009-01-12 23:05:11 +0000347
348def Match(pattern, s):
349 """Matches the string with the pattern, caching the compiled regexp."""
350 # The regexp compilation caching is inlined in both Match and Search for
351 # performance reasons; factoring it out into a separate function turns out
352 # to be noticeably expensive.
353 if not pattern in _regexp_compile_cache:
354 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
355 return _regexp_compile_cache[pattern].match(s)
356
357
358def Search(pattern, s):
359 """Searches the string for the pattern, caching the compiled regexp."""
360 if not pattern in _regexp_compile_cache:
361 _regexp_compile_cache[pattern] = sre_compile.compile(pattern)
362 return _regexp_compile_cache[pattern].search(s)
363
364
365class _IncludeState(dict):
366 """Tracks line numbers for includes, and the order in which includes appear.
367
368 As a dict, an _IncludeState object serves as a mapping between include
369 filename and line number on which that file was included.
370
371 Call CheckNextIncludeOrder() once for each header in the file, passing
372 in the type constants defined above. Calls in an illegal order will
373 raise an _IncludeError with an appropriate error message.
374
375 """
376 # self._section will move monotonically through this set. If it ever
377 # needs to move backwards, CheckNextIncludeOrder will raise an error.
378 _INITIAL_SECTION = 0
379 _MY_H_SECTION = 1
380 _C_SECTION = 2
381 _CPP_SECTION = 3
382 _OTHER_H_SECTION = 4
383
384 _TYPE_NAMES = {
385 _C_SYS_HEADER: 'C system header',
386 _CPP_SYS_HEADER: 'C++ system header',
387 _LIKELY_MY_HEADER: 'header this file implements',
388 _POSSIBLE_MY_HEADER: 'header this file may implement',
389 _OTHER_HEADER: 'other header',
390 }
391 _SECTION_NAMES = {
392 _INITIAL_SECTION: "... nothing. (This can't be an error.)",
393 _MY_H_SECTION: 'a header this file implements',
394 _C_SECTION: 'C system header',
395 _CPP_SECTION: 'C++ system header',
396 _OTHER_H_SECTION: 'other header',
397 }
398
399 def __init__(self):
400 dict.__init__(self)
erg@google.coma868d2d2009-10-09 21:18:45 +0000401 # The name of the current section.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000402 self._section = self._INITIAL_SECTION
erg@google.coma868d2d2009-10-09 21:18:45 +0000403 # The path of last found header.
404 self._last_header = ''
405
406 def CanonicalizeAlphabeticalOrder(self, header_path):
407 """Returns a path canonicalized for alphabetical comparisson.
408
409 - replaces "-" with "_" so they both cmp the same.
410 - removes '-inl' since we don't require them to be after the main header.
411 - lowercase everything, just in case.
412
413 Args:
414 header_path: Path to be canonicalized.
415
416 Returns:
417 Canonicalized path.
418 """
419 return header_path.replace('-inl.h', '.h').replace('-', '_').lower()
420
421 def IsInAlphabeticalOrder(self, header_path):
422 """Check if a header is in alphabetical order with the previous header.
423
424 Args:
425 header_path: Header to be checked.
426
427 Returns:
428 Returns true if the header is in alphabetical order.
429 """
430 canonical_header = self.CanonicalizeAlphabeticalOrder(header_path)
431 if self._last_header > canonical_header:
432 return False
433 self._last_header = canonical_header
434 return True
erg@google.com4e00b9a2009-01-12 23:05:11 +0000435
436 def CheckNextIncludeOrder(self, header_type):
437 """Returns a non-empty error message if the next header is out of order.
438
439 This function also updates the internal state to be ready to check
440 the next include.
441
442 Args:
443 header_type: One of the _XXX_HEADER constants defined above.
444
445 Returns:
446 The empty string if the header is in the right order, or an
447 error message describing what's wrong.
448
449 """
450 error_message = ('Found %s after %s' %
451 (self._TYPE_NAMES[header_type],
452 self._SECTION_NAMES[self._section]))
453
erg@google.coma868d2d2009-10-09 21:18:45 +0000454 last_section = self._section
455
erg@google.com4e00b9a2009-01-12 23:05:11 +0000456 if header_type == _C_SYS_HEADER:
457 if self._section <= self._C_SECTION:
458 self._section = self._C_SECTION
459 else:
erg@google.coma868d2d2009-10-09 21:18:45 +0000460 self._last_header = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +0000461 return error_message
462 elif header_type == _CPP_SYS_HEADER:
463 if self._section <= self._CPP_SECTION:
464 self._section = self._CPP_SECTION
465 else:
erg@google.coma868d2d2009-10-09 21:18:45 +0000466 self._last_header = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +0000467 return error_message
468 elif header_type == _LIKELY_MY_HEADER:
469 if self._section <= self._MY_H_SECTION:
470 self._section = self._MY_H_SECTION
471 else:
472 self._section = self._OTHER_H_SECTION
473 elif header_type == _POSSIBLE_MY_HEADER:
474 if self._section <= self._MY_H_SECTION:
475 self._section = self._MY_H_SECTION
476 else:
477 # This will always be the fallback because we're not sure
478 # enough that the header is associated with this file.
479 self._section = self._OTHER_H_SECTION
480 else:
481 assert header_type == _OTHER_HEADER
482 self._section = self._OTHER_H_SECTION
483
erg@google.coma868d2d2009-10-09 21:18:45 +0000484 if last_section != self._section:
485 self._last_header = ''
486
erg@google.com4e00b9a2009-01-12 23:05:11 +0000487 return ''
488
489
490class _CppLintState(object):
491 """Maintains module-wide state.."""
492
493 def __init__(self):
494 self.verbose_level = 1 # global setting.
495 self.error_count = 0 # global count of reported errors
erg@google.come35f7652009-06-19 20:52:09 +0000496 # filters to apply when emitting error messages
497 self.filters = _DEFAULT_FILTERS[:]
erg@google.coma868d2d2009-10-09 21:18:45 +0000498 self.counting = 'total' # In what way are we counting errors?
499 self.errors_by_category = {} # string to int dict storing error counts
erg@google.com4e00b9a2009-01-12 23:05:11 +0000500
501 # output format:
502 # "emacs" - format that emacs can parse (default)
503 # "vs7" - format that Microsoft Visual Studio 7 can parse
504 self.output_format = 'emacs'
505
506 def SetOutputFormat(self, output_format):
507 """Sets the output format for errors."""
508 self.output_format = output_format
509
510 def SetVerboseLevel(self, level):
511 """Sets the module's verbosity, and returns the previous setting."""
512 last_verbose_level = self.verbose_level
513 self.verbose_level = level
514 return last_verbose_level
515
erg@google.coma868d2d2009-10-09 21:18:45 +0000516 def SetCountingStyle(self, counting_style):
517 """Sets the module's counting options."""
518 self.counting = counting_style
519
erg@google.com4e00b9a2009-01-12 23:05:11 +0000520 def SetFilters(self, filters):
521 """Sets the error-message filters.
522
523 These filters are applied when deciding whether to emit a given
524 error message.
525
526 Args:
527 filters: A string of comma-separated filters (eg "+whitespace/indent").
528 Each filter should start with + or -; else we die.
erg@google.coma87abb82009-02-24 01:41:01 +0000529
530 Raises:
531 ValueError: The comma-separated filters did not all start with '+' or '-'.
532 E.g. "-,+whitespace,-whitespace/indent,whitespace/badfilter"
erg@google.com4e00b9a2009-01-12 23:05:11 +0000533 """
erg@google.come35f7652009-06-19 20:52:09 +0000534 # Default filters always have less priority than the flag ones.
535 self.filters = _DEFAULT_FILTERS[:]
536 for filt in filters.split(','):
537 clean_filt = filt.strip()
538 if clean_filt:
539 self.filters.append(clean_filt)
erg@google.com4e00b9a2009-01-12 23:05:11 +0000540 for filt in self.filters:
541 if not (filt.startswith('+') or filt.startswith('-')):
542 raise ValueError('Every filter in --filters must start with + or -'
543 ' (%s does not)' % filt)
544
erg@google.coma868d2d2009-10-09 21:18:45 +0000545 def ResetErrorCounts(self):
erg@google.com4e00b9a2009-01-12 23:05:11 +0000546 """Sets the module's error statistic back to zero."""
547 self.error_count = 0
erg@google.coma868d2d2009-10-09 21:18:45 +0000548 self.errors_by_category = {}
erg@google.com4e00b9a2009-01-12 23:05:11 +0000549
erg@google.coma868d2d2009-10-09 21:18:45 +0000550 def IncrementErrorCount(self, category):
erg@google.com4e00b9a2009-01-12 23:05:11 +0000551 """Bumps the module's error statistic."""
552 self.error_count += 1
erg@google.coma868d2d2009-10-09 21:18:45 +0000553 if self.counting in ('toplevel', 'detailed'):
554 if self.counting != 'detailed':
555 category = category.split('/')[0]
556 if category not in self.errors_by_category:
557 self.errors_by_category[category] = 0
558 self.errors_by_category[category] += 1
erg@google.com4e00b9a2009-01-12 23:05:11 +0000559
erg@google.coma868d2d2009-10-09 21:18:45 +0000560 def PrintErrorCounts(self):
561 """Print a summary of errors by category, and the total."""
562 for category, count in self.errors_by_category.iteritems():
563 sys.stderr.write('Category \'%s\' errors found: %d\n' %
564 (category, count))
565 sys.stderr.write('Total errors found: %d\n' % self.error_count)
erg@google.com4e00b9a2009-01-12 23:05:11 +0000566
567_cpplint_state = _CppLintState()
568
569
570def _OutputFormat():
571 """Gets the module's output format."""
572 return _cpplint_state.output_format
573
574
575def _SetOutputFormat(output_format):
576 """Sets the module's output format."""
577 _cpplint_state.SetOutputFormat(output_format)
578
579
580def _VerboseLevel():
581 """Returns the module's verbosity setting."""
582 return _cpplint_state.verbose_level
583
584
585def _SetVerboseLevel(level):
586 """Sets the module's verbosity, and returns the previous setting."""
587 return _cpplint_state.SetVerboseLevel(level)
588
589
erg@google.coma868d2d2009-10-09 21:18:45 +0000590def _SetCountingStyle(level):
591 """Sets the module's counting options."""
592 _cpplint_state.SetCountingStyle(level)
593
594
erg@google.com4e00b9a2009-01-12 23:05:11 +0000595def _Filters():
596 """Returns the module's list of output filters, as a list."""
597 return _cpplint_state.filters
598
599
600def _SetFilters(filters):
601 """Sets the module's error-message filters.
602
603 These filters are applied when deciding whether to emit a given
604 error message.
605
606 Args:
607 filters: A string of comma-separated filters (eg "whitespace/indent").
608 Each filter should start with + or -; else we die.
609 """
610 _cpplint_state.SetFilters(filters)
611
612
613class _FunctionState(object):
614 """Tracks current function name and the number of lines in its body."""
615
616 _NORMAL_TRIGGER = 250 # for --v=0, 500 for --v=1, etc.
617 _TEST_TRIGGER = 400 # about 50% more than _NORMAL_TRIGGER.
618
619 def __init__(self):
620 self.in_a_function = False
621 self.lines_in_function = 0
622 self.current_function = ''
623
624 def Begin(self, function_name):
625 """Start analyzing function body.
626
627 Args:
628 function_name: The name of the function being tracked.
629 """
630 self.in_a_function = True
631 self.lines_in_function = 0
632 self.current_function = function_name
633
634 def Count(self):
635 """Count line in current function body."""
636 if self.in_a_function:
637 self.lines_in_function += 1
638
639 def Check(self, error, filename, linenum):
640 """Report if too many lines in function body.
641
642 Args:
643 error: The function to call with any errors found.
644 filename: The name of the current file.
645 linenum: The number of the line to check.
646 """
647 if Match(r'T(EST|est)', self.current_function):
648 base_trigger = self._TEST_TRIGGER
649 else:
650 base_trigger = self._NORMAL_TRIGGER
651 trigger = base_trigger * 2**_VerboseLevel()
652
653 if self.lines_in_function > trigger:
654 error_level = int(math.log(self.lines_in_function / base_trigger, 2))
655 # 50 => 0, 100 => 1, 200 => 2, 400 => 3, 800 => 4, 1600 => 5, ...
656 if error_level > 5:
657 error_level = 5
658 error(filename, linenum, 'readability/fn_size', error_level,
659 'Small and focused functions are preferred:'
660 ' %s has %d non-comment lines'
661 ' (error triggered by exceeding %d lines).' % (
662 self.current_function, self.lines_in_function, trigger))
663
664 def End(self):
665 """Stop analizing function body."""
666 self.in_a_function = False
667
668
669class _IncludeError(Exception):
670 """Indicates a problem with the include order in a file."""
671 pass
672
673
674class FileInfo:
675 """Provides utility functions for filenames.
676
677 FileInfo provides easy access to the components of a file's path
678 relative to the project root.
679 """
680
681 def __init__(self, filename):
682 self._filename = filename
683
684 def FullName(self):
685 """Make Windows paths like Unix."""
686 return os.path.abspath(self._filename).replace('\\', '/')
687
688 def RepositoryName(self):
689 """FullName after removing the local path to the repository.
690
691 If we have a real absolute path name here we can try to do something smart:
692 detecting the root of the checkout and truncating /path/to/checkout from
693 the name so that we get header guards that don't include things like
694 "C:\Documents and Settings\..." or "/home/username/..." in them and thus
695 people on different computers who have checked the source out to different
696 locations won't see bogus errors.
697 """
698 fullname = self.FullName()
699
700 if os.path.exists(fullname):
701 project_dir = os.path.dirname(fullname)
702
703 if os.path.exists(os.path.join(project_dir, ".svn")):
704 # If there's a .svn file in the current directory, we recursively look
705 # up the directory tree for the top of the SVN checkout
706 root_dir = project_dir
707 one_up_dir = os.path.dirname(root_dir)
708 while os.path.exists(os.path.join(one_up_dir, ".svn")):
709 root_dir = os.path.dirname(root_dir)
710 one_up_dir = os.path.dirname(one_up_dir)
711
712 prefix = os.path.commonprefix([root_dir, project_dir])
713 return fullname[len(prefix) + 1:]
714
erg@google.com5e169692010-01-28 20:17:01 +0000715 # Not SVN? Try to find a git or hg top level directory by searching up
716 # from the current path.
erg@google.com4e00b9a2009-01-12 23:05:11 +0000717 root_dir = os.path.dirname(fullname)
718 while (root_dir != os.path.dirname(root_dir) and
erg@google.com5e169692010-01-28 20:17:01 +0000719 not os.path.exists(os.path.join(root_dir, ".git")) and
720 not os.path.exists(os.path.join(root_dir, ".hg"))):
erg@google.com4e00b9a2009-01-12 23:05:11 +0000721 root_dir = os.path.dirname(root_dir)
erg@google.com42e59b02010-10-04 22:18:07 +0000722
723 if (os.path.exists(os.path.join(root_dir, ".git")) or
724 os.path.exists(os.path.join(root_dir, ".hg"))):
725 prefix = os.path.commonprefix([root_dir, project_dir])
726 return fullname[len(prefix) + 1:]
erg@google.com4e00b9a2009-01-12 23:05:11 +0000727
728 # Don't know what to do; header guard warnings may be wrong...
729 return fullname
730
731 def Split(self):
732 """Splits the file into the directory, basename, and extension.
733
734 For 'chrome/browser/browser.cc', Split() would
735 return ('chrome/browser', 'browser', '.cc')
736
737 Returns:
738 A tuple of (directory, basename, extension).
739 """
740
741 googlename = self.RepositoryName()
742 project, rest = os.path.split(googlename)
743 return (project,) + os.path.splitext(rest)
744
745 def BaseName(self):
746 """File base name - text after the final slash, before the final period."""
747 return self.Split()[1]
748
749 def Extension(self):
750 """File extension - text following the final period."""
751 return self.Split()[2]
752
753 def NoExtension(self):
754 """File has no source file extension."""
755 return '/'.join(self.Split()[0:2])
756
757 def IsSource(self):
758 """File has a source file extension."""
759 return self.Extension()[1:] in ('c', 'cc', 'cpp', 'cxx')
760
761
erg+personal@google.com05189642010-04-30 20:43:03 +0000762def _ShouldPrintError(category, confidence, linenum):
763 """Returns true iff confidence >= verbose, category passes
764 filter and is not NOLINT-suppressed."""
765
766 # There are three ways we might decide not to print an error message:
767 # a "NOLINT(category)" comment appears in the source,
erg@google.com4e00b9a2009-01-12 23:05:11 +0000768 # the verbosity level isn't high enough, or the filters filter it out.
erg+personal@google.com05189642010-04-30 20:43:03 +0000769 if IsErrorSuppressedByNolint(category, linenum):
770 return False
erg@google.com4e00b9a2009-01-12 23:05:11 +0000771 if confidence < _cpplint_state.verbose_level:
772 return False
773
774 is_filtered = False
775 for one_filter in _Filters():
776 if one_filter.startswith('-'):
777 if category.startswith(one_filter[1:]):
778 is_filtered = True
779 elif one_filter.startswith('+'):
780 if category.startswith(one_filter[1:]):
781 is_filtered = False
782 else:
783 assert False # should have been checked for in SetFilter.
784 if is_filtered:
785 return False
786
787 return True
788
789
790def Error(filename, linenum, category, confidence, message):
791 """Logs the fact we've found a lint error.
792
793 We log where the error was found, and also our confidence in the error,
794 that is, how certain we are this is a legitimate style regression, and
795 not a misidentification or a use that's sometimes justified.
796
erg+personal@google.com05189642010-04-30 20:43:03 +0000797 False positives can be suppressed by the use of
798 "cpplint(category)" comments on the offending line. These are
799 parsed into _error_suppressions.
800
erg@google.com4e00b9a2009-01-12 23:05:11 +0000801 Args:
802 filename: The name of the file containing the error.
803 linenum: The number of the line containing the error.
804 category: A string used to describe the "category" this bug
805 falls under: "whitespace", say, or "runtime". Categories
806 may have a hierarchy separated by slashes: "whitespace/indent".
807 confidence: A number from 1-5 representing a confidence score for
808 the error, with 5 meaning that we are certain of the problem,
809 and 1 meaning that it could be a legitimate construct.
810 message: The error message.
811 """
erg+personal@google.com05189642010-04-30 20:43:03 +0000812 if _ShouldPrintError(category, confidence, linenum):
erg@google.coma868d2d2009-10-09 21:18:45 +0000813 _cpplint_state.IncrementErrorCount(category)
erg@google.com4e00b9a2009-01-12 23:05:11 +0000814 if _cpplint_state.output_format == 'vs7':
815 sys.stderr.write('%s(%s): %s [%s] [%d]\n' % (
816 filename, linenum, message, category, confidence))
817 else:
818 sys.stderr.write('%s:%s: %s [%s] [%d]\n' % (
819 filename, linenum, message, category, confidence))
820
821
822# Matches standard C++ escape esequences per 2.13.2.3 of the C++ standard.
823_RE_PATTERN_CLEANSE_LINE_ESCAPES = re.compile(
824 r'\\([abfnrtv?"\\\']|\d+|x[0-9a-fA-F]+)')
825# Matches strings. Escape codes should already be removed by ESCAPES.
826_RE_PATTERN_CLEANSE_LINE_DOUBLE_QUOTES = re.compile(r'"[^"]*"')
827# Matches characters. Escape codes should already be removed by ESCAPES.
828_RE_PATTERN_CLEANSE_LINE_SINGLE_QUOTES = re.compile(r"'.'")
829# Matches multi-line C++ comments.
830# This RE is a little bit more complicated than one might expect, because we
831# have to take care of space removals tools so we can handle comments inside
832# statements better.
833# The current rule is: We only clear spaces from both sides when we're at the
834# end of the line. Otherwise, we try to remove spaces from the right side,
835# if this doesn't work we try on left side but only if there's a non-character
836# on the right.
837_RE_PATTERN_CLEANSE_LINE_C_COMMENTS = re.compile(
838 r"""(\s*/\*.*\*/\s*$|
839 /\*.*\*/\s+|
840 \s+/\*.*\*/(?=\W)|
841 /\*.*\*/)""", re.VERBOSE)
842
843
844def IsCppString(line):
845 """Does line terminate so, that the next symbol is in string constant.
846
847 This function does not consider single-line nor multi-line comments.
848
849 Args:
850 line: is a partial line of code starting from the 0..n.
851
852 Returns:
853 True, if next character appended to 'line' is inside a
854 string constant.
855 """
856
857 line = line.replace(r'\\', 'XX') # after this, \\" does not match to \"
858 return ((line.count('"') - line.count(r'\"') - line.count("'\"'")) & 1) == 1
859
860
861def FindNextMultiLineCommentStart(lines, lineix):
862 """Find the beginning marker for a multiline comment."""
863 while lineix < len(lines):
864 if lines[lineix].strip().startswith('/*'):
865 # Only return this marker if the comment goes beyond this line
866 if lines[lineix].strip().find('*/', 2) < 0:
867 return lineix
868 lineix += 1
869 return len(lines)
870
871
872def FindNextMultiLineCommentEnd(lines, lineix):
873 """We are inside a comment, find the end marker."""
874 while lineix < len(lines):
875 if lines[lineix].strip().endswith('*/'):
876 return lineix
877 lineix += 1
878 return len(lines)
879
880
881def RemoveMultiLineCommentsFromRange(lines, begin, end):
882 """Clears a range of lines for multi-line comments."""
883 # Having // dummy comments makes the lines non-empty, so we will not get
884 # unnecessary blank line warnings later in the code.
885 for i in range(begin, end):
886 lines[i] = '// dummy'
887
888
889def RemoveMultiLineComments(filename, lines, error):
890 """Removes multiline (c-style) comments from lines."""
891 lineix = 0
892 while lineix < len(lines):
893 lineix_begin = FindNextMultiLineCommentStart(lines, lineix)
894 if lineix_begin >= len(lines):
895 return
896 lineix_end = FindNextMultiLineCommentEnd(lines, lineix_begin)
897 if lineix_end >= len(lines):
898 error(filename, lineix_begin + 1, 'readability/multiline_comment', 5,
899 'Could not find end of multi-line comment')
900 return
901 RemoveMultiLineCommentsFromRange(lines, lineix_begin, lineix_end + 1)
902 lineix = lineix_end + 1
903
904
905def CleanseComments(line):
906 """Removes //-comments and single-line C-style /* */ comments.
907
908 Args:
909 line: A line of C++ source.
910
911 Returns:
912 The line with single-line comments removed.
913 """
914 commentpos = line.find('//')
915 if commentpos != -1 and not IsCppString(line[:commentpos]):
916 line = line[:commentpos]
917 # get rid of /* ... */
918 return _RE_PATTERN_CLEANSE_LINE_C_COMMENTS.sub('', line)
919
920
erg@google.coma87abb82009-02-24 01:41:01 +0000921class CleansedLines(object):
erg@google.com4e00b9a2009-01-12 23:05:11 +0000922 """Holds 3 copies of all lines with different preprocessing applied to them.
923
924 1) elided member contains lines without strings and comments,
925 2) lines member contains lines without comments, and
926 3) raw member contains all the lines without processing.
927 All these three members are of <type 'list'>, and of the same length.
928 """
929
930 def __init__(self, lines):
931 self.elided = []
932 self.lines = []
933 self.raw_lines = lines
934 self.num_lines = len(lines)
935 for linenum in range(len(lines)):
936 self.lines.append(CleanseComments(lines[linenum]))
937 elided = self._CollapseStrings(lines[linenum])
938 self.elided.append(CleanseComments(elided))
939
940 def NumLines(self):
941 """Returns the number of lines represented."""
942 return self.num_lines
943
944 @staticmethod
945 def _CollapseStrings(elided):
946 """Collapses strings and chars on a line to simple "" or '' blocks.
947
948 We nix strings first so we're not fooled by text like '"http://"'
949
950 Args:
951 elided: The line being processed.
952
953 Returns:
954 The line with collapsed strings.
955 """
956 if not _RE_PATTERN_INCLUDE.match(elided):
957 # Remove escaped characters first to make quote/single quote collapsing
958 # basic. Things that look like escaped characters shouldn't occur
959 # outside of strings and chars.
960 elided = _RE_PATTERN_CLEANSE_LINE_ESCAPES.sub('', elided)
961 elided = _RE_PATTERN_CLEANSE_LINE_SINGLE_QUOTES.sub("''", elided)
962 elided = _RE_PATTERN_CLEANSE_LINE_DOUBLE_QUOTES.sub('""', elided)
963 return elided
964
965
966def CloseExpression(clean_lines, linenum, pos):
967 """If input points to ( or { or [, finds the position that closes it.
968
969 If lines[linenum][pos] points to a '(' or '{' or '[', finds the the
970 linenum/pos that correspond to the closing of the expression.
971
972 Args:
973 clean_lines: A CleansedLines instance containing the file.
974 linenum: The number of the line to check.
975 pos: A position on the line.
976
977 Returns:
978 A tuple (line, linenum, pos) pointer *past* the closing brace, or
979 (line, len(lines), -1) if we never find a close. Note we ignore
980 strings and comments when matching; and the line we return is the
981 'cleansed' line at linenum.
982 """
983
984 line = clean_lines.elided[linenum]
985 startchar = line[pos]
986 if startchar not in '({[':
987 return (line, clean_lines.NumLines(), -1)
988 if startchar == '(': endchar = ')'
989 if startchar == '[': endchar = ']'
990 if startchar == '{': endchar = '}'
991
992 num_open = line.count(startchar) - line.count(endchar)
993 while linenum < clean_lines.NumLines() and num_open > 0:
994 linenum += 1
995 line = clean_lines.elided[linenum]
996 num_open += line.count(startchar) - line.count(endchar)
997 # OK, now find the endchar that actually got us back to even
998 endpos = len(line)
999 while num_open >= 0:
1000 endpos = line.rfind(')', 0, endpos)
1001 num_open -= 1 # chopped off another )
1002 return (line, linenum, endpos + 1)
1003
1004
1005def CheckForCopyright(filename, lines, error):
1006 """Logs an error if no Copyright message appears at the top of the file."""
1007
1008 # We'll say it should occur by line 10. Don't forget there's a
1009 # dummy line at the front.
1010 for line in xrange(1, min(len(lines), 11)):
1011 if re.search(r'Copyright', lines[line], re.I): break
1012 else: # means no copyright line was found
1013 error(filename, 0, 'legal/copyright', 5,
1014 'No copyright message found. '
1015 'You should have a line: "Copyright [year] <Copyright Owner>"')
1016
1017
1018def GetHeaderGuardCPPVariable(filename):
1019 """Returns the CPP variable that should be used as a header guard.
1020
1021 Args:
1022 filename: The name of a C++ header file.
1023
1024 Returns:
1025 The CPP variable that should be used as a header guard in the
1026 named file.
1027
1028 """
1029
erg+personal@google.com05189642010-04-30 20:43:03 +00001030 # Restores original filename in case that cpplint is invoked from Emacs's
1031 # flymake.
1032 filename = re.sub(r'_flymake\.h$', '.h', filename)
1033
erg@google.com4e00b9a2009-01-12 23:05:11 +00001034 fileinfo = FileInfo(filename)
1035 return re.sub(r'[-./\s]', '_', fileinfo.RepositoryName()).upper() + '_'
1036
1037
1038def CheckForHeaderGuard(filename, lines, error):
1039 """Checks that the file contains a header guard.
1040
erg@google.coma87abb82009-02-24 01:41:01 +00001041 Logs an error if no #ifndef header guard is present. For other
erg@google.com4e00b9a2009-01-12 23:05:11 +00001042 headers, checks that the full pathname is used.
1043
1044 Args:
1045 filename: The name of the C++ header file.
1046 lines: An array of strings, each representing a line of the file.
1047 error: The function to call with any errors found.
1048 """
1049
1050 cppvar = GetHeaderGuardCPPVariable(filename)
1051
1052 ifndef = None
1053 ifndef_linenum = 0
1054 define = None
1055 endif = None
1056 endif_linenum = 0
1057 for linenum, line in enumerate(lines):
1058 linesplit = line.split()
1059 if len(linesplit) >= 2:
1060 # find the first occurrence of #ifndef and #define, save arg
1061 if not ifndef and linesplit[0] == '#ifndef':
1062 # set ifndef to the header guard presented on the #ifndef line.
1063 ifndef = linesplit[1]
1064 ifndef_linenum = linenum
1065 if not define and linesplit[0] == '#define':
1066 define = linesplit[1]
1067 # find the last occurrence of #endif, save entire line
1068 if line.startswith('#endif'):
1069 endif = line
1070 endif_linenum = linenum
1071
1072 if not ifndef or not define or ifndef != define:
1073 error(filename, 0, 'build/header_guard', 5,
1074 'No #ifndef header guard found, suggested CPP variable is: %s' %
1075 cppvar)
1076 return
1077
1078 # The guard should be PATH_FILE_H_, but we also allow PATH_FILE_H__
1079 # for backward compatibility.
erg+personal@google.com05189642010-04-30 20:43:03 +00001080 if ifndef != cppvar:
erg@google.com4e00b9a2009-01-12 23:05:11 +00001081 error_level = 0
1082 if ifndef != cppvar + '_':
1083 error_level = 5
1084
erg+personal@google.com05189642010-04-30 20:43:03 +00001085 ParseNolintSuppressions(filename, lines[ifndef_linenum], ifndef_linenum,
1086 error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001087 error(filename, ifndef_linenum, 'build/header_guard', error_level,
1088 '#ifndef header guard has wrong style, please use: %s' % cppvar)
1089
erg+personal@google.com05189642010-04-30 20:43:03 +00001090 if endif != ('#endif // %s' % cppvar):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001091 error_level = 0
1092 if endif != ('#endif // %s' % (cppvar + '_')):
1093 error_level = 5
1094
erg+personal@google.com05189642010-04-30 20:43:03 +00001095 ParseNolintSuppressions(filename, lines[endif_linenum], endif_linenum,
1096 error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001097 error(filename, endif_linenum, 'build/header_guard', error_level,
1098 '#endif line should be "#endif // %s"' % cppvar)
1099
1100
1101def CheckForUnicodeReplacementCharacters(filename, lines, error):
1102 """Logs an error for each line containing Unicode replacement characters.
1103
1104 These indicate that either the file contained invalid UTF-8 (likely)
1105 or Unicode replacement characters (which it shouldn't). Note that
1106 it's possible for this to throw off line numbering if the invalid
1107 UTF-8 occurred adjacent to a newline.
1108
1109 Args:
1110 filename: The name of the current file.
1111 lines: An array of strings, each representing a line of the file.
1112 error: The function to call with any errors found.
1113 """
1114 for linenum, line in enumerate(lines):
1115 if u'\ufffd' in line:
1116 error(filename, linenum, 'readability/utf8', 5,
1117 'Line contains invalid UTF-8 (or Unicode replacement character).')
1118
1119
1120def CheckForNewlineAtEOF(filename, lines, error):
1121 """Logs an error if there is no newline char at the end of the file.
1122
1123 Args:
1124 filename: The name of the current file.
1125 lines: An array of strings, each representing a line of the file.
1126 error: The function to call with any errors found.
1127 """
1128
1129 # The array lines() was created by adding two newlines to the
1130 # original file (go figure), then splitting on \n.
1131 # To verify that the file ends in \n, we just have to make sure the
1132 # last-but-two element of lines() exists and is empty.
1133 if len(lines) < 3 or lines[-2]:
1134 error(filename, len(lines) - 2, 'whitespace/ending_newline', 5,
1135 'Could not find a newline character at the end of the file.')
1136
1137
1138def CheckForMultilineCommentsAndStrings(filename, clean_lines, linenum, error):
1139 """Logs an error if we see /* ... */ or "..." that extend past one line.
1140
1141 /* ... */ comments are legit inside macros, for one line.
1142 Otherwise, we prefer // comments, so it's ok to warn about the
1143 other. Likewise, it's ok for strings to extend across multiple
1144 lines, as long as a line continuation character (backslash)
1145 terminates each line. Although not currently prohibited by the C++
1146 style guide, it's ugly and unnecessary. We don't do well with either
1147 in this lint program, so we warn about both.
1148
1149 Args:
1150 filename: The name of the current file.
1151 clean_lines: A CleansedLines instance containing the file.
1152 linenum: The number of the line to check.
1153 error: The function to call with any errors found.
1154 """
1155 line = clean_lines.elided[linenum]
1156
1157 # Remove all \\ (escaped backslashes) from the line. They are OK, and the
1158 # second (escaped) slash may trigger later \" detection erroneously.
1159 line = line.replace('\\\\', '')
1160
1161 if line.count('/*') > line.count('*/'):
1162 error(filename, linenum, 'readability/multiline_comment', 5,
1163 'Complex multi-line /*...*/-style comment found. '
1164 'Lint may give bogus warnings. '
1165 'Consider replacing these with //-style comments, '
1166 'with #if 0...#endif, '
1167 'or with more clearly structured multi-line comments.')
1168
1169 if (line.count('"') - line.count('\\"')) % 2:
1170 error(filename, linenum, 'readability/multiline_string', 5,
1171 'Multi-line string ("...") found. This lint script doesn\'t '
1172 'do well with such strings, and may give bogus warnings. They\'re '
1173 'ugly and unnecessary, and you should use concatenation instead".')
1174
1175
1176threading_list = (
1177 ('asctime(', 'asctime_r('),
1178 ('ctime(', 'ctime_r('),
1179 ('getgrgid(', 'getgrgid_r('),
1180 ('getgrnam(', 'getgrnam_r('),
1181 ('getlogin(', 'getlogin_r('),
1182 ('getpwnam(', 'getpwnam_r('),
1183 ('getpwuid(', 'getpwuid_r('),
1184 ('gmtime(', 'gmtime_r('),
1185 ('localtime(', 'localtime_r('),
1186 ('rand(', 'rand_r('),
1187 ('readdir(', 'readdir_r('),
1188 ('strtok(', 'strtok_r('),
1189 ('ttyname(', 'ttyname_r('),
1190 )
1191
1192
1193def CheckPosixThreading(filename, clean_lines, linenum, error):
1194 """Checks for calls to thread-unsafe functions.
1195
1196 Much code has been originally written without consideration of
1197 multi-threading. Also, engineers are relying on their old experience;
1198 they have learned posix before threading extensions were added. These
1199 tests guide the engineers to use thread-safe functions (when using
1200 posix directly).
1201
1202 Args:
1203 filename: The name of the current file.
1204 clean_lines: A CleansedLines instance containing the file.
1205 linenum: The number of the line to check.
1206 error: The function to call with any errors found.
1207 """
1208 line = clean_lines.elided[linenum]
1209 for single_thread_function, multithread_safe_function in threading_list:
1210 ix = line.find(single_thread_function)
erg@google.coma87abb82009-02-24 01:41:01 +00001211 # Comparisons made explicit for clarity -- pylint: disable-msg=C6403
erg@google.com4e00b9a2009-01-12 23:05:11 +00001212 if ix >= 0 and (ix == 0 or (not line[ix - 1].isalnum() and
1213 line[ix - 1] not in ('_', '.', '>'))):
1214 error(filename, linenum, 'runtime/threadsafe_fn', 2,
1215 'Consider using ' + multithread_safe_function +
1216 '...) instead of ' + single_thread_function +
1217 '...) for improved thread safety.')
1218
1219
erg@google.coma868d2d2009-10-09 21:18:45 +00001220# Matches invalid increment: *count++, which moves pointer instead of
erg@google.com36649102009-03-25 21:18:36 +00001221# incrementing a value.
erg@google.coma868d2d2009-10-09 21:18:45 +00001222_RE_PATTERN_INVALID_INCREMENT = re.compile(
erg@google.com36649102009-03-25 21:18:36 +00001223 r'^\s*\*\w+(\+\+|--);')
1224
1225
1226def CheckInvalidIncrement(filename, clean_lines, linenum, error):
erg@google.coma868d2d2009-10-09 21:18:45 +00001227 """Checks for invalid increment *count++.
erg@google.com36649102009-03-25 21:18:36 +00001228
1229 For example following function:
1230 void increment_counter(int* count) {
1231 *count++;
1232 }
1233 is invalid, because it effectively does count++, moving pointer, and should
1234 be replaced with ++*count, (*count)++ or *count += 1.
1235
1236 Args:
1237 filename: The name of the current file.
1238 clean_lines: A CleansedLines instance containing the file.
1239 linenum: The number of the line to check.
1240 error: The function to call with any errors found.
1241 """
1242 line = clean_lines.elided[linenum]
erg@google.coma868d2d2009-10-09 21:18:45 +00001243 if _RE_PATTERN_INVALID_INCREMENT.match(line):
erg@google.com36649102009-03-25 21:18:36 +00001244 error(filename, linenum, 'runtime/invalid_increment', 5,
1245 'Changing pointer instead of value (or unused value of operator*).')
1246
1247
erg@google.com4e00b9a2009-01-12 23:05:11 +00001248class _ClassInfo(object):
1249 """Stores information about a class."""
1250
1251 def __init__(self, name, linenum):
1252 self.name = name
1253 self.linenum = linenum
1254 self.seen_open_brace = False
1255 self.is_derived = False
1256 self.virtual_method_linenumber = None
1257 self.has_virtual_destructor = False
1258 self.brace_depth = 0
1259
1260
1261class _ClassState(object):
1262 """Holds the current state of the parse relating to class declarations.
1263
1264 It maintains a stack of _ClassInfos representing the parser's guess
1265 as to the current nesting of class declarations. The innermost class
1266 is at the top (back) of the stack. Typically, the stack will either
1267 be empty or have exactly one entry.
1268 """
1269
1270 def __init__(self):
1271 self.classinfo_stack = []
1272
1273 def CheckFinished(self, filename, error):
1274 """Checks that all classes have been completely parsed.
1275
1276 Call this when all lines in a file have been processed.
1277 Args:
1278 filename: The name of the current file.
1279 error: The function to call with any errors found.
1280 """
1281 if self.classinfo_stack:
1282 # Note: This test can result in false positives if #ifdef constructs
1283 # get in the way of brace matching. See the testBuildClass test in
1284 # cpplint_unittest.py for an example of this.
1285 error(filename, self.classinfo_stack[0].linenum, 'build/class', 5,
1286 'Failed to find complete declaration of class %s' %
1287 self.classinfo_stack[0].name)
1288
1289
1290def CheckForNonStandardConstructs(filename, clean_lines, linenum,
1291 class_state, error):
1292 """Logs an error if we see certain non-ANSI constructs ignored by gcc-2.
1293
1294 Complain about several constructs which gcc-2 accepts, but which are
1295 not standard C++. Warning about these in lint is one way to ease the
1296 transition to new compilers.
1297 - put storage class first (e.g. "static const" instead of "const static").
1298 - "%lld" instead of %qd" in printf-type functions.
1299 - "%1$d" is non-standard in printf-type functions.
1300 - "\%" is an undefined character escape sequence.
1301 - text after #endif is not allowed.
1302 - invalid inner-style forward declaration.
1303 - >? and <? operators, and their >?= and <?= cousins.
1304 - classes with virtual methods need virtual destructors (compiler warning
1305 available, but not turned on yet.)
1306
erg@google.coma868d2d2009-10-09 21:18:45 +00001307 Additionally, check for constructor/destructor style violations and reference
1308 members, as it is very convenient to do so while checking for
1309 gcc-2 compliance.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001310
1311 Args:
1312 filename: The name of the current file.
1313 clean_lines: A CleansedLines instance containing the file.
1314 linenum: The number of the line to check.
1315 class_state: A _ClassState instance which maintains information about
1316 the current stack of nested class declarations being parsed.
1317 error: A callable to which errors are reported, which takes 4 arguments:
1318 filename, line number, error level, and message
1319 """
1320
1321 # Remove comments from the line, but leave in strings for now.
1322 line = clean_lines.lines[linenum]
1323
1324 if Search(r'printf\s*\(.*".*%[-+ ]?\d*q', line):
1325 error(filename, linenum, 'runtime/printf_format', 3,
1326 '%q in format strings is deprecated. Use %ll instead.')
1327
1328 if Search(r'printf\s*\(.*".*%\d+\$', line):
1329 error(filename, linenum, 'runtime/printf_format', 2,
1330 '%N$ formats are unconventional. Try rewriting to avoid them.')
1331
1332 # Remove escaped backslashes before looking for undefined escapes.
1333 line = line.replace('\\\\', '')
1334
1335 if Search(r'("|\').*\\(%|\[|\(|{)', line):
1336 error(filename, linenum, 'build/printf_format', 3,
1337 '%, [, (, and { are undefined character escapes. Unescape them.')
1338
1339 # For the rest, work with both comments and strings removed.
1340 line = clean_lines.elided[linenum]
1341
1342 if Search(r'\b(const|volatile|void|char|short|int|long'
1343 r'|float|double|signed|unsigned'
1344 r'|schar|u?int8|u?int16|u?int32|u?int64)'
1345 r'\s+(auto|register|static|extern|typedef)\b',
1346 line):
1347 error(filename, linenum, 'build/storage_class', 5,
1348 'Storage class (static, extern, typedef, etc) should be first.')
1349
1350 if Match(r'\s*#\s*endif\s*[^/\s]+', line):
1351 error(filename, linenum, 'build/endif_comment', 5,
1352 'Uncommented text after #endif is non-standard. Use a comment.')
1353
1354 if Match(r'\s*class\s+(\w+\s*::\s*)+\w+\s*;', line):
1355 error(filename, linenum, 'build/forward_decl', 5,
1356 'Inner-style forward declarations are invalid. Remove this line.')
1357
1358 if Search(r'(\w+|[+-]?\d+(\.\d*)?)\s*(<|>)\?=?\s*(\w+|[+-]?\d+)(\.\d*)?',
1359 line):
1360 error(filename, linenum, 'build/deprecated', 3,
1361 '>? and <? (max and min) operators are non-standard and deprecated.')
1362
erg@google.coma868d2d2009-10-09 21:18:45 +00001363 if Search(r'^\s*const\s*string\s*&\s*\w+\s*;', line):
1364 # TODO(unknown): Could it be expanded safely to arbitrary references,
1365 # without triggering too many false positives? The first
1366 # attempt triggered 5 warnings for mostly benign code in the regtest, hence
1367 # the restriction.
1368 # Here's the original regexp, for the reference:
1369 # type_name = r'\w+((\s*::\s*\w+)|(\s*<\s*\w+?\s*>))?'
1370 # r'\s*const\s*' + type_name + '\s*&\s*\w+\s*;'
1371 error(filename, linenum, 'runtime/member_string_references', 2,
1372 'const string& members are dangerous. It is much better to use '
1373 'alternatives, such as pointers or simple constants.')
1374
erg@google.com4e00b9a2009-01-12 23:05:11 +00001375 # Track class entry and exit, and attempt to find cases within the
1376 # class declaration that don't meet the C++ style
1377 # guidelines. Tracking is very dependent on the code matching Google
1378 # style guidelines, but it seems to perform well enough in testing
1379 # to be a worthwhile addition to the checks.
1380 classinfo_stack = class_state.classinfo_stack
1381 # Look for a class declaration
1382 class_decl_match = Match(
1383 r'\s*(template\s*<[\w\s<>,:]*>\s*)?(class|struct)\s+(\w+(::\w+)*)', line)
1384 if class_decl_match:
1385 classinfo_stack.append(_ClassInfo(class_decl_match.group(3), linenum))
1386
1387 # Everything else in this function uses the top of the stack if it's
1388 # not empty.
1389 if not classinfo_stack:
1390 return
1391
1392 classinfo = classinfo_stack[-1]
1393
1394 # If the opening brace hasn't been seen look for it and also
1395 # parent class declarations.
1396 if not classinfo.seen_open_brace:
1397 # If the line has a ';' in it, assume it's a forward declaration or
1398 # a single-line class declaration, which we won't process.
1399 if line.find(';') != -1:
1400 classinfo_stack.pop()
1401 return
1402 classinfo.seen_open_brace = (line.find('{') != -1)
1403 # Look for a bare ':'
1404 if Search('(^|[^:]):($|[^:])', line):
1405 classinfo.is_derived = True
1406 if not classinfo.seen_open_brace:
1407 return # Everything else in this function is for after open brace
1408
1409 # The class may have been declared with namespace or classname qualifiers.
1410 # The constructor and destructor will not have those qualifiers.
1411 base_classname = classinfo.name.split('::')[-1]
1412
1413 # Look for single-argument constructors that aren't marked explicit.
1414 # Technically a valid construct, but against style.
1415 args = Match(r'(?<!explicit)\s+%s\s*\(([^,()]+)\)'
1416 % re.escape(base_classname),
1417 line)
1418 if (args and
1419 args.group(1) != 'void' and
1420 not Match(r'(const\s+)?%s\s*&' % re.escape(base_classname),
1421 args.group(1).strip())):
1422 error(filename, linenum, 'runtime/explicit', 5,
1423 'Single-argument constructors should be marked explicit.')
1424
1425 # Look for methods declared virtual.
1426 if Search(r'\bvirtual\b', line):
1427 classinfo.virtual_method_linenumber = linenum
1428 # Only look for a destructor declaration on the same line. It would
1429 # be extremely unlikely for the destructor declaration to occupy
1430 # more than one line.
1431 if Search(r'~%s\s*\(' % base_classname, line):
1432 classinfo.has_virtual_destructor = True
1433
1434 # Look for class end.
1435 brace_depth = classinfo.brace_depth
1436 brace_depth = brace_depth + line.count('{') - line.count('}')
1437 if brace_depth <= 0:
1438 classinfo = classinfo_stack.pop()
1439 # Try to detect missing virtual destructor declarations.
1440 # For now, only warn if a non-derived class with virtual methods lacks
1441 # a virtual destructor. This is to make it less likely that people will
1442 # declare derived virtual destructors without declaring the base
1443 # destructor virtual.
1444 if ((classinfo.virtual_method_linenumber is not None) and
1445 (not classinfo.has_virtual_destructor) and
1446 (not classinfo.is_derived)): # Only warn for base classes
1447 error(filename, classinfo.linenum, 'runtime/virtual', 4,
1448 'The class %s probably needs a virtual destructor due to '
1449 'having virtual method(s), one declared at line %d.'
1450 % (classinfo.name, classinfo.virtual_method_linenumber))
1451 else:
1452 classinfo.brace_depth = brace_depth
1453
1454
1455def CheckSpacingForFunctionCall(filename, line, linenum, error):
1456 """Checks for the correctness of various spacing around function calls.
1457
1458 Args:
1459 filename: The name of the current file.
1460 line: The text of the line to check.
1461 linenum: The number of the line to check.
1462 error: The function to call with any errors found.
1463 """
1464
1465 # Since function calls often occur inside if/for/while/switch
1466 # expressions - which have their own, more liberal conventions - we
1467 # first see if we should be looking inside such an expression for a
1468 # function call, to which we can apply more strict standards.
1469 fncall = line # if there's no control flow construct, look at whole line
1470 for pattern in (r'\bif\s*\((.*)\)\s*{',
1471 r'\bfor\s*\((.*)\)\s*{',
1472 r'\bwhile\s*\((.*)\)\s*[{;]',
1473 r'\bswitch\s*\((.*)\)\s*{'):
1474 match = Search(pattern, line)
1475 if match:
1476 fncall = match.group(1) # look inside the parens for function calls
1477 break
1478
1479 # Except in if/for/while/switch, there should never be space
1480 # immediately inside parens (eg "f( 3, 4 )"). We make an exception
1481 # for nested parens ( (a+b) + c ). Likewise, there should never be
1482 # a space before a ( when it's a function argument. I assume it's a
1483 # function argument when the char before the whitespace is legal in
1484 # a function name (alnum + _) and we're not starting a macro. Also ignore
1485 # pointers and references to arrays and functions coz they're too tricky:
1486 # we use a very simple way to recognize these:
1487 # " (something)(maybe-something)" or
1488 # " (something)(maybe-something," or
1489 # " (something)[something]"
1490 # Note that we assume the contents of [] to be short enough that
1491 # they'll never need to wrap.
1492 if ( # Ignore control structures.
1493 not Search(r'\b(if|for|while|switch|return|delete)\b', fncall) and
1494 # Ignore pointers/references to functions.
1495 not Search(r' \([^)]+\)\([^)]*(\)|,$)', fncall) and
1496 # Ignore pointers/references to arrays.
1497 not Search(r' \([^)]+\)\[[^\]]+\]', fncall)):
erg@google.com36649102009-03-25 21:18:36 +00001498 if Search(r'\w\s*\(\s(?!\s*\\$)', fncall): # a ( used for a fn call
erg@google.com4e00b9a2009-01-12 23:05:11 +00001499 error(filename, linenum, 'whitespace/parens', 4,
1500 'Extra space after ( in function call')
erg@google.com36649102009-03-25 21:18:36 +00001501 elif Search(r'\(\s+(?!(\s*\\)|\()', fncall):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001502 error(filename, linenum, 'whitespace/parens', 2,
1503 'Extra space after (')
1504 if (Search(r'\w\s+\(', fncall) and
1505 not Search(r'#\s*define|typedef', fncall)):
1506 error(filename, linenum, 'whitespace/parens', 4,
1507 'Extra space before ( in function call')
1508 # If the ) is followed only by a newline or a { + newline, assume it's
1509 # part of a control statement (if/while/etc), and don't complain
1510 if Search(r'[^)]\s+\)\s*[^{\s]', fncall):
1511 error(filename, linenum, 'whitespace/parens', 2,
1512 'Extra space before )')
1513
1514
1515def IsBlankLine(line):
1516 """Returns true if the given line is blank.
1517
1518 We consider a line to be blank if the line is empty or consists of
1519 only white spaces.
1520
1521 Args:
1522 line: A line of a string.
1523
1524 Returns:
1525 True, if the given line is blank.
1526 """
1527 return not line or line.isspace()
1528
1529
1530def CheckForFunctionLengths(filename, clean_lines, linenum,
1531 function_state, error):
1532 """Reports for long function bodies.
1533
1534 For an overview why this is done, see:
1535 http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Write_Short_Functions
1536
1537 Uses a simplistic algorithm assuming other style guidelines
1538 (especially spacing) are followed.
1539 Only checks unindented functions, so class members are unchecked.
1540 Trivial bodies are unchecked, so constructors with huge initializer lists
1541 may be missed.
1542 Blank/comment lines are not counted so as to avoid encouraging the removal
1543 of vertical space and commments just to get through a lint check.
1544 NOLINT *on the last line of a function* disables this check.
1545
1546 Args:
1547 filename: The name of the current file.
1548 clean_lines: A CleansedLines instance containing the file.
1549 linenum: The number of the line to check.
1550 function_state: Current function name and lines in body so far.
1551 error: The function to call with any errors found.
1552 """
1553 lines = clean_lines.lines
1554 line = lines[linenum]
1555 raw = clean_lines.raw_lines
1556 raw_line = raw[linenum]
1557 joined_line = ''
1558
1559 starting_func = False
erg@google.coma87abb82009-02-24 01:41:01 +00001560 regexp = r'(\w(\w|::|\*|\&|\s)*)\(' # decls * & space::name( ...
erg@google.com4e00b9a2009-01-12 23:05:11 +00001561 match_result = Match(regexp, line)
1562 if match_result:
1563 # If the name is all caps and underscores, figure it's a macro and
1564 # ignore it, unless it's TEST or TEST_F.
1565 function_name = match_result.group(1).split()[-1]
1566 if function_name == 'TEST' or function_name == 'TEST_F' or (
1567 not Match(r'[A-Z_]+$', function_name)):
1568 starting_func = True
1569
1570 if starting_func:
1571 body_found = False
erg@google.coma87abb82009-02-24 01:41:01 +00001572 for start_linenum in xrange(linenum, clean_lines.NumLines()):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001573 start_line = lines[start_linenum]
1574 joined_line += ' ' + start_line.lstrip()
1575 if Search(r'(;|})', start_line): # Declarations and trivial functions
1576 body_found = True
1577 break # ... ignore
1578 elif Search(r'{', start_line):
1579 body_found = True
1580 function = Search(r'((\w|:)*)\(', line).group(1)
1581 if Match(r'TEST', function): # Handle TEST... macros
1582 parameter_regexp = Search(r'(\(.*\))', joined_line)
1583 if parameter_regexp: # Ignore bad syntax
1584 function += parameter_regexp.group(1)
1585 else:
1586 function += '()'
1587 function_state.Begin(function)
1588 break
1589 if not body_found:
erg@google.coma87abb82009-02-24 01:41:01 +00001590 # No body for the function (or evidence of a non-function) was found.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001591 error(filename, linenum, 'readability/fn_size', 5,
1592 'Lint failed to find start of function body.')
1593 elif Match(r'^\}\s*$', line): # function end
erg+personal@google.com05189642010-04-30 20:43:03 +00001594 function_state.Check(error, filename, linenum)
erg@google.com4e00b9a2009-01-12 23:05:11 +00001595 function_state.End()
1596 elif not Match(r'^\s*$', line):
1597 function_state.Count() # Count non-blank/non-comment lines.
1598
1599
1600_RE_PATTERN_TODO = re.compile(r'^//(\s*)TODO(\(.+?\))?:?(\s|$)?')
1601
1602
1603def CheckComment(comment, filename, linenum, error):
1604 """Checks for common mistakes in TODO comments.
1605
1606 Args:
1607 comment: The text of the comment from the line in question.
1608 filename: The name of the current file.
1609 linenum: The number of the line to check.
1610 error: The function to call with any errors found.
1611 """
1612 match = _RE_PATTERN_TODO.match(comment)
1613 if match:
1614 # One whitespace is correct; zero whitespace is handled elsewhere.
1615 leading_whitespace = match.group(1)
1616 if len(leading_whitespace) > 1:
1617 error(filename, linenum, 'whitespace/todo', 2,
1618 'Too many spaces before TODO')
1619
1620 username = match.group(2)
1621 if not username:
1622 error(filename, linenum, 'readability/todo', 2,
1623 'Missing username in TODO; it should look like '
1624 '"// TODO(my_username): Stuff."')
1625
1626 middle_whitespace = match.group(3)
erg@google.coma87abb82009-02-24 01:41:01 +00001627 # Comparisons made explicit for correctness -- pylint: disable-msg=C6403
erg@google.com4e00b9a2009-01-12 23:05:11 +00001628 if middle_whitespace != ' ' and middle_whitespace != '':
1629 error(filename, linenum, 'whitespace/todo', 2,
1630 'TODO(my_username) should be followed by a space')
1631
1632
1633def CheckSpacing(filename, clean_lines, linenum, error):
1634 """Checks for the correctness of various spacing issues in the code.
1635
1636 Things we check for: spaces around operators, spaces after
1637 if/for/while/switch, no spaces around parens in function calls, two
1638 spaces between code and comment, don't start a block with a blank
1639 line, don't end a function with a blank line, don't have too many
1640 blank lines in a row.
1641
1642 Args:
1643 filename: The name of the current file.
1644 clean_lines: A CleansedLines instance containing the file.
1645 linenum: The number of the line to check.
1646 error: The function to call with any errors found.
1647 """
1648
1649 raw = clean_lines.raw_lines
1650 line = raw[linenum]
1651
1652 # Before nixing comments, check if the line is blank for no good
1653 # reason. This includes the first line after a block is opened, and
1654 # blank lines at the end of a function (ie, right before a line like '}'
1655 if IsBlankLine(line):
1656 elided = clean_lines.elided
1657 prev_line = elided[linenum - 1]
1658 prevbrace = prev_line.rfind('{')
1659 # TODO(unknown): Don't complain if line before blank line, and line after,
1660 # both start with alnums and are indented the same amount.
1661 # This ignores whitespace at the start of a namespace block
1662 # because those are not usually indented.
1663 if (prevbrace != -1 and prev_line[prevbrace:].find('}') == -1
1664 and prev_line[:prevbrace].find('namespace') == -1):
1665 # OK, we have a blank line at the start of a code block. Before we
1666 # complain, we check if it is an exception to the rule: The previous
1667 # non-empty line has the paramters of a function header that are indented
1668 # 4 spaces (because they did not fit in a 80 column line when placed on
1669 # the same line as the function name). We also check for the case where
1670 # the previous line is indented 6 spaces, which may happen when the
1671 # initializers of a constructor do not fit into a 80 column line.
1672 exception = False
1673 if Match(r' {6}\w', prev_line): # Initializer list?
1674 # We are looking for the opening column of initializer list, which
1675 # should be indented 4 spaces to cause 6 space indentation afterwards.
1676 search_position = linenum-2
1677 while (search_position >= 0
1678 and Match(r' {6}\w', elided[search_position])):
1679 search_position -= 1
1680 exception = (search_position >= 0
1681 and elided[search_position][:5] == ' :')
1682 else:
1683 # Search for the function arguments or an initializer list. We use a
1684 # simple heuristic here: If the line is indented 4 spaces; and we have a
1685 # closing paren, without the opening paren, followed by an opening brace
1686 # or colon (for initializer lists) we assume that it is the last line of
1687 # a function header. If we have a colon indented 4 spaces, it is an
1688 # initializer list.
1689 exception = (Match(r' {4}\w[^\(]*\)\s*(const\s*)?(\{\s*$|:)',
1690 prev_line)
1691 or Match(r' {4}:', prev_line))
1692
1693 if not exception:
1694 error(filename, linenum, 'whitespace/blank_line', 2,
1695 'Blank line at the start of a code block. Is this needed?')
1696 # This doesn't ignore whitespace at the end of a namespace block
1697 # because that is too hard without pairing open/close braces;
1698 # however, a special exception is made for namespace closing
1699 # brackets which have a comment containing "namespace".
1700 #
1701 # Also, ignore blank lines at the end of a block in a long if-else
1702 # chain, like this:
1703 # if (condition1) {
1704 # // Something followed by a blank line
1705 #
1706 # } else if (condition2) {
1707 # // Something else
1708 # }
1709 if linenum + 1 < clean_lines.NumLines():
1710 next_line = raw[linenum + 1]
1711 if (next_line
1712 and Match(r'\s*}', next_line)
1713 and next_line.find('namespace') == -1
1714 and next_line.find('} else ') == -1):
1715 error(filename, linenum, 'whitespace/blank_line', 3,
1716 'Blank line at the end of a code block. Is this needed?')
1717
1718 # Next, we complain if there's a comment too near the text
1719 commentpos = line.find('//')
1720 if commentpos != -1:
1721 # Check if the // may be in quotes. If so, ignore it
erg@google.coma87abb82009-02-24 01:41:01 +00001722 # Comparisons made explicit for clarity -- pylint: disable-msg=C6403
erg@google.com4e00b9a2009-01-12 23:05:11 +00001723 if (line.count('"', 0, commentpos) -
1724 line.count('\\"', 0, commentpos)) % 2 == 0: # not in quotes
1725 # Allow one space for new scopes, two spaces otherwise:
1726 if (not Match(r'^\s*{ //', line) and
1727 ((commentpos >= 1 and
1728 line[commentpos-1] not in string.whitespace) or
1729 (commentpos >= 2 and
1730 line[commentpos-2] not in string.whitespace))):
1731 error(filename, linenum, 'whitespace/comments', 2,
1732 'At least two spaces is best between code and comments')
1733 # There should always be a space between the // and the comment
1734 commentend = commentpos + 2
1735 if commentend < len(line) and not line[commentend] == ' ':
1736 # but some lines are exceptions -- e.g. if they're big
1737 # comment delimiters like:
1738 # //----------------------------------------------------------
erg@google.come35f7652009-06-19 20:52:09 +00001739 # or they begin with multiple slashes followed by a space:
1740 # //////// Header comment
1741 match = (Search(r'[=/-]{4,}\s*$', line[commentend:]) or
1742 Search(r'^/+ ', line[commentend:]))
erg@google.com4e00b9a2009-01-12 23:05:11 +00001743 if not match:
1744 error(filename, linenum, 'whitespace/comments', 4,
1745 'Should have a space between // and comment')
1746 CheckComment(line[commentpos:], filename, linenum, error)
1747
1748 line = clean_lines.elided[linenum] # get rid of comments and strings
1749
1750 # Don't try to do spacing checks for operator methods
1751 line = re.sub(r'operator(==|!=|<|<<|<=|>=|>>|>)\(', 'operator\(', line)
1752
1753 # We allow no-spaces around = within an if: "if ( (a=Foo()) == 0 )".
1754 # Otherwise not. Note we only check for non-spaces on *both* sides;
1755 # sometimes people put non-spaces on one side when aligning ='s among
1756 # many lines (not that this is behavior that I approve of...)
1757 if Search(r'[\w.]=[\w.]', line) and not Search(r'\b(if|while) ', line):
1758 error(filename, linenum, 'whitespace/operators', 4,
1759 'Missing spaces around =')
1760
1761 # It's ok not to have spaces around binary operators like + - * /, but if
1762 # there's too little whitespace, we get concerned. It's hard to tell,
1763 # though, so we punt on this one for now. TODO.
1764
1765 # You should always have whitespace around binary operators.
1766 # Alas, we can't test < or > because they're legitimately used sans spaces
1767 # (a->b, vector<int> a). The only time we can tell is a < with no >, and
1768 # only if it's not template params list spilling into the next line.
1769 match = Search(r'[^<>=!\s](==|!=|<=|>=)[^<>=!\s]', line)
1770 if not match:
1771 # Note that while it seems that the '<[^<]*' term in the following
1772 # regexp could be simplified to '<.*', which would indeed match
1773 # the same class of strings, the [^<] means that searching for the
1774 # regexp takes linear rather than quadratic time.
1775 if not Search(r'<[^<]*,\s*$', line): # template params spill
1776 match = Search(r'[^<>=!\s](<)[^<>=!\s]([^>]|->)*$', line)
1777 if match:
1778 error(filename, linenum, 'whitespace/operators', 3,
1779 'Missing spaces around %s' % match.group(1))
1780 # We allow no-spaces around << and >> when used like this: 10<<20, but
1781 # not otherwise (particularly, not when used as streams)
1782 match = Search(r'[^0-9\s](<<|>>)[^0-9\s]', line)
1783 if match:
1784 error(filename, linenum, 'whitespace/operators', 3,
1785 'Missing spaces around %s' % match.group(1))
1786
1787 # There shouldn't be space around unary operators
1788 match = Search(r'(!\s|~\s|[\s]--[\s;]|[\s]\+\+[\s;])', line)
1789 if match:
1790 error(filename, linenum, 'whitespace/operators', 4,
1791 'Extra space for operator %s' % match.group(1))
1792
1793 # A pet peeve of mine: no spaces after an if, while, switch, or for
1794 match = Search(r' (if\(|for\(|while\(|switch\()', line)
1795 if match:
1796 error(filename, linenum, 'whitespace/parens', 5,
1797 'Missing space before ( in %s' % match.group(1))
1798
1799 # For if/for/while/switch, the left and right parens should be
1800 # consistent about how many spaces are inside the parens, and
1801 # there should either be zero or one spaces inside the parens.
1802 # We don't want: "if ( foo)" or "if ( foo )".
erg@google.come35f7652009-06-19 20:52:09 +00001803 # Exception: "for ( ; foo; bar)" and "for (foo; bar; )" are allowed.
erg@google.com4e00b9a2009-01-12 23:05:11 +00001804 match = Search(r'\b(if|for|while|switch)\s*'
1805 r'\(([ ]*)(.).*[^ ]+([ ]*)\)\s*{\s*$',
1806 line)
1807 if match:
1808 if len(match.group(2)) != len(match.group(4)):
1809 if not (match.group(3) == ';' and
erg@google.come35f7652009-06-19 20:52:09 +00001810 len(match.group(2)) == 1 + len(match.group(4)) or
1811 not match.group(2) and Search(r'\bfor\s*\(.*; \)', line)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00001812 error(filename, linenum, 'whitespace/parens', 5,
1813 'Mismatching spaces inside () in %s' % match.group(1))
1814 if not len(match.group(2)) in [0, 1]:
1815 error(filename, linenum, 'whitespace/parens', 5,
1816 'Should have zero or one spaces inside ( and ) in %s' %
1817 match.group(1))
1818
1819 # You should always have a space after a comma (either as fn arg or operator)
1820 if Search(r',[^\s]', line):
1821 error(filename, linenum, 'whitespace/comma', 3,
1822 'Missing space after ,')
1823
1824 # Next we will look for issues with function calls.
1825 CheckSpacingForFunctionCall(filename, line, linenum, error)
1826
1827 # Except after an opening paren, you should have spaces before your braces.
1828 # And since you should never have braces at the beginning of a line, this is
1829 # an easy test.
1830 if Search(r'[^ (]{', line):
1831 error(filename, linenum, 'whitespace/braces', 5,
1832 'Missing space before {')
1833
1834 # Make sure '} else {' has spaces.
1835 if Search(r'}else', line):
1836 error(filename, linenum, 'whitespace/braces', 5,
1837 'Missing space before else')
1838
1839 # You shouldn't have spaces before your brackets, except maybe after
1840 # 'delete []' or 'new char * []'.
1841 if Search(r'\w\s+\[', line) and not Search(r'delete\s+\[', line):
1842 error(filename, linenum, 'whitespace/braces', 5,
1843 'Extra space before [')
1844
1845 # You shouldn't have a space before a semicolon at the end of the line.
1846 # There's a special case for "for" since the style guide allows space before
1847 # the semicolon there.
1848 if Search(r':\s*;\s*$', line):
1849 error(filename, linenum, 'whitespace/semicolon', 5,
1850 'Semicolon defining empty statement. Use { } instead.')
1851 elif Search(r'^\s*;\s*$', line):
1852 error(filename, linenum, 'whitespace/semicolon', 5,
1853 'Line contains only semicolon. If this should be an empty statement, '
1854 'use { } instead.')
1855 elif (Search(r'\s+;\s*$', line) and
1856 not Search(r'\bfor\b', line)):
1857 error(filename, linenum, 'whitespace/semicolon', 5,
1858 'Extra space before last semicolon. If this should be an empty '
1859 'statement, use { } instead.')
1860
1861
1862def GetPreviousNonBlankLine(clean_lines, linenum):
1863 """Return the most recent non-blank line and its line number.
1864
1865 Args:
1866 clean_lines: A CleansedLines instance containing the file contents.
1867 linenum: The number of the line to check.
1868
1869 Returns:
1870 A tuple with two elements. The first element is the contents of the last
1871 non-blank line before the current line, or the empty string if this is the
1872 first non-blank line. The second is the line number of that line, or -1
1873 if this is the first non-blank line.
1874 """
1875
1876 prevlinenum = linenum - 1
1877 while prevlinenum >= 0:
1878 prevline = clean_lines.elided[prevlinenum]
1879 if not IsBlankLine(prevline): # if not a blank line...
1880 return (prevline, prevlinenum)
1881 prevlinenum -= 1
1882 return ('', -1)
1883
1884
1885def CheckBraces(filename, clean_lines, linenum, error):
1886 """Looks for misplaced braces (e.g. at the end of line).
1887
1888 Args:
1889 filename: The name of the current file.
1890 clean_lines: A CleansedLines instance containing the file.
1891 linenum: The number of the line to check.
1892 error: The function to call with any errors found.
1893 """
1894
1895 line = clean_lines.elided[linenum] # get rid of comments and strings
1896
1897 if Match(r'\s*{\s*$', line):
1898 # We allow an open brace to start a line in the case where someone
1899 # is using braces in a block to explicitly create a new scope,
1900 # which is commonly used to control the lifetime of
1901 # stack-allocated variables. We don't detect this perfectly: we
1902 # just don't complain if the last non-whitespace character on the
1903 # previous non-blank line is ';', ':', '{', or '}'.
1904 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
1905 if not Search(r'[;:}{]\s*$', prevline):
1906 error(filename, linenum, 'whitespace/braces', 4,
1907 '{ should almost always be at the end of the previous line')
1908
1909 # An else clause should be on the same line as the preceding closing brace.
1910 if Match(r'\s*else\s*', line):
1911 prevline = GetPreviousNonBlankLine(clean_lines, linenum)[0]
1912 if Match(r'\s*}\s*$', prevline):
1913 error(filename, linenum, 'whitespace/newline', 4,
1914 'An else should appear on the same line as the preceding }')
1915
1916 # If braces come on one side of an else, they should be on both.
1917 # However, we have to worry about "else if" that spans multiple lines!
1918 if Search(r'}\s*else[^{]*$', line) or Match(r'[^}]*else\s*{', line):
1919 if Search(r'}\s*else if([^{]*)$', line): # could be multi-line if
1920 # find the ( after the if
1921 pos = line.find('else if')
1922 pos = line.find('(', pos)
1923 if pos > 0:
1924 (endline, _, endpos) = CloseExpression(clean_lines, linenum, pos)
1925 if endline[endpos:].find('{') == -1: # must be brace after if
1926 error(filename, linenum, 'readability/braces', 5,
1927 'If an else has a brace on one side, it should have it on both')
1928 else: # common case: else not followed by a multi-line if
1929 error(filename, linenum, 'readability/braces', 5,
1930 'If an else has a brace on one side, it should have it on both')
1931
1932 # Likewise, an else should never have the else clause on the same line
1933 if Search(r'\belse [^\s{]', line) and not Search(r'\belse if\b', line):
1934 error(filename, linenum, 'whitespace/newline', 4,
1935 'Else clause should never be on same line as else (use 2 lines)')
1936
1937 # In the same way, a do/while should never be on one line
1938 if Match(r'\s*do [^\s{]', line):
1939 error(filename, linenum, 'whitespace/newline', 4,
1940 'do/while clauses should not be on a single line')
1941
1942 # Braces shouldn't be followed by a ; unless they're defining a struct
1943 # or initializing an array.
1944 # We can't tell in general, but we can for some common cases.
1945 prevlinenum = linenum
1946 while True:
1947 (prevline, prevlinenum) = GetPreviousNonBlankLine(clean_lines, prevlinenum)
1948 if Match(r'\s+{.*}\s*;', line) and not prevline.count(';'):
1949 line = prevline + line
1950 else:
1951 break
1952 if (Search(r'{.*}\s*;', line) and
1953 line.count('{') == line.count('}') and
1954 not Search(r'struct|class|enum|\s*=\s*{', line)):
1955 error(filename, linenum, 'readability/braces', 4,
1956 "You don't need a ; after a }")
1957
1958
1959def ReplaceableCheck(operator, macro, line):
1960 """Determine whether a basic CHECK can be replaced with a more specific one.
1961
1962 For example suggest using CHECK_EQ instead of CHECK(a == b) and
1963 similarly for CHECK_GE, CHECK_GT, CHECK_LE, CHECK_LT, CHECK_NE.
1964
1965 Args:
1966 operator: The C++ operator used in the CHECK.
1967 macro: The CHECK or EXPECT macro being called.
1968 line: The current source line.
1969
1970 Returns:
1971 True if the CHECK can be replaced with a more specific one.
1972 """
1973
1974 # This matches decimal and hex integers, strings, and chars (in that order).
1975 match_constant = r'([-+]?(\d+|0[xX][0-9a-fA-F]+)[lLuU]{0,3}|".*"|\'.*\')'
1976
1977 # Expression to match two sides of the operator with something that
1978 # looks like a literal, since CHECK(x == iterator) won't compile.
1979 # This means we can't catch all the cases where a more specific
1980 # CHECK is possible, but it's less annoying than dealing with
1981 # extraneous warnings.
1982 match_this = (r'\s*' + macro + r'\((\s*' +
1983 match_constant + r'\s*' + operator + r'[^<>].*|'
1984 r'.*[^<>]' + operator + r'\s*' + match_constant +
1985 r'\s*\))')
1986
1987 # Don't complain about CHECK(x == NULL) or similar because
1988 # CHECK_EQ(x, NULL) won't compile (requires a cast).
1989 # Also, don't complain about more complex boolean expressions
1990 # involving && or || such as CHECK(a == b || c == d).
1991 return Match(match_this, line) and not Search(r'NULL|&&|\|\|', line)
1992
1993
1994def CheckCheck(filename, clean_lines, linenum, error):
1995 """Checks the use of CHECK and EXPECT macros.
1996
1997 Args:
1998 filename: The name of the current file.
1999 clean_lines: A CleansedLines instance containing the file.
2000 linenum: The number of the line to check.
2001 error: The function to call with any errors found.
2002 """
2003
2004 # Decide the set of replacement macros that should be suggested
2005 raw_lines = clean_lines.raw_lines
2006 current_macro = ''
2007 for macro in _CHECK_MACROS:
2008 if raw_lines[linenum].find(macro) >= 0:
2009 current_macro = macro
2010 break
2011 if not current_macro:
2012 # Don't waste time here if line doesn't contain 'CHECK' or 'EXPECT'
2013 return
2014
2015 line = clean_lines.elided[linenum] # get rid of comments and strings
2016
2017 # Encourage replacing plain CHECKs with CHECK_EQ/CHECK_NE/etc.
2018 for operator in ['==', '!=', '>=', '>', '<=', '<']:
2019 if ReplaceableCheck(operator, current_macro, line):
2020 error(filename, linenum, 'readability/check', 2,
2021 'Consider using %s instead of %s(a %s b)' % (
2022 _CHECK_REPLACEMENT[current_macro][operator],
2023 current_macro, operator))
2024 break
2025
2026
2027def GetLineWidth(line):
2028 """Determines the width of the line in column positions.
2029
2030 Args:
2031 line: A string, which may be a Unicode string.
2032
2033 Returns:
2034 The width of the line in column positions, accounting for Unicode
2035 combining characters and wide characters.
2036 """
2037 if isinstance(line, unicode):
2038 width = 0
2039 for c in unicodedata.normalize('NFC', line):
2040 if unicodedata.east_asian_width(c) in ('W', 'F'):
2041 width += 2
2042 elif not unicodedata.combining(c):
2043 width += 1
2044 return width
2045 else:
2046 return len(line)
2047
2048
2049def CheckStyle(filename, clean_lines, linenum, file_extension, error):
2050 """Checks rules from the 'C++ style rules' section of cppguide.html.
2051
2052 Most of these rules are hard to test (naming, comment style), but we
2053 do what we can. In particular we check for 2-space indents, line lengths,
2054 tab usage, spaces inside code, etc.
2055
2056 Args:
2057 filename: The name of the current file.
2058 clean_lines: A CleansedLines instance containing the file.
2059 linenum: The number of the line to check.
2060 file_extension: The extension (without the dot) of the filename.
2061 error: The function to call with any errors found.
2062 """
2063
2064 raw_lines = clean_lines.raw_lines
2065 line = raw_lines[linenum]
2066
2067 if line.find('\t') != -1:
2068 error(filename, linenum, 'whitespace/tab', 1,
2069 'Tab found; better to use spaces')
2070
2071 # One or three blank spaces at the beginning of the line is weird; it's
2072 # hard to reconcile that with 2-space indents.
2073 # NOTE: here are the conditions rob pike used for his tests. Mine aren't
2074 # as sophisticated, but it may be worth becoming so: RLENGTH==initial_spaces
2075 # if(RLENGTH > 20) complain = 0;
2076 # if(match($0, " +(error|private|public|protected):")) complain = 0;
2077 # if(match(prev, "&& *$")) complain = 0;
2078 # if(match(prev, "\\|\\| *$")) complain = 0;
2079 # if(match(prev, "[\",=><] *$")) complain = 0;
2080 # if(match($0, " <<")) complain = 0;
2081 # if(match(prev, " +for \\(")) complain = 0;
2082 # if(prevodd && match(prevprev, " +for \\(")) complain = 0;
2083 initial_spaces = 0
2084 cleansed_line = clean_lines.elided[linenum]
2085 while initial_spaces < len(line) and line[initial_spaces] == ' ':
2086 initial_spaces += 1
2087 if line and line[-1].isspace():
2088 error(filename, linenum, 'whitespace/end_of_line', 4,
2089 'Line ends in whitespace. Consider deleting these extra spaces.')
2090 # There are certain situations we allow one space, notably for labels
2091 elif ((initial_spaces == 1 or initial_spaces == 3) and
2092 not Match(r'\s*\w+\s*:\s*$', cleansed_line)):
2093 error(filename, linenum, 'whitespace/indent', 3,
2094 'Weird number of spaces at line-start. '
2095 'Are you using a 2-space indent?')
2096 # Labels should always be indented at least one space.
2097 elif not initial_spaces and line[:2] != '//' and Search(r'[^:]:\s*$',
2098 line):
2099 error(filename, linenum, 'whitespace/labels', 4,
2100 'Labels should always be indented at least one space. '
erg+personal@google.com05189642010-04-30 20:43:03 +00002101 'If this is a member-initializer list in a constructor or '
2102 'the base class list in a class definition, the colon should '
2103 'be on the following line.')
2104
erg@google.com4e00b9a2009-01-12 23:05:11 +00002105
2106 # Check if the line is a header guard.
2107 is_header_guard = False
2108 if file_extension == 'h':
2109 cppvar = GetHeaderGuardCPPVariable(filename)
2110 if (line.startswith('#ifndef %s' % cppvar) or
2111 line.startswith('#define %s' % cppvar) or
2112 line.startswith('#endif // %s' % cppvar)):
2113 is_header_guard = True
2114 # #include lines and header guards can be long, since there's no clean way to
2115 # split them.
erg@google.coma87abb82009-02-24 01:41:01 +00002116 #
2117 # URLs can be long too. It's possible to split these, but it makes them
2118 # harder to cut&paste.
2119 if (not line.startswith('#include') and not is_header_guard and
erg@google.com36649102009-03-25 21:18:36 +00002120 not Match(r'^\s*//.*http(s?)://\S*$', line)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002121 line_width = GetLineWidth(line)
2122 if line_width > 100:
2123 error(filename, linenum, 'whitespace/line_length', 4,
2124 'Lines should very rarely be longer than 100 characters')
2125 elif line_width > 80:
2126 error(filename, linenum, 'whitespace/line_length', 2,
2127 'Lines should be <= 80 characters long')
2128
2129 if (cleansed_line.count(';') > 1 and
2130 # for loops are allowed two ;'s (and may run over two lines).
2131 cleansed_line.find('for') == -1 and
2132 (GetPreviousNonBlankLine(clean_lines, linenum)[0].find('for') == -1 or
2133 GetPreviousNonBlankLine(clean_lines, linenum)[0].find(';') != -1) and
2134 # It's ok to have many commands in a switch case that fits in 1 line
2135 not ((cleansed_line.find('case ') != -1 or
2136 cleansed_line.find('default:') != -1) and
2137 cleansed_line.find('break;') != -1)):
2138 error(filename, linenum, 'whitespace/newline', 4,
2139 'More than one command on the same line')
2140
2141 # Some more style checks
2142 CheckBraces(filename, clean_lines, linenum, error)
2143 CheckSpacing(filename, clean_lines, linenum, error)
2144 CheckCheck(filename, clean_lines, linenum, error)
2145
2146
2147_RE_PATTERN_INCLUDE_NEW_STYLE = re.compile(r'#include +"[^/]+\.h"')
2148_RE_PATTERN_INCLUDE = re.compile(r'^\s*#\s*include\s*([<"])([^>"]*)[>"].*$')
2149# Matches the first component of a filename delimited by -s and _s. That is:
2150# _RE_FIRST_COMPONENT.match('foo').group(0) == 'foo'
2151# _RE_FIRST_COMPONENT.match('foo.cc').group(0) == 'foo'
2152# _RE_FIRST_COMPONENT.match('foo-bar_baz.cc').group(0) == 'foo'
2153# _RE_FIRST_COMPONENT.match('foo_bar-baz.cc').group(0) == 'foo'
2154_RE_FIRST_COMPONENT = re.compile(r'^[^-_.]+')
2155
2156
2157def _DropCommonSuffixes(filename):
2158 """Drops common suffixes like _test.cc or -inl.h from filename.
2159
2160 For example:
2161 >>> _DropCommonSuffixes('foo/foo-inl.h')
2162 'foo/foo'
2163 >>> _DropCommonSuffixes('foo/bar/foo.cc')
2164 'foo/bar/foo'
2165 >>> _DropCommonSuffixes('foo/foo_internal.h')
2166 'foo/foo'
2167 >>> _DropCommonSuffixes('foo/foo_unusualinternal.h')
2168 'foo/foo_unusualinternal'
2169
2170 Args:
2171 filename: The input filename.
2172
2173 Returns:
2174 The filename with the common suffix removed.
2175 """
2176 for suffix in ('test.cc', 'regtest.cc', 'unittest.cc',
2177 'inl.h', 'impl.h', 'internal.h'):
2178 if (filename.endswith(suffix) and len(filename) > len(suffix) and
2179 filename[-len(suffix) - 1] in ('-', '_')):
2180 return filename[:-len(suffix) - 1]
2181 return os.path.splitext(filename)[0]
2182
2183
2184def _IsTestFilename(filename):
2185 """Determines if the given filename has a suffix that identifies it as a test.
2186
2187 Args:
2188 filename: The input filename.
2189
2190 Returns:
2191 True if 'filename' looks like a test, False otherwise.
2192 """
2193 if (filename.endswith('_test.cc') or
2194 filename.endswith('_unittest.cc') or
2195 filename.endswith('_regtest.cc')):
2196 return True
2197 else:
2198 return False
2199
2200
2201def _ClassifyInclude(fileinfo, include, is_system):
2202 """Figures out what kind of header 'include' is.
2203
2204 Args:
2205 fileinfo: The current file cpplint is running over. A FileInfo instance.
2206 include: The path to a #included file.
2207 is_system: True if the #include used <> rather than "".
2208
2209 Returns:
2210 One of the _XXX_HEADER constants.
2211
2212 For example:
2213 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'stdio.h', True)
2214 _C_SYS_HEADER
2215 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'string', True)
2216 _CPP_SYS_HEADER
2217 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/foo.h', False)
2218 _LIKELY_MY_HEADER
2219 >>> _ClassifyInclude(FileInfo('foo/foo_unknown_extension.cc'),
2220 ... 'bar/foo_other_ext.h', False)
2221 _POSSIBLE_MY_HEADER
2222 >>> _ClassifyInclude(FileInfo('foo/foo.cc'), 'foo/bar.h', False)
2223 _OTHER_HEADER
2224 """
2225 # This is a list of all standard c++ header files, except
2226 # those already checked for above.
2227 is_stl_h = include in _STL_HEADERS
2228 is_cpp_h = is_stl_h or include in _CPP_HEADERS
2229
2230 if is_system:
2231 if is_cpp_h:
2232 return _CPP_SYS_HEADER
2233 else:
2234 return _C_SYS_HEADER
2235
2236 # If the target file and the include we're checking share a
2237 # basename when we drop common extensions, and the include
2238 # lives in . , then it's likely to be owned by the target file.
2239 target_dir, target_base = (
2240 os.path.split(_DropCommonSuffixes(fileinfo.RepositoryName())))
2241 include_dir, include_base = os.path.split(_DropCommonSuffixes(include))
2242 if target_base == include_base and (
2243 include_dir == target_dir or
2244 include_dir == os.path.normpath(target_dir + '/../public')):
2245 return _LIKELY_MY_HEADER
2246
2247 # If the target and include share some initial basename
2248 # component, it's possible the target is implementing the
2249 # include, so it's allowed to be first, but we'll never
2250 # complain if it's not there.
2251 target_first_component = _RE_FIRST_COMPONENT.match(target_base)
2252 include_first_component = _RE_FIRST_COMPONENT.match(include_base)
2253 if (target_first_component and include_first_component and
2254 target_first_component.group(0) ==
2255 include_first_component.group(0)):
2256 return _POSSIBLE_MY_HEADER
2257
2258 return _OTHER_HEADER
2259
2260
erg@google.coma87abb82009-02-24 01:41:01 +00002261
erg@google.come35f7652009-06-19 20:52:09 +00002262def CheckIncludeLine(filename, clean_lines, linenum, include_state, error):
2263 """Check rules that are applicable to #include lines.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002264
erg@google.come35f7652009-06-19 20:52:09 +00002265 Strings on #include lines are NOT removed from elided line, to make
2266 certain tasks easier. However, to prevent false positives, checks
2267 applicable to #include lines in CheckLanguage must be put here.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002268
2269 Args:
2270 filename: The name of the current file.
2271 clean_lines: A CleansedLines instance containing the file.
2272 linenum: The number of the line to check.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002273 include_state: An _IncludeState instance in which the headers are inserted.
2274 error: The function to call with any errors found.
2275 """
2276 fileinfo = FileInfo(filename)
2277
erg@google.come35f7652009-06-19 20:52:09 +00002278 line = clean_lines.lines[linenum]
erg@google.com4e00b9a2009-01-12 23:05:11 +00002279
2280 # "include" should use the new style "foo/bar.h" instead of just "bar.h"
erg@google.come35f7652009-06-19 20:52:09 +00002281 if _RE_PATTERN_INCLUDE_NEW_STYLE.search(line):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002282 error(filename, linenum, 'build/include', 4,
2283 'Include the directory when naming .h files')
2284
2285 # we shouldn't include a file more than once. actually, there are a
2286 # handful of instances where doing so is okay, but in general it's
2287 # not.
erg@google.come35f7652009-06-19 20:52:09 +00002288 match = _RE_PATTERN_INCLUDE.search(line)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002289 if match:
2290 include = match.group(2)
2291 is_system = (match.group(1) == '<')
2292 if include in include_state:
2293 error(filename, linenum, 'build/include', 4,
2294 '"%s" already included at %s:%s' %
2295 (include, filename, include_state[include]))
2296 else:
2297 include_state[include] = linenum
2298
2299 # We want to ensure that headers appear in the right order:
2300 # 1) for foo.cc, foo.h (preferred location)
2301 # 2) c system files
2302 # 3) cpp system files
2303 # 4) for foo.cc, foo.h (deprecated location)
2304 # 5) other google headers
2305 #
2306 # We classify each include statement as one of those 5 types
2307 # using a number of techniques. The include_state object keeps
2308 # track of the highest type seen, and complains if we see a
2309 # lower type after that.
2310 error_message = include_state.CheckNextIncludeOrder(
2311 _ClassifyInclude(fileinfo, include, is_system))
2312 if error_message:
2313 error(filename, linenum, 'build/include_order', 4,
2314 '%s. Should be: %s.h, c system, c++ system, other.' %
2315 (error_message, fileinfo.BaseName()))
erg@google.coma868d2d2009-10-09 21:18:45 +00002316 if not include_state.IsInAlphabeticalOrder(include):
2317 error(filename, linenum, 'build/include_alpha', 4,
2318 'Include "%s" not in alphabetical order' % include)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002319
erg@google.come35f7652009-06-19 20:52:09 +00002320 # Look for any of the stream classes that are part of standard C++.
2321 match = _RE_PATTERN_INCLUDE.match(line)
2322 if match:
2323 include = match.group(2)
2324 if Match(r'(f|ind|io|i|o|parse|pf|stdio|str|)?stream$', include):
2325 # Many unit tests use cout, so we exempt them.
2326 if not _IsTestFilename(filename):
2327 error(filename, linenum, 'readability/streams', 3,
2328 'Streams are highly discouraged.')
2329
2330def CheckLanguage(filename, clean_lines, linenum, file_extension, include_state,
2331 error):
2332 """Checks rules from the 'C++ language rules' section of cppguide.html.
2333
2334 Some of these rules are hard to test (function overloading, using
2335 uint32 inappropriately), but we do the best we can.
2336
2337 Args:
2338 filename: The name of the current file.
2339 clean_lines: A CleansedLines instance containing the file.
2340 linenum: The number of the line to check.
2341 file_extension: The extension (without the dot) of the filename.
2342 include_state: An _IncludeState instance in which the headers are inserted.
2343 error: The function to call with any errors found.
2344 """
erg@google.com4e00b9a2009-01-12 23:05:11 +00002345 # If the line is empty or consists of entirely a comment, no need to
2346 # check it.
2347 line = clean_lines.elided[linenum]
2348 if not line:
2349 return
2350
erg@google.come35f7652009-06-19 20:52:09 +00002351 match = _RE_PATTERN_INCLUDE.search(line)
2352 if match:
2353 CheckIncludeLine(filename, clean_lines, linenum, include_state, error)
2354 return
2355
erg@google.com4e00b9a2009-01-12 23:05:11 +00002356 # Create an extended_line, which is the concatenation of the current and
2357 # next lines, for more effective checking of code that may span more than one
2358 # line.
2359 if linenum + 1 < clean_lines.NumLines():
2360 extended_line = line + clean_lines.elided[linenum + 1]
2361 else:
2362 extended_line = line
2363
2364 # Make Windows paths like Unix.
2365 fullname = os.path.abspath(filename).replace('\\', '/')
2366
2367 # TODO(unknown): figure out if they're using default arguments in fn proto.
2368
erg@google.com4e00b9a2009-01-12 23:05:11 +00002369 # Check for non-const references in functions. This is tricky because &
2370 # is also used to take the address of something. We allow <> for templates,
2371 # (ignoring whatever is between the braces) and : for classes.
2372 # These are complicated re's. They try to capture the following:
2373 # paren (for fn-prototype start), typename, &, varname. For the const
2374 # version, we're willing for const to be before typename or after
2375 # Don't check the implemention on same line.
2376 fnline = line.split('{', 1)[0]
2377 if (len(re.findall(r'\([^()]*\b(?:[\w:]|<[^()]*>)+(\s?&|&\s?)\w+', fnline)) >
2378 len(re.findall(r'\([^()]*\bconst\s+(?:typename\s+)?(?:struct\s+)?'
2379 r'(?:[\w:]|<[^()]*>)+(\s?&|&\s?)\w+', fnline)) +
2380 len(re.findall(r'\([^()]*\b(?:[\w:]|<[^()]*>)+\s+const(\s?&|&\s?)[\w]+',
2381 fnline))):
2382
2383 # We allow non-const references in a few standard places, like functions
2384 # called "swap()" or iostream operators like "<<" or ">>".
2385 if not Search(
2386 r'(swap|Swap|operator[<>][<>])\s*\(\s*(?:[\w:]|<.*>)+\s*&',
2387 fnline):
2388 error(filename, linenum, 'runtime/references', 2,
2389 'Is this a non-const reference? '
2390 'If so, make const or use a pointer.')
2391
2392 # Check to see if they're using an conversion function cast.
2393 # I just try to capture the most common basic types, though there are more.
2394 # Parameterless conversion functions, such as bool(), are allowed as they are
2395 # probably a member operator declaration or default constructor.
2396 match = Search(
erg@google.coma868d2d2009-10-09 21:18:45 +00002397 r'(\bnew\s+)?\b' # Grab 'new' operator, if it's there
2398 r'(int|float|double|bool|char|int32|uint32|int64|uint64)\([^)]', line)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002399 if match:
2400 # gMock methods are defined using some variant of MOCK_METHODx(name, type)
2401 # where type may be float(), int(string), etc. Without context they are
2402 # virtually indistinguishable from int(x) casts.
erg@google.coma868d2d2009-10-09 21:18:45 +00002403 if (match.group(1) is None and # If new operator, then this isn't a cast
2404 not Match(r'^\s*MOCK_(CONST_)?METHOD\d+(_T)?\(', line)):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002405 error(filename, linenum, 'readability/casting', 4,
2406 'Using deprecated casting style. '
2407 'Use static_cast<%s>(...) instead' %
erg@google.coma868d2d2009-10-09 21:18:45 +00002408 match.group(2))
erg@google.com4e00b9a2009-01-12 23:05:11 +00002409
2410 CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum],
2411 'static_cast',
2412 r'\((int|float|double|bool|char|u?int(16|32|64))\)',
2413 error)
2414 # This doesn't catch all cases. Consider (const char * const)"hello".
2415 CheckCStyleCast(filename, linenum, line, clean_lines.raw_lines[linenum],
2416 'reinterpret_cast', r'\((\w+\s?\*+\s?)\)', error)
2417
2418 # In addition, we look for people taking the address of a cast. This
2419 # is dangerous -- casts can assign to temporaries, so the pointer doesn't
2420 # point where you think.
2421 if Search(
2422 r'(&\([^)]+\)[\w(])|(&(static|dynamic|reinterpret)_cast\b)', line):
2423 error(filename, linenum, 'runtime/casting', 4,
2424 ('Are you taking an address of a cast? '
2425 'This is dangerous: could be a temp var. '
2426 'Take the address before doing the cast, rather than after'))
2427
2428 # Check for people declaring static/global STL strings at the top level.
2429 # This is dangerous because the C++ language does not guarantee that
2430 # globals with constructors are initialized before the first access.
2431 match = Match(
2432 r'((?:|static +)(?:|const +))string +([a-zA-Z0-9_:]+)\b(.*)',
2433 line)
2434 # Make sure it's not a function.
2435 # Function template specialization looks like: "string foo<Type>(...".
2436 # Class template definitions look like: "string Foo<Type>::Method(...".
2437 if match and not Match(r'\s*(<.*>)?(::[a-zA-Z0-9_]+)?\s*\(([^"]|$)',
2438 match.group(3)):
2439 error(filename, linenum, 'runtime/string', 4,
2440 'For a static/global string constant, use a C style string instead: '
2441 '"%schar %s[]".' %
2442 (match.group(1), match.group(2)))
2443
2444 # Check that we're not using RTTI outside of testing code.
2445 if Search(r'\bdynamic_cast<', line) and not _IsTestFilename(filename):
2446 error(filename, linenum, 'runtime/rtti', 5,
2447 'Do not use dynamic_cast<>. If you need to cast within a class '
2448 "hierarchy, use static_cast<> to upcast. Google doesn't support "
2449 'RTTI.')
2450
2451 if Search(r'\b([A-Za-z0-9_]*_)\(\1\)', line):
2452 error(filename, linenum, 'runtime/init', 4,
2453 'You seem to be initializing a member variable with itself.')
2454
2455 if file_extension == 'h':
2456 # TODO(unknown): check that 1-arg constructors are explicit.
2457 # How to tell it's a constructor?
2458 # (handled in CheckForNonStandardConstructs for now)
2459 # TODO(unknown): check that classes have DISALLOW_EVIL_CONSTRUCTORS
2460 # (level 1 error)
2461 pass
2462
2463 # Check if people are using the verboten C basic types. The only exception
2464 # we regularly allow is "unsigned short port" for port.
2465 if Search(r'\bshort port\b', line):
2466 if not Search(r'\bunsigned short port\b', line):
2467 error(filename, linenum, 'runtime/int', 4,
2468 'Use "unsigned short" for ports, not "short"')
2469 else:
2470 match = Search(r'\b(short|long(?! +double)|long long)\b', line)
2471 if match:
2472 error(filename, linenum, 'runtime/int', 4,
2473 'Use int16/int64/etc, rather than the C type %s' % match.group(1))
2474
2475 # When snprintf is used, the second argument shouldn't be a literal.
2476 match = Search(r'snprintf\s*\(([^,]*),\s*([0-9]*)\s*,', line)
erg+personal@google.com05189642010-04-30 20:43:03 +00002477 if match and match.group(2) != '0':
2478 # If 2nd arg is zero, snprintf is used to calculate size.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002479 error(filename, linenum, 'runtime/printf', 3,
2480 'If you can, use sizeof(%s) instead of %s as the 2nd arg '
2481 'to snprintf.' % (match.group(1), match.group(2)))
2482
2483 # Check if some verboten C functions are being used.
2484 if Search(r'\bsprintf\b', line):
2485 error(filename, linenum, 'runtime/printf', 5,
2486 'Never use sprintf. Use snprintf instead.')
2487 match = Search(r'\b(strcpy|strcat)\b', line)
2488 if match:
2489 error(filename, linenum, 'runtime/printf', 4,
2490 'Almost always, snprintf is better than %s' % match.group(1))
2491
2492 if Search(r'\bsscanf\b', line):
2493 error(filename, linenum, 'runtime/printf', 1,
2494 'sscanf can be ok, but is slow and can overflow buffers.')
2495
erg@google.coma868d2d2009-10-09 21:18:45 +00002496 # Check if some verboten operator overloading is going on
2497 # TODO(unknown): catch out-of-line unary operator&:
2498 # class X {};
2499 # int operator&(const X& x) { return 42; } // unary operator&
2500 # The trick is it's hard to tell apart from binary operator&:
2501 # class Y { int operator&(const Y& x) { return 23; } }; // binary operator&
2502 if Search(r'\boperator\s*&\s*\(\s*\)', line):
2503 error(filename, linenum, 'runtime/operator', 4,
2504 'Unary operator& is dangerous. Do not use it.')
2505
erg@google.com4e00b9a2009-01-12 23:05:11 +00002506 # Check for suspicious usage of "if" like
2507 # } if (a == b) {
2508 if Search(r'\}\s*if\s*\(', line):
2509 error(filename, linenum, 'readability/braces', 4,
2510 'Did you mean "else if"? If not, start a new line for "if".')
2511
2512 # Check for potential format string bugs like printf(foo).
2513 # We constrain the pattern not to pick things like DocidForPrintf(foo).
2514 # Not perfect but it can catch printf(foo.c_str()) and printf(foo->c_str())
2515 match = re.search(r'\b((?:string)?printf)\s*\(([\w.\->()]+)\)', line, re.I)
2516 if match:
2517 error(filename, linenum, 'runtime/printf', 4,
2518 'Potential format string bug. Do %s("%%s", %s) instead.'
2519 % (match.group(1), match.group(2)))
2520
2521 # Check for potential memset bugs like memset(buf, sizeof(buf), 0).
2522 match = Search(r'memset\s*\(([^,]*),\s*([^,]*),\s*0\s*\)', line)
2523 if match and not Match(r"^''|-?[0-9]+|0x[0-9A-Fa-f]$", match.group(2)):
2524 error(filename, linenum, 'runtime/memset', 4,
2525 'Did you mean "memset(%s, 0, %s)"?'
2526 % (match.group(1), match.group(2)))
2527
2528 if Search(r'\busing namespace\b', line):
2529 error(filename, linenum, 'build/namespaces', 5,
2530 'Do not use namespace using-directives. '
2531 'Use using-declarations instead.')
2532
2533 # Detect variable-length arrays.
2534 match = Match(r'\s*(.+::)?(\w+) [a-z]\w*\[(.+)];', line)
2535 if (match and match.group(2) != 'return' and match.group(2) != 'delete' and
2536 match.group(3).find(']') == -1):
2537 # Split the size using space and arithmetic operators as delimiters.
2538 # If any of the resulting tokens are not compile time constants then
2539 # report the error.
2540 tokens = re.split(r'\s|\+|\-|\*|\/|<<|>>]', match.group(3))
2541 is_const = True
2542 skip_next = False
2543 for tok in tokens:
2544 if skip_next:
2545 skip_next = False
2546 continue
2547
2548 if Search(r'sizeof\(.+\)', tok): continue
2549 if Search(r'arraysize\(\w+\)', tok): continue
2550
2551 tok = tok.lstrip('(')
2552 tok = tok.rstrip(')')
2553 if not tok: continue
2554 if Match(r'\d+', tok): continue
2555 if Match(r'0[xX][0-9a-fA-F]+', tok): continue
2556 if Match(r'k[A-Z0-9]\w*', tok): continue
2557 if Match(r'(.+::)?k[A-Z0-9]\w*', tok): continue
2558 if Match(r'(.+::)?[A-Z][A-Z0-9_]*', tok): continue
2559 # A catch all for tricky sizeof cases, including 'sizeof expression',
2560 # 'sizeof(*type)', 'sizeof(const type)', 'sizeof(struct StructName)'
2561 # requires skipping the next token becasue we split on ' ' and '*'.
2562 if tok.startswith('sizeof'):
2563 skip_next = True
2564 continue
2565 is_const = False
2566 break
2567 if not is_const:
2568 error(filename, linenum, 'runtime/arrays', 1,
2569 'Do not use variable-length arrays. Use an appropriately named '
2570 "('k' followed by CamelCase) compile-time constant for the size.")
2571
2572 # If DISALLOW_EVIL_CONSTRUCTORS, DISALLOW_COPY_AND_ASSIGN, or
2573 # DISALLOW_IMPLICIT_CONSTRUCTORS is present, then it should be the last thing
2574 # in the class declaration.
2575 match = Match(
2576 (r'\s*'
2577 r'(DISALLOW_(EVIL_CONSTRUCTORS|COPY_AND_ASSIGN|IMPLICIT_CONSTRUCTORS))'
2578 r'\(.*\);$'),
2579 line)
2580 if match and linenum + 1 < clean_lines.NumLines():
2581 next_line = clean_lines.elided[linenum + 1]
2582 if not Search(r'^\s*};', next_line):
2583 error(filename, linenum, 'readability/constructors', 3,
2584 match.group(1) + ' should be the last thing in the class')
2585
2586 # Check for use of unnamed namespaces in header files. Registration
2587 # macros are typically OK, so we allow use of "namespace {" on lines
2588 # that end with backslashes.
2589 if (file_extension == 'h'
2590 and Search(r'\bnamespace\s*{', line)
2591 and line[-1] != '\\'):
2592 error(filename, linenum, 'build/namespaces', 4,
2593 'Do not use unnamed namespaces in header files. See '
2594 'http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces'
2595 ' for more information.')
2596
2597
2598def CheckCStyleCast(filename, linenum, line, raw_line, cast_type, pattern,
2599 error):
2600 """Checks for a C-style cast by looking for the pattern.
2601
2602 This also handles sizeof(type) warnings, due to similarity of content.
2603
2604 Args:
2605 filename: The name of the current file.
2606 linenum: The number of the line to check.
2607 line: The line of code to check.
2608 raw_line: The raw line of code to check, with comments.
2609 cast_type: The string for the C++ cast to recommend. This is either
2610 reinterpret_cast or static_cast, depending.
2611 pattern: The regular expression used to find C-style casts.
2612 error: The function to call with any errors found.
2613 """
2614 match = Search(pattern, line)
2615 if not match:
2616 return
2617
2618 # e.g., sizeof(int)
2619 sizeof_match = Match(r'.*sizeof\s*$', line[0:match.start(1) - 1])
2620 if sizeof_match:
2621 error(filename, linenum, 'runtime/sizeof', 1,
2622 'Using sizeof(type). Use sizeof(varname) instead if possible')
2623 return
2624
2625 remainder = line[match.end(0):]
2626
2627 # The close paren is for function pointers as arguments to a function.
2628 # eg, void foo(void (*bar)(int));
2629 # The semicolon check is a more basic function check; also possibly a
2630 # function pointer typedef.
2631 # eg, void foo(int); or void foo(int) const;
2632 # The equals check is for function pointer assignment.
2633 # eg, void *(*foo)(int) = ...
2634 #
2635 # Right now, this will only catch cases where there's a single argument, and
2636 # it's unnamed. It should probably be expanded to check for multiple
2637 # arguments with some unnamed.
2638 function_match = Match(r'\s*(\)|=|(const)?\s*(;|\{|throw\(\)))', remainder)
2639 if function_match:
2640 if (not function_match.group(3) or
2641 function_match.group(3) == ';' or
2642 raw_line.find('/*') < 0):
2643 error(filename, linenum, 'readability/function', 3,
2644 'All parameters should be named in a function')
2645 return
2646
2647 # At this point, all that should be left is actual casts.
2648 error(filename, linenum, 'readability/casting', 4,
2649 'Using C-style cast. Use %s<%s>(...) instead' %
2650 (cast_type, match.group(1)))
2651
2652
2653_HEADERS_CONTAINING_TEMPLATES = (
2654 ('<deque>', ('deque',)),
2655 ('<functional>', ('unary_function', 'binary_function',
2656 'plus', 'minus', 'multiplies', 'divides', 'modulus',
2657 'negate',
2658 'equal_to', 'not_equal_to', 'greater', 'less',
2659 'greater_equal', 'less_equal',
2660 'logical_and', 'logical_or', 'logical_not',
2661 'unary_negate', 'not1', 'binary_negate', 'not2',
2662 'bind1st', 'bind2nd',
2663 'pointer_to_unary_function',
2664 'pointer_to_binary_function',
2665 'ptr_fun',
2666 'mem_fun_t', 'mem_fun', 'mem_fun1_t', 'mem_fun1_ref_t',
2667 'mem_fun_ref_t',
2668 'const_mem_fun_t', 'const_mem_fun1_t',
2669 'const_mem_fun_ref_t', 'const_mem_fun1_ref_t',
2670 'mem_fun_ref',
2671 )),
2672 ('<limits>', ('numeric_limits',)),
2673 ('<list>', ('list',)),
2674 ('<map>', ('map', 'multimap',)),
2675 ('<memory>', ('allocator',)),
2676 ('<queue>', ('queue', 'priority_queue',)),
2677 ('<set>', ('set', 'multiset',)),
2678 ('<stack>', ('stack',)),
2679 ('<string>', ('char_traits', 'basic_string',)),
2680 ('<utility>', ('pair',)),
2681 ('<vector>', ('vector',)),
2682
2683 # gcc extensions.
2684 # Note: std::hash is their hash, ::hash is our hash
2685 ('<hash_map>', ('hash_map', 'hash_multimap',)),
2686 ('<hash_set>', ('hash_set', 'hash_multiset',)),
2687 ('<slist>', ('slist',)),
2688 )
2689
2690_HEADERS_ACCEPTED_BUT_NOT_PROMOTED = {
2691 # We can trust with reasonable confidence that map gives us pair<>, too.
2692 'pair<>': ('map', 'multimap', 'hash_map', 'hash_multimap')
2693}
2694
2695_RE_PATTERN_STRING = re.compile(r'\bstring\b')
2696
2697_re_pattern_algorithm_header = []
erg@google.coma87abb82009-02-24 01:41:01 +00002698for _template in ('copy', 'max', 'min', 'min_element', 'sort', 'swap',
2699 'transform'):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002700 # Match max<type>(..., ...), max(..., ...), but not foo->max, foo.max or
2701 # type::max().
2702 _re_pattern_algorithm_header.append(
2703 (re.compile(r'[^>.]\b' + _template + r'(<.*?>)?\([^\)]'),
2704 _template,
2705 '<algorithm>'))
2706
2707_re_pattern_templates = []
2708for _header, _templates in _HEADERS_CONTAINING_TEMPLATES:
2709 for _template in _templates:
2710 _re_pattern_templates.append(
2711 (re.compile(r'(\<|\b)' + _template + r'\s*\<'),
2712 _template + '<>',
2713 _header))
2714
2715
erg@google.come35f7652009-06-19 20:52:09 +00002716def FilesBelongToSameModule(filename_cc, filename_h):
2717 """Check if these two filenames belong to the same module.
2718
2719 The concept of a 'module' here is a as follows:
2720 foo.h, foo-inl.h, foo.cc, foo_test.cc and foo_unittest.cc belong to the
2721 same 'module' if they are in the same directory.
2722 some/path/public/xyzzy and some/path/internal/xyzzy are also considered
2723 to belong to the same module here.
2724
2725 If the filename_cc contains a longer path than the filename_h, for example,
2726 '/absolute/path/to/base/sysinfo.cc', and this file would include
2727 'base/sysinfo.h', this function also produces the prefix needed to open the
2728 header. This is used by the caller of this function to more robustly open the
2729 header file. We don't have access to the real include paths in this context,
2730 so we need this guesswork here.
2731
2732 Known bugs: tools/base/bar.cc and base/bar.h belong to the same module
2733 according to this implementation. Because of this, this function gives
2734 some false positives. This should be sufficiently rare in practice.
2735
2736 Args:
2737 filename_cc: is the path for the .cc file
2738 filename_h: is the path for the header path
2739
2740 Returns:
2741 Tuple with a bool and a string:
2742 bool: True if filename_cc and filename_h belong to the same module.
2743 string: the additional prefix needed to open the header file.
2744 """
2745
2746 if not filename_cc.endswith('.cc'):
2747 return (False, '')
2748 filename_cc = filename_cc[:-len('.cc')]
2749 if filename_cc.endswith('_unittest'):
2750 filename_cc = filename_cc[:-len('_unittest')]
2751 elif filename_cc.endswith('_test'):
2752 filename_cc = filename_cc[:-len('_test')]
2753 filename_cc = filename_cc.replace('/public/', '/')
2754 filename_cc = filename_cc.replace('/internal/', '/')
2755
2756 if not filename_h.endswith('.h'):
2757 return (False, '')
2758 filename_h = filename_h[:-len('.h')]
2759 if filename_h.endswith('-inl'):
2760 filename_h = filename_h[:-len('-inl')]
2761 filename_h = filename_h.replace('/public/', '/')
2762 filename_h = filename_h.replace('/internal/', '/')
2763
2764 files_belong_to_same_module = filename_cc.endswith(filename_h)
2765 common_path = ''
2766 if files_belong_to_same_module:
2767 common_path = filename_cc[:-len(filename_h)]
2768 return files_belong_to_same_module, common_path
2769
2770
2771def UpdateIncludeState(filename, include_state, io=codecs):
2772 """Fill up the include_state with new includes found from the file.
2773
2774 Args:
2775 filename: the name of the header to read.
2776 include_state: an _IncludeState instance in which the headers are inserted.
2777 io: The io factory to use to read the file. Provided for testability.
2778
2779 Returns:
2780 True if a header was succesfully added. False otherwise.
2781 """
2782 headerfile = None
2783 try:
2784 headerfile = io.open(filename, 'r', 'utf8', 'replace')
2785 except IOError:
2786 return False
2787 linenum = 0
2788 for line in headerfile:
2789 linenum += 1
2790 clean_line = CleanseComments(line)
2791 match = _RE_PATTERN_INCLUDE.search(clean_line)
2792 if match:
2793 include = match.group(2)
2794 # The value formatting is cute, but not really used right now.
2795 # What matters here is that the key is in include_state.
2796 include_state.setdefault(include, '%s:%d' % (filename, linenum))
2797 return True
2798
2799
2800def CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error,
2801 io=codecs):
erg@google.com4e00b9a2009-01-12 23:05:11 +00002802 """Reports for missing stl includes.
2803
2804 This function will output warnings to make sure you are including the headers
2805 necessary for the stl containers and functions that you use. We only give one
2806 reason to include a header. For example, if you use both equal_to<> and
2807 less<> in a .h file, only one (the latter in the file) of these will be
2808 reported as a reason to include the <functional>.
2809
erg@google.com4e00b9a2009-01-12 23:05:11 +00002810 Args:
2811 filename: The name of the current file.
2812 clean_lines: A CleansedLines instance containing the file.
2813 include_state: An _IncludeState instance.
2814 error: The function to call with any errors found.
erg@google.come35f7652009-06-19 20:52:09 +00002815 io: The IO factory to use to read the header file. Provided for unittest
2816 injection.
erg@google.com4e00b9a2009-01-12 23:05:11 +00002817 """
erg@google.com4e00b9a2009-01-12 23:05:11 +00002818 required = {} # A map of header name to linenumber and the template entity.
2819 # Example of required: { '<functional>': (1219, 'less<>') }
2820
2821 for linenum in xrange(clean_lines.NumLines()):
2822 line = clean_lines.elided[linenum]
2823 if not line or line[0] == '#':
2824 continue
2825
2826 # String is special -- it is a non-templatized type in STL.
erg+personal@google.com05189642010-04-30 20:43:03 +00002827 m = _RE_PATTERN_STRING.search(line)
2828 if m:
2829 # Don't warn about strings in non-STL namespaces:
2830 # (We check only the first match per line; good enough.)
2831 prefix = line[:m.start()]
2832 if prefix.endswith('std::') or not prefix.endswith('::'):
2833 required['<string>'] = (linenum, 'string')
erg@google.com4e00b9a2009-01-12 23:05:11 +00002834
2835 for pattern, template, header in _re_pattern_algorithm_header:
2836 if pattern.search(line):
2837 required[header] = (linenum, template)
2838
2839 # The following function is just a speed up, no semantics are changed.
2840 if not '<' in line: # Reduces the cpu time usage by skipping lines.
2841 continue
2842
2843 for pattern, template, header in _re_pattern_templates:
2844 if pattern.search(line):
2845 required[header] = (linenum, template)
2846
erg@google.come35f7652009-06-19 20:52:09 +00002847 # The policy is that if you #include something in foo.h you don't need to
2848 # include it again in foo.cc. Here, we will look at possible includes.
2849 # Let's copy the include_state so it is only messed up within this function.
2850 include_state = include_state.copy()
2851
2852 # Did we find the header for this file (if any) and succesfully load it?
2853 header_found = False
2854
2855 # Use the absolute path so that matching works properly.
2856 abs_filename = os.path.abspath(filename)
2857
2858 # For Emacs's flymake.
2859 # If cpplint is invoked from Emacs's flymake, a temporary file is generated
2860 # by flymake and that file name might end with '_flymake.cc'. In that case,
2861 # restore original file name here so that the corresponding header file can be
2862 # found.
2863 # e.g. If the file name is 'foo_flymake.cc', we should search for 'foo.h'
2864 # instead of 'foo_flymake.h'
erg+personal@google.com05189642010-04-30 20:43:03 +00002865 abs_filename = re.sub(r'_flymake\.cc$', '.cc', abs_filename)
erg@google.come35f7652009-06-19 20:52:09 +00002866
2867 # include_state is modified during iteration, so we iterate over a copy of
2868 # the keys.
2869 for header in include_state.keys(): #NOLINT
2870 (same_module, common_path) = FilesBelongToSameModule(abs_filename, header)
2871 fullpath = common_path + header
2872 if same_module and UpdateIncludeState(fullpath, include_state, io):
2873 header_found = True
2874
2875 # If we can't find the header file for a .cc, assume it's because we don't
2876 # know where to look. In that case we'll give up as we're not sure they
2877 # didn't include it in the .h file.
2878 # TODO(unknown): Do a better job of finding .h files so we are confident that
2879 # not having the .h file means there isn't one.
2880 if filename.endswith('.cc') and not header_found:
2881 return
2882
erg@google.com4e00b9a2009-01-12 23:05:11 +00002883 # All the lines have been processed, report the errors found.
2884 for required_header_unstripped in required:
2885 template = required[required_header_unstripped][1]
2886 if template in _HEADERS_ACCEPTED_BUT_NOT_PROMOTED:
2887 headers = _HEADERS_ACCEPTED_BUT_NOT_PROMOTED[template]
2888 if [True for header in headers if header in include_state]:
2889 continue
2890 if required_header_unstripped.strip('<>"') not in include_state:
2891 error(filename, required[required_header_unstripped][0],
2892 'build/include_what_you_use', 4,
2893 'Add #include ' + required_header_unstripped + ' for ' + template)
2894
2895
2896def ProcessLine(filename, file_extension,
2897 clean_lines, line, include_state, function_state,
2898 class_state, error):
2899 """Processes a single line in the file.
2900
2901 Args:
2902 filename: Filename of the file that is being processed.
2903 file_extension: The extension (dot not included) of the file.
2904 clean_lines: An array of strings, each representing a line of the file,
2905 with comments stripped.
2906 line: Number of line being processed.
2907 include_state: An _IncludeState instance in which the headers are inserted.
2908 function_state: A _FunctionState instance which counts function lines, etc.
2909 class_state: A _ClassState instance which maintains information about
2910 the current stack of nested class declarations being parsed.
2911 error: A callable to which errors are reported, which takes 4 arguments:
2912 filename, line number, error level, and message
2913
2914 """
2915 raw_lines = clean_lines.raw_lines
erg+personal@google.com05189642010-04-30 20:43:03 +00002916 ParseNolintSuppressions(filename, raw_lines[line], line, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002917 CheckForFunctionLengths(filename, clean_lines, line, function_state, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002918 CheckForMultilineCommentsAndStrings(filename, clean_lines, line, error)
2919 CheckStyle(filename, clean_lines, line, file_extension, error)
2920 CheckLanguage(filename, clean_lines, line, file_extension, include_state,
2921 error)
2922 CheckForNonStandardConstructs(filename, clean_lines, line,
2923 class_state, error)
2924 CheckPosixThreading(filename, clean_lines, line, error)
erg@google.com36649102009-03-25 21:18:36 +00002925 CheckInvalidIncrement(filename, clean_lines, line, error)
erg@google.com4e00b9a2009-01-12 23:05:11 +00002926
2927
2928def ProcessFileData(filename, file_extension, lines, error):
2929 """Performs lint checks and reports any errors to the given error function.
2930
2931 Args:
2932 filename: Filename of the file that is being processed.
2933 file_extension: The extension (dot not included) of the file.
2934 lines: An array of strings, each representing a line of the file, with the
2935 last element being empty if the file is termined with a newline.
2936 error: A callable to which errors are reported, which takes 4 arguments:
2937 """
2938 lines = (['// marker so line numbers and indices both start at 1'] + lines +
2939 ['// marker so line numbers end in a known way'])
2940
2941 include_state = _IncludeState()
2942 function_state = _FunctionState()
2943 class_state = _ClassState()
2944
erg+personal@google.com05189642010-04-30 20:43:03 +00002945 ResetNolintSuppressions()
2946
erg@google.com4e00b9a2009-01-12 23:05:11 +00002947 CheckForCopyright(filename, lines, error)
2948
2949 if file_extension == 'h':
2950 CheckForHeaderGuard(filename, lines, error)
2951
2952 RemoveMultiLineComments(filename, lines, error)
2953 clean_lines = CleansedLines(lines)
2954 for line in xrange(clean_lines.NumLines()):
2955 ProcessLine(filename, file_extension, clean_lines, line,
2956 include_state, function_state, class_state, error)
2957 class_state.CheckFinished(filename, error)
2958
2959 CheckForIncludeWhatYouUse(filename, clean_lines, include_state, error)
2960
2961 # We check here rather than inside ProcessLine so that we see raw
2962 # lines rather than "cleaned" lines.
2963 CheckForUnicodeReplacementCharacters(filename, lines, error)
2964
2965 CheckForNewlineAtEOF(filename, lines, error)
2966
erg@google.com4e00b9a2009-01-12 23:05:11 +00002967def ProcessFile(filename, vlevel):
2968 """Does google-lint on a single file.
2969
2970 Args:
2971 filename: The name of the file to parse.
2972
2973 vlevel: The level of errors to report. Every error of confidence
2974 >= verbose_level will be reported. 0 is a good default.
2975 """
2976
2977 _SetVerboseLevel(vlevel)
2978
2979 try:
2980 # Support the UNIX convention of using "-" for stdin. Note that
2981 # we are not opening the file with universal newline support
2982 # (which codecs doesn't support anyway), so the resulting lines do
2983 # contain trailing '\r' characters if we are reading a file that
2984 # has CRLF endings.
2985 # If after the split a trailing '\r' is present, it is removed
2986 # below. If it is not expected to be present (i.e. os.linesep !=
2987 # '\r\n' as in Windows), a warning is issued below if this file
2988 # is processed.
2989
2990 if filename == '-':
2991 lines = codecs.StreamReaderWriter(sys.stdin,
2992 codecs.getreader('utf8'),
2993 codecs.getwriter('utf8'),
2994 'replace').read().split('\n')
2995 else:
2996 lines = codecs.open(filename, 'r', 'utf8', 'replace').read().split('\n')
2997
2998 carriage_return_found = False
2999 # Remove trailing '\r'.
3000 for linenum in range(len(lines)):
3001 if lines[linenum].endswith('\r'):
3002 lines[linenum] = lines[linenum].rstrip('\r')
3003 carriage_return_found = True
3004
3005 except IOError:
3006 sys.stderr.write(
3007 "Skipping input '%s': Can't open for reading\n" % filename)
3008 return
3009
3010 # Note, if no dot is found, this will give the entire filename as the ext.
3011 file_extension = filename[filename.rfind('.') + 1:]
3012
3013 # When reading from stdin, the extension is unknown, so no cpplint tests
3014 # should rely on the extension.
3015 if (filename != '-' and file_extension != 'cc' and file_extension != 'h'
3016 and file_extension != 'cpp'):
3017 sys.stderr.write('Ignoring %s; not a .cc or .h file\n' % filename)
3018 else:
3019 ProcessFileData(filename, file_extension, lines, Error)
3020 if carriage_return_found and os.linesep != '\r\n':
3021 # Use 0 for linenum since outputing only one error for potentially
3022 # several lines.
3023 Error(filename, 0, 'whitespace/newline', 1,
3024 'One or more unexpected \\r (^M) found;'
3025 'better to use only a \\n')
3026
3027 sys.stderr.write('Done processing %s\n' % filename)
3028
3029
3030def PrintUsage(message):
3031 """Prints a brief usage string and exits, optionally with an error message.
3032
3033 Args:
3034 message: The optional error message.
3035 """
3036 sys.stderr.write(_USAGE)
3037 if message:
3038 sys.exit('\nFATAL ERROR: ' + message)
3039 else:
3040 sys.exit(1)
3041
3042
3043def PrintCategories():
3044 """Prints a list of all the error-categories used by error messages.
3045
3046 These are the categories used to filter messages via --filter.
3047 """
erg+personal@google.com05189642010-04-30 20:43:03 +00003048 sys.stderr.write(''.join(' %s\n' % cat for cat in _ERROR_CATEGORIES))
erg@google.com4e00b9a2009-01-12 23:05:11 +00003049 sys.exit(0)
3050
3051
3052def ParseArguments(args):
3053 """Parses the command line arguments.
3054
3055 This may set the output format and verbosity level as side-effects.
3056
3057 Args:
3058 args: The command line arguments:
3059
3060 Returns:
3061 The list of filenames to lint.
3062 """
3063 try:
3064 (opts, filenames) = getopt.getopt(args, '', ['help', 'output=', 'verbose=',
erg@google.coma868d2d2009-10-09 21:18:45 +00003065 'counting=',
erg@google.com4e00b9a2009-01-12 23:05:11 +00003066 'filter='])
3067 except getopt.GetoptError:
3068 PrintUsage('Invalid arguments.')
3069
3070 verbosity = _VerboseLevel()
3071 output_format = _OutputFormat()
3072 filters = ''
erg@google.coma868d2d2009-10-09 21:18:45 +00003073 counting_style = ''
erg@google.com4e00b9a2009-01-12 23:05:11 +00003074
3075 for (opt, val) in opts:
3076 if opt == '--help':
3077 PrintUsage(None)
3078 elif opt == '--output':
3079 if not val in ('emacs', 'vs7'):
3080 PrintUsage('The only allowed output formats are emacs and vs7.')
3081 output_format = val
3082 elif opt == '--verbose':
3083 verbosity = int(val)
3084 elif opt == '--filter':
3085 filters = val
erg@google.coma87abb82009-02-24 01:41:01 +00003086 if not filters:
erg@google.com4e00b9a2009-01-12 23:05:11 +00003087 PrintCategories()
erg@google.coma868d2d2009-10-09 21:18:45 +00003088 elif opt == '--counting':
3089 if val not in ('total', 'toplevel', 'detailed'):
3090 PrintUsage('Valid counting options are total, toplevel, and detailed')
3091 counting_style = val
erg@google.com4e00b9a2009-01-12 23:05:11 +00003092
3093 if not filenames:
3094 PrintUsage('No files were specified.')
3095
3096 _SetOutputFormat(output_format)
3097 _SetVerboseLevel(verbosity)
3098 _SetFilters(filters)
erg@google.coma868d2d2009-10-09 21:18:45 +00003099 _SetCountingStyle(counting_style)
erg@google.com4e00b9a2009-01-12 23:05:11 +00003100
3101 return filenames
3102
3103
3104def main():
3105 filenames = ParseArguments(sys.argv[1:])
3106
3107 # Change stderr to write with replacement characters so we don't die
3108 # if we try to print something containing non-ASCII characters.
3109 sys.stderr = codecs.StreamReaderWriter(sys.stderr,
3110 codecs.getreader('utf8'),
3111 codecs.getwriter('utf8'),
3112 'replace')
3113
erg@google.coma868d2d2009-10-09 21:18:45 +00003114 _cpplint_state.ResetErrorCounts()
erg@google.com4e00b9a2009-01-12 23:05:11 +00003115 for filename in filenames:
3116 ProcessFile(filename, _cpplint_state.verbose_level)
erg@google.coma868d2d2009-10-09 21:18:45 +00003117 _cpplint_state.PrintErrorCounts()
3118
erg@google.com4e00b9a2009-01-12 23:05:11 +00003119 sys.exit(_cpplint_state.error_count > 0)
3120
3121
3122if __name__ == '__main__':
3123 main()