commit 17af756df42cda5d6dc1e5b4bca48ab2df053c21
author Łukasz Strzałkowski <lukasz.strzalkowski@gmail.com> Fri Jun 09 13:53:39 2017 -0700
committer Carl Mastrangelo <notcarl@google.com> Fri Jun 09 13:53:39 2017 -0700
tree bd69348645b59ee2eb316e54e3ca94fbed530280
parent 8d304b68922d654b02d5437a01999f052e2ada1c

core: deprecate MethodDescriptor.create

Use MethodDescriptor.newBuilder instead

core/src/main/java/io/grpc/MethodDescriptor.java

diff --git a/core/src/main/java/io/grpc/MethodDescriptor.java b/core/src/main/java/io/grpc/MethodDescriptor.java
index 9a0b063..57ac7b5 100644
--- a/core/src/main/java/io/grpc/MethodDescriptor.java
+++ b/core/src/main/java/io/grpc/MethodDescriptor.java
@@ -200,7 +200,9 @@
    * @param requestMarshaller the marshaller used to encode and decode requests
    * @param responseMarshaller the marshaller used to encode and decode responses
    * @since 1.0.0
+   * @deprecated use {@link #newBuilder()}.
    */
+  @Deprecated
   public static <RequestT, ResponseT> MethodDescriptor<RequestT, ResponseT> create(
       MethodType type, String fullMethodName,
       Marshaller<RequestT> requestMarshaller,

core/src/test/java/io/grpc/MethodDescriptorTest.java

diff --git a/core/src/test/java/io/grpc/MethodDescriptorTest.java b/core/src/test/java/io/grpc/MethodDescriptorTest.java
index 56d5b46..9647214 100644
--- a/core/src/test/java/io/grpc/MethodDescriptorTest.java
+++ b/core/src/test/java/io/grpc/MethodDescriptorTest.java
@@ -32,6 +32,7 @@
 public class MethodDescriptorTest {
   @Test
   public void createMethodDescriptor() {
+    @SuppressWarnings("deprecation") // MethodDescriptor.create
     MethodDescriptor<String, String> descriptor = MethodDescriptor.<String, String>create(
         MethodType.CLIENT_STREAMING, "/package.service/method", new StringMarshaller(),
         new StringMarshaller());

core/src/test/java/io/grpc/ServiceDescriptorTest.java

diff --git a/core/src/test/java/io/grpc/ServiceDescriptorTest.java b/core/src/test/java/io/grpc/ServiceDescriptorTest.java
index 2c29a80..0f12aa2 100644
--- a/core/src/test/java/io/grpc/ServiceDescriptorTest.java
+++ b/core/src/test/java/io/grpc/ServiceDescriptorTest.java
@@ -63,6 +63,7 @@
 
   @Test
   public void failsOnNonMatchingNames() {
+    @SuppressWarnings("deprecation") // MethodDescriptor.create
     List<MethodDescriptor<?, ?>> descriptors = Collections.<MethodDescriptor<?, ?>>singletonList(
         MethodDescriptor.create(
             MethodType.UNARY,
@@ -78,6 +79,7 @@
 
   @Test
   public void failsOnNonDuplicateNames() {
+    @SuppressWarnings("deprecation") // MethodDescriptor.create
     List<MethodDescriptor<?, ?>> descriptors = Arrays.<MethodDescriptor<?, ?>>asList(
         MethodDescriptor.create(
             MethodType.UNARY,

core/src/test/java/io/grpc/internal/CensusModulesTest.java

diff --git a/core/src/test/java/io/grpc/internal/CensusModulesTest.java b/core/src/test/java/io/grpc/internal/CensusModulesTest.java
index c5a93bf..466b51f 100644
--- a/core/src/test/java/io/grpc/internal/CensusModulesTest.java
+++ b/core/src/test/java/io/grpc/internal/CensusModulesTest.java
@@ -131,9 +131,13 @@
         }
       };
 
-  private final MethodDescriptor<String, String> method = MethodDescriptor.create(
-      MethodDescriptor.MethodType.UNKNOWN, "package1.service2/method3",
-      MARSHALLER, MARSHALLER);
+  private final MethodDescriptor<String, String> method =
+      MethodDescriptor.<String, String>newBuilder()
+          .setType(MethodDescriptor.MethodType.UNKNOWN)
+          .setRequestMarshaller(MARSHALLER)
+          .setResponseMarshaller(MARSHALLER)
+          .setFullMethodName("package1.service2/method3")
+          .build();
   private final FakeClock fakeClock = new FakeClock();
   private final FakeStatsContextFactory statsCtxFactory = new FakeStatsContextFactory();
   private final Random random = new Random(0);