commit d74091f567a2ae251524b8a901f6b4f9f57bb4df
author Kun Zhang <zhangkun@google.com> Fri Sep 16 22:34:27 2016 -0700
committer Kun Zhang <zhangkun@google.com> Tue Sep 20 21:12:43 2016 -0700
tree 78d8a0ec0a2129524476815a58ab83614686641d
parent 107fa8e801fe93bd84ac15b9258a16e2729fb287

core: fix a discrepency in state transition.

Channel state API doesn't allow a TRANSIENT_FAILURE->IDLE edge.
Change TransportSet to always transition to CONNECTING after
TRANSIENT_FAILURE.

This behavior, combined with that it never uses IDLE_TIMEOUT to
transition from READY to IDLE, effectivly makes TransportSet
Channel-state API-compliant under an infinite IDLE_TIMEOUT.

Also set the default IDLE_TIMEOUT to 30min.

core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java

diff --git a/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java b/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java
index 3c28004..39d78b6 100644
--- a/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java
+++ b/core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java
@@ -78,6 +78,12 @@
   static final long IDLE_MODE_MAX_TIMEOUT_DAYS = 30;
 
   /**
+   * The default idle timeout.
+   */
+  @VisibleForTesting
+  static final long IDLE_MODE_DEFAULT_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(30);
+
+  /**
    * An idle timeout smaller than this would be capped to it.
    */
   @VisibleForTesting
@@ -110,7 +116,7 @@
   @Nullable
   private CompressorRegistry compressorRegistry;
 
-  private long idleTimeoutMillis = ManagedChannelImpl.IDLE_TIMEOUT_MILLIS_DISABLE;
+  private long idleTimeoutMillis = IDLE_MODE_DEFAULT_TIMEOUT_MILLIS;
 
   protected AbstractManagedChannelImplBuilder(String target) {
     this.target = Preconditions.checkNotNull(target, "target");