commit f4694f57f9dbba533cde642917c3347b4ad4d668
author nathanmittler <nathanmittler@google.com> Wed Jun 25 09:18:42 2014 -0700
committer Eric Anderson <ejona@google.com> Thu Jan 08 14:42:26 2015 -0800
tree 4d6d3803caf1ccd2b6c04600be0dc87ee053390b
parent 69336671788495cf6a7b6390a3a50c77501c51f2

A couple minor fixes to Channel for bugs exposed while integration testing with Netty transport.

-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=69939586

core/src/main/java/com/google/net/stubby/ChannelImpl.java

diff --git a/core/src/main/java/com/google/net/stubby/ChannelImpl.java b/core/src/main/java/com/google/net/stubby/ChannelImpl.java
index acf4861..cb3645d 100644
--- a/core/src/main/java/com/google/net/stubby/ChannelImpl.java
+++ b/core/src/main/java/com/google/net/stubby/ChannelImpl.java
@@ -52,9 +52,13 @@
 
   @Override
   protected synchronized void doStop() {
-    activeTransport.stopAsync();
-    activeTransport = null;
-    // The last TransportListener will call notifyStopped().
+    if (activeTransport != null) {
+      activeTransport.stopAsync();
+      activeTransport = null;
+      // The last TransportListener will call notifyStopped().
+    } else {
+      notifyStopped();
+    }
   }
 
   @Override
@@ -115,7 +119,7 @@
 
   private class CallImpl<ReqT, RespT> extends Call<ReqT, RespT> {
     private final MethodDescriptor<ReqT, RespT> method;
-    private final SerializingExecutor executor;
+    private final SerializingExecutor callExecutor;
     // TODO(user): Consider moving flow control notification/management to Call itself.
     private final Collection<SettableFuture<Void>> inProcessFutures
         = Collections.synchronizedSet(new HashSet<SettableFuture<Void>>());
@@ -123,7 +127,7 @@
 
     public CallImpl(MethodDescriptor<ReqT, RespT> method, SerializingExecutor executor) {
       this.method = method;
-      this.executor = executor;
+      this.callExecutor = executor;
     }
 
     @Override
@@ -134,8 +138,11 @@
 
     @Override
     public void cancel() {
-      Preconditions.checkState(stream != null, "Not started");
-      stream.cancel();
+      // Cancel is called in exception handling cases, so it may be the case that the
+      // stream was never successfully created.
+      if (stream != null) {
+        stream.cancel();
+      }
     }
 
     @Override
@@ -200,7 +207,7 @@
       private ListenableFuture<Void> dispatchCallable(
           final Callable<ListenableFuture<Void>> callable) {
         final SettableFuture<Void> ours = SettableFuture.create();
-        executor.execute(new Runnable() {
+        callExecutor.execute(new Runnable() {
           @Override
           public void run() {
             try {
@@ -252,7 +259,7 @@
           future.cancel(false);
         }
         inProcessFutures.clear();
-        executor.execute(new Runnable() {
+        callExecutor.execute(new Runnable() {
           @Override
           public void run() {
             observer.onClose(status);

stub/src/main/java/com/google/net/stubby/stub/Calls.java

diff --git a/stub/src/main/java/com/google/net/stubby/stub/Calls.java b/stub/src/main/java/com/google/net/stubby/stub/Calls.java
index c0a125b..bd6849e 100644
--- a/stub/src/main/java/com/google/net/stubby/stub/Calls.java
+++ b/stub/src/main/java/com/google/net/stubby/stub/Calls.java
@@ -18,7 +18,6 @@
 import java.util.concurrent.Future;
 import java.util.concurrent.LinkedBlockingQueue;
 
-
 /**
  * Utility functions for processing different call idioms. We have one-to-one correspondence
  * between utilities in this class and the potential signatures in a generated stub class so