commit 0ec6973b743e8e1f463bdcc8691e1869097c92f0
author Yash Tibrewal <yashkt@google.com> Mon Aug 13 10:48:41 2018 -0700
committer Yash Tibrewal <yashkt@google.com> Mon Aug 13 10:48:41 2018 -0700
tree bb708a0be46086f94c8209118bbf1bd61580843e
parent 0d757a659fd24ecfed801614565d2408e2e302fc

Revert semantic changes for fd_notify_on_*

src/core/lib/iomgr/buffer_list.h

diff --git a/src/core/lib/iomgr/buffer_list.h b/src/core/lib/iomgr/buffer_list.h
index 0f66dcc..cbbf50a 100644
--- a/src/core/lib/iomgr/buffer_list.h
+++ b/src/core/lib/iomgr/buffer_list.h
@@ -31,6 +31,8 @@
 
 namespace grpc_core {
 struct Timestamps {
+  /* TODO(yashykt): This would also need to store OPTSTAT once support is added
+   */
   gpr_timespec sendmsg_time;
   gpr_timespec scheduled_time;
   gpr_timespec sent_time;

src/core/lib/iomgr/ev_epoll1_linux.cc

diff --git a/src/core/lib/iomgr/ev_epoll1_linux.cc b/src/core/lib/iomgr/ev_epoll1_linux.cc
index e8ee5c4..86a0243 100644
--- a/src/core/lib/iomgr/ev_epoll1_linux.cc
+++ b/src/core/lib/iomgr/ev_epoll1_linux.cc
@@ -386,27 +386,15 @@
 }
 
 static void fd_notify_on_read(grpc_fd* fd, grpc_closure* closure) {
-  if (closure != nullptr) {
-    fd->read_closure->NotifyOn(closure);
-  } else {
-    fd->read_closure->SetReady();
-  }
+  fd->read_closure->NotifyOn(closure);
 }
 
 static void fd_notify_on_write(grpc_fd* fd, grpc_closure* closure) {
-  if (closure != nullptr) {
-    fd->write_closure->NotifyOn(closure);
-  } else {
-    fd->write_closure->SetReady();
-  }
+  fd->write_closure->NotifyOn(closure);
 }
 
 static void fd_notify_on_error(grpc_fd* fd, grpc_closure* closure) {
-  if (closure != nullptr) {
-    fd->error_closure->NotifyOn(closure);
-  } else {
-    fd->error_closure->SetReady();
-  }
+  fd->error_closure->NotifyOn(closure);
 }
 
 static void fd_become_readable(grpc_fd* fd, grpc_pollset* notifier) {

src/core/lib/iomgr/ev_epollex_linux.cc

diff --git a/src/core/lib/iomgr/ev_epollex_linux.cc b/src/core/lib/iomgr/ev_epollex_linux.cc
index b17aa90..7b36841 100644
--- a/src/core/lib/iomgr/ev_epollex_linux.cc
+++ b/src/core/lib/iomgr/ev_epollex_linux.cc
@@ -539,27 +539,15 @@
 }
 
 static void fd_notify_on_read(grpc_fd* fd, grpc_closure* closure) {
-  if (closure != nullptr) {
-    fd->read_closure->NotifyOn(closure);
-  } else {
-    fd->read_closure->SetReady();
-  }
+  fd->read_closure->NotifyOn(closure);
 }
 
 static void fd_notify_on_write(grpc_fd* fd, grpc_closure* closure) {
-  if (closure != nullptr) {
-    fd->write_closure->NotifyOn(closure);
-  } else {
-    fd->write_closure->SetReady();
-  }
+  fd->write_closure->NotifyOn(closure);
 }
 
 static void fd_notify_on_error(grpc_fd* fd, grpc_closure* closure) {
-  if (closure != nullptr) {
-    fd->error_closure->NotifyOn(closure);
-  } else {
-    fd->error_closure->SetReady();
-  }
+  fd->error_closure->NotifyOn(closure);
 }
 
 /*******************************************************************************

src/core/lib/iomgr/ev_epollsig_linux.cc

diff --git a/src/core/lib/iomgr/ev_epollsig_linux.cc b/src/core/lib/iomgr/ev_epollsig_linux.cc
index 7bdfa22..2189801 100644
--- a/src/core/lib/iomgr/ev_epollsig_linux.cc
+++ b/src/core/lib/iomgr/ev_epollsig_linux.cc
@@ -947,27 +947,15 @@
 }
 
 static void fd_notify_on_read(grpc_fd* fd, grpc_closure* closure) {
-  if (closure != nullptr) {
-    fd->read_closure->NotifyOn(closure);
-  } else {
-    fd->read_closure->SetReady();
-  }
+  fd->read_closure->NotifyOn(closure);
 }
 
 static void fd_notify_on_write(grpc_fd* fd, grpc_closure* closure) {
-  if (closure != nullptr) {
-    fd->write_closure->NotifyOn(closure);
-  } else {
-    fd->write_closure->SetReady();
-  }
+  fd->write_closure->NotifyOn(closure);
 }
 
 static void fd_notify_on_error(grpc_fd* fd, grpc_closure* closure) {
-  if (closure != nullptr) {
-    fd->error_closure->NotifyOn(closure);
-  } else {
-    fd->error_closure->SetReady();
-  }
+  fd->error_closure->NotifyOn(closure);
 }
 
 /*******************************************************************************

src/core/lib/iomgr/internal_errqueue.cc

diff --git a/src/core/lib/iomgr/internal_errqueue.cc b/src/core/lib/iomgr/internal_errqueue.cc
index 3f3da66..8823737 100644
--- a/src/core/lib/iomgr/internal_errqueue.cc
+++ b/src/core/lib/iomgr/internal_errqueue.cc
@@ -30,7 +30,7 @@
 
 bool kernel_supports_errqueue() {
 #ifdef LINUX_VERSION_CODE
-#if LINUX_VERSION_CODE <= KERNEL_VERSION(4, 0, 0)
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 0, 0)
   return true;
 #endif /* LINUX_VERSION_CODE <= KERNEL_VERSION(4, 0, 0) */
 #endif /* LINUX_VERSION_CODE */