Code review changes.
diff --git a/src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc b/src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc
index d861746..025ee29 100644
--- a/src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc
+++ b/src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc
@@ -44,9 +44,9 @@
grpc_lb_policy base;
/** all our subchannels */
grpc_lb_subchannel_list *subchannel_list;
- /** Latest pending subchannel list. */
+ /** latest pending subchannel list */
grpc_lb_subchannel_list *latest_pending_subchannel_list;
- /** Selected subchannel in \a subchannel_list. */
+ /** selected subchannel in \a subchannel_list */
grpc_lb_subchannel_data *selected;
/** have we started picking? */
bool started_picking;
@@ -351,7 +351,7 @@
}
// If we've started picking, start trying to connect to the first
// subchannel in the new list.
- if (p->started_picking && subchannel_list->num_subchannels > 0) {
+ if (p->started_picking) {
grpc_lb_subchannel_list_ref_for_connectivity_watch(
subchannel_list, "connectivity_watch+update");
grpc_lb_subchannel_data_start_connectivity_watch(
@@ -396,7 +396,7 @@
// either the current or latest pending subchannel lists.
GPR_ASSERT(sd->subchannel_list == p->subchannel_list ||
sd->subchannel_list == p->latest_pending_subchannel_list);
- // Update state counters.
+ // Update state.
sd->curr_connectivity_state = sd->pending_connectivity_state_unsafe;
// Handle updates for the currently selected subchannel.
if (p->selected == sd) {