commit bfb4e06e3c209907e9e4e15f915b4a3cd318f42c
author Yuchen Zeng <zyc@google.com> Wed Aug 23 23:34:32 2017 -0700
committer Yuchen Zeng <zyc@google.com> Wed Aug 23 23:47:15 2017 -0700
tree 1dbabfc323df74644f348dc25bdbed17b9ad7674
parent 4d88416c1126c0596f2964a4bcd482cd758d2793

Check connectivity intermittently

src/cpp/client/channel_cc.cc

diff --git a/src/cpp/client/channel_cc.cc b/src/cpp/client/channel_cc.cc
index f3e7470..ffe88df 100644
--- a/src/cpp/client/channel_cc.cc
+++ b/src/cpp/client/channel_cc.cc
@@ -35,12 +35,15 @@
 #include <grpc/slice.h>
 #include <grpc/support/alloc.h>
 #include <grpc/support/log.h>
+#include <grpc/support/sync.h>
 #include <grpc/support/thd.h>
+#include <grpc/support/time.h>
 #include "src/core/lib/profiling/timers.h"
 
 namespace grpc {
 
 namespace {
+int kConnectivityCheckIntervalMsec = 100;
 void WatchStateChange(void* arg);
 }  // namespace
 
@@ -59,7 +62,13 @@
     while (state != GRPC_CHANNEL_SHUTDOWN) {
       channel_->NotifyOnStateChange(state, gpr_inf_future(GPR_CLOCK_REALTIME),
                                     &cq_, NULL);
-      cq_.Next(&tag, &ok);
+      while (cq_.AsyncNext(&tag, &ok, gpr_inf_past(GPR_CLOCK_REALTIME)) ==
+             CompletionQueue::TIMEOUT) {
+        gpr_sleep_until(
+            gpr_time_add(gpr_now(GPR_CLOCK_REALTIME),
+                         gpr_time_from_micros(kConnectivityCheckIntervalMsec,
+                                              GPR_TIMESPAN)));
+      }
       state = channel_->GetState(false);
     }
   }
@@ -84,10 +93,10 @@
   void Destroy() {
     if (thd_id_ != 0) {
       gpr_thd_join(thd_id_);
-      bool ok = false;
-      void* tag = NULL;
-      shutdown_cq_.Next(&tag, &ok);
     }
+    bool ok = false;
+    void* tag = NULL;
+    shutdown_cq_.Next(&tag, &ok);
   }
 
  private:

test/cpp/end2end/end2end_test.cc

diff --git a/test/cpp/end2end/end2end_test.cc b/test/cpp/end2end/end2end_test.cc
index b145c50..f316dd0 100644
--- a/test/cpp/end2end/end2end_test.cc
+++ b/test/cpp/end2end/end2end_test.cc
@@ -704,6 +704,10 @@
   ResetStub();
   SendRpc(stub_.get(), 1, false);
   RestartServer(std::shared_ptr<AuthMetadataProcessor>());
+  // It needs more than 2 * kConnectivityCheckIntervalMsec time to reconnect
+  // the channel
+  gpr_sleep_until(gpr_time_add(gpr_now(GPR_CLOCK_REALTIME),
+                               gpr_time_from_millis(210, GPR_TIMESPAN)));
   SendRpc(stub_.get(), 1, false);
 }