commit c637cc922fa5813bf9da5840b3746924dcc021cc
author Nicolas Noble <nicolasnoble@users.noreply.github.com> Tue Mar 24 22:32:21 2015 -0700
committer Nicolas Noble <nicolasnoble@users.noreply.github.com> Tue Mar 24 22:32:21 2015 -0700
tree f12ff189928106f7b9f1baf123d7a9024475e360
parent dad14be4eb359326a11253196f035c8f36fbdc86
parent 2f223460b0d65c3069165f6c5249f98cb9fda56a

Merge pull request #1128 from jboeuf/static_analysis_fixes

Fixing errors found by clang static analysis.

src/core/tsi/ssl_transport_security.c

diff --git a/src/core/tsi/ssl_transport_security.c b/src/core/tsi/ssl_transport_security.c
index 33645ca..018ddc4 100644
--- a/src/core/tsi/ssl_transport_security.c
+++ b/src/core/tsi/ssl_transport_security.c
@@ -567,7 +567,8 @@
     EC_KEY* ecdh = EC_KEY_new_by_curve_name(NID_X9_62_prime256v1);
     if (!SSL_CTX_set_tmp_ecdh(context, ecdh)) {
       gpr_log(GPR_ERROR, "Could not set ephemeral ECDH key.");
-      result = TSI_INTERNAL_ERROR;
+      EC_KEY_free(ecdh);
+      return TSI_INTERNAL_ERROR;
     }
     SSL_CTX_set_options(context, SSL_OP_SINGLE_ECDH_USE);
     EC_KEY_free(ecdh);
@@ -604,6 +605,7 @@
   unsigned char* current;
   *protocol_name_list = NULL;
   *protocol_name_list_length = 0;
+  if (num_alpn_protocols == 0) return TSI_INVALID_ARGUMENT;
   for (i = 0; i < num_alpn_protocols; i++) {
     if (alpn_protocols_lengths[i] == 0) {
       gpr_log(GPR_ERROR, "Invalid 0-length protocol name.");