commit cb4b2b5d7dc1699a709ffce8b96a3920bd39f8eb
author murgatroid99 <mlumish@google.com> Thu Oct 27 11:30:50 2016 -0700
committer murgatroid99 <mlumish@google.com> Thu Oct 27 11:30:50 2016 -0700
tree db1c7a983955fae28de3301c34d9011fbaa4ee76
parent 5a38f2e490b876a6c0486aab6def201665c5c2bb

libuv changes don't work with Electron

binding.gyp

diff --git a/binding.gyp b/binding.gyp
index 92360a4..141104a 100644
--- a/binding.gyp
+++ b/binding.gyp
@@ -46,10 +46,14 @@
       'include'
     ],
     'defines': [
-      'GPR_BACKWARDS_COMPATIBILITY_MODE',
-      'GRPC_UV'
+      'GPR_BACKWARDS_COMPATIBILITY_MODE'
     ],
     'conditions': [
+      ['runtime=="node"', {
+        'defines': [
+          'GRPC_UV'
+        ]
+      }],
       # This is the condition for using boringssl
       ['OS=="win" or runtime=="electron"', {
         "include_dirs": [

templates/binding.gyp.template

diff --git a/templates/binding.gyp.template b/templates/binding.gyp.template
index 2fc840d..9b9e4e1 100644
--- a/templates/binding.gyp.template
+++ b/templates/binding.gyp.template
@@ -48,10 +48,14 @@
         'include'
       ],
       'defines': [
-        'GPR_BACKWARDS_COMPATIBILITY_MODE',
-        'GRPC_UV'
+        'GPR_BACKWARDS_COMPATIBILITY_MODE'
       ],
       'conditions': [
+        ['runtime=="node"', {
+          'defines': [
+            'GRPC_UV'
+          ]
+        }],
         # This is the condition for using boringssl
         ['OS=="win" or runtime=="electron"', {
           "include_dirs": [