commit d4792e9d8dc9cdfe0514305eb4e14a6ec4d322da
author Muxi Yan <mxyan@google.com> Tue Jun 13 10:00:53 2017 -0700
committer Muxi Yan <mxyan@google.com> Tue Jun 13 10:00:53 2017 -0700
tree 84c803bc90c76ec32eb39b47cf9b811f10253266
parent d7d6a2e12bb4ae0057f45b964555018245865cb2

Polish GRXBufferedPipe

src/objective-c/RxLibrary/GRXBufferedPipe.m

diff --git a/src/objective-c/RxLibrary/GRXBufferedPipe.m b/src/objective-c/RxLibrary/GRXBufferedPipe.m
index 3bb9e2a..fbdaf9d 100644
--- a/src/objective-c/RxLibrary/GRXBufferedPipe.m
+++ b/src/objective-c/RxLibrary/GRXBufferedPipe.m
@@ -41,7 +41,7 @@
 @implementation GRXBufferedPipe {
   NSError *_errorOrNil;
   dispatch_queue_t _writeQueue;
-  dispatch_once_t _finishQueue;
+  dispatch_once_t _finishAction;
 }
 
 @synthesize state = _state;
@@ -54,7 +54,6 @@
   if (self = [super init]) {
     _state = GRXWriterStateNotStarted;
     _writeQueue = dispatch_queue_create(NULL, DISPATCH_QUEUE_SERIAL);
-    self.inputIsFinished = NO;
     dispatch_suspend(_writeQueue);
   }
   return self;
@@ -74,10 +73,7 @@
   }
   __weak GRXBufferedPipe *weakSelf = self;
   dispatch_async(_writeQueue, ^(void) {
-    GRXBufferedPipe *strongSelf = weakSelf;
-    if (strongSelf && strongSelf.writeable) {
-      [strongSelf.writeable writeValue:value];
-    }
+    [weakSelf.writeable writeValue:value];
   });
 }
 
@@ -86,23 +82,18 @@
     return;
   }
   self.inputIsFinished = YES;
-  if (errorOrNil) {
-    // No need to write pending values.
-    dispatch_once(&_finishQueue, ^{
+  dispatch_once(&_finishAction, ^{
+    if (errorOrNil) {
+      // No need to write pending values.
       _errorOrNil = errorOrNil;
       [self finishWithError:_errorOrNil];
-    });
-  } else {
-    dispatch_once(&_finishQueue, ^{
+    } else {
       __weak GRXBufferedPipe *weakSelf = self;
       dispatch_async(_writeQueue, ^{
-        GRXBufferedPipe *strongSelf = weakSelf;
-        if (strongSelf) {
-          [strongSelf finishWithError:nil];
-        }
+        [weakSelf finishWithError:nil];
       });
-    });
-  }
+    }
+  });
 }
 
 #pragma mark GRXWriter implementation