commit f77a4ad9f7d0e84ee418165c4c9a604ea89780f9
author Stanley Cheung <stanleycheung@google.com> Tue Feb 16 09:45:51 2016 -0800
committer Stanley Cheung <stanleycheung@google.com> Tue Feb 16 09:45:51 2016 -0800
tree 85ca55f3cfd453297a79355c094bf3d92b617555
parent b91f0f27c5cfd92b5f9358fe54f556fec6005d22

channel constructor the array is required

src/php/ext/grpc/channel.c

diff --git a/src/php/ext/grpc/channel.c b/src/php/ext/grpc/channel.c
index 97e8cc1..2c64b91 100644
--- a/src/php/ext/grpc/channel.c
+++ b/src/php/ext/grpc/channel.c
@@ -141,8 +141,8 @@
   HashTable *array_hash;
   zval **creds_obj = NULL;
   wrapped_grpc_channel_credentials *creds = NULL;
-  /* "s|a" == 1 string, 1 optional array */
-  if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|a", &target,
+  /* "sa" == 1 string, 1 array */
+  if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sa", &target,
                             &target_length, &args_array) == FAILURE) {
     zend_throw_exception(spl_ce_InvalidArgumentException,
                          "Channel expects a string and an array", 1 TSRMLS_CC);