commit 8d62075e136d207b8fb8ea98d3fd7ec051bdee3c
author limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> Tue Mar 31 22:37:26 2009 +0000
committer limpbizkit <limpbizkit@d779f126-a31b-0410-b53b-1d3aecad763e> Tue Mar 31 22:37:26 2009 +0000
tree 197626a48751f4e38b5d8ed757953ee20608eb34
parent d31578ae6b4154c6480d5b8703bb0ecdfecbbff9

Support deferred lookups of providers and members injectors from the Encounter. 

The behaviour is slightly different depending on when the InjectableTypeListener.hear() method is invoked...

A) If it's invoked before the Injector is created, then getProvider() always returns immediately. The provider may not be used until the injector has been created.

B) If it's invoked after the Injector has been created, then getProvider() builds the provider immediately. This includes the work to build the binding (recursively) and this method may fail with a ConfigurationException.

It would be possible to change B) to behave more like A), but the utility of doing so is quite limited. One case that still needs test coverage is when the listener calls getProvider(B.class) while hearing about B. For now, this will probably fail. That's probably okay for now.

git-svn-id: https://google-guice.googlecode.com/svn/trunk@922 d779f126-a31b-0410-b53b-1d3aecad763e

src/com/google/inject/EncounterImpl.java

diff --git a/src/com/google/inject/EncounterImpl.java b/src/com/google/inject/EncounterImpl.java
index ac55d9b..09dc8f6 100644
--- a/src/com/google/inject/EncounterImpl.java
+++ b/src/com/google/inject/EncounterImpl.java
@@ -16,25 +16,34 @@
 
 package com.google.inject;
 
-import com.google.inject.spi.InjectableType;
-import com.google.inject.spi.InjectionListener;
-import com.google.inject.spi.Message;
+import com.google.inject.internal.Errors;
 import com.google.inject.internal.ImmutableList;
 import com.google.inject.internal.Lists;
 import com.google.inject.matcher.Matcher;
 import com.google.inject.matcher.Matchers;
-import java.util.List;
+import com.google.inject.spi.InjectableType;
+import com.google.inject.spi.InjectionListener;
+import com.google.inject.spi.Message;
 import java.lang.reflect.Method;
+import java.util.List;
 import org.aopalliance.intercept.MethodInterceptor;
 
 /**
  * @author jessewilson@google.com (Jesse Wilson)
  */
-class EncounterImpl<T> implements InjectableType.Encounter<T> {
+public final class EncounterImpl<T> implements InjectableType.Encounter<T> {
+
+  private final Errors errors;
+  private final Lookups lookups;
   private List<InjectionListener<? super T>> injectionListeners; // lazy
   private List<MethodAspect> aspects; // lazy
 
-  boolean hasAddedAspects() {
+  public EncounterImpl(Errors errors, Lookups lookups) {
+    this.errors = errors;
+    this.lookups = lookups;
+  }
+
+  public boolean hasAddedAspects() {
     return aspects != null;
   }
 
@@ -46,7 +55,7 @@
     return aspects;
   }
 
-  ImmutableList<InjectionListener<? super T>> getInjectionListeners() {
+  public ImmutableList<InjectionListener<? super T>> getInjectionListeners() {
     return injectionListeners == null
         ? ImmutableList.<InjectionListener<? super T>>of()
         : ImmutableList.copyOf(injectionListeners);
@@ -58,7 +67,7 @@
       injectionListeners = Lists.newArrayList();
     }
 
-    injectionListeners.add((InjectionListener<T>) injectionListener);
+    injectionListeners.add(injectionListener);
   }
 
   public void bindInterceptor(Matcher<? super Method> methodMatcher,
@@ -72,30 +81,30 @@
   }
 
   public void addError(String message, Object... arguments) {
-    throw new UnsupportedOperationException("TODO");
+    errors.addMessage(message, arguments);
   }
 
   public void addError(Throwable t) {
-    throw new UnsupportedOperationException("TODO");
+    errors.errorInUserCode(t, "An exception was caught and reported. Message: %s", t.getMessage());
   }
 
   public void addError(Message message) {
-    throw new UnsupportedOperationException("TODO");
+    errors.addMessage(message);
   }
 
   public <T> Provider<T> getProvider(Key<T> key) {
-    throw new UnsupportedOperationException("TODO");
+    return lookups.getProvider(key);
   }
 
   public <T> Provider<T> getProvider(Class<T> type) {
-    throw new UnsupportedOperationException("TODO");
+    return getProvider(Key.get(type));
   }
 
   public <T> MembersInjector<T> getMembersInjector(TypeLiteral<T> typeLiteral) {
-    throw new UnsupportedOperationException("TODO");
+    return lookups.getMembersInjector(typeLiteral);
   }
 
   public <T> MembersInjector<T> getMembersInjector(Class<T> type) {
-    throw new UnsupportedOperationException("TODO");
+    return getMembersInjector(TypeLiteral.get(type));
   }
-}
+}
\ No newline at end of file