Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / external / guice / 47151c2d678d391e929166687b75139fa57ad70e
  1. 47151c2 Private modules first draft. I'm not in love with the name "PrivateModules" or the "expose" method. But I think this is a reasonable first implementation of parent/child modules. by limpbizkit · 16 years ago
  2. 1db2393 Initializer cleanup. Now each InjectableReference takes care of itself, which should make the code a bit simpler to use. by limpbizkit · 16 years ago
  3. 2a60707 Rewrite of parent injectors. by limpbizkit · 16 years ago
  4. 5fb9d92 Rewrite of parent injectors. by limpbizkit · 16 years ago
  5. cb93c79 jmourits' changes to assistedinject so toString() etc. on the proxies work. Previously they were blowing up with NPEs in some situations. by limpbizkit · 16 years ago
  6. 5127365 Creating a copy of the bindings-to-inject before looping over them. There was a problem where JIT-singletons were being added while we were looping, and this was causing ConcurrentModificationExceptions. by limpbizkit · 16 years ago
  7. f67bc73 upgrade to jarjar 1.0rc8 by chris.nokleberg · 16 years ago
  8. 8c4c71c Fixing a serialization problem as reported by Ben Yu: TypeLiteral is serializable, which causes warnings in anonymous inner type literals. by limpbizkit · 16 years ago
  9. deb0807 Follow up to r616 - my IDE didn't include deleted files with my commit, now fixed. by limpbizkit · 16 years ago
  10. d7366b4 Added updated Javadocs. by limpbizkit · 16 years ago
  11. b3a8f0b Last of the planned major changes to the SPI. Aside from Javadoc I consider the SPI to be complete for v2. (with a possible addition of a ProviderMethodBinding feature also) by limpbizkit · 16 years ago
  12. a6e0e78 Moving error sources so they're now reported in the same place for configuration errors and runtime errors. This means that instead of seeing this: by limpbizkit · 16 years ago
  13. 18cb191 Splitting up finding member injectors from finding injection points. This is intended to make it so the new SPI exposes injection points on Module elements without actually having to resolve 'em. by limpbizkit · 16 years ago
  14. 1490c5b Fixing a bug where exceptions thrown by @ProvidedBy providers weren't being wrapped in a ProvisionException. by limpbizkit · 16 years ago
  15. 45e8353 Removed old Javadocs. by limpbizkit · 16 years ago
  16. a98bc7a Cleaning up some internals for the SPI. by limpbizkit · 16 years ago
  17. ff29552 A new mechanical test suite with 114 tests, trying out various combinations of: by limpbizkit · 16 years ago
  18. a886599 Removing oldversion SPI and commands. These are both replaced by Elements. by limpbizkit · 16 years ago
  19. 97a51ff Neil Dunn's scope overrides patch by limpbizkit · 16 years ago
  20. a9a8edc Adding a default BindingScopingVisitor to make use easier. by limpbizkit · 16 years ago
  21. 676492a Including a cause stacktrace in CreationException. Several people were complaining about the missing stacktraces, because their logging was configured to not display anything! by limpbizkit · 16 years ago
  22. 85fa885 Tests for some package visibility issues. This comes from problems with our classloading hooks, which I've disabled until the problem is resolved. by limpbizkit · 16 years ago
  23. 76a2b9a Changing InjectionPoint.member to be swapped for a serializable instance lazily rather than eagerly. This is what Bob had originally requested, and only now do I learn my lesson (from Sam's memory leak). Bob=smart. by limpbizkit · 16 years ago
  24. 4ce9cfa Changing the loading of StackTraceElements to be as lazy as possible. Sam Berlin was running into memory issues when these were loaded eagerly. by limpbizkit · 16 years ago
  25. 457d478 Robbie Vanbrabant's idea - Modules.combine should take collections by limpbizkit · 16 years ago
  26. 2d88730 Sam Berlin's idea- Modules.combine by limpbizkit · 16 years ago
  27. 896cdae We wanted to make extra sure that annotated injection points don't get JIT bindings by limpbizkit · 16 years ago
  28. cb32cbc We now support wildcards in bindings! The wildcards can only be used as type parameters for other types, not for top-level bindings on their own. by limpbizkit · 16 years ago
  29. 27fc50d Fixing a critical bug! The following code was broken (although we did have a TODO dating back to sometime last year) by limpbizkit · 16 years ago
  30. d6becac Full test coverage for errors... by limpbizkit · 16 years ago
  31. 5789ef4 A few more errors tests. There's only about five left till we have full test coverage for our errors code. by limpbizkit · 16 years ago
  32. 918dff8 Moved Errors (an implementation detail class) out of InjectionPoint (a public API). by limpbizkit · 16 years ago
  33. 8eef998 Robbie V implemented a fix so that Stage.TOOL doesn't return an Injector whose methods won't work properly. by limpbizkit · 16 years ago
  34. 89046e7 ProviderMethods are now automatically installed from their module. That means that the following Injector will have "A" bound to the String: by limpbizkit · 16 years ago
  35. 7e1e4f7 New mini EDSL: by limpbizkit · 16 years ago
  36. 53c5f76 ProviderMethods now works with generic types. It won't work perfectly due to erasure (the provider objects can't have unresolved type parameters) but it should make most generic stuff work as expected. by limpbizkit · 16 years ago
  37. 179c7ce Added updated Javadocs. by limpbizkit · 16 years ago
  38. 15c875d Removed old Javadocs. by limpbizkit · 16 years ago
  39. 7640744 LAST move of the visitors. I moved BindTargetVisitor to BindingTargetVisitor and Element.Visitor to ElementVisitor by limpbizkit · 16 years ago
  40. afa4b5d LAST move of the visitors. I moved BindTargetVisitor to BindingTargetVisitor and Element.Visitor to ElementVisitor by limpbizkit · 16 years ago
  41. 8cbb162 Moving visitors out of Binding so they don't show up in the main com.google.inject package core Javadocs by limpbizkit · 16 years ago
  42. c6c0208 Moving visitors out of Binding so they don't show up in the main com.google.inject package core Javadocs by limpbizkit · 16 years ago
  43. eb1d719 Added updated Javadocs. by limpbizkit · 16 years ago
  44. 998d0ea Removed old Javadocs. by limpbizkit · 16 years ago
  45. 318e9b4 New names for the core elements: by limpbizkit · 16 years ago
  46. 00ca9f7 New names for the core elements: by limpbizkit · 16 years ago
  47. 465bd4e Added updated Javadocs. by limpbizkit · 16 years ago
  48. a762898 Removed old Javadocs. by limpbizkit · 16 years ago
  49. 83ae2e0 Added updated Javadocs. by limpbizkit · 16 years ago
  50. 7b0813a Removed old Javadocs. by limpbizkit · 16 years ago
  51. 3af8411 Javadoc for Binding. by limpbizkit · 16 years ago
  52. d1fe130 Combining Binding and BindConstant elements in the SPI. by limpbizkit · 16 years ago
  53. aa72625 Slight naming cleanup for Binding API, and a bit of Javadoc. More to follow . . .. This commit fixes a blunder with the previous one. by limpbizkit · 16 years ago
  54. 575976c Slight naming cleanup for Binding API, and a bit of Javadoc. More to follow . . . by limpbizkit · 16 years ago
  55. 0614667 Deprecating the old commands and old SPI in favour of the new unified API. It uses one Element class for both Module Elements and Injector Elements. by limpbizkit · 16 years ago
  56. 477f9f9 Grand unification of commands and SPI: by limpbizkit · 16 years ago
  57. 4a89ad3 Added requireBinding() convenience method to AbstractModule. by limpbizkit · 16 years ago
  58. 9a3c189 Fixed an error pointed out by Brian Harris. Yikes. by limpbizkit · 16 years ago
  59. 03664e0 New TypeResolver. This will help to make ProviderMethods smarter. by limpbizkit · 16 years ago
  60. 96d2164 Added tests for a few cases where we could detect a misplaced annotation (but we don't currently) by limpbizkit · 16 years ago
  61. f3429ae Removing a redundant synchronized statement, on the advice of Stuart McCulls who was studying this code (in order to close issue 89). by limpbizkit · 16 years ago
  62. fe2c25e Adding ElementType.METHOD to play nice with ProviderMethods by limpbizkit · 16 years ago
  63. 7bf3e3c Fix for issue 69: by limpbizkit · 16 years ago
  64. 7f0bc5a Removing the check for issue 64. We already blow up when trying to make Class or Constructor's members accessible, via the new private-constructor check. by limpbizkit · 16 years ago
  65. e731d19 Tweaking error handling. by limpbizkit · 16 years ago
  66. e8fd68a Applying proper PECS to commands. by limpbizkit · 16 years ago
  67. 7a2341b A fix to an unfortunate, rare concurrency problem. During injector creation, it's possbile that an @Inject method will start a thread, and attempt to access injected members while the injector is still being created. The IdentityHashSet of members to inject is currently accessed, and everything blows up. Terrible! by limpbizkit · 16 years ago
  68. 31179c0 Contribution from Jacob Hite to make it so installing modules is exception-tolerant. by limpbizkit · 16 years ago
  69. 2083772 Restoring Guice's ability to use private no-arg constructors in private classes. This is unfortunate, but it looks like this is going to be way too hard to fix to be worthwhile. by limpbizkit · 16 years ago
  70. 58f3bb8 Axing EarlyRequestProvider and FutureInjector. Now that commands are more tightly coupled with Guice core, we don't need them. by limpbizkit · 16 years ago
  71. 73475a4 A new test that shows the deficiencies of FutureInjector. Now that commands are better integrated, we might be able to solve this more transparently... by limpbizkit · 16 years ago
  72. 46db36a Small test tweaks. by limpbizkit · 16 years ago
  73. 47062f1 More of mcculls fixes for choosing which classloader to use for generated classes. I believe this solves the package-private problem and the memory leak problem. Nice work Stuart! by limpbizkit · 16 years ago
  74. 9da2707 Test for a package method in a public class by limpbizkit · 16 years ago
  75. eb06177 Stuart's fixes for the BytecodeGenTest. by limpbizkit · 16 years ago
  76. d37c58b Disallowing private, no arg constructors that don't have @Inject on 'em. This is issue #120. The workaround is to increase the visibility of the constructor (package private still works) or to add @Inject on the constructed type. by limpbizkit · 16 years ago
  77. 0b25412 Moving BytecodeGenTest to a non-Guice package. We should consider moving integration-style tests to this package, since a lot of our tests might only be passing due to visibility of test objects. by limpbizkit · 16 years ago
  78. d8a06a4 Moving BytecodeGenTest to a non-Guice package. We should consider moving integration-style tests to this package, since a lot of our tests might only be passing due to visibility of test objects. by limpbizkit · 16 years ago
  79. 869a3c0 Stuart McCulloch contributed a custom classloader that fixes the memory leak and supports OSGi-style classloaders (plus any other form of non-delegation). by limpbizkit · 16 years ago
  80. 3b4bd86 Added a testcase that shows issue 125 is fixed. by limpbizkit · 16 years ago
  81. 2e1c91b Test for issue 152, to confirm how untargetted bindings work. by limpbizkit · 16 years ago
  82. b82da41 Binder.requestInjection, as implemented by Mike Ward. by limpbizkit · 16 years ago
  83. be72185 I don't think we have the full generics supported for ProviderMethods yet. by limpbizkit · 16 years ago
  84. 2c2c610 More cleanup of Errors -- including sources as a factory method rather than push/pop methods (that require try/finally clauses) by limpbizkit · 16 years ago
  85. 32beee6 Mike Ward's inSubpackage feature for issue 75. by limpbizkit · 16 years ago
  86. 568fa2a Axing SourceProviders and SourceProvider in favour of Binder.withSource and Binder.skipSources by limpbizkit · 16 years ago
  87. 6663d02 Axing SourceProviders and SourceProvider in favour of Binder.withSource and Binder.skipSources by limpbizkit · 16 years ago
  88. 9532e62 Eliminated static from SourceProviders. The new mechanism to specify the source of a binding is like this: by limpbizkit · 16 years ago
  89. 7d9991e Binder.withSource() added. I'd still like to start using it within the exceptions, and then cleanup their static configuration of SourceProviders. by limpbizkit · 16 years ago
  90. 185d2a2 Added some new error messages: by limpbizkit · 16 years ago
  91. 76f1457 Fixing some places where we were using SourceProviders when we should have been using other sources by limpbizkit · 16 years ago
  92. 163c48a Cleanup after the big errors refactoring. by limpbizkit · 16 years ago
  93. c5c488e TypeConversion errors cleanup by limpbizkit · 16 years ago
  94. 2a45dd5 Massive refactoring to exception handling. I'm trying to simplify things, but they are currently a little bit more complicated. I'll do another round shortly. by limpbizkit · 16 years ago
  95. 9dc32d4 Massive refactoring to exception handling. I'm trying to simplify things, but they are currently a little bit more complicated. I'll do another round shortly. by limpbizkit · 16 years ago
  96. 564053f Massive refactoring to exception handling. I'm trying to simplify things, but they are currently a little bit more complicated. I'll do another round shortly. by limpbizkit · 16 years ago
  97. df98fcd Refactoring error messages. I changed 'em from public static final constants to methods. The benefit is that now the arguments are typechecked. More importantly, now we can gather coverage on methods. Which opens the door to figuring out which methods we have test coverage for (not very many!) by limpbizkit · 16 years ago
  98. 49f67c0 Fixing owner types so they're no longer missing in ThrowingProviderBinder. Also adding the necessary precondition checks so that we always include 'em when necessary. by limpbizkit · 16 years ago
  99. 7629584 Fixing issue 142. by limpbizkit · 16 years ago
  100. 3beaaaf Making Types public for issue 123. by limpbizkit · 16 years ago