Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / external / guice / 6c9726f5611c276cd51561c73633a5dc4288838e / core / src / com / google / inject / internal / InjectorImpl.java
  1. 6c9726f Clarify some documentation about linked bindings and child injectors. by Tavian Barnes · 9 years ago
  2. 1dd0a91 Fix https://github.com/google/guice/issues/888. by Tavian Barnes · 9 years ago
  3. 1285790 Guice: Fix for issue 295 (@ProvidedBy doesn't work with enums) by Sam Berlin · 10 years ago
  4. c00df28 Automated code cleanups by internal tool. by Sam Berlin · 10 years ago
  5. ca81e59 Submitting Stuart McCulloch's patch from https://github.com/sonatype/sisu-guice/blob/master/PATCHES/GUICE_288_decouple_thread_local.patch. by Sam Berlin · 10 years ago
  6. d57f8ec The bug in the test that became flaky has been fixed. Note that this is not a strict rollback of the rollback - I've added protection against the NPE that would happen if there's a GC between the isBlacklisted call and the getSources call. by Sam Berlin · 10 years ago
  7. c013fac *** Reason for rollback *** by Sam Berlin · 10 years ago
  8. bab9b60 Enhance WeakKeySet to auto evict keys and avoid calling toString on Keys. by Christian Edward Gruber · 10 years ago
  9. c01ba1d Convert an anonymous subclass of ThreadLocal in the implementation of InjectorImpl to a nested class, thus eliminating its implicit parent reference. This implicit parent reference creates some additional work during debugging and is unnecessary. by Christian Edward Gruber · 11 years ago
  10. 9e2d95b Clean up some formatting (includes some format artifacts from internal changes), and remove executable bit from several files which do not need them. by Christian Edward Gruber · 11 years ago
  11. e391585 Change Key so that it upgrades Annotation classes where all methods have default values into an instance of the Annotation with the defaults as values, so that: by Christian Edward Gruber · 11 years ago
  12. c756777 Add Binder.requireAtInjectOnConstructors, to force Guice to require @Inject annotations on constructors. by Sam Berlin · 12 years ago
  13. d51292d Change ProvisionListener to expose Binding instead of Key, and change bindListener to use a Matcher for Binding instead of Key. This is a backwards incompatible change, but we haven't released yet, so it's worth doing. by Sam Berlin · 12 years ago
  14. efa4e9f by guice.mirrorbot@gmail.com · 13 years ago
  15. 5221c15 by sberlin · 13 years ago
  16. b7a02b0 by sberlin · 13 years ago
  17. d9c913a switch Guice from manually repackaging Guava to depending on Guava. it's still jarjar'd right now, which is causing a ~400k increase in guice-snapshot.jar. next step is to switch to ProGuard to remove the unnecessary code and cut it back down (even further?!). this will let people build from Guice source and depend directly on Guava code without having to worry about hiding internal/util. by sberlin · 13 years ago
  18. ba75f35 issue 631 -- expose dependency hierarchy in ProvisionListener. by sberlin · 13 years ago
  19. 132a5db issue 78 - provision interception. this only lets you listen to provisions (both before & after provisioning occurs), it does not let you change the return value of the provision. by sberlin · 13 years ago
  20. d5737a6 fix @ProvidedBy circular dependencies. by sberlin · 13 years ago
  21. c94f450 assert that ProviderInternalFactory doesn't think circular dependencies exist when the providers are in different PrivateModules, temporarily remove check for @ProvidedBy due to other things that need fixing first. by sberlin · 13 years ago
  22. 425d099 fix provider circular dependency detection to use the Key it is creating, not the Key it is fulfulling, to catch errors sooner. by sberlin · 13 years ago
  23. e6ce188 fix issue 626 -- properly handle circular proxies between providers (either failing or proxying), prevents StackOverflowErrors. by sberlin · 13 years ago
  24. 9cdfe3a issue 610 - let requireExplicitBindings still allow TypeConverters to create ConvertedConstantBindings. by sberlin · 13 years ago
  25. cc17f14 significantly improve error reporting for binding a key already bound in a child injector or private module. include all sources in the error msg (since it can be in many sibling private modules or child injectors), including whether or not it as a JIT binding. by sberlin · 13 years ago
  26. 45ca7f6 issue 345 - better error message for private modules. show the source of a child binding instead of just saying its in a child injector. also give a hint that you may have wanted to expose the binding. by sberlin · 13 years ago
  27. 8b64d45 Remove InjectorBuilder in favor of methods in Binder. by sberlin · 13 years ago
  28. b2f1760 issue 436 -- add Injector.getTypeConverters, and expand ConvertedConstantBinding to expose the TypeConverter for it. patch graciously provided by Stuart, thanks! by sberlin · 14 years ago
  29. f712ffd make sure MembersInjector dependencies don't blow up on requireExplicitBindings. by sberlin · 14 years ago
  30. 6f0aee6 move @nullable to internal.util by sberlin · 14 years ago
  31. 74d714c Issue 552: (step 1) move core code to its own subdirectory by mcculls · 14 years ago[Renamed from src/com/google/inject/internal/InjectorImpl.java]
  32. b1fa81f fix requireExplicitBindings so TypeLiteral<T> can be injected. by sberlin@gmail.com · 14 years ago
  33. 9a227be Move internal utility code to separate package. by limpbizkit@gmail.com · 14 years ago
  34. 47e69ef fix issue 507, pointed out by stuart -- LinkedProviderBindingImpl did not implement HasDependencies & the injector wasn't checking for instanceof before casting. by sberlin · 14 years ago
  35. 7bcec88 fixes issue 263 -- introduces ability to "deduplicate" bindings. all BindingImpl subclasses now implement equals/hashcode properly and duplicates can be erased by throwing them into a set (preferably a LinkedHashSet to preserve the order of the elements). no new API methods. by sberlin@gmail.com · 14 years ago
  36. 7df9cf3 fixes issue 319 -- cleanup invalid leftover bindings that were added optimistically to support circular references. by sberlin · 14 years ago
  37. 6760625 Injector.getExistingBinding + tests, ultimately necessary to create a proper solution for issue 430 (and useful in its own right for SPI usage). by sberlin · 14 years ago
  38. c2a6625 cleanup related to issue 395. rather than using Guice.createInjectorBuilder, use "new InjectorBuilder()". deprecated methods in Guice that took the Stage parameter. (didn't deprecate other methods because it's still a good easy-to-use way to start getting into Guice.) added more tests to JitBindingsTest for @Provides, child injectors & private modules (private modules was broken!). rolled passing around Injector options (stage, jitDisabled) into a new InjectorOptions class to prevent those things from breaking again in the future. renamed InjectorBuilderImpl to InternalInjectorCreator because it has to be public for InjectorBuilder to use it, and didn't want to confuse auto-complete IDEs into offering InjectorBuilderImpl as an option. by sberlin · 14 years ago
  39. 888a264 fixes issue 342 - ability to disable JIT bindings (require explicit bindings). this revision creates a new public facing API of: by sberlin · 14 years ago
  40. 97c2271 issue 454 - add an annotation to mark @Injectable methods as wanting injection during Stage.TOOL. by sberlin · 14 years ago
  41. 48f3a91 Fixing typo in ProviderBindingImpl's toString() pointed out by Frank. by limpbizkit · 15 years ago
  42. 0cb8b86 Including sources in providers wrapped for scoping. This fixes a problem reported by Isaac on bug 271. by limpbizkit · 15 years ago
  43. 3ea8095 Some small optimizations. Getting sources still takes the most time of all (~40%), followed by reflective access on the methods and fields of classes. There's not much we can do here, aside from the often-suggested compile-time code-gen DI. by limpbizkit · 15 years ago
  44. 1920322 New scope checker feature. by limpbizkit · 15 years ago
  45. 91425c3 Fix for bug 403, wherein explicit bindings were kept in the JIT bindings map. by limpbizkit · 15 years ago
  46. 37387e2 Injector.getAllBindings(), feature for issue 389. by limpbizkit · 15 years ago
  47. 0afda9a Fixing a old bug wherein calling "Provider.get()" inside of an existing scope would kill the internal context and leave the injector in an inconsistent state. by limpbizkit · 15 years ago
  48. f374014 Fixin' typos in implementation detail, as pointed out by Dhanji. by limpbizkit · 15 years ago
  49. 4447564 toConstructor() core implementation. This still requires test coverage, and maybe a review of the API. by limpbizkit · 15 years ago
  50. 5ae41eb Post release refactor. I moved almost everything that was package-private in com.google.inject to the internal package. The motivation is to simplify things - the previous setup was extremely awkward because c.g.i could call into internal, but not the reverse. Similarly for the SPI package. by limpbizkit · 15 years ago[Renamed (93%) from src/com/google/inject/InjectorImpl.java]
  51. b92f540 Fix for an embarassing bug reported by Dmitry Skavish. by limpbizkit · 15 years ago
  52. 833265f patch from mcculls: by limpbizkit · 15 years ago
  53. e89c49e Some low-hanging fruit optimizations. by limpbizkit · 15 years ago
  54. eb40513 Overdue update to fix the no-AOP build of Guice to compile. by limpbizkit · 15 years ago
  55. a843a95 Simplifying listeners: by limpbizkit · 15 years ago
  56. 8d62075 Support deferred lookups of providers and members injectors from the Encounter. by limpbizkit · 15 years ago
  57. 7cef5b0 We now fire InjectionListeners on member injectors. by limpbizkit · 15 years ago
  58. 0ca7f91 It is now possible to inject a MembersInjector<T> anywhere, just like how we already support injecting a Provider<T> and a TypeLiteral<T> anywhere. by limpbizkit · 15 years ago
  59. 97eac0f Injector.getMembersInjector() and Binder.getMembersInjector() APIs both implemented and tested. by limpbizkit · 15 years ago
  60. 516e2ab Error handling. Now if InjectionListeners or InjectableTypeListeners fail, we include those errors in our pretty error report. by limpbizkit · 15 years ago
  61. 03b81a6 Early draft of InjectionListeners. by limpbizkit · 15 years ago
  62. 53664a7 Regrettably replacing jarjar'd Google Collections with minimal copies of the parts that we use. by limpbizkit · 15 years ago
  63. c3f9284 Renaming PrivateEnvironment to PrivateElements. I don't love this name 'cause I don't like plural names for classes; it reminds me of Collections, which is a utility class rather than an instantiable type. by limpbizkit · 15 years ago
  64. 8996e80 phopkins' changes to BindingTargetVisitor so it accepts wildcard types. Original patch submitted with issue 290. by limpbizkit · 15 years ago
  65. c45600e InjectionRequests now expose their injection points (or throw an exception upon request) by limpbizkit · 15 years ago
  66. 76c24b1 This should be the last big refactoring before Guice 2 final... by limpbizkit · 15 years ago
  67. 79dc99b Implementing dtm's clever suggestions for optimizing getJustInTimeBinding for child injectors. by limpbizkit · 15 years ago
  68. fcbdf99 Pretty massive rewrite of PrivateModules so that they're now implemented in core Guice. by limpbizkit · 16 years ago
  69. 4272aef Key.get() now explodes when you give it a type parameter like 'T'. Guice has never supported this, but now we fail earlier. by limpbizkit · 16 years ago
  70. 3a8c155 Changed the InjectionPoint factory methods. Now the ConfigurationException includes a partial value, which means that a sink collection doesn't need to be passed in. by limpbizkit · 16 years ago
  71. b0f3c9b Guice now reifies types! If you inject a TypeLiteral<T>, Guice will deduce what T is and inject the proper TypeLiteral for you. by limpbizkit · 16 years ago
  72. a8dccb3 Hierarchical Parent Child Chained injectors are now threadsafe by limpbizkit · 16 years ago
  73. 8ba9788 This change is big, and it makes Guice slower. I'll need to follow-up with some optimizations that make TypeResolver quicker. by limpbizkit · 16 years ago
  74. 72d11dd Taking advantage of the error message changes in some extensions. by limpbizkit · 16 years ago
  75. 0689806 Hopefully the last of the big exceptions refactorings. I went through all of the places we're adding context to our Errors object and made sure we're never doubling-up -- specifing the same injection point or key multiple times. by limpbizkit · 16 years ago
  76. 490833f Cleaning up exceptions and Javadoc: by limpbizkit · 16 years ago
  77. edd8d64 New API: Injector.getParent by limpbizkit · 16 years ago
  78. 5fb9d92 Rewrite of parent injectors. by limpbizkit · 16 years ago
  79. b3a8f0b Last of the planned major changes to the SPI. Aside from Javadoc I consider the SPI to be complete for v2. (with a possible addition of a ProviderMethodBinding feature also) by limpbizkit · 16 years ago
  80. a6e0e78 Moving error sources so they're now reported in the same place for configuration errors and runtime errors. This means that instead of seeing this: by limpbizkit · 16 years ago
  81. 18cb191 Splitting up finding member injectors from finding injection points. This is intended to make it so the new SPI exposes injection points on Module elements without actually having to resolve 'em. by limpbizkit · 16 years ago
  82. 1490c5b Fixing a bug where exceptions thrown by @ProvidedBy providers weren't being wrapped in a ProvisionException. by limpbizkit · 16 years ago
  83. a98bc7a Cleaning up some internals for the SPI. by limpbizkit · 16 years ago
  84. a886599 Removing oldversion SPI and commands. These are both replaced by Elements. by limpbizkit · 16 years ago
  85. 4ce9cfa Changing the loading of StackTraceElements to be as lazy as possible. Sam Berlin was running into memory issues when these were loaded eagerly. by limpbizkit · 16 years ago
  86. cb32cbc We now support wildcards in bindings! The wildcards can only be used as type parameters for other types, not for top-level bindings on their own. by limpbizkit · 16 years ago
  87. 27fc50d Fixing a critical bug! The following code was broken (although we did have a TODO dating back to sometime last year) by limpbizkit · 16 years ago
  88. 5789ef4 A few more errors tests. There's only about five left till we have full test coverage for our errors code. by limpbizkit · 16 years ago
  89. afa4b5d LAST move of the visitors. I moved BindTargetVisitor to BindingTargetVisitor and Element.Visitor to ElementVisitor by limpbizkit · 16 years ago
  90. c6c0208 Moving visitors out of Binding so they don't show up in the main com.google.inject package core Javadocs by limpbizkit · 16 years ago
  91. 477f9f9 Grand unification of commands and SPI: by limpbizkit · 16 years ago
  92. 4a89ad3 Added requireBinding() convenience method to AbstractModule. by limpbizkit · 16 years ago
  93. e731d19 Tweaking error handling. by limpbizkit · 16 years ago
  94. 7a2341b A fix to an unfortunate, rare concurrency problem. During injector creation, it's possbile that an @Inject method will start a thread, and attempt to access injected members while the injector is still being created. The IdentityHashSet of members to inject is currently accessed, and everything blows up. Terrible! by limpbizkit · 16 years ago
  95. 47062f1 More of mcculls fixes for choosing which classloader to use for generated classes. I believe this solves the package-private problem and the memory leak problem. Nice work Stuart! by limpbizkit · 16 years ago
  96. 869a3c0 Stuart McCulloch contributed a custom classloader that fixes the memory leak and supports OSGi-style classloaders (plus any other form of non-delegation). by limpbizkit · 16 years ago
  97. 2c2c610 More cleanup of Errors -- including sources as a factory method rather than push/pop methods (that require try/finally clauses) by limpbizkit · 16 years ago
  98. 6663d02 Axing SourceProviders and SourceProvider in favour of Binder.withSource and Binder.skipSources by limpbizkit · 16 years ago
  99. 9532e62 Eliminated static from SourceProviders. The new mechanism to specify the source of a binding is like this: by limpbizkit · 16 years ago
  100. 185d2a2 Added some new error messages: by limpbizkit · 16 years ago