commit a6a68cfddd6e6af7bc4c6242ae596d7cb0f16936
author Chih-Hung Hsieh <chh@google.com> Thu Sep 28 12:08:43 2017 -0700
committer Fredrik Roubert <roubert@google.com> Fri Sep 29 17:04:59 2017 +0200
tree 4b3813ecd3ddf919df2e57d88426bed8bb3f5af8
parent 31836f800f0cd1fc1f78cc4c8ab4a6ea1b9fca7e

Use -Werror in external/icu

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ifbacc95b5038b8ad2ca8eef6bf4731bc1eb3c7d9

android_utils/Android.bp

diff --git a/android_utils/Android.bp b/android_utils/Android.bp
index 6c205bf..5b5bbc6 100644
--- a/android_utils/Android.bp
+++ b/android_utils/Android.bp
@@ -20,6 +20,10 @@
         "libicuuc",
         "liblog",
     ],
+    cflags: [
+        "-Wall",
+        "-Werror",
+    ],
     local_include_dirs: ["include"],
     export_include_dirs: ["include"],
 }

icu4c/source/Android.bp

diff --git a/icu4c/source/Android.bp b/icu4c/source/Android.bp
index 2941ea4..5a5c11d 100644
--- a/icu4c/source/Android.bp
+++ b/icu4c/source/Android.bp
@@ -22,5 +22,9 @@
     host_supported: true,
     srcs: ["stubdata/stubdata.cpp"],
     local_include_dirs: ["common"],
+    cflags: [
+        "-Wall",
+        "-Werror",
+    ],
     cppflags: ["-std=c++11"],
 }

icu4c/source/common/Android.bp

diff --git a/icu4c/source/common/Android.bp b/icu4c/source/common/Android.bp
index 2b7d1e0..1af484d 100644
--- a/icu4c/source/common/Android.bp
+++ b/icu4c/source/common/Android.bp
@@ -214,6 +214,8 @@
         "-O3",
         "-fvisibility=hidden",
 
+        "-Wall",
+        "-Werror",
         "-Wno-unused-parameter",
         "-Wno-missing-field-initializers",
         "-Wno-sign-compare",

icu4c/source/i18n/Android.bp

diff --git a/icu4c/source/i18n/Android.bp b/icu4c/source/i18n/Android.bp
index ae7a2fd..b823c22 100644
--- a/icu4c/source/i18n/Android.bp
+++ b/icu4c/source/i18n/Android.bp
@@ -221,6 +221,8 @@
         "-DU_I18N_IMPLEMENTATION",
         "-O3",
         "-fvisibility=hidden",
+        "-Wall",
+        "-Werror",
         "-Wno-unused-parameter",
     ],
     cppflags: [