| commit | fc06b28b4611c4b59be9c2ed0bde0e82c826e68f | [log] [tgz] |
|---|---|---|
| author | Federico Tomassetti <f.tomassetti@gmail.com> | Mon Nov 30 09:51:39 2015 +0100 |
| committer | Federico Tomassetti <f.tomassetti@gmail.com> | Mon Nov 30 09:51:39 2015 +0100 |
| tree | 85b35c94aee5af539d71688a37b72e2a171dc5a4 | |
| parent | e66e92e834de35778cfc2d4d9ebc161f5804c3f2 [diff] | |
| parent | dae951368ec19f99d45d3a405cb27e7cb805e5f9 [diff] |
Merge pull request #232 from ftomassetti/issue_231 issue231: fix how empty Enums are dumped
diff --git a/javaparser-core/src/main/java/com/github/javaparser/ast/visitor/DumpVisitor.java b/javaparser-core/src/main/java/com/github/javaparser/ast/visitor/DumpVisitor.java index 4253dac..ada8ce5 100644 --- a/javaparser-core/src/main/java/com/github/javaparser/ast/visitor/DumpVisitor.java +++ b/javaparser-core/src/main/java/com/github/javaparser/ast/visitor/DumpVisitor.java
@@ -1278,11 +1278,11 @@ } } } - if (n.getMembers() != null) { + if (!n.getMembers().isEmpty()) { printer.printLn(";"); printMembers(n.getMembers(), arg); } else { - if (n.getEntries() != null) { + if (!n.getEntries().isEmpty()) { printer.printLn(); } }
diff --git a/javaparser-testing/src/test/java/com/github/javaparser/bdd/steps/DumpingSteps.java b/javaparser-testing/src/test/java/com/github/javaparser/bdd/steps/DumpingSteps.java index abd37fc..730a22f 100644 --- a/javaparser-testing/src/test/java/com/github/javaparser/bdd/steps/DumpingSteps.java +++ b/javaparser-testing/src/test/java/com/github/javaparser/bdd/steps/DumpingSteps.java
@@ -47,6 +47,11 @@ this.sourceUnderTest = classSrc.trim(); } + @Given("the compilation unit:$classSrc") + public void givenTheCompilationUnit(String classSrc) { + this.sourceUnderTest = classSrc.trim(); + } + @When("the class is parsed by the Java parser") public void whenTheClassIsParsedByTheJavaParser() throws ParseException { compilationUnit = JavaParser.parse(new ByteArrayInputStream(sourceUnderTest.getBytes()));
diff --git a/javaparser-testing/src/test/resources/com/github/javaparser/bdd/dumping_scenarios.story b/javaparser-testing/src/test/resources/com/github/javaparser/bdd/dumping_scenarios.story index 8a720a8..2f72ddf 100644 --- a/javaparser-testing/src/test/resources/com/github/javaparser/bdd/dumping_scenarios.story +++ b/javaparser-testing/src/test/resources/com/github/javaparser/bdd/dumping_scenarios.story
@@ -119,4 +119,16 @@ // another foo bar } } -} \ No newline at end of file +} + + +Scenario: An empty Enum is dumped correctly +Given the compilation unit: +package test; enum XYZ {} +When the class is parsed by the Java parser +Then it is dumped to: +package test; + +enum XYZ { + +}