Harden V8IsolateMemoryDumpProvider::DumpHeapStatistics.
Currently the function adds "other_spaces" that contains the difference
between the total metrics and the sum of spaces.
If the sizes do not match, then this can result in size_t underflow:
https://bugs.chromium.org/p/v8/issues/detail?id=7668
We should just assert that the sizes match and remove "other_spaces".
Bug: v8:7668
Change-Id: Ib768cec6b2fb7faf3e2c53a89cbd926547ddf603
Reviewed-on: https://chromium-review.googlesource.com/1016602
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553519}
CrOS-Libchrome-Original-Commit: 46433ade5c7e4b58d9a6011756aeb0d8643e405c
1 file changed