Disallow resetting the CommandLine after native startup.
Once the native message loop is running, native code might access the
command line. Resetting the CommandLine back to a Java version (thereby
nulling out the native command line) can cause DCHECKs at a later point,
which results in test flakiness. Tests that legitimately need to reset
the command line can do that before native startup.
Because the NativeCommandLine is only instantiated during native
startup, remove the whole JNI call. Also disentangle LibraryLoader and
CommandLine, and delete unused code to do with command line resets.
Bug: 771205
TBR: michaelbai@chromium.org
Change-Id: Ie0b0dbef4e5a7b4a6e6f1987ef03cf8599a07e74
Reviewed-on: https://chromium-review.googlesource.com/698304
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507534}
CrOS-Libchrome-Original-Commit: 137034a1880ce42f27ade6e6566c5e62ac3051ee
6 files changed