This changes around our handling of file descriptors to reduce code duplication and increase clarity. I tried to minimize actual changes and just move code. There are a few exceptions:
The input file descriptor buffer is now a deque rather than a complicated fixed size buffer with extra overflow. This greatly simplifies some code. In practice, I don't think this will change the number of allocations we do in a practical way.
I changed a few logging statements that seemed relevant to IPC developers only into the "D" variants.
The msghdr struct used to be declared once at the top of ProcessOutgoingMessages and re-used for all calls to recvmsg. Now that the different callers are split out into sub functions, there is more initialization of the msghdr structs used in this call. I don't think this will be significant.
Review URL: http://codereview.chromium.org/9533002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124272 0039d316-1c4b-4281-b951-d872f2087c98
CrOS-Libchrome-Original-Commit: 334f302db0310f47d20eb532cb0bae401a0eddbe
2 files changed