| commit | 4b94522ac811ed3bb2eb2f8b5429807039e4d00b | [log] [tgz] |
|---|---|---|
| author | Olga Sharonova <olka@chromium.org> | Sat Nov 18 05:48:31 2017 +0900 |
| committer | Qijiang Fan <fqj@google.com> | Fri Jun 05 07:48:30 2020 +0900 |
| tree | 5587f4c0054921171bdcd0adc49ed80669000b30 | |
| parent | b1b78371a5943f0a8004f5d4aec6989dc3ede9ba [diff] |
Make sure DCHECK_CALLED_ON_VALID_THREAD(foo) << "message" compiles when DCHECK is off DCHECK() is defined like this when DCHECKs are off: #define DCHECK(condition) EAT_STREAM_PARAMETERS << !(condition) see [https://cs.chromium.org/chromium/src/base/logging.h?type=cs&sq=package:chromium&l=867] and DCHECK_CALLED_ON_VALID_THREAD() is defined to nothing in that case, so streaming version of it does not compile, see example: [https://build.chromium.org/p/tryserver.chromium.chromiumos/builders/chromeos-daisy-rel/builds/4095/steps/compile%20%28with%20patch%29/logs/stdio] Bug: Change-Id: I4959c08b2a6181051b8a74b0babef36abad83df9 Reviewed-on: https://chromium-review.googlesource.com/776595 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#517546} CrOS-Libchrome-Original-Commit: b2c3af62fc0f7d95165d881b54621ea378a83912