Revert of android: Async setupConnection binder call (patchset #4 id:60001 of https://codereview.chromium.org/2810433002/ )
Reason for revert:
Appears to have broken ChildProcessLauncherTest_testBindServiceFromMultipleProcesses/0 on https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/41605
junit.framework.AssertionFailedError
at org.chromium.content.browser.ChildProcessLauncherTest.testBindServiceFromMultipleProcesses(ChildProcessLauncherTest.java:448)
at java.lang.reflect.Method.invokeNative(Native Method)
at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
Original issue's description:
> android: Async setupConnection binder call
>
> Make setupConnection oneway/async. Add a ICallbackInt interface to
> return the PID of the child process. The reply is then posted back to
> launcher thread. Connection setup is already mostly async so only
> involves moving related code to the reply callback.
>
> One caveat is that getCallingPid no longer works and just returns 0
> for oneway calls. The pid check is not strictly necessary, so dropped
> the from setupConnection instead.
>
> BUG=689758, 690118
>
> Review-Url: https://codereview.chromium.org/2810433002
> Cr-Commit-Position: refs/heads/master@{#463332}
> Committed: https://chromium.googlesource.com/chromium/src/+/39c7bd71dc2f9c9f692dd346e4e4e525af25ede1
TBR=rsesek@chromium.org,jcivelli@chromium.org,torne@chromium.org,boliu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=689758, 690118
Review-Url: https://codereview.chromium.org/2806343003
Cr-Commit-Position: refs/heads/master@{#463387}
CrOS-Libchrome-Original-Commit: 2cc9e495637d506c65ae9802408043f7fbaf27d2
2 files changed