Chrome OS: Reduce NOTREACHED() overhead for release builds.

For Chrome OS release builds, implement a dedicated LogErrorNotReached() function to reduce
the number of function calls per NOTREACHED() call site from 5+ to 1 and drop custom messages that are appended to NOTREACHED().  (Release builds on other platforms drop NOTREACHED() altogether, so no changes there.)

This change reduces the size of my chromeos=1 executable by 1.7 MB (ca. 1%).

BUG=484283

Review URL: https://codereview.chromium.org/1124673004

Cr-Commit-Position: refs/heads/master@{#331249}


CrOS-Libchrome-Original-Commit: ff3f34ae4fefa2d0ecce5ba338b1afb9505c72d4
2 files changed
tree: 98aec8b51a0356419258990a6763f1cf19ddd6d0
  1. base/
  2. build/
  3. components/
  4. dbus/
  5. device/
  6. ipc/
  7. mojo/
  8. testing/
  9. third_party/
  10. ui/