commit 5faed3c5aa85fe439dcfeab55e397e5be5f6b938
author brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Thu Oct 27 06:48:00 2011 +0900
committer Qijiang Fan <fqj@google.com> Thu Jun 04 11:59:42 2020 +0900
tree e3e9fd8c3ae0d1d226f6434d65dfe2ac2d19fcf5
parent bd7a6ad7d8456b191244280a491fd65ac51881ce

Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.

[ Reland of 107042 http://codereview.chromium.org/8368009 ]

I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8341026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98


CrOS-Libchrome-Original-Commit: a42d4638f0335dbfd14c1c9f6b05a7b09703a78e

base/message_loop.cc

diff --git a/base/message_loop.cc b/base/message_loop.cc
index 593c03c..553efb1 100644
--- a/base/message_loop.cc
+++ b/base/message_loop.cc
@@ -258,7 +258,7 @@
 
 void MessageLoop::PostTask(
     const tracked_objects::Location& from_here, Task* task) {
-  CHECK(task);
+  DCHECK(task);
   PendingTask pending_task(
       base::Bind(
           &base::subtle::TaskClosureAdapter::Run,
@@ -270,7 +270,7 @@
 
 void MessageLoop::PostDelayedTask(
     const tracked_objects::Location& from_here, Task* task, int64 delay_ms) {
-  CHECK(task);
+  DCHECK(task);
   PendingTask pending_task(
       base::Bind(
           &base::subtle::TaskClosureAdapter::Run,
@@ -282,7 +282,7 @@
 
 void MessageLoop::PostNonNestableTask(
     const tracked_objects::Location& from_here, Task* task) {
-  CHECK(task);
+  DCHECK(task);
   PendingTask pending_task(
       base::Bind(
           &base::subtle::TaskClosureAdapter::Run,
@@ -294,7 +294,7 @@
 
 void MessageLoop::PostNonNestableDelayedTask(
     const tracked_objects::Location& from_here, Task* task, int64 delay_ms) {
-  CHECK(task);
+  DCHECK(task);
   PendingTask pending_task(
       base::Bind(
           &base::subtle::TaskClosureAdapter::Run,
@@ -306,7 +306,7 @@
 
 void MessageLoop::PostTask(
     const tracked_objects::Location& from_here, const base::Closure& task) {
-  CHECK(!task.is_null()) << from_here.ToString();
+  DCHECK(!task.is_null()) << from_here.ToString();
   PendingTask pending_task(task, from_here, CalculateDelayedRuntime(0), true);
   AddToIncomingQueue(&pending_task);
 }
@@ -314,7 +314,7 @@
 void MessageLoop::PostDelayedTask(
     const tracked_objects::Location& from_here, const base::Closure& task,
     int64 delay_ms) {
-  CHECK(!task.is_null()) << from_here.ToString();
+  DCHECK(!task.is_null()) << from_here.ToString();
   PendingTask pending_task(task, from_here,
                            CalculateDelayedRuntime(delay_ms), true);
   AddToIncomingQueue(&pending_task);
@@ -322,7 +322,7 @@
 
 void MessageLoop::PostNonNestableTask(
     const tracked_objects::Location& from_here, const base::Closure& task) {
-  CHECK(!task.is_null()) << from_here.ToString();
+  DCHECK(!task.is_null()) << from_here.ToString();
   PendingTask pending_task(task, from_here, CalculateDelayedRuntime(0), false);
   AddToIncomingQueue(&pending_task);
 }
@@ -330,7 +330,7 @@
 void MessageLoop::PostNonNestableDelayedTask(
     const tracked_objects::Location& from_here, const base::Closure& task,
     int64 delay_ms) {
-  CHECK(!task.is_null()) << from_here.ToString();
+  DCHECK(!task.is_null()) << from_here.ToString();
   PendingTask pending_task(task, from_here,
                            CalculateDelayedRuntime(delay_ms), false);
   AddToIncomingQueue(&pending_task);