Revert "[cc] Split TransformNode members into input values and derived values"
This reverts commit ce3e2fd8496123a0737dcee3dd1d44bccbf36456.
Reason for revert: Speculative revert. This CL is in the regression range [1] for WebKit layout failure in css3/blending/background-blend-mode-overlapping-accelerated-elements.html [2] and it updates Win7 expectations without updating Win10 expectations which makes it a likely culprit to my mind.
[1] https://chromium.googlesource.com/chromium/src/+log/4d62f13f73427a9c9881fe3249ceeebbe2226d4b%5E..a20785d5c280afeaa21aead507fa6c16f905eba8?pretty=fuller&n=
[2] https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/26322
Original change's description:
> [cc] Split TransformNode members into input values and derived values
>
> This cleanup CL refactors TransformNode structure so that its member
> variables are splitted into input values and derived values, so that it
> is clearer which values are expected to be set by the client and which
> are to be recalculated by impl thread every frame.
>
> In the process, pre_local and post_local are eliminated and is only
> computed on the fly. To achieve this, the calculation of post_local
> needs to be unified between root and non-root layers. Previously the
> transform node #0 stores the scale component of the root transform[1],
> and node #1 stores the root transform with scale component extracted.
>
> With this CL, transform node #0 stores the whole root transform and
> node #1 becomes a regular node.
>
> This CL affects rounding error of draw matrices due to the change in
> association order. Should introduce no other behavior change.
>
> [1] root transform = device_transform * device_scale * page_scale
>
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Ia553ec5816d71eff6e2d7bc42b51b439817d9d2b
> Reviewed-on: https://chromium-review.googlesource.com/685544
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Ali Juma <ajuma@chromium.org>
> Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506901}
TBR=danakj@chromium.org,ajuma@chromium.org,trchen@chromium.org,chrishtr@chromium.org
Change-Id: I861b7f6ac3911d872aa2c98a4c4e4a1e0b603411
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/704855
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507033}
CrOS-Libchrome-Original-Commit: 326859caa87667c2c244d1253f57506f13ef7a51
1 file changed