Move JoinString to the base namespace.

Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString.

Update callers who pass empty separators to use a base::StringPiece()

Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster).

TBR=zelidrag@chromium.org for chromeos

Review URL: https://codereview.chromium.org/1223153003

Cr-Commit-Position: refs/heads/master@{#338762}


CrOS-Libchrome-Original-Commit: 0eabfa001ba06d3c66992b95b69a988ef0633992
6 files changed
tree: 98982167b5f4f7ed9e885d050772ae5ba2b44ba2
  1. base/
  2. build/
  3. components/
  4. dbus/
  5. device/
  6. ipc/
  7. mojo/
  8. testing/
  9. third_party/
  10. ui/