Revert of Adds eventlog provider dll to describe the message types of SYSLOG. (patchset #2 id:20001 of https://codereview.chromium.org/2476353003/ )
Reason for revert:
Caused windows compile errors:
https://uberchromegw.corp.google.com/i/chromium/builders/Win/builds/49108/steps/steps/logs/stdio
[1/1] LINK(DLL) eventlog_provider.dll eventlog_provider.dll.lib eventlog_provider.dll.pdb
ninja explain: output eventlog_provider.dll.lib doesn't exist
ninja explain: eventlog_provider.dll.lib is dirty
Original issue's description:
> Adds eventlog provider dll to describe the message types of SYSLOG.
>
> Creates a dll file that can be registered with the system event-logging
> mechanisms on Windows to make the events generated when using the SYSLOG
> macro nicer to read in the Event Viewer snapin.
>
> BUG=642115
> TEST=manual
>
> Committed: https://crrev.com/cee58011177e2cf4bb8cfd08e64b0cd48629b0ff
> Cr-Commit-Position: refs/heads/master@{#431872}
TBR=brettw@chromium.org,pastarmovj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642115
Review-Url: https://codereview.chromium.org/2502643003
Cr-Commit-Position: refs/heads/master@{#431875}
CrOS-Libchrome-Original-Commit: 145864aeae7cb83aefb0c645f23705f174a1850e
diff --git a/base/syslog_logging.cc b/base/syslog_logging.cc
index 2313856..1d3daf9 100644
--- a/base/syslog_logging.cc
+++ b/base/syslog_logging.cc
@@ -6,8 +6,6 @@
#include "base/syslog_logging.h"
#if defined(OS_WIN)
-#include "base/win/eventlog_messages.h"
-
#include <windows.h>
#elif defined(OS_LINUX)
#include <syslog.h>
@@ -53,8 +51,10 @@
log_type = EVENTLOG_ERROR_TYPE;
break;
}
- if (!ReportEventA(event_log_handle, log_type, BROWSER_CATEGORY,
- MSG_LOG_MESSAGE, NULL, 1, 0, strings, NULL)) {
+ // TODO(pastarmovj): Register Chrome's event log resource types to make the
+ // entries nicer. 1337 is just a made up event id type.
+ if (!ReportEventA(event_log_handle, log_type, 0, 1337, NULL, 1, 0,
+ strings, NULL)) {
stream() << " !!NOT ADDED TO EVENTLOG!!";
}
DeregisterEventSource(event_log_handle);