| commit | d0ad51106c9072f4e37ad872c0083b6e097bb713 | [log] [tgz] |
|---|---|---|
| author | erikchen <erikchen@chromium.org> | Sat Oct 24 07:34:01 2015 +0900 |
| committer | Qijiang Fan <fqj@google.com> | Fri Jun 05 01:41:16 2020 +0900 |
| tree | 82d0f618efa8acdf84cb4ac6ae645469b5f4a35c | |
| parent | e14aba72c2cd67ef9425b0064eb0840e60253994 [diff] |
Revert of mac: Add auto-close and share-read-only functionality to SharedMemory. (patchset #5 id:80001 of https://codereview.chromium.org/1418113003/ ) Reason for revert: New unit-tests failing on 10.8 http://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/10139/steps/base_unittests/logs/SharedMemoryMacMultiProcessTest.MachShareToProcessReadonly Original issue's description: > mac: Add auto-close and share-read-only functionality to Mach based SharedMemory. > > base::FileDescriptor has a property |auto_close| that is used to indicate that > when the object is passed to an IPC message, the message takes ownership of the > underlying OS handle. Since SharedMemoryHandle needs to be interchangeable with > base::FileDescriptor, I added a property with similar functionality named > |ownership_passes_to_ipc_|. > > The method ShareToProcess() is used to lower the current and maximum protection > of the underlying OS handle before it is transferred to a different process. I > implemented this functionality for Mach memory objects. > > BUG=535711 > > Committed: https://crrev.com/033bbbcb63cab781552dfb435c035131c423de30 > Cr-Commit-Position: refs/heads/master@{#355880} TBR=mark@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=535711 Review URL: https://codereview.chromium.org/1421933002 Cr-Commit-Position: refs/heads/master@{#355908} CrOS-Libchrome-Original-Commit: 160caaaf74aa406be6acf71b274583d30fa07552