| commit | d155d9ff920aa9a887bc373ace500b2f51919a44 | [log] [tgz] |
|---|---|---|
| author | Chris Watkins <watk@chromium.org> | Wed Nov 29 16:16:38 2017 +0900 |
| committer | Qijiang Fan <fqj@google.com> | Fri Jun 05 07:54:02 2020 +0900 |
| tree | 0f6aeed8a1644d5cb48a7837c48bb59fa831172d | |
| parent | f90b17dc6249d0a4511c606ffc0dcfe05f42ae45 [diff] [blame] |
Run clang-tidy modernize-use-equals-{delete,default} on //base
See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8
This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
git diff --name-only | \
xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'
BUG=778959,778957
Change-Id: I95a3f3dae4796e4a7beb77793a6101f433a2c649
Reviewed-on: https://chromium-review.googlesource.com/789718
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520033}
CrOS-Libchrome-Original-Commit: bb7211cd3762a8545d29b0d5bfebcb94ec4db081
diff --git a/base/sync_socket_unittest.cc b/base/sync_socket_unittest.cc index 202aa2c..fdcd9a1 100644 --- a/base/sync_socket_unittest.cc +++ b/base/sync_socket_unittest.cc
@@ -30,7 +30,7 @@ thread_.Start(); } - ~HangingReceiveThread() override {} + ~HangingReceiveThread() override = default; void Run() override { int data = 0;