| commit | d3377b3837e19f854a54f0d9a6e109c7534d9ef6 | [log] [tgz] |
|---|---|---|
| author | agrieve <agrieve@chromium.org> | Thu Sep 03 05:32:59 2015 +0900 |
| committer | Qijiang Fan <fqj@google.com> | Thu Jun 04 19:36:10 2020 +0900 |
| tree | 37de056fd6ff1717d6e5b60c09e1bf661bfe509c | |
| parent | 532a6462d69bbf2181775c7bcf0555598272880a [diff] |
Revert of Fix javac command never caching input .md5s (patchset #8 id:140001 of https://codereview.chromium.org/1308083002/ ) Reason for revert: Causing try-bot failures: e.g.: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/111130/steps/compile%20%28without%20patch%29/logs/stdio Original issue's description: > Fix javac command never caching input .md5s > > This was broken over a year ago by http://crrev.com/a78eb479 > > This change also removes --classes-dir (which is currently unused), and makes --jar-path (always used) required. > > It also forces the command to run if the output is missing (rather than relying completely on the .stamp file) > > On my ubiquity machine: > Add a log statement to a file in base_java then build chrome_apk: > > Before: > real 2m25.188s > user 4m52.950s > sys 1m10.064s > > After: > real 1m16.989s > user 1m13.795s > sys 0m44.040s > > BUG=523420, 379190 > > Committed: https://crrev.com/1c366880cb68fbf25050f1c6d78684eb6ae2e644 > Cr-Commit-Position: refs/heads/master@{#346975} TBR=jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=523420, 379190 Review URL: https://codereview.chromium.org/1309663005 Cr-Commit-Position: refs/heads/master@{#347011} CrOS-Libchrome-Original-Commit: a936d4429436bd69009eecdc8a8fa97763dcbe22