| commit | d70c8184da142cebb29f8cf39be454819be89471 | [log] [tgz] |
|---|---|---|
| author | Denis Yaroshevskiy <dyaroshev@yandex-team.ru> | Fri May 11 17:18:34 2018 +0900 |
| committer | Qijiang Fan <fqj@google.com> | Fri Jun 05 09:19:54 2020 +0900 |
| tree | 7c32f831fbf4ff12a8b3736a79bc78819c3a5e55 | |
| parent | 50eaa291446625e89c51c66fdf5120a76c024c54 [diff] |
Google C++ style guide recomends nothrow move constructors and generally applying noexcept where it make sense. https://google.github.io/styleguide/cppguide.html#noexcept Noexcept until recently didn't work with out of line default declarations. This CL tests that now it compiles on all platforms by applying noexcept for a few default move operations. Since this CL is useful not only to test but to merge too, I suggest we merge it. Discussion on noexcept: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/cxx/ze4WJFg7RvU/6wU_9xltBgAJ Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If65a9da6dc803e4dbd03765656a6f122bcb8210e Reviewed-on: https://chromium-review.googlesource.com/1046005 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Denis Yaroshevskiy <dyaroshev@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#557813} CrOS-Libchrome-Original-Commit: 66971f5a768d4da084fed27cc5f4d3550e47c212