Allow LOG_DCHECK to be configured via Feature in SyzyASAN builds.
This CL supports an experiment to enable DCHECKs in some Canary builds,
in order to gather data on broken DCHECK'd invariants, e.g. due to
faulty calling code or incorrect/over-zealous DCHECKing.
This CL changes the LOG_DCHECK LogSeverity to be switchable at run-
time in SyzyASAN builds with DCHECKs enabled, based on the setting of
a "DcheckIsFatal" Feature.
The Feature defaults to off, with an exception for death-test child
processes to allow death-tests to continue to work without modification.
This means that DCHECKs will be compiled-in and generate INFO level log
output, and can be switched via the command-line, or via Finch
experiment, to be made fatal.
Bug: 596231
Change-Id: I390aecdba40c8a8b396d6a4a03162ff071e9c3d5
Reviewed-on: https://chromium-review.googlesource.com/559809
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497183}
CrOS-Libchrome-Original-Commit: 289477f6c6cfc2ca788955623aede8ed02c08012
4 files changed