| commit | e44703f5f0f46559a0d957babe6b1482618f7442 | [log] [tgz] |
|---|---|---|
| author | asvitkine <asvitkine@chromium.org> | Fri Nov 20 11:37:56 2015 +0900 |
| committer | Qijiang Fan <fqj@google.com> | Fri Jun 05 01:53:06 2020 +0900 |
| tree | 2231b846a772653f956f5c220f6461ad53366b52 | |
| parent | 95784c5ea901a2ad362597a5686718edc03b808c [diff] |
Use subtle::NoBarrier* statements for Histogram flags_ field. This is similar to this CL which provided the same treatment to some of the other histogram internal fields: https://codereview.chromium.org/116983004 This field can be accessed from multiple threads which causes TSAN to report data races. Using NoBarrier instructions makes this intention explicit and silences the TSAN errors. Here's some context for the data race and why it's harmless: https://code.google.com/p/chromium/issues/detail?id=535359#c14 BUG=535359 Review URL: https://codereview.chromium.org/1445283004 Cr-Commit-Position: refs/heads/master@{#360723} CrOS-Libchrome-Original-Commit: a74e3d57c0c1feebb1f0bf28a4dfaea03b3734d2