commit 79b2d64a672b3bf657bfacc9d0b0cae6293e34f2
author Glenn Randers-Pehrson <glennrp at users.sourceforge.net> Wed Oct 13 07:31:14 2010 -0500
committer Glenn Randers-Pehrson <glennrp at users.sourceforge.net> Wed Oct 13 07:31:14 2010 -0500
tree e50768f7d1ee968982e48b69409b6ae331d19073
parent e34f80e5aa20c7b0d17d681290aa21cfcb027ba6

[devel] also check for negative out-of-range text compression mode

pngset.c

diff --git a/pngset.c b/pngset.c
index e49bf6d..a87b3e0 100644
--- a/pngset.c
+++ b/pngset.c
@@ -677,14 +677,15 @@
       if (text_ptr[i].key == NULL)
           continue;
 
-      key_len = png_strlen(text_ptr[i].key);
-
-      if (text_ptr[i].compression >= PNG_TEXT_COMPRESSION_LAST)
+      if (text_ptr[i].compression < PNG_TEXT_COMPRESSION_NONE ||
+          text_ptr[i].compression >= PNG_TEXT_COMPRESSION_LAST)
       {
          png_warning(png_ptr, "text compression mode is out of range");
          continue;
       }
 
+      key_len = png_strlen(text_ptr[i].key);
+
       if (text_ptr[i].compression <= 0)
       {
          lang_len = 0;