commit 3fffeafbdc2b8ec5f78f4014ce41d334c44e98fa
author Jens Axboe <axboe@kernel.dk> Fri Oct 23 07:42:31 2020 -0600
committer Jens Axboe <axboe@kernel.dk> Fri Oct 23 07:42:31 2020 -0600
tree 6207b89008fc48bc6956a2b2269225a720e71e66
parent 5d12b139d50e9330cf2a3aea360a9aa91a2eb487
parent 6a89214da88954079b077d0c7d793ce7bc7c25b1

Merge branch 'pu/unsafe-tmpdir' of https://github.com/guillemj/liburing

* 'pu/unsafe-tmpdir' of https://github.com/guillemj/liburing:
  configure: Fix unsafe temporary file creation

configure

diff --git a/configure b/configure
index 518a5b0..c911f59 100755
--- a/configure
+++ b/configure
@@ -1,13 +1,4 @@
 #!/bin/sh
-#
-# set temporary file name
-if test ! -z "$TMPDIR" ; then
-    TMPDIR1="${TMPDIR}"
-elif test ! -z "$TEMPDIR" ; then
-    TMPDIR1="${TEMPDIR}"
-else
-    TMPDIR1="/tmp"
-fi
 
 cc=${CC:-gcc}
 cxx=${CXX:-g++}
@@ -82,10 +73,10 @@
 exit 0
 fi
 
-TMPC="${TMPDIR1}/fio-conf-${RANDOM}-$$-${RANDOM}.c"
-TMPC2="${TMPDIR1}/fio-conf-${RANDOM}-$$-${RANDOM}-2.c"
-TMPO="${TMPDIR1}/fio-conf-${RANDOM}-$$-${RANDOM}.o"
-TMPE="${TMPDIR1}/fio-conf-${RANDOM}-$$-${RANDOM}.exe"
+TMPC="$(mktemp --tmpdir fio-conf-XXXXXXXXXX.c)"
+TMPC2="$(mktemp --tmpdir fio-conf-XXXXXXXXXX-2.c)"
+TMPO="$(mktemp --tmpdir fio-conf-XXXXXXXXXX.o)"
+TMPE="$(mktemp --tmpdir fio-conf-XXXXXXXXXX.exe)"
 
 # NB: do not call "exit" in the trap handler; this is buggy with some shells;
 # see <1285349658-3122-1-git-send-email-loic.minier@linaro.org>