commit a8a07b9caf32f1bc204f86f36a77f83122394b6c
author Ramesh Katuri <ramesh.katuri@ittiam.com> Tue Sep 18 12:04:31 2018 +0530
committer Rohit Yengisetty <rngy@google.com> Tue Oct 16 17:30:27 2018 -0700
tree da05b627f6c10e54fe4d737f24c86f8364a8e593
parent 9907ba5ba19f8619b51f70480602708da96bbcf4

Fix for crash due to un-initailized variables in drc module

Nested loop used wrong subscript in inner loop, leading to bad
iteration count and haphazard clearing of data structure.

Bug: 113885537
Test: vendor
Change-Id: Ia9cb53205f4e91ee99268202114fc2001eae2de3
(cherry picked from commit 988f5bd17c64c2efcb6e0a36c633065488ca2b79)

decoder/drc_src/impd_drc_gain_decoder.c

diff --git a/decoder/drc_src/impd_drc_gain_decoder.c b/decoder/drc_src/impd_drc_gain_decoder.c
index 43ae7b2..4b48f54 100644
--- a/decoder/drc_src/impd_drc_gain_decoder.c
+++ b/decoder/drc_src/impd_drc_gain_decoder.c
@@ -148,25 +148,25 @@
         p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[k]
             .buf_interpolation_count = drc_instruction_str->gain_element_count;
         for (i = 0;
-             i < p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[i]
+             i < p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[k]
                      .buf_interpolation_count;
              i++) {
-          p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[i]
+          p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[k]
               .buf_interpolation[i]
               .str_node.time = 0;
-          p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[i]
+          p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[k]
               .buf_interpolation[i]
               .prev_node.time = -1;
-          p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[i]
+          p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[k]
               .buf_interpolation[i]
               .str_node.loc_db_gain = 0.0f;
-          p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[i]
+          p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[k]
               .buf_interpolation[i]
               .str_node.slope = 0.0f;
 
           for (j = 0; j < 2 * AUDIO_CODEC_FRAME_SIZE_MAX + MAX_SIGNAL_DELAY;
                j++) {
-            p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[i]
+            p_drc_gain_dec_structs->drc_gain_buffers.pstr_gain_buf[k]
                 .buf_interpolation[i]
                 .lpcm_gains[j] = 1.f;
           }