commit 2f9c6c5fdfd5c87046295b37cd3bd99b6d4e7b09
author Wind Yuan <feng.yuan@intel.com> Thu Apr 30 16:53:28 2015 +0800
committer Wind Yuan <feng.yuan@intel.com> Mon May 04 15:04:35 2015 +0800
tree a17a2fef4e2019b9d05492dc425be56029dad11a
parent 42d62b1bccdc1a46b06b1b80b24c6af7036fb65b

fix xcam_mem_clear bug which can't clear array mem

 * xcam_mem_clear usage change to:
    int a;
    int b[10];
    xcam_mem_clear (a);
    xcam_mem_clear (b);
 * only works for stack variables not heap objects

xcore/x3a_analyzer_aiq.cpp

diff --git a/xcore/x3a_analyzer_aiq.cpp b/xcore/x3a_analyzer_aiq.cpp
index 136b1e7..cac2347 100644
--- a/xcore/x3a_analyzer_aiq.cpp
+++ b/xcore/x3a_analyzer_aiq.cpp
@@ -72,7 +72,7 @@
 
     _aiq_compositor = new AiqCompositor ();
     XCAM_ASSERT (_aiq_compositor.ptr());
-    xcam_mem_clear (&_sensor_mode_data);
+    xcam_mem_clear (_sensor_mode_data);
 
     XCAM_LOG_DEBUG ("X3aAnalyzerAiq constructed");
 }
@@ -129,7 +129,7 @@
 
     XCAM_ASSERT (_aiq_compositor.ptr());
 
-    xcam_mem_clear (&binary);
+    xcam_mem_clear (binary);
     XCAM_FAIL_RETURN (
         ERROR,
         reader.read(binary),
@@ -161,10 +161,9 @@
     XCamReturn ret = XCAM_RETURN_NO_ERROR;
     X3aResultList first_results;
     struct atomisp_sensor_mode_data sensor_mode_data;
-    xcam_mem_clear (&sensor_mode_data);
 
     XCAM_ASSERT (_isp.ptr());
-    xcam_mem_clear (&sensor_mode_data);
+    xcam_mem_clear (sensor_mode_data);
 
     ret = _isp->get_sensor_mode_data (sensor_mode_data);
     XCAM_FAIL_RETURN (WARNING, ret == XCAM_RETURN_NO_ERROR, ret, "get sensor mode data failed");