| commit | 07b7428b69c368611d215a140fe630b2d1e61349 | [log] [tgz] |
|---|---|---|
| author | Nick Wellnhofer <wellnhofer@aevum.de> | Thu Jun 01 00:19:14 2017 +0200 |
| committer | Nick Wellnhofer <wellnhofer@aevum.de> | Thu Jun 01 14:31:28 2017 +0200 |
| tree | bd1a5f9d46e510bf3b57447f90e30044b8dc73c5 | |
| parent | ac9a4560ee85b18811ff8ab7791ddfff7b144b0a [diff] |
Simplify control flow in xmlParseStartTag2
Remove some goto labels and deduplicate a bit of code after handling
namespaces.
Before:
loop {
parseAttribute
if (ok) {
if (defaultNamespace) {
handleDefaultNamespace
if (error)
goto skip_default_ns;
handleDefaultNamespace
skip_default_ns:
freeAttr
nextAttr
continue;
}
if (namespace) {
handleNamespace
if (error)
goto skip_ns;
handleNamespace
skip_ns:
freeAttr
nextAttr;
continue;
}
handleAttr
} else {
freeAttr
}
nextAttr
}
After:
loop {
parseAttribute
if (!ok)
goto next_attr;
if (defaultNamespace) {
handleDefaultNamespace
if (error)
goto next_attr;
handleDefaultNamespace
} else if (namespace) {
handleNamespace
if (error)
goto next_attr;
handleNamespace
} else {
handleAttr
}
next_attr:
freeAttr
nextAttr
}