commit c43ac6698818d63e28f3f9691dba8a9cdbc6d469
author Carlo Bramini <carlo.bramix@libero.it> Thu Oct 14 14:27:54 2010 +0200
committer Daniel Veillard <veillard@redhat.com> Thu Oct 14 14:27:54 2010 +0200
tree 9c7d66c5a9880e507af2795d48eac675793460de
parent 2ddecc23862bab1a9a9e51e097aefc92ec305e28

Avoid a descriptor leak in catalog loading code

File descriptors could be leaked in xmlLoadFileContent()

catalog.c

diff --git a/catalog.c b/catalog.c
index af84b7c..f33a0aa 100644
--- a/catalog.c
+++ b/catalog.c
@@ -997,18 +997,15 @@
     }
 #ifdef HAVE_STAT
     len = read(fd, content, size);
+    close(fd);
 #else
     len = fread(content, 1, size, fd);
+    fclose(fd);
 #endif
     if (len < 0) {
         xmlFree(content);
         return (NULL);
     }
-#ifdef HAVE_STAT
-    close(fd);
-#else
-    fclose(fd);
-#endif
     content[len] = 0;
 
     return(content);