commit f6cf57a03b9f8b4aadeb473f8bf16c38fa6a3499
author Daniel Veillard <veillard@src.gnome.org> Wed May 09 23:53:30 2007 +0000
committer Daniel Veillard <veillard@src.gnome.org> Wed May 09 23:53:30 2007 +0000
tree 938c4945692cccb91ab4d42892bbd607d8ec823a
parent 1ca1be2ad5cbca1e9d7c45c9c2f849bee3adcd9a

applied patch to fix xmlListAppend() from Georges-André SILBER also fix

* list.c: applied patch to fix xmlListAppend() from 
  Georges-André SILBER
* valid.c: also fix the place wher it was called.
Daniel

svn path=/trunk/; revision=3614

valid.c

diff --git a/valid.c b/valid.c
index a239e68..b035f62 100644
--- a/valid.c
+++ b/valid.c
@@ -2998,19 +2998,32 @@
 	    xmlErrValid(NULL, XML_ERR_INTERNAL_ERROR,
 		    "xmlAddRef: Reference list creation failed!\n",
 		    NULL);
-            return(NULL);
+	    goto failed;
         }
         if (xmlHashAddEntry(table, value, ref_list) < 0) {
             xmlListDelete(ref_list);
 	    xmlErrValid(NULL, XML_ERR_INTERNAL_ERROR,
 		    "xmlAddRef: Reference list insertion failed!\n",
 		    NULL);
-            return(NULL);
+	    goto failed;
         }
     }
-/*    xmlListInsert(ref_list, ret); */
-    xmlListAppend(ref_list, ret);
+    if (xmlListAppend(ref_list, ret) != 0) {
+	xmlErrValid(NULL, XML_ERR_INTERNAL_ERROR,
+		    "xmlAddRef: Reference list insertion failed!\n",
+		    NULL);
+        goto failed;
+    }
     return(ret);
+failed:
+    if (ret != NULL) {
+        if (ret->value != NULL)
+	    xmlFree((char *)ret->value);
+        if (ret->name != NULL)
+	    xmlFree((char *)ret->name);
+        xmlFree(ret);
+    }
+    return(NULL);
 }
 
 /**